- 27 Feb, 2019 40 commits
-
-
Céline O'Neil authored
This CL adds a seed corpus to the CompositorFrame fuzzer. It can be defined in protobuf text format (.asciipb) and is automatically encoded to binary for use with the binary proto fuzzer. Defining a seed corpus is useful if there are known good and interesting starting points for the fuzzer, and is recommended by Chromium's fuzzing guide: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/efficient_fuzzer.md#Seed-Corpus As the CompositorFrame fuzzer increases in complexity, it will take an increasingly long time for libfuzzer to stumble upon interesting inputs, which will at the very least slow down local testing of new additions to the fuzzer. Adding a GN target to automatically encode the seed corpus protobuf messages allows us to take advantage of the faster binary proto fuzzing (as opposed to text proto fuzzing), but keeps it easy for a human to define and understand test cases. It also keeps us from having to check in hard-to-decipher binary test files to the Chromium repository. The GN target and Python script for the conversion were based off of similar automation in //src/chrome/browser/resources/safe_browsing/. Bug: 923088 Change-Id: If07887d6711b06e0682dc6e9c4a56d72ecb89b2a Reviewed-on: https://chromium-review.googlesource.com/c/1480868 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636136}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating CameraState into @IntDef using rules similar to other @IntDef inside Chromium project: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface BUG=919666 Change-Id: Ia61774a94dabc6acf7f9615f6fe083f2e5dc1bdf Reviewed-on: https://chromium-review.googlesource.com/c/1487813 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636135}
-
Sigurdur Asgeirsson authored
Bug: 936456 Change-Id: I31c53d888666aa5cf0e7787c12e24486e61834da Reviewed-on: https://chromium-review.googlesource.com/c/1492033 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636134}
-
Ella Ge authored
This reverts commit 3fbdb522. Reason for revert: failing on Mac10.10 and Mac10.11 Original change's description: > [AF] GoogleBlue50 as Autofill's field preview bg color > > This basically reverts the experimentation scaffolding introduced by > crrev.com/1174710, and makes GoogleBlue50 the field preview bg color > for Autofill and Autocomplete. > > Bug: 935991 > Change-Id: Id821f57c5a2954d502ca241e4414fd452cc501ce > Reviewed-on: https://chromium-review.googlesource.com/c/1489173 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636103} TBR=tkent@chromium.org,tmartino@chromium.org,ftirelo@chromium.org Change-Id: Id05bd9c4b40aa79130779d4602791678566d9c60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935991 Reviewed-on: https://chromium-review.googlesource.com/c/1492437 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65b79c43c5bc..5b0a3cc05375 Created with: gclient setdep -r src-internal@5b0a3cc05375 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: I8325a002d4354561784a7a18c189e5970c4c2228 Reviewed-on: https://chromium-review.googlesource.com/c/1492009Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636132}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f2eb10133f86..827da8450d9c git log f2eb10133f86..827da8450d9c --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Fork groupAlerts() for spa Created with: gclient setdep -r src/third_party/catapult@827da8450d9c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I2bd3965207148b0150c994a2717ddba846797d86 Reviewed-on: https://chromium-review.googlesource.com/c/1492372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636131}
-
Tarun Bansal authored
Approval doc here: http://shortn/_FVcQvJsxmu Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1484739 which got reverted. PS#1 is the patch that got reverted. Bug: 893923 Change-Id: Ia765f0c092ad64ab89c306b239b45982758299a9 TBR: holte@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1491770Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#636130}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/617f4eb4e5b7..1eac440c1718 git log 617f4eb4e5b7..1eac440c1718 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 ilkos@google.com Merge "Improve error msg for out of order events" Created with: gclient setdep -r src/third_party/perfetto@1eac440c1718 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5f67ed4e126d7a26b52e8bd59994e956b21611f3 Reviewed-on: https://chromium-review.googlesource.com/c/1492195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636129}
-
Anastasia Helfinstein authored
BUG=936234 Change-Id: I5af50ebd5bcc477c96d83ff7d2d6d3220cb5cd7e Reviewed-on: https://chromium-review.googlesource.com/c/1487843 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#636128}
-
Oksana Zhuravlova authored
This change adds a TestDocumentInterfaceBroker class to make it easier to override DocumentInterfaceBroker methods in C++ tests, as well as tests that the override mechanism works as expected. Bug: 718652 Change-Id: I19b8acfb0aaa6a5d38fb040973eb0e6d24392177 Reviewed-on: https://chromium-review.googlesource.com/c/1482593 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#636127}
-
Brad Hall authored
This adds the cipd yaml file used to build the chromium/llvm-build-tools/dsymutil package Bug: 930147 Change-Id: If7a61664fe13c26120e1534590549716b73bee46 Reviewed-on: https://chromium-review.googlesource.com/c/1492363 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636126}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/c18353d214c04da5349e97283d6d70b8176a96f8..a6124742d008e7cd4613833350a16d68537687c9 Bug: none Change-Id: Icce46a330aa8b4b9f1c3d70ac5e8120706cf475e Reviewed-on: https://chromium-review.googlesource.com/c/1492352 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#636125}
-
Yue Li authored
Bug: 935928 Test: Local Build Change-Id: I397d5f118d6dfbfdcd8b1b318e552780068560da Reviewed-on: https://chromium-review.googlesource.com/c/1490114Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#636124}
-
Huanzhong Huang authored
This fix allows Clear Browsing Data [table view] to remember the item selection state through modifying ChromeBrowserState upon item selection/deseletion. This is in accordance with how Clear Browsing Data [collection view] (as well as CBD on Desktop/Android) behaves. Bug: 936422 Change-Id: I4dd61a6ef75047f94b0e0ab59ac13e7242477ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1491656 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#636123}
-
Kristi Park authored
Add browsertests for dark mode and chips. Extract common test components into a separate file. Bug: 928548 Change-Id: I36c76aa57af6814c8b71497b2101d9c736bf568b Reviewed-on: https://chromium-review.googlesource.com/c/1490520 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#636122}
-
Chris Lu authored
Uses SettingsSwitchItem and SettingsSwitchCell to present UISwitch toggle if flag is on so user only has option between never sending data or sending data over either Wifi or Cellular. Screenshot: https://drive.google.com/file/d/15Bwzl1BO6iHZVnpvQ104FkD9YLD0Uze3/view?usp=sharing Bug: 931289 Change-Id: I96bc0a6a4b7770457f0c7e6e2583c7eb1a20d46b Reviewed-on: https://chromium-review.googlesource.com/c/1488171Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#636121}
-
Edwin Joe authored
Created a new TabSwitchEventLatencyRecorder class that will track the latency between input event timestamp and the time when tab switching begin processing, and upload the metric to a UMA. Changed the TabStripModel::ActivateTabAt method interface to take enough input event context from the Tab to the TabStripModel, and changed all TabStripModel::ActivateTabAt callsites accordingly. Bug: 921120 Change-Id: I5476ad7db6ebf12e66af61a87c057a154a8e94e4 Reviewed-on: https://chromium-review.googlesource.com/c/1461188 Commit-Queue: Edwin Joe <ejoe@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#636120}
-
Shimi Zhang authored
There are two entries for testOnJsBeforeUnloadIsCalled, removing this one since the crbug is marked as fixed. The other one is assigned to me. Bug: 719974 Test: validated with json validator Change-Id: Ie9973a7ad81a3425b1476fb75e400e7ff6aa7db9 Reviewed-on: https://chromium-review.googlesource.com/c/1492471Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#636119}
-
manuk authored
Certain table cells contain children div's with negative right-margins as a workaround for the lack of flex-gap-support (see comments in omnibox_output.js for more details). When the direct child of a table cell has negative margins, the child overflows the right side of the cell causing: 1) The overflowing cell's scrollbar will overlay adjacent cells. 2) If the overflowing cell is in the rightmost table column, it overflows the table as well, causing the page to receive a horizontal scroll bar. To avoid these issues, this CL nests div's with negative margins inside 'dummy' parent div's. Bug: 891303 Change-Id: I43e2156448c2f5c58a3a4d67063b008f2d90f913 Reviewed-on: https://chromium-review.googlesource.com/c/1491993Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636118}
-
Alice Boxhall authored
This is pre-work for https://chromium-review.googlesource.com/c/chromium/src/+/1369489/29. Bug: 835455 Change-Id: I23bcce41638ca0d4d07d499e977df7ec9a1cc717 Reviewed-on: https://chromium-review.googlesource.com/c/1484878Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636117}
-
Michael Lippautz authored
This moves the ActiveScriptWrappable roots iteration into the actual roots iteration block. It improves readability as all roots are iterated in one place. A side-effect of this is that the write barrier may not trigger anymore for ActiveScriptWrappable's during this iteration. This is enforced as the write barrier is turned off before iterating roots. Bug: 843903 Change-Id: I91232f3aabde9a49a89461aeff1fc084744afb03 Reviewed-on: https://chromium-review.googlesource.com/c/1482982 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636116}
-
Fredrik Söderquist authored
The 'buffered-rendering' and 'color-rendering' properties don't actually do anything, so don't trigger invalidation for them. Fix up comment about gradient stop properties in the vicinity. Change-Id: Iaab0717cf7fc0f0c2a7b13dcae73945c556086f9 Reviewed-on: https://chromium-review.googlesource.com/c/1491311 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636115}
-
Kevin Marshall authored
Migrate base::debug::StackTrace to emit stack traces in the new format documented at https://fuchsia.googlesource.com/zircon/+/master/docs/symbolizer_markup.md Bug: 777252 Change-Id: If42d62af4d358efc3ba61af2b6118026eec9a15f Reviewed-on: https://chromium-review.googlesource.com/c/1474678 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#636114}
-
Adam Langley authored
This will be needed for testing PIN support. Change-Id: I274226528fe5fd3616d4e81233516e08f66406d9 Reviewed-on: https://chromium-review.googlesource.com/c/1484080 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#636113}
-
Sigurdur Asgeirsson authored
Adding the PerformanceManagerTabHelper to these GuestViews allows tracking them and their frame trees in the performance manager graph. Bug: 936071 Change-Id: Iba1c58b41be35c508fc64538f9d6f652821d3242 Reviewed-on: https://chromium-review.googlesource.com/c/1492034 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#636112}
-
Wez authored
Change-Id: I927a12adaf39f28a4e09f61a76a31c411bda2c63 Reviewed-on: https://chromium-review.googlesource.com/c/1489422Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#636111}
-
Will Harris authored
Change enum to use the correct version. Also, populate the WindowsExitCode with a lot more codes seen in the wild. BUG=931436,767906 Change-Id: I95106106da197aa875c033f91a5237b5573291b7 Reviewed-on: https://chromium-review.googlesource.com/c/1490518Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636110}
-
Richard Knoll authored
Bug: 891339 Change-Id: Ia1bd2b8c392d5a60894f6296fb7ffad4e443eae0 Reviewed-on: https://chromium-review.googlesource.com/c/1470200 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#636109}
-
Azeem Arshad authored
The ShouldSkipUserVisibleOnlyRequirements method compares messages app url against the origin. This breaks the whitelisting since the app is now hosted at non-root path. Fixed this by comparing the origin of the app url. Bug: 936285 Change-Id: I5f71017148ec34cfbb45ae0c74aeffff96b88614 Reviewed-on: https://chromium-review.googlesource.com/c/1490755Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636108}
-
Hao Zhang authored
Bug: 929499 Change-Id: Id6e2dafcd263dd11767dacdcd096b27b71d7e954 Reviewed-on: https://chromium-review.googlesource.com/c/1481722Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#636107}
-
Kevin Marshall authored
Queries key-value pairs from a FIDL service and makes them available to Web content via the cast.__platform__.queryPlatformValue() JavaScript API. Refactor shared script injection logic into helper functions. Bug: 929291 Change-Id: Ic58b6e325a4a1d459e8359513ef7030475ae2000 Reviewed-on: https://chromium-review.googlesource.com/c/1456874 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#636106}
-
sczs authored
- Creates a leadingButton that will hold the Infobar badge. - Adds the password icon resources. - Sets the leadingButton to display the passwords badge if IsInfobarUIRebootEnabled. Screenshot: https://drive.google.com/open?id=1I4kFr7sk1LZXQfFsJNUuebmtAG3kf59q Bug: 911864 Change-Id: Id9851f2beb48dd1ed476d80dc729e6ab30e26f97 Reviewed-on: https://chromium-review.googlesource.com/c/1487149Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#636105}
-
Cuicui Ruan authored
When resizing the window with the mouse, it's hard to trigger the black background. When resizing the window with touch screen, it is easy to trigger the black background. Comparing the difference and found that when mouse pressed down, Android receives the drag_started message right away to prepare for drag resizing, while GESTURE_TAP_DOWN, Android doesn't receive the drag_started message until receiving GESTURE_SCROLL_BEGIN, which makes the resizing window falling behind. So the solution is to send the drag_started message to Android when GESTURE_TAP_DOWN after showing resizing shadow. This will improve the two situations: 1) When resizing from small window to big window, it reduces the chances to show the black background. 2) When resizing from big window to small window, it reduces the laggy window. Bug: b/122966727 Test: Manual test. It improves the resizing performance for ARC++. TestED other functions such as moving windows in clamshell mode and tablet mode in split window, and no strange behavior happened. Trybot was also passed. Change-Id: I0641291c4f5ad696798d0a0468e727d91b50ba6d Reviewed-on: https://chromium-review.googlesource.com/c/1474451 Commit-Queue: Cici Ruan <cuicuiruan@google.com> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#636104}
-
Fabio Tirelo authored
This basically reverts the experimentation scaffolding introduced by crrev.com/1174710, and makes GoogleBlue50 the field preview bg color for Autofill and Autocomplete. Bug: 935991 Change-Id: Id821f57c5a2954d502ca241e4414fd452cc501ce Reviewed-on: https://chromium-review.googlesource.com/c/1489173 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#636103}
-
Xida Chen authored
Currently the virtual/threaded/ version of animation-iteration-event-short-iterations.html times out on Asan bot occasionally. The bug number associated with it is a very generic bug. I filed a new bug (https://crbug.com/936462) specifically for this test and change the bug number in this CL. Bug: 248938 Change-Id: Ic203fcbd61cd0fc6e1e0d5ffad5c39c0141e94b2 Reviewed-on: https://chromium-review.googlesource.com/c/1489050 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636102}
-
Ella Ge authored
disable ChromeExtensionFunctionUnitTest.SimpleFunctionTest on windows and chromeos TBR: lazyboy@chromium.org Bug: 925780 Change-Id: I16a21ee84b03b8d0dd967255008e990560e04f1e Reviewed-on: https://chromium-review.googlesource.com/c/1492296Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636101}
-
Fabrice de Gans-Riberi authored
Other similar targets under the //fuchsia directory are referred to as "core" rather than "common". This target is renamed for consistency. Bug: 922635 Change-Id: I84e54aa5183f7590f0caa88b0f943e88ee9aea56 Reviewed-on: https://chromium-review.googlesource.com/c/1489519 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636100}
-
Ian Wells authored
Adds radio buttons to chrome://offline-internals to enable sending X-Offline-Prefetch-Testing with GeneratePageBundle requests so that prefetching can be tested in countries for which prefetching is restricted (or so that the "forbidden" response can be tested from Weblite-friendly countries). Bug: 881120 Change-Id: I66d03d6f2cb71a06b08e5cd300e789bf60acc1c4 Reviewed-on: https://chromium-review.googlesource.com/c/1481951 Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#636099}
-
Tom Tan authored
Bug: 934025 Change-Id: Ibad5ef62fa80c57be05fb145b3b44c70f2585ae4 Reviewed-on: https://chromium-review.googlesource.com/c/1479887 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636098}
-
Scott Violet authored
This is wired up as follows: . ash::WmToplevelWindowEventHandler, which handles toplevel resizes/moving calls to aura::Window when the resize loop starts/end. Specifically NotifyResizeLoop*. . aura::Window::NotifyResizeLoop* calls to WindowObserver::OnResizeLoop*. . NativeWidgetAura gets overrides for OnResizeLoop* that calls to Widget functions (OnNativeWidget*UserBoundsChange). . For the remote client case NonClientFrameController, which is a WidgetDelegate, forwards the calls to ws::TopLevelWindow. . ws::TopLevelWindow trivials forwards the call to the remote client over mojom. . WindowTreeClient (the remote client) forwards the calls to the aura::Window. . DesktopWindowTreeHostMus (remote client) overrides the new WindowObserver functions and calls to the Widget. This means we can collect metrics for window resizing on ChromeOS. BUG=none TEST=covered by tests Change-Id: Iccfe3b769aa4a5813dde5571db4d29e6ef54125a Reviewed-on: https://chromium-review.googlesource.com/c/1485128Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#636097}
-