GitLab

The removes a check on initialization, because the key may be set
after initialization but before use.

BUG=382977

Review URL: https://codereview.chromium.org/347803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278596 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds BluetoothGattConnectionChromeOS and implements
BluetoothDeviceChromeOS::CreateGattConnection. At this point, creating
a connection simply calls org.bluez.Device1.Connect without pairing.
BluetoothGattConnectionChromeOS::Disconnect currently doesn't do anything,
at least until there is a system in bluetoothd for managing GATT connections
properly between Chrome and its profiles and plugins.

BUG=384620,381305
TEST=device_unittests

Review URL: https://codereview.chromium.org/333983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278595 0039d316-1c4b-4281-b951-d872f2087c98

With this change we rely on Service.Visible and only use
Manager.Services to determine which services to observe.

BUG=384380
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/330833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278594 0039d316-1c4b-4281-b951-d872f2087c98

As an intermediate step to disambiguate notifications
at notification UI manager level, we rename notification_id()
to delegate_id() to clarify that it is not an id for
notification in message center.

Also change assignment operator of message center's
notification to protected. Other members are still used by
notification list so they need to be public.

BUG=297867

Review URL: https://codereview.chromium.org/344763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384944
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/345853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278592 0039d316-1c4b-4281-b951-d872f2087c98

There is also a page transition animation to wait for after timer is fired.

BUG=385167

Review URL: https://codereview.chromium.org/344793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278591 0039d316-1c4b-4281-b951-d872f2087c98

This will allow experimentation to occur in M37 without concern about
blowing out memory.  A more thorough memory limit re-evaluation
is expected in M38.

BUG=374917
R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/342523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278590 0039d316-1c4b-4281-b951-d872f2087c98

 gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.

BUG=381601
TEST=covered by test.
R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/340613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278589 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DummySearchBoxView to the experimental app list which
forwards its input to the AppListMainView search box in a similar way
to the NTP's fakebox.

BUG=349727

Review URL: https://codereview.chromium.org/335343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385744
R=jar@chromium.org

Review URL: https://codereview.chromium.org/341553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278587 0039d316-1c4b-4281-b951-d872f2087c98

This adds more of the chrome/common target. The sources don't all compile yet so this is commented out.

Add many resources targets required my chrome/common.

R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/348663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278586 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/333153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278571 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278568 0039d316-1c4b-4281-b951-d872f2087c98

On HiDPI windows these coordinates are in DIPs. While posting them via the PostMessage API we
need to convert them back to pixel using the correct scale factor.

This caused bookmarks to get incorrectly saved at times.

Changes in this patch are as below:-
1. menu_controller.cc. Convert screen_loc to pixels before   invoking Win32 API's as they expect values in pixels.

2. screen_win.cc. Fix the GetWindowAtScreenPoint function   to convert the point to pixels before invoking  
   the WindowFromPoint API.

BUG=381605
R=sky

Review URL: https://codereview.chromium.org/341763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278559 0039d316-1c4b-4281-b951-d872f2087c98

This changes HistoryURLProviderParams from holding an ACMatches object to
holding a HistoryMatches object; the HistoryMatches will no longer be fixed up
in DoAutocomplete(), but rather after it returns control to the UI thread.

The majority of this change is mechanical, but some nontrivial changes have to
be made to DoAutocomplete() to account for how the "promote" action it could
previously take must also happen on the UI thread.  Therefore the |params|
object also has to gain a few members to allow the post-DoAutocomplete() code to
do promotion correctly.

BUG=376199
TEST=none
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/333273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/342823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385379,379219
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/348673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278556 0039d316-1c4b-4281-b951-d872f2087c98

Reverting on trunk per author's request to eliminate top crasher.

> Win Video Capture: Add support for HDYC pixel format.
> 
> This pixel format is a synonym of YUYV and is needed
> for at least the DeckLink video capture card.
> This format is not specified in Windows headers
> probably because this is just a synonym of other
> pixel formats, IOW they are all the same except for
> the first word, which is the name read in hex
> backwards:
> 30323449 --> 0x30 0x32 0x34 0x49 -> 024I
> 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH
> 
> and then all the YUV (422 and 420 alike) use the same
> trailing sequence 
> ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}}
> 
> HDYC: http://www.fourcc.org/yuv.php#HDYC
> 
> BUG=380939
> 
> Review URL: https://codereview.chromium.org/317073010

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/345843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278555 0039d316-1c4b-4281-b951-d872f2087c98

Reverting on trunk at author's request to eliminate crasher

> VideoCaptureDevice Win: Enumerate devices' supported formats when they don't have a DevicePath property.
> 
> BUG=380939
> 
> Review URL: https://codereview.chromium.org/328463002

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/340353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278554 0039d316-1c4b-4281-b951-d872f2087c98

Reverting from trunk at author's request to address crash.

> Smart Revert 276260 "Win Video Capture: Add support for HDYC pixel for..."
> 
> "Smart" because it needed some rebasing.
> 
> > Win Video Capture: Add support for HDYC pixel format.
> >
> > This pixel format is a synonym of YUYV and is needed
> > for at least the DeckLink video capture card.
> > This format is not specified in Windows headers
> > probably because this is just a synonym of other
> > pixel formats, IOW they are all the same except for
> > the first word, which is the name read in hex
> > backwards:
> > 30323449 --> 0x30 0x32 0x34 0x49 -> 024I
> > 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH
> >
> > and then all the YUV (422 and 420 alike) use the same
> > trailing sequence
> > ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}}
> >
> > HDYC: http://www.fourcc.org/yuv.php#HDYC
> >
> > BUG=380939
> >
> > Review URL: https://codereview.chromium.org/317073010
> 
> NOTRY=true
> 
> TBR=mcasas@chromium.org
> 
> Review URL: https://codereview.chromium.org/338853009

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/342253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278553 0039d316-1c4b-4281-b951-d872f2087c98

Doing this via HTML for now; back to RST after I/O.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/342773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278552 0039d316-1c4b-4281-b951-d872f2087c98

JVM's AttachCurrentThread() resets thread name if the caller doesn't pass
thread name. Pass it first time call of AttachCurrentThread(). Not call next
times to reduce syscall (prctl) overhead.

BUG=384603

Review URL: https://codereview.chromium.org/330823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278551 0039d316-1c4b-4281-b951-d872f2087c98

They were changed in https://chromiumcodereview.appspot.com/11360211, but
histograms.xml reflects the old one.

BUG=none

Review URL: https://codereview.chromium.org/327163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278550 0039d316-1c4b-4281-b951-d872f2087c98

This change is related to the new plugin page action UI https://codereview.chromium.org/319553008/

BUG=307323

Review URL: https://codereview.chromium.org/300873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=this is the demo
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/347923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278548 0039d316-1c4b-4281-b951-d872f2087c98

* Don't allow launching GAIA sign in for user pod that is shown with multi-profile policy restriction
* Always show policy bubble when hovering over user pod / clicking/tapping on it.

BUG=385498

Review URL: https://codereview.chromium.org/341453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380916

Review URL: https://codereview.chromium.org/312203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278546 0039d316-1c4b-4281-b951-d872f2087c98

This partially fixes the ozone build.

Tested with:

$ gn gen out/Debug_gn --args='use_ozone=true'
$ ninja -C out/Debug_gn

BUG=None
TEST=see above
TBR=brettw@chromium.org,sadrul@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/338183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278544 0039d316-1c4b-4281-b951-d872f2087c98

Add a test for this case.

TEST=unit tests
BUG=386220
R=binji@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/344833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278543 0039d316-1c4b-4281-b951-d872f2087c98

Don't signal a service is removed unless we've signaled it was added.

BUG=365835

Review URL: https://codereview.chromium.org/346873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278542 0039d316-1c4b-4281-b951-d872f2087c98

Code cleanup for the logic that generates the labels used by the about:gpu page
to report on the feature status. Also separates (and fixes) reporting for impl-side-painting
and gpu rasterization.

BUG=386420

Review URL: https://codereview.chromium.org/344653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386593

Review URL: https://codereview.chromium.org/346833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278540 0039d316-1c4b-4281-b951-d872f2087c98

> [Downloads] Retry renames after transient failures.
> 
> If the cause of a rename failure is suspected of being transient
> (sharing violations, suspected race conditions in the file system), then
> retry the rename with an exponential backoff.
> 
> BUG=368455
> 
> Review URL: https://codereview.chromium.org/319603003

TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/342233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278537 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that windows created in ASH honor the shell work area etc.

We have bugs today where in the first maximized window in ASH does not honor the work area
leading to problems.

Changes as below:-
1. Added a function IsAshProcess for Windows in ash_init.cc. This returns true if the browser
   is launched to serve ASH.
2. In the DefaultTargetDisplayProvider::GetTargetDisplay function check if the browser is launched
   for ASH along with the check for whether ASH is to be opened on startup. If yes then we get the
   display for the root window created for ASH.

BUG=361776
R=sky

Review URL: https://codereview.chromium.org/348513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278534 0039d316-1c4b-4281-b951-d872f2087c98

Polling GL queries is taking ~7us each time on Android.  Processing
queries from ::DrawElements & ::DrawArrays may not be a good idea as
50 to 100 draw calls per-frame with GPU rendering is common
i.e. 350~700us, and more so as we aim for handling higher draw call
counts in the future.

Pending queries are still polled in the following cases:
 - After glFlush().
 - After glFinish().
 - After processing any GpuCommandBufferStub  IPC message.
 - As delayed work, at up to 1000Hz.

BUG=385937

Review URL: https://codereview.chromium.org/342923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357747

Review URL: https://codereview.chromium.org/310413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278532 0039d316-1c4b-4281-b951-d872f2087c98

Now that we rolled the DEPS for speex library, we can use the GN BUILD
file directory from src/third_party/speex.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn speex
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/343943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278531 0039d316-1c4b-4281-b951-d872f2087c98

Alter the design of the bootstrap sandbox to only take over the bootstrap port of children when necessary.

Rather than replacing the bootstrap port outright in the browser process, this
change merely registers the sandboxed bootstrap port with launchd. When a
sandboxed child is being launched with base::LaunchProcess(), a new
LaunchOptions can specify a bootstrap name to look up and use as a replacement
bootstrap port.

The bootstrap port in the new child is replaced after fork() but before exec().
The kernel clears the IPC space during both of these system calls, so no other
references to the original bootstrap port will exist after replacing the port
with the sandboxed one and exec()ing.

This change also partially reverts r276026, which introduced a permissive
policy for NPAPI plugins. Since those plugins are no longer affected by the
bootstrap sandbox, it can be removed.

BUG=367863,383513,383517,383791,386330
R=jam@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/347783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278530 0039d316-1c4b-4281-b951-d872f2087c98

R=navabi@chromium.org

Review URL: https://codereview.chromium.org/345793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278529 0039d316-1c4b-4281-b951-d872f2087c98

This was accidentally broken in r270074 when I added support
for the IAccessible2_2 interface; I got the confusing
COM_INTERFACE_ENTRY syntax subtly wrong.

BUG=386374

Review URL: https://codereview.chromium.org/343653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278528 0039d316-1c4b-4281-b951-d872f2087c98