- 01 Nov, 2019 40 commits
-
-
Livvie Lin authored
Bug: 1008219 Change-Id: I7517202a58ab3d363d9f8f6ba354f7c2a6dd08e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884428Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711711}
-
Matvey Larionov authored
Bug: 330260 Change-Id: I93b00f0c992d879c26f883132eece92a382bb3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890413 Auto-Submit: Matvey Larionov <matthewtff@yandex-team.ru> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711710}
-
Fredrik Söderquist authored
When 'end' changes so that we need to discard/prune our current interval, and said interval is the first interval, revert back to waiting for a first interval again. Bug: 1020163 Change-Id: I7185253474e23a3a58294043102c91e1a59fe10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895335Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#711709}
-
Etienne Bergeron authored
This CL is adding a fuzzer for RenderText API. The stream of bytes is used to drive which API is called and with which parameters. Bug: 1019913 Change-Id: I7a3e6ed2f881a228619d50eefff35cc7093bcc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890958 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#711708}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7870e6996a1..a7669da7bf27 git log a7870e6996a1..a7669da7bf27 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 primiano@google.com CI: Don't run benchmarks under sanitizers and debug Created with: gclient setdep -r src/third_party/perfetto@a7669da7bf27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic94f9b06f7c4f96e7cd54fd5492c4a484b57f660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711707}
-
Andrii Shyshkalov authored
This reverts commit 8e4bd238. Reason for revert: want to verify that workarounds to https://crbug.com/869227 inside vpython itself are actually useful plus to read more logs. The original can re-landed any time if new occurrences of https://crbug.com/869227 manifest themselves. Original change's description: > Remove SpawnedTestServer timeouts. > > These timeouts are ancient. The test infrastructure has its own > timeouts, which should make these obsolete. Also, this may help with > https://crbug.com/869227, where starting the Python test server > times out. > > Bug: 869227 > Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707894} TBR=davidben@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869227 Change-Id: Ic11c2e9a78568738a7712a1141876840f8a63740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893789 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#711706}
-
dpapad authored
CL produced with ESLint's --fix command line flag. Not sure whether those violations existed before ESlint checks were applied to this folder, or whether they were added later. Bug: 1019312 Change-Id: I36c6c6fd1bda88f69b9823ec0dbaec64b09729bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892216 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711705}
-
gogerald authored
Bug: 982018 Change-Id: I6d9bb134e4d98fbd7ebae7a889afd14f880dbfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894139 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711704}
-
Nico Weber authored
This reverts commit dfd0e0a0. Reason for revert: This reverted half the change, leaving trunk broken, see https://crbug.com/1020524 Original change's description: > Revert "Make AppMenuModel keep most submenus in a vector." > > This reverts commit 849315dd. > > Reason for revert: [sheriff] does not build on Mac per builder (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/125702) > > Original change's description: > > Make AppMenuModel keep most submenus in a vector. > > > > They are only needed for ownership, so no need to give them names and concrete > > types. Removes some forward declarations from the header and serendipitously > > happens to remove GOOGLE_CHROME_BUILD from the header as well. > > > > No intended behavior change. > > > > Bug: 961769 > > Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 > > Commit-Queue: Robert Sesek <rsesek@chromium.org> > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711431} > > TBR=thakis@chromium.org,rsesek@chromium.org > > Change-Id: Id7abf98d32a424fdf3d8d0638c9967931eec30a8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 961769 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893867 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711663} TBR=thakis@chromium.org,rsesek@chromium.org,armax@chromium.org Change-Id: Iae16e60dadcda2a91ff8207e214f18989caf5a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895640Reviewed-by:
-
sandromaggi authored
In case of an error (or generally stopping the flow), the usual suspects were cleared. The form was not and stayed visible. Upon interaction with the form in a shut-down state, the system would crash. This is not easily reproducible in normal use but may appear when tab switching is enabled. Bug: b/143753128 Change-Id: I3301f1299fe6a40fe3780752aa3b92b32becc538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893999Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#711702}
-
Eric Robinson authored
This parameter will be used by the HTTP cache to reset when the cache structure has changed, such as when the user becomes part of a finch experiment that uses as different key structure for the cache. Rather than keeping previous entries, this will force the cache to reset in these instances. TBR=ericrk Bug: 1002220 Change-Id: I4bd64e0c546cf6490f61edb3b5bb978daf68808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834403 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#711701}
-
Matt Jones authored
This patch allows features to use the BottomSheetController without necessarily triggering the creation of the BottomSheet itself. This required a few changes: - Observers are now added via the BottomSheetController. This allows features that only want to observe the sheet to do so. If the sheet is not yet created, the observers are stored in a 'pending' list. After the sheet is created, the observers are added to the proper sheet. - The BottomSheet is now created the first time content is requested in the sheet. Supporting this is a 'supplier' of the bottom sheet that wraps the creation logic (still defined in ChromeActivity). - The back button handling and some sheet state accessors have been moved to the controller to prevent external sources from needing to access the bottom sheet directly (especially before it is created). These changes get the bottom sheet much closer to being able to move to the RootUiCoordinator. Bug: 986310, 1002277 Change-Id: I2e79b11bf2b036a33baaadfb62e9a8e59ad5a0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863641 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711700}
-
Henrique Nakashima authored
Use SharedPreferencesManager instead. Bug: 1017800 Change-Id: I67054cbf4ed55c97223258a243b0dab46ff3384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888730Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711699}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ce44a354069..c3d1f9b0cd99 git log 3ce44a354069..c3d1f9b0cd99 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 ivoc@webrtc.org Enable injection of a custom NetEqFactory into PeerConnectionFactory. 2019-10-31 philipp.hancke@googlemail.com do not offer gcm as the preferred cipher suite Created with: gclient setdep -r src/third_party/webrtc@c3d1f9b0cd99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:713701 Change-Id: I62f551a8c393a5a226d4837c3e538bd82251d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893149Reviewed-by:
-
Joshua Pawlicki authored
Extensions.CrxFetchFailureRetryCountGoogleUrl Extensions.CrxFetchSuccessRetryCountGoogleUrl Extensions.ExtensionUpdaterFirstUpdateCheckErrorsGoogleUrl Extensions.ExtensionUpdaterFirstUpdateCheckErrorsNonGoogleUrl Extensions.ExtensionUpdaterRawUpdateCalls Extensions.ExtensionUpdaterUpdateCalls Extensions.ExtensionUpdaterUpdateFoundCount Extensions.UnifiedExtensionUpdaterUpdateCalls Extensions.UpdateManifestDuplicateEntryCount Extensions.UpdateManifestHasProdVersionMinCount Bug: 945554, 975117, 975557, 975557 Change-Id: I1390fb314f33875ba7f0eb11166ce380a2314f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893527 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711697}
-
Asanka Herath authored
Change-Id: I4b651743fdbe3d61fc33028180d71a31ae38ff29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894876Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#711696}
-
Armando Miraglia authored
This reverts commit 9810f16e. Reason for revert: [sheriff] causing failures in webkit linux leak (https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/6377) Original change's description: > Always match :focus-visible on focused element according to user preference. > > The :focus-visible pseudo-selector emulates the existing behaviour of native > elements like buttons by only showing a focus ring when focus is moved using > the keyboard. > > This change modifies that behaviour to always match :focus-visible on the > focused element, regardless of how focus was moved (effectively making > :focus-visible equivalent to :focus) if the user has enabled the "Highlight the > object with keyboard focus when it changes" setting on Chrome OS. > > This plumbs through the ash::prefs::kAccessibilityFocusHighlightEnabled > preference on Chrome OS to a new web setting on Blink, and checks that setting > when computing whether :focus-visible matches on the focused element. > > Bug: 817199 > Change-Id: I072e24eba525e5f62507fb5ab7a369d618067c2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886075 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711597} TBR=ellyjones@chromium.org,falken@chromium.org,dmazzoni@chromium.org,aboxhall@chromium.org,tkent@chromium.org,dominickn@chromium.org Change-Id: Iea484109588c85168a832cc1950c61666a67fb79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894001Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711695}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f28e9facdd3c..204286b6942e git log f28e9facdd3c..204286b6942e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 khokhlov@google.com Make HistogramBinBoundaries creation thread-safe Created with: gclient setdep -r src/third_party/catapult@204286b6942e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1019888 Change-Id: Ib56cc63181d38bfd01067426f3cfe1607bb5a724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894917Reviewed-by:
-
Sophie Chang authored
I have put this behind a feature flag so we can ensure that we can handle the load from the new set of users I still need to do the blacklist management, but as that is a much bigger CL, I will do that separately. Bug: 1005279 Change-Id: I2d357549fc0c97aef7628f8c4b98fa73d0b556c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886352 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#711693}
-
Sahel Sharify authored
This cl cleans up the order in which we calculate whether or not should skip UI, building UI, and showing it on Android. Without this change it is possible that ShouldSkipUI is true but we still show the payment sheet UI. After this change we build the UI and calculate ShouldSkipUI after both of the following conditions are met: 1-request.show is called. 2-All instruments are ready. To properly handle concurrent request.show attempts, both setting and reading "sShowingPaymentRequest" should happen in .show(). Bug: 984694 Change-Id: I7ccae4b1346c5206184217f7c721bcc9db9b3df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877047Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2af989b003e..a7870e6996a1 git log d2af989b003e..a7870e6996a1 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 eseckler@google.com processor: Make sql/sqlite layer optional at compile time Created with: gclient setdep -r src/third_party/perfetto@a7870e6996a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: I494691d9cf0799282004f53e8a7424edc1636cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893150Reviewed-by:
-
Sky Malice authored
Bug: 1020341 Change-Id: I90fd34199754b53585014118b6fefece37e3ccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894395Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711690}
-
Michael Crouse authored
This feature is now enabled by default (https://chromium-review.googlesource.com/c/chromium/src/+/1887718) so this is no longer needed in the json file. Bug: 932707 Change-Id: Ibc5d43e788694857da94652e948e39d771a46b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894141Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#711689}
-
Francois Doray authored
The goal is to support having a BEST_EFFORT execution fence prior to main message loop start in BrowserMainLoop, and a fence when visible tabs are loading in //chrome/browser/resource_coordinator. The lifetime of both fences would overlap. The reason for not having a single fence is that the first fence is controlled by //content whereas the second fence is controlled by //chrome (precise tracking of whether a tab is loading is a //chrome feature). Bug: 839110, 1016825 Change-Id: Icaceee4cf9e5a1d4c52f9bb91e69e9f8125cee2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872807 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711688}
-
Lily Chen authored
Change-Id: I01434f6ef23fcd61a6aec55ef051bb7ba46f8341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895495 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#711687}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2302c7e1. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ic339e36f2c773ba1a51c423be5a22324bbbec9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711686}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I926c4ad7ba373b281e28ac99eeee2456b63fc461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893869Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#711685}
-
Brian Osman authored
Corrects a small bias problem that prevented pure black, and introduced a small chroma shift on greys. In media/video-canvas.html, improve the test so that failures print the timecode and failing channel value. Bug: skia:9543 Change-Id: I691a04c53d476e51a0236f942a93a955865871bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893372Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#711684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bb0ce8e..b1ae70fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ba22d2d98863107fae38dd9ec9a18c72c2ee952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711683}
-
Joshua Pawlicki authored
Bug: 1020330 Change-Id: Ia6aa7442290c5af37c56e387c17cd609ed6467b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894265 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/385f3caebd48..d2af989b003e git log 385f3caebd48..d2af989b003e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 eseckler@google.com processor: Replace pbzero includes in importer headers with fwd decls Created with: gclient setdep -r src/third_party/perfetto@d2af989b003e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:130786981 Change-Id: I6a8bd3b5ad937c6ad9d221e0a6b2313ebb4bc8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895294Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/736b04307a..0c74f23ba9 TBR=sigurds@chromium.org Change-Id: Ib6f2e121d8936255172f9926690739806e349430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895191Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711680}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec, kMiscPlatformAPI if it's not speced yet or kInternalDefault if it's a non-spec-related task. R=falken@chromium.org Change-Id: Ib693ffc41d9c096f3ed6d4e4ab9797cf8fdd1773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888031Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711679}
-
Elly Fong-Jones authored
This change removes DialogDelegate::CreateExtraView, replacing it with a non-virtual method DialogDelegate::DisownExtraView that simply hands back the view provided via DialogDelegate::SetExtraView. An earlier iteration of this change (CL 1881312) went further in adding DialogClientView::SetExtraView() and having DialogDelegate push the extra view to DialogClientView. This broke a bunch of tests in a subtle way: the obvious place to call DCV::SetExtraView was from DD::OnWidgetInitialized. DCV::SetExtraView would then add the new view to DCV, which would invalidate its layout. However, many tests were doing essentially this: TestDialogDelegate delegate; ShowBubble(&delegate); TryToUseExtraView(); and then trying to use the extra view's bounds, most commonly by synthesizing mouse clicks on it. At this point the extra view's layout is invalid *but* it has not yet been laid out, because View::InvalidateLayout schedules a deferred re-layout later. The design where DCV pulls the extra view from DD doesn't have this issue: during the initial construction of DCV, DCV fetches the extra view and slots it into its layout, and then the initial layout pass in Widget::Init causes the extra view to get laid out. Deferring inserting the extra view until after Widget::Init has finished is what causes the extra view to not be laid out (and hence the tests to fail). It's not obvious how to fix this: 1) The tests could manually force a re-layout here, or 2) The tests could be rewritten to not depend on the extra view's bounds, by not trying to deliver mouse events to it somehow, or 3) DCV::SetupLayout could always force an explicit Layout, ignoring the lazy layout system in View::InvalidateLayout None of these seem palatable, so I'm shelving that specific problem and the general cleanup of the interface between DialogDelegate and DialogClientView until a later date. Bug: 1011446 Change-Id: I9641c6306756fd5702a8e9b60558e3223a02f73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887835 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711678}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ce01db4f59d..f28e9facdd3c git log 1ce01db4f59d..f28e9facdd3c --date=short --no-merges --format='%ad %ae %s' 2019-11-01 perezju@chromium.org [Telemetry] Clean up more story_runner unit tests Created with: gclient setdep -r src/third_party/catapult@f28e9facdd3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1008852 Change-Id: I8a78d1ca68e59dd592a66ba7168b0a08253b2d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895157Reviewed-by:
-
Francois Doray authored
The --disable-best-effort-tasks switch was only read when a task execution fence was created. This CL ensure that it is read even if there is no task execution fence. It also adds a test to verify the behavior and avoid future regressions. The TabCapturePerformanceTest.Performance test used --disable-best-effort-tasks to ensure that the test can pass without BEST_EFFORT tasks. Prior to this CL, this flag only prevented BEST_EFFORT tasks from running in the browser process. With this CL, it also prevents BEST_EFFORT tasks from running in renderers and utility processes. Since the test needs BEST_EFFORT tasks to run in utility processes for tracing, this CL changes --disable-best-effort-tasks to ScopedBestEffortExecutionFence. The ScopedBestEffortExecutionFence only prevents BEST_EFFORT tasks from running in the process where it is used (keeps the test's existing behavior). Bug: 839110 Change-Id: I4ef104ccabb81840cbb48d309e1ed3baaa20feda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872654Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec, kMiscPlatformAPI if it's not speced yet or kInternalDefault if it's a non-spec-related task. R=falken@chromium.org,peter@chromium.org Change-Id: Id82556a9da16d0d04acdaf4eed7a9604e8796172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891290Reviewed-by:
-
Juan Antonio Navarro Perez authored
Ensure benchmark names match the regex r'^[\w._-]+$'. Bug: 994187 Change-Id: I2209c2a7c98c638a1e8aa3ad925b1efdc0be6499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886900 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711674}
-
Juan Antonio Navarro Perez authored
To debug testRunPerformanceTestsTelemetrySharded_end2end, add more information and a better formatted output to help figure out the cause of problems when things go wrong. Also re-enable the test on linux to see if previous failures reoccur. Bug: 996003 Change-Id: I86ed6ca3c03943674bc77483688ea24fa5193225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886680Reviewed-by:
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of DOMException, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: Ic11d5b0528ce909faa641ec01047ec2ef4d88775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890404 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711672}
-
