- 04 Aug, 2020 40 commits
-
-
Samuel Attard authored
This ensures that Voice Over can accurately read the words you are typing Bug: 1110480 Change-Id: Ie47053136aa51bc28382f9053175e25d21ac6906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330812 Commit-Queue: Jeremy Rose <jeremya@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#794753}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cf93e1de9eb8..e289c0284053 2020-08-04 bsheedy@chromium.org [Telemetry] Fix minidumps on Q+ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1112486 Tbr: skyostil@google.com Change-Id: Ia9214dff8befc2182b5e3369e4211d7f5e4be871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794752}
-
Dan Harrington authored
- Ignore the signal unless all history is cleared - instead of suppressing feed requests, use signed-out requests for 30 minutes. Bug: 1044139 Change-Id: Ic15d384603777b32b5be4a950441df863032441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333298 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#794751}
-
Mohamed Amir Yosef authored
Details are in the linked bug. Bug: 1108181 Change-Id: If32e2aaf7ab5b38d18607813bf0b6a407826e0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323392 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#794750}
-
Sophie Chang authored
Bug: 1112500 Change-Id: Icdf1aed836db7eb60189709dc1a9a02ca3142420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335506 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794749}
-
Raymond Toy authored
The real and imaginary arrays used to construct a PeriodicWave must have a length of at least 2. Otherwise, throw an IndexSizeError. The error message now looks like: "The length of the real array provided (1) is less than the minimum bound (2)." Test now passes so remove the expected results. Bug: 1112826 Change-Id: Ic336dcd955276aef74b132e39bfed09ca3b67732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337076 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794748}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596549454-7f993c1fb49036aa3a3eb3f7c44ae7cd093767bd.profdata to chrome-win32-master-1596560172-90d73787e73e756b1319ad7ac9a0bacd58cfb767.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2f2dc8cf2612ec891bf852103b9c80b8a674ad1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337374Reviewed-by:
-
Andrew Xu authored
The native view of the navigation widget is not activatable when its target visibility is false. As a result, when the navigation widget is hidden, it fails to get the focus through the FOCUS_SHELF accelerator. This CL fixes the issue by showing the navigation widget before setting the focus. Bug: 1111426 Change-Id: I9a1303ff6170eb98b255e6ce5d3814efce4d08c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337097 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794746}
-
Richard Machado authored
Change-Id: Ibe7a264294c797e751a08910e6297fad8bad2226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295696 Commit-Queue: Ricky Machado <richardmachado@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#794745}
-
Fred Mello authored
https://docs.google.com/document/d/1fmaUj2L_ZOjtwLRf6Bm7OBfUR2XSPb5-ICnxtpfsI70 Bug: 1112872 Change-Id: I85ef46f55bfac62b2c653d06eab4095fdd21a101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337265 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#794744}
-
David Black authored
Previously pressing Cmd+V when ClipboardHistory was already showing would cause the ClipboardHistory menu to re-run. This caused UI jank. Now, pressing Cmd+V will instead execute the selected menu item. If no menu item is selected, the first menu item will be default selected. Eventually this logic will be updated to allow for sequential paste. Bug: 1110013, 1109305 Change-Id: Iab7c71b4b18b0fc77a1f5a2f1903a18a69870436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336022Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Jacques Newman authored
This is just a mitigation in case we need it, I am still investigating to see if there is a better solution. CL that introduced regression: https: //chromium-review.googlesource.com/c/chromium/src/+/2219098 Bug: 1110068 Change-Id: Ib69395ea6ebe56183a9e39d1696ea42c64411b79 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328051Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794742}
-
Angela Yoeurng authored
Pressing enter on the keyword button in the button row did not enter keyword mode as edit model would update since we were moving "away" from a button. This CL adds an extra check to make sure we're not touching keyword mode Some presentational logic for the Inline Tab Match button was moved from AutoCompleteMatch into OmniboxResultView and OmniboxPopupModel. The KEYWORD selection state was also moved to after FOCUSED_BUTTON_KEYWORD.Tabbing out of keyword mode should continue to the next visual selection, i.e. the Tab Match button. With the previous ordering the focus moves backwards to the remove suggestion button. Bug: 1111220 Change-Id: I05eabb179cd9f00624af2a6e96b9b842ab196a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328511 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794741}
-
Moe Ahmadi authored
- Adds promo browser command JS resources. - Makes changes to NTP JS to handle browser commands from the promos. - Exposes the desktop implementation of the handler interface via NTP. - Adds browser tests. For more information see go/promos-deeplinking-settings Bug: 1106421 Change-Id: Ib2643f47889cbb5d4a05b7721b1f5026e120a5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333292 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794740}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a8084f7d..cc5f2c8c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d2a977d77798aeee6ad76c71adebfebc51bc740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337154Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794739}
-
Edward Lesmes authored
This is a reland of 474b44df To be landed after prod freeze ends. Original change's description: > Reland "PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks." > > This is a reland of e6d6e338 > > CheckDirMetadataFormat returns a list of input_api.Command objects, > which are not derived from output_api.PresubmitResult. > > Fixed by running it using input_api.RunTests. > > Original change's description: > > PRESUBMIT.py: Replace checkteamtags with DIR_METADATA checks. > > > > checkteamtags is no longer necessary. > > - Add a check to validate DIR_METADATA files. > > This obviates the need fo checkteamtags, as `dirmd` validates metadata in > > OWNERS files, and we no longer need to enforce a unique team email for all > > (component, OS) pair. > > - Add a check to enforce that OWNERS files contain no metadata if a > > DIR_METADATA file is present in the same directory. > > > > Bug: 1102997 > > Change-Id: I661f7a1958824e7d20642d65534c2502d1a050e2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317838 > > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791884} > > Bug: 1102997 > Change-Id: Iff7d2569ee4e9a5a66773dba47e2de8e3c8f9b82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321550 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792486} Bug: 1102997 Change-Id: Id37529f26d549756c9175e92141143aeb1ba66e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330738Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#794738}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/06e30bae5cbf..b156b016f22b 2020-08-04 hjd@google.com Merge "ui: Userspace slice aggregation V0" 2020-08-04 treehugger-gerrit@google.com Merge "Store superclass in HeapGraphType." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If3ac62413c1c68ef97e59094932b21919194e0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337128Reviewed-by:
-
Yue Li authored
QuickAnswersUiController should not try to access the quick answers view in destructor, since the view is owned by view hierarchy. Set the pointer to null instead and added a unittest case for it. Bug: b/162806534 Test: Run the newly added test in ash_unittests Change-Id: Iedc5ca63c178a62b54b55525d5469874e97704c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336495Reviewed-by:
-
wutao authored
Change the transition animation duration to 500 ms. Bug: b/162782654 Test: manual Change-Id: Ic7ee30843bc04c4666a29e56ff859343acb29b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337376Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794735}
-
Mitsuru Oshima authored
Bug: None Change-Id: I699335142351d8a33e031db7d8d921536d06a3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336496Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#794734}
-
Eric Orth authored
Included a minor change to make DnsQuery copyable because previously only allowed copying while changing to a new ID. Bug: 1112786 Change-Id: Ie2f741358b74fa2629142b76b47f965dc3378fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336300Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#794733}
-
Dale Curtis authored
Per Microsoft, there are threading issues in the older versions of the vpx decoding dlls. R=zmo Bug: 1062849, 1094840 Change-Id: I404c35cfaf7bac714c05f3da11b5f341042e3fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333079Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794732}
-
Fred Mello authored
https://docs.google.com/document/d/1_hupTnjnQoEnguC1PXv-WJcS9ViVeNJsuWSNWWYYB2c Submitted a request to create a new component in crbug (UI>Browser>Accessibility): https://bugs.chromium.org/p/chromium/issues/detail?id=1112889 Bug: 1112872 Change-Id: I7fb752e14576613bbab1c84754ec4b54444cec3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337256 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
-
Muyao Xu authored
- Log the current available media sinks users can see in the Cast Dialog when users close the window. - Log when useres start/stop a cast session. - Replace some DLOG()s with the native component logger. Bug: 687380, b/154273698 Change-Id: I383ea07adc0a5b1a9a59898be17127f0cd87dc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303568 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#794730}
-
Swapnil authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. We collect the UMA statistics for the time taken to verify the signature of CRX. Following histogram is added: Extensions.ForceInstalledTime.CRXDownloadCompleteTo. VerificationComplete Bug: 1102369 Change-Id: Ic1b38abcff8557fba1cd1c6b59de716d489355d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336080Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#794729}
-
Yu Han authored
Bug: 1112778 Change-Id: I781e82988f137cdf2edf01634c94510a5642fad4 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335756Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794728}
-
Lei Zhang authored
Check for FPDF_StructElement_CountChildren() result for negative values, which means error. Do not continue on error. Also check the children count earlier in the function, and return early when possible. Change-Id: If7365ef32054bc9d6200482c458cfc2471af8bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337127 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Adam Langley authored
All caBLE work can actually be done in by a single upcall from the content/ layer rather than needing three functions. BUG=1002262 Change-Id: Ibf995b9266808b75101d46960b5a96baf50908b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333867Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#794726}
-
Brian Sheedy authored
Bypasses Skia Gold functionality in all Gold-backed tests, as there appears to be a Gold outage which is affecting bots. TBR=kainino@chromium.org No-Try: true Bug: 1112946 Change-Id: I0ce096473c6378a6771cee16417cfcb600914279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337264Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794725}
-
Matthew Mourgos authored
This change checks whether images to be standardized have a height equal to their width, and if needed, adds padding to ensure the width and height of the image are equal. Bug: 1110496 Change-Id: I2879c0ad821074a30b7a983ae89541a7aade613d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336636Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#794724}
-
Becca Hughes authored
This will open a feedback dialog when clicked. BUG=1111981 Change-Id: I8a7091181231ffb405f0369aa67e423b191bcdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333371Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#794723}
-
Noah Rose Ledesma authored
The Global Media Controls (GMC) UI will allow the user to change the audio output device used for a webpage. This change adds a method to the RenderHostImpl allowing normal output device authorization to be bypassed for a single device selected by the user. The bypass works by storing a single device id hashed for a particular security origin in the AudioOutputAuthorizationHandler. The result of access permission checks will then be overwritten if the requested device has the same id as what was stored. Bug: 1105132 Change-Id: I9d22e617c502ed8d69fdddc06571017c7ba1f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295824 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#794722}
-
Rebekah Potter authored
This reverts commit 4af05312. Reason for revert: Breaking ash_unittests and browser_tests on chrome os builders, see https://bugs.chromium.org/p/chromium/issues/detail?id=1112924 Original change's description: > Change hiding timer logic for password textfield on login/lock screen > > 5-second instead of 3-second timer for password/PIN going back to masked format. > 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. > > Bug: 1101326 > Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#794602} TBR=rsorokin@chromium.org,tellier@google.com Change-Id: I2cb94561e291ccadf623af2bd4529cd4c9bd23de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337388Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794721}
-
Jan Wilken Dörrie authored
This change includes the last fixes to fully migrate chrome_cleaner to use std::wstring instead of base::string16 in its implementation. In order to be future proof, this change also adds explicit conversions when interfacing with cross-platform APIs, that rely on using base::string16. Bug: 911896 Change-Id: Id2ffe83831012b7ece1c51457325c151a9310774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333839Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794720}
-
Claude van der Merwe authored
The "Keep wi-fi on during sleep" setting was deprecated in https://chromium-review.googlesource.com/c/chromium/src/+/2163040. Removed kWakeOnWifiDarkConnect / wake_on_wifi_darkconnect from the code and the setting from the UI. Bug: 1077126 Change-Id: I6753e8296e5fd1652fce0027b8069e41c4a9c87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335481Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#794719}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium style guide. Bug: 1106011 Change-Id: I815f93eab2c860f191827342e6489b80a717c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335319 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#794718}
-
Rebekah Potter authored
This reverts commit 3cea47a9. Reason for revert: This CL is a likely suspect for breaking fullscreen/compositor-touch-hit-rects-fullscrean-video-controls.html test from blink_web_tests across multiple platforms. Original change's description: > Composite fullscreen videos with composited descendants. > > This fixes the referenced performance regression in which some such > videos stopped being composited. > > Bug: 1108972 > > Change-Id: Ia77d33c1c50cf25427d825ae3969a120a8cde640 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335648 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794573} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I1e1ea71e70e557b867e03f66496bfc97cc182165 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108972, 1112884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337261 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This also clean some of the code in base/memory/memory_pressure* (as a reply to some comments on one of the early patchsets). Bug: 1105630 Change-Id: I74332c5ada89139a4d73728d65dc24a8b700a97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310906Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#794716}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9969655224d7ca76d5ad35880312095065108d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336905 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I37fed8d5dffc78513fc5d4dd762b1ede9c358cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336191Reviewed-by:
-
