- 22 May, 2020 40 commits
-
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iad5e16fcafed40a29bc65aa8923dfda0b7ec9d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213328Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771334}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80abb89c3632..ec31488ace66 2020-05-22 mtklein@google.com Revert "Add a tessellation mode that uses indirect draws" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I44e9edc52e3ed0240bfaae92a038009c083956eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771333}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ee5ef3583d8..71f352e32811 2020-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6f723ebbe3b0 to 2cf9621d6d6f (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ic851d144c8698e9b52d5bdecab9bc9bd9d20dc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213542Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590119331-1f693e469085ff93aa0c94ab92b41ec8ed0e78d9.profdata to chrome-win32-master-1590147234-0a723ff3779a785a5a73326d87db7cb98fa45feb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I22551e62a333ecf57c4aed528211de48d2266e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213547Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70e7d879d045..7524d2e6a243 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: I6c9f3fc092ba1d37758a4ca79cbbffc3fc6ca161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213543Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771330}
-
Alexander Surkov authored
line indexes. AccTreeFormatter serializes accessible objects as a combination of role/name/etc. It'd be nicer if the objects were serialized as line indexes from the expectation file. It makes more readable and error proneness serialization. Bug: 1082800 Change-Id: Icf37067c05b967183baa7496bd4e5188a8abc1d0 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202958 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#771329}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea4a9d33f5fa..70e7d879d045 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: Ie924a21eca6dba43c286a26a7e1f1e201a716df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213445Reviewed-by:
-
Michael Achenbach authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b912f2..414d114a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org Change-Id: If7cbfb0cb3dab152b05c76d9c1222f854ccb44b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212206Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#771327}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/96a80283cc0f..0ee5ef3583d8 2020-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 3c47dac28208 to b0264b87ffb5 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Iaaffd8544394ae4c15045306c6b033f378649f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213319Reviewed-by:
-
Mugdha Lakhani authored
This removes expectations for non existing tests from the WebLayer WPT expectations file. Bug: 1057771 Change-Id: I5cabe191ac20d1f1dabfb80ac6f05e4d80bbb23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212521Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#771325}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/609a0cffce10..ea4a9d33f5fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I4c5588b71647a4d27dd65c19025e4d847438e948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213313Reviewed-by:
-
Ankit Kumar authored
This CL populates the data of a popup note associated with a highlight. The populated data is sent from plugin to mimehandler. The pepper interfaces are already structured to pass along the popup note text data. The CL also modifies the structures related to highlight in the plugin layer to store the note text, which is then passed on to the pepper layer while sending highlight related data. Unit test has been modified to validate the popup note text value. Bug: 1008775 Change-Id: I0e83b7d04d23922daa20ccd3e5c8e602c6ac5077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208318 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771323}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If788d41bbbaf2f9c7bc72a54e616d04ae0166f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213318Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590119331-9d6af4f8adcea4a27aaea0d62407ee7617e48430.profdata to chrome-mac-master-1590134157-7528a57fcdaef12919b38ac2ee42ea942a34f878.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Icaff70583e7945d85a479260960c87a887ffa957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213443Reviewed-by:
-
Henrique Ferreiro authored
Bug: 1029142 Change-Id: I72eeb7f72b5eac76356f6c0d90942dc429b5b159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185115 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Rohit Agarwal authored
Intent URIs can expose file:// URI which upon external navigation from can result in unhandled FileUriExposedException android exception. This CL adds check in ExternalNavigationHandler to ensure we never send the intents generated by Intent URIs with file scheme to Android which could result in unhandled exception. This CL also adds unit and browser tests. Bug: 1085476 Change-Id: I0cff50d517a491dc27e345372ddcc5c77f8e26cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212169 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771319}
-
Ankit Kumar authored
Bug: 1084957 Change-Id: Ida67162676737644e987a43aaff5cf713a75301e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212221Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771318} -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bc656b61d29..80abb89c3632 2020-05-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I76e137f4f9443397e346df4413ac2e9ec1fa272f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213314Reviewed-by:
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: I17f1433a8303cf2bfbeade76dc196b7a81921236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203347 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771316}
-
Rahul Singh authored
This CL fixes an issue that prevents an app icon from appearing when the Create shortcut dialog is invoked. The dialog is invoked by clicking: Customize and control Google Chrome > More tools > Create shortcut... Cause: The initial CL for shortcuts menu https://crrev.com/c/2146212 modified FilterSquareIconsFromMap() in web_app_install_utils.cc. From: void FilterSquareIconsFromMap(const IconsMap& icons_map, std::vector<SkBitmap>* square_icons) To: void FilterSquareIconsFromMap( const std::vector<WebApplicationIconInfo>& icon_infos, const IconsMap& icons_map, std::vector<SkBitmap>* square_icons) This was done because icons_map can contain both app icon and shortcut icon related bitmaps when a site specifies shortcuts icons in it's web app manifest and the shortcuts menu feature is enabled. The code inside FilterSquareIconsFromMap() iterated over icon_infos while adding bitmaps to the square_icons vector. Those bitmaps were used to generate app icons of various sizes. For some websites like www.google.com icon_infos can be empty. In such cases, the code to populate square_icons in FilterSquareIconsFromMap doesn't run as there's nothing to iterate over. This results in an empty square_icons which in turn leads to no app icon in the Create shortcut dialog. Fix: This CL reverts FilterSquareIconsFromMap() to its state before the shortcuts menu feature landed (no icon_infos argument). In FilterAndResizeIconsGenerateMissing() which calls FilterSquareIconsFromMap, the code checks if kDesktopPWAsAppIconShortcutsMenu is enabled. When the feature is disabled, it calls FilterSquareIconsFromMap(). When the feature is enabled, it calls the newly added: void FilterSquareIconsFromMapDisregardShortcutIcons( const std::vector<WebApplicationIconInfo>& icon_infos, const IconsMap& icons_map, std::vector<SkBitmap>* square_icons){} This method calls FilterSquareIconsFromMap() if icon_infos is empty. Otherwise, it iterates over icon_infos. Testing: I tested this fix by invoking the Create shortcut dialog with the DesktopPWAsAppIconShortcutsMenu feature enabled and also with it disabled. In both cases, app icons showed up as expected. I've also added a couple new unit tests for FilterAndResizeIconsGenerateMissing(). Bug: 1084913 Change-Id: I59bf6ca45e84546a93c891c52014017bd566c8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209968 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#771315}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I57ba4a61297a9834022c6d73998dea8d1079530c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213235 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da90c3765908..9bc656b61d29 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 16e86c0b to f1735ff5 (360 revisions) 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e8b8b8164520 to 96a80283cc0f (13 revisions) 2020-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 8a3cc5c4dfd8 to 65ee6497d620 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1080984 Tbr: lovisolo@google.com Test: Test: Test: angle_perftest --gtest_filter="*Trace*egypt*"Test: Test: angle_perftests Change-Id: Ic95ebf9d698ef97ee456cb63f23177e2bbc84fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213308Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f41b134dc274..609a0cffce10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: Ifee72dde42827fe1d9eca789b5cecd832bb1e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213304Reviewed-by:
-
Pawel Baran authored
Change-Id: If5e0b52e6e6348ea72c708a90da08ef0b189f930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207173 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Tom Anderson authored
These are needed for [1]. Normally, events are only read, but there is a special case for client messages where we want to write an event that will be sent directly to another client. Also the connection setup data doesn't have a corresponding reply, so a special reader needs to be added for this too. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2212976 BUG=1066670 R=msisov CC=sky Change-Id: Ibded85ee3451a891c41ada62f32167bb779ed924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209961 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#771310}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590091165-7a7a14d98fbe05f411f7ca7cd83845ea7366876a.profdata to chrome-win64-master-1590119331-fbabb52511f6c610b90717a191978d71b893771f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I34908a5e994fbcbcbaf5f5db3b62b6269cfd8283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213309Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590091165-57e2eb3ac957bb561cdabd6b908ea2826fe03189.profdata to chrome-win32-master-1590119331-1f693e469085ff93aa0c94ab92b41ec8ed0e78d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id8d96f7d9d82d73e3593525f90d34c622c57f25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213310Reviewed-by:
-
Victor Costan authored
AppCacheNetworkServiceBrowserTest.SSLCertificateCachedCorrectly has been flaking out since December 2019. Disable the flaky test, to stop slowing down CQ. It's unlikely that we'll invest into figuring out what's happening here. Bug: 1031090 Change-Id: I9157559ee1770e6755a6af3215f5a80153d0235b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210912 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
David Black authored
Bug: b:153496343 Change-Id: I859f09af03f1b93a03202bc3ef913da14c31de72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211137 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#771306}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/317dce5c81c0..da90c3765908 2020-05-22 fmalita@chromium.org [skottie] Cleanup KeyframeAnimatorBuilder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Id5386c4eeb4ab99a0a99d146a78051cf29ff37f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213302Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590105571-9ab15c0da41a7aac619a0ba03729f850a564de99.profdata to chrome-mac-master-1590119331-9d6af4f8adcea4a27aaea0d62407ee7617e48430.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I05dc33a012d738f090b6b3a25b40d449c8025973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213306Reviewed-by:
-
rbpotter authored
- Fix some comment indentation - Remove extra lines in function descriptions - Change non-closure comments to not use closure (/**) annotation Bug: None Change-Id: I7dea133834907172567854968e16f0f92db923f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209969 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771303}
-
Abhijeet Singh authored
The API currently takes 8 parameters and since not all of them are required, the params are factored out to a struct in this CL for a cleaner API. Bug: b:135949296 Test: Tested on Chrome OS VM and Atlas test device. Change-Id: I014662599150b7e795d2e5902fbea0cebbd8af22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212815Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#771302}
-
David Black authored
TBR=xiaohuic@chromium.org Bug: b:146669457 Change-Id: Ia0b5894cfe748d001b25911df3a2aa761807afbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213233Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/456c48d718c1..f41b134dc274 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1041701 Tbr: yosin@google.com Change-Id: Ic03e4cd96ac38cf0479971381774c33bae97e514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213229Reviewed-by:
-
Victor Fei authored
Refactor the following AXNode table functions to directly return std::vector<AXNode::AXID> like the following: std::vector<AXNode::AXID> GetTableColHeaderNodeIds() const; std::vector<AXNode::AXID> GetTableColHeaderNodeIds(int col_index) const; std::vector<AXNode::AXID> GetTableRowHeaderNodeIds(int row_index) const; std::vector<AXNode::AXID> GetTableUniqueCellIds() const; std::vector<AXNode::AXID> GetTableCellColHeaderNodeIds() const; std::vector<AXNode::AXID> GetTableCellRowHeaderNodeIds() const; Previously these results vectors were passed in as a pointer and modified. This new change should have no performance impact as c++ std library utilizes Move Semantics when returning std::vector AX-RelNotes: N/A. No impact on AT behaviors. Change-Id: I7aab763091b972a52576ba5227ee7dccc1e05d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209633Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74f67e29f7ee..42033b2c6a25 2020-05-22 linyhe@microsoft.com Fix gclient-new-workdir when source repo is shallow clone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib5542507540eb1161ee9248bc477bc9af17637f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213230Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 927697 Change-Id: If7e8aa4898d44b38f9b2df7cdca7a2aed7c16063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210820 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
David Black authored
Proactive suggestions feature experiment is being turned down. Cleaning up footprint. Bug: b:157237955 Change-Id: I192398967acd9562a224845b8b2faa39d42e6727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212468Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Ankit Kumar authored
When focus transitions to or out of the PDF document, notify the PDF UI of the same. PDF UI needs the information to draw/hide the focus rectangle around the PDF document. Unit tests have been added to validate the scenario. Bug: 1069370 Change-Id: Ic25d79139ebf361d85168891580d14187610b0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061928Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771295}
-
