GitLab

Upstream Review:
"Remove writeJSON / toJSONString from generated protocol types."
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2013082

In addition, remove no longer used method builderAppendQuotedString
from v8_inspector_string.{h,cc}.

New Rev: 6361d066985aafcb5c7d7b4066da0a0ecaa5866d

Change-Id: I975ffa795b01cd44e16f9d8e42127a3c23528213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013314Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733925}

Following bot results are included.
1062 1064 1069 1071 1072 1073 1074 1075 1077 1078 1079 1080
1081 1082 1083

45 lines were removed and 6 lines were deflaked by consecutive
results since 1061.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: Iabe36ca8cee09897b6e815c9892cf47017d1b09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010750Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733924}

Also rename any function only used in tests as ...ForTesting()

Bug: 1007223
Change-Id: Icba435869d4d78d48f021c989c2c340852bd122c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004989Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733923}

Failing

TBR=vitaliii@chromium.org

Bug: 1044514
Change-Id: I698c4527a69a6e689e4be99e145b1bbf7bef327b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013047Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733922}

As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2003320
Added a test for the new logic and fixed the test that was broken.

Bug: 1042611
Change-Id: I26f29d782879f28272fc5d544c0a783b7dc948de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010789
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733921}

This reverts commit 9ff29d67.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Roll src/third_party/devtools-frontend/src 564dcf4c071b..28a405e6e578 (1 commits)
> 
> https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564dcf4c071b..28a405e6e578
> 
> git log 564dcf4c071b..28a405e6e578 --date=short --first-parent --format='%ad %ae %s'
> 2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
> 
> Created with:
>   gclient setdep -r src/third_party/devtools-frontend/src@28a405e6e578
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/devtools-frontend-chromium
> Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Bug: None
> Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
> Change-Id: I5bb1aadf2b46e6a7722af2fd200c0118ae1cbe16
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014154
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#733886}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com

Change-Id: I725c77303c6a5a2d4fb76b8b24320e0a4eedbf54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014443Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733920}

This reverts commit aaab30e7.

Reason for revert: BUG:1044520

Original change's description:
> Local NTP: make past search matches change realbox icon to clock
> 
> R=​mahmadi@chromium.org
> 
> Fixed: 1043335
> Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614
> Auto-Submit: Dan Beam <dbeam@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Commit-Queue: Dan Beam <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733854}

TBR=dbeam@chromium.org,mahmadi@chromium.org

Change-Id: I2b2371de6ae0e3144a3bd827539526864859c570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013245Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733919}

When ImageLoader get requests to process image files, it checks message
sender's id to disallow requests from unknown clients.
However, sender's id is currently not trustworthy (issue 982361). We
should use sender's origin instead as a short-term fix.

Bug: 10321587
Test: Manual test on Files/Gallery to show thumbnails from ImageLoader.
Change-Id: Idb61850795828a63b37aa43b66d4875ad7abbfc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989728
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733918}

https://pdfium.googlesource.com/pdfium.git/+log/c3e55aa23f88..a216865467dd

git log c3e55aa23f88..a216865467dd --date=short --first-parent --format='%ad %ae %s'
2020-01-21 tsepez@chromium.org Add doubleclick event handling to pdfium_test_event_helper.cc
2020-01-21 thestig@chromium.org Fix some nits in CPDF_TextPage code.

Created with:
  gclient setdep -r src/third_party/pdfium@a216865467dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1043510
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I9254e43b033930e1573eccc14e5d5a0e9f8bc9d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013907Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733917}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=mahmadi@chromium.org

Bug: 1042208
Change-Id: Ia971578b2b012398b81c4a14d206732411f384b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007581Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733916}

This is enabled only when Out-of-Renderer CORS is enabled.

Bug: 835821, 724929, 876678, 876670, 876669, 876668, 876666, 848275
Change-Id: Ia6a3553797007f9bb905de8b84d39ec7b2370d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011786
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733915}

https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e

git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s'
2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19)
2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18)
2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17)
2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15)

Created with:
  gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium
Please CC bling-p10-rolls@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc
Bug: None
Tbr: bling-p10-rolls@google.com
Change-Id: I86df0fb78be3e2361d85316ad293d926a4194c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013203Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733914}

This reverts commit 0bfc424a.

Reason for revert: Found cause of revert and fixed

Original change's description:
> [Sheriff]: Revert "More Settings Page Interaction UMA"
>
> This reverts commit 561bf1af.
>
> Reason for revert:
> Strongly suspect this is causing failures on the debug builders:
> [29058:775:0117/070736.663833:ERROR:CONSOLE(49)] "Mocha test failed: PersonalizationOptionsTests_AllBuilds signinAllowedToggle
> Error: Uncaught TypeError: Cannot read property 'PRIVACY_CHROME_SIGN_IN' of undefined (chrome://settings/privacy_page/personalization_options.js:102)
>
> r732804 was reverted earlier for the same reasons, but there are still failures coming from the settings code, albeit less
>
> Original change's description:
> > More Settings Page Interaction UMA
> >
> > Move the settings enum and the call to uma to a separate browser proxy.
> >
> > Add UMA to all site settings subpage interactions and new toggles moved to the main settings card
> >
> > Bug: 1032584
> > Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651
> > Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
> > Reviewed-by: Dan Beam <dbeam@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#732785}
>
> TBR=dbeam@chromium.org,harrisonsean@chromium.org
>
> Change-Id: Id4ee78d89487ecf7e6d1935088d02b29de89c7c8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1032584
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007829
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732870}

Change-Id: Id60aa270741ac9305effac5a13587eb1a1d89102
Bug: 1032584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007716Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733913}

SSLErrorHandler is on course to being componentized for sharing with
WebLayer. It currently internally triggers extension events when
security interstitials are shown. As this is //chrome-level behavior
that cannot be componentized, this CL gives SSLErrorHandler an API
via which the client can set a callback that is triggered on showing
of security interstitials.

Bug: 1030692
Change-Id: Ic3846d62c598af55ae64d880b229b37f1a12390c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010943Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733912}

The Plugin VM installer currently fails if a VM already exists. This can
happen if the user manually sets up a VM via vmc. This CL updates the
installer so that it first checks whether a VM exists, and proceeds to
the finished state immediately if so.

Bug: 1038816
Change-Id: I19381288c7fd2f2beaa82ffdb72ae5102d1f4c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014203
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#733911}

This reverts commit ba52e783.

Reason for revert: This caused flakiness in the TwoClientAutofillProfileSyncTest.ClientsAddSameProfile test.

Original change's description:
> Reland "Fix flaky test ServerAddressConvertsToSameLocalAddress"
> 
> This is a reland of commit b3873b4d.
> 
> The CL fixes a race condition in production code of autofill profile
> sync bridge by modifying merge logic of the datatype. Previously, the
> logic for dealing with duplicate entities was to always prefer the
> remote one and silently delete the local one. This could end up with
> two clients having a different entry each and the sync server having
> both duplicate entries. The new behavior, introduced in this CL is to
> keep the profile with greater GUID, lexicographically.
> 
> This change should also remove flakiness of one integration test (that
> uncovered the actual issue), so the CL reenables the test.
> 
> The original CL caused flakiness in another integration test since GUIDs
> in that test are randomly attributed. In this reland, we fix this by
> making the expectation on the number of sync deletions depend on which
> one of the test GUIDs is bigger.
> 
> Bug: 917498
> Change-Id: I13994ac5bef8fcae41d37350e08ee80ab90f0916
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002571
> Auto-Submit: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733636}

TBR=kolos@chromium.org,jkrcal@chromium.org,mastiz@chromium.org

Change-Id: Ifad46c8c079b24a07c044b9d6a5ffdc77a439617
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 917498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013281Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733910}

error of SharedWorker is |Event| type or |ErrorEvent|.
This CL removes error.message because |Event| doesn't have |message| property.
https://html.spec.whatwg.org/multipage/indices.html#event-error

Bug: 1043634
Change-Id: Id7ff6b4222c56b770457731694f07fd850504681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011621Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733909}

Using wpt-import in Chromium a94bda97.
With Chromium commits locally applied on WPT:
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I7e39010224ddee171c719d52fbe006c4510bb1b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012796Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733908}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fef76e222696..49d180876100


Created with:
  gclient setdep -r src-internal@49d180876100

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ia10c7d1bdf65399d8201321657bd3cd6a5772baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014301Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733907}

Based on the given |file_type|, GetRecentFiles to ARC media source
should return filtered result.
For instance, if the specified file_type is "Images", we should query
recent files only on "images_root" in the MediaDocumentsProvider.

Bug: 1040049
Test: Ran unit_tests
Change-Id: I1e24d9c8338355b7036fe2a7ad1d129c54d7a2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012200Reviewed-by: Satoshi Niwa <niwa@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733906}

The image processor's output buffers don't need to follow the decoder's
coded size ; what we are interested in is having a buffer that can
contain just the visible area.

The VDA already (correctly) does this and thus needs no update.

BUG=chromium:982172
BUG=b:141579960
BUG=b:146599071
BUG=b:141965953
TEST=Youtube playing in 240, 360, 480 and 720p on desktop and Android
with Krane and Kevin. No artefact or green line visible.
TEST=GtsMediaTestCases com.google.android.media.gts.MediaPlayerTest
 #testLLAMA_H264_BASELINE_240P_800_DOWNLOADED_V0_SYNC passes on Krane
without a green line.

Change-Id: I35c24ef6c56d1c7fe91e879483698f1f9f5e51d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011785
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733905}

This reverts commit bbbb72b3.

Reason for revert: MediaAppUIBrowserTest failing on linux-chromeos-chrome
Fixed: 1044503

Original change's description:
> Enable chrome.metricsPrivate for the untrusted context of MediaApp so we can use UMA.
> 
> Doc: http://go/backlight-ea-uma-metrics (slightly outdated)
> 
> Bug: 996088, b/128567301
> Change-Id: Ia272a35815ac92de954a6e5c43e1c2d4ea502e0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000440
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Commit-Queue: David Lei <dlei@google.com>
> Cr-Commit-Position: refs/heads/master@{#733884}

TBR=tapted@chromium.org,benwells@chromium.org,dlei@google.com

Change-Id: I7e95b2c95bb5b1abd2f19416e585ae6f7f6f404b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996088, b/128567301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014354Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733904}

I accidentally removed this in crrev.com/c/1973194, and subsequent
attempts to roll the AVD images have failed on larger test suites as a
result.

Bug: 922145
Change-Id: Ie7b55f456dcd27ec1d17b33814ea258345892c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012790
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733903}

This reverts commit 32a1f8bf.

Reason for revert: LocalNTPJavascriptTest failing on 7 builder(s)
Fixed: 1044497

Original change's description:
> WebApps: Implement unregistering file handlers on Linux.
> 
> This will allow us to disable the file handlers for an app on Linux
> without uninstalling it. This is necessary preparation for the origin
> trial, as we need to be able to disable/enable the file handlers as
> the validity of the app's origin trial changes.
> 
> Bug: 1028448
> Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234
> Commit-Queue: Jay Harris <harrisjay@chromium.org>
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733859}

TBR=loyso@chromium.org,harrisjay@chromium.org

Change-Id: I67239e88d48df1d70ff1a432863b3be26d5d7bd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014352Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733902}

This reverts commit d17c53b3.

Reason for revert: This makes the GPU process crash on startup on Krane (and probably many other ChromeOS devices).

Original change's description:
> Call PreSandboxStartup after GL initialization in GpuInit
> 
> Fixes "vaInitialize failed: unknown libva error"
> on Wayland with LIBVA_DRIVER_NAME=i965
> 
> VaapiWrapper relies on the GL implementation to decide
> which display to use. If the GL implementation is none,
> then VaapiWrapper is likely to do the wrong guess resulting
> in the above error.
> 
> Bug: 1041229
> Change-Id: I1255a032a5e14b3aaffe3026a886de7e6d9ff0d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011640
> Reviewed-by: Maggie Chen <magchen@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733847}

TBR=kbr@chromium.org,julien.isorce@chromium.org,magchen@chromium.org

Change-Id: Ic536f47506a2e9a3f6db8f946732030295a8d63f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014351Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733901}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by me.

Bug: 1041419
Change-Id: I730b20897134a058e4f98b5279d4dc3409c6cab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012602
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733900}

When importing a buffer, the provided buffer's size may differ from the
size we requested from ProvidePictureBuffersWithVisibleRect(). We
already accounted the width difference, but not the height, which
resulted in green lines being visible when the provided buffer differed
in height, and was single-planar: the image processor would render using
the assumed height, while the GPU would render using the real height,
resulting in the color plane being offset by one or two lines.

Since the VDA and SVDA both need to do this, factorize the actual buffer
size's computation code into a VDA helper, and call it from both.

BUG=chromium:982172
BUG=b:141579960
BUG=b:146599071
BUG=b:141965953
TEST=Youtube playing in 240, 360, 480 and 720p on desktop and Android
with Hana, Krane and Kevin. No artefact or green line visible.

Change-Id: I0e28446805fd382cbe0d3aab30b704c85ca52b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011784
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733899}

ManifestUpdateManager and ManifestUpdateTask are not used outside of
web_applications and are not isolated components, they should live one
level up while maintaining independence from the BMO/Extension backend.

This CL is in preparation to add a dependency from
ManifestUpdateManager to SystemWebAppManager.

Bug: 1035242
Change-Id: I3a5e8e691079619e5b063ac90653dcae6ee3f76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973441
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733898}

The histogram Search.ContextualSearchQuickActions.Category is
being written with an incorrect upper-bound that is too low.

The values written are in the range 0-5 which matches the enum in
enums.xml.  The problem is that the supplied upper-bound for the value
is being incorrectly supplied as being 3 rather than 6. This has the
effect of lumping all the high values into the third bucket.

Here's what tipped me off: when I viewed the histogram data I could see
there were only 3 buckets and the last had a wonky max value.
Pic here: https://screenshot.googleplex.com/BiZRJPYwSAi.png

This just fixes the supplied upper-bound to be correct, and extends the
histogram out for a year.

Change-Id: I11ba80ac0429468812b92817d85493091e987b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003574Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733897}

Nuances:

- Differently from other conversions, where it is possible to remove
method handlers in RenderFrame and WebLocalFrame levels when
switching away from legacy IPC to mojo, in this particular case,
the method WebLocalFrame::DispatchBeforeUnloadEvent() is still called
directly by other sources [0], hence it can not be removed.

[0] RenderFrameImpl::BeginNavigation().

- Some tests (eg [1] and [2]) used to simulate the receipt of the
FrameHostMsg_BeforeUnload_ACK message, which is being converted to
a mojo completion callback by this CL.
In such cases, TestRenderFrameHost::SendBeforeUnloadACK() was used as
a replacement.

[1] RenderFrameHostManagerTest.CancelPendingProperlyDeletesOrSwaps
[2] WebContentsImplTest.CrossSiteUnloadHandlers

- Some other tests (eg [3]) used to simulate the receipt of the
FrameMsg_BeforeUnload message, also being converted to a mojo message
by this CL.
For such cases, TestRenderFrame class got an extra method
SimulateBeforeUnload(), that calls out the appropriate handling logic.

[3] RenderViewImplTest.DispatchBeforeUnloadCanDetachFrame

- Last, in [4], test used to intercept and ignore the
Msg_BeforeUnload_ACKadParentHang, using a BrowserMessageFilter override
(see DropBeforeUnloadACKFilter). However, since this CL converts this
ACK-like legacy IPC to a mojo closure, the CL mimics the approach used
in  RenderFrameHostFactoryForHistoryBackInterceptor (see [5]).

[4] RenderFrameHostImplBrowserTest.IframeBeforeUnloadParentHang
[5] //content/browser/navigation_browsertest.cc

BUG=1042800
R=avi@chromium.org, dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: Ia580cfe2c7d58e22e4d790a47387926158508919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010920
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733896}

The previous code supposed that we created PaintOffsetTranslation for
all scrollable elements. This is not true for SVG foreign objects for
which we can't create PaintOffsetTranslation because the offset is in
SVG space which is affected by transform.

Bug: 1030109
Change-Id: I161821c50e091257f77b2f806ac5c00c903198da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012904Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733895}

These are no longer necessary because undefined methods are delegated to
self.underlyingScrollView by default with -forwardInvocation:.

And it makes easier to preserve properties using CRWPropertiesStore by
deleting them.

Bug: 1023250
Change-Id: I3ad9fc7ccc919086dd57a019a721461736fa21f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006843Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733894}

... to HTMLSelectElement

- Early-return for !UsesMenuList().  LayoutListBox doesn't have
  UpdateFromElement() implementation.

- Move LayoutMenuList::option_style_ to HTMLSelectElement.

This CL has no behavior changes.

Bug: 1040828
Change-Id: I5870e228f9ad473844d6a05e7611e59cbcfcd084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014205Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733893}

Rename InitializeHardwareOverlaySupport() to
UpdateHardwareOverlaySupport() and update the code of hardware overlay
cap query in preparation for display change.

Bug: 1042989
Change-Id: Iff36a6a5b4caf49c730736550e11360ee69d6513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013320Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733892}

The current code for updating |this.tasks_| does not account for when
|this.tasks_| is an empty array. Fix this: Only update |this.tasks_| if
there are tasks to update.

Also remove redundant function |getAvailableTasks_|.

Bug: 1038799
Change-Id: Iacf74ad6d620ce5001a7de73bfa762b0ea0f0be7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014206
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733891}

In guest mode, the Drive integration service exists, but it is not
mounted or enabled, meaning some operations on it will lead to a crash.
Use drive::util::GetIntegrationServiceByProfile instead of going through
the factory, as it also checks if drive is mounted.

Bug: 1029477
Change-Id: I5f3e71ee7e788507613f5fe6f158db4e0c4add87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011467
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Auto-Submit: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733890}

This is needed so we can offer an upgrade on the next Crostini start.

Bug: 1024693
Change-Id: I204ab5348330d9a2869e420c1c0f828e55116323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011472Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733889}

It's no longer necessary as we've introduced our own abstraction
layer, arc::ArcClientAdapter. This CL injects a fake ArcClientAdapter
implementation to the test fixture to simplify the test. That allows
us to remove all usage of chromeos:: and login_manager:: from the
test, and the test no longer depends on the internals of the ARC
container.

BUG=b:143175953
TEST=try

Change-Id: Ia39f492a94b5698794df423b181ff935b944eec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008284Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733888}

This brings the LaunchParams dictionary into line with what's discussed
in the explainer:
https://github.com/WICG/file-handling/blob/master/explainer.md

Bug: 829689
Change-Id: I3322099aeb8cdcf558acb8a59076fbbc285467e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012377Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733887}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564dcf4c071b..28a405e6e578

git log 564dcf4c071b..28a405e6e578 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@28a405e6e578

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5bb1aadf2b46e6a7722af2fd200c0118ae1cbe16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014154Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733886}