- 11 Apr, 2018 40 commits
-
-
Bernhard Bauer authored
Bug: 814365 Change-Id: I34a05ddbf20c74efeffc2c1081cbc79ed60b49db Reviewed-on: https://chromium-review.googlesource.com/1005034Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549891}
-
Katie D authored
In https://chromium-review.googlesource.com/c/chromium/src/+/794511/6/ui/accessibility/ax_tree.cc#275, I renamed |clipped| to |intersection| (and introduced a new |clipped| var with a slightly different meaning). I missed renaming the comment about |clipped|, so doing that in this change. NOTRY=true Change-Id: I5ed9bce774da738950f1199ce9138f51c25beaee Reviewed-on: https://chromium-review.googlesource.com/1005907Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549890}
-
Bence Béky authored
Do not call deprecated QuitCurrentWhenIdleDeprecated() in net/http/http_stream_factory_impl_unittest.cc. The relation to https://crbug.com/829429 is that because of presubmit rules, this is blocking the rename of net/http/http_stream_factory_impl_unittest.cc at https://crrev.com/c/1000487. Bug: 829429 Change-Id: Id05bca35788d013794c177e606334bad3e37290f Reviewed-on: https://chromium-review.googlesource.com/1005110 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549889}
-
vitaliii authored
This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/986514. After that CL, UserEventSyncBridge does not delete user consent events when sync is disabled, instead they are persisted in the store. In this CL, these user consent event are resubmitted to sync when sync is reenabled (based on OnSyncStarting call). This is done to avoid losing consents, especially in DICE where sync may be disabled frequently. On the other hand, it is allowed to record the same consent multiple times and this is heavily utilized in this CL. One could potentially come up with something simpler, however, later we will have to avoid syncing events emitted from a different account. Due to this requirement, the approach in this CL could not be simplified further. Bug: 781765 Change-Id: Ia1278d716b0ace05084f1de56f0647e149fd0e5e Reviewed-on: https://chromium-review.googlesource.com/1004896 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549888}
-
Joshua Pawlicki authored
Bug: 831284 Change-Id: I84d27cfb61725524d1ec9b12ffaa1bda221529ff Reviewed-on: https://chromium-review.googlesource.com/1005797Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#549887}
-
Michael Thiessen authored
This reverts commit f2ccbfd1. Reason for revert: Speculative revert for crbug.com/831589 Original change's description: > VR: Clean up WebVR headset insertion. > > This CL makes it explicitly clear when we care about whether the page > was listening for activate before pause, and when we should autopresent > on entering VR (for headset insertion). > > This also removes the workaround in vr_display_impl that allowed pages > without focus to handle displayActivate, favoring handling this case > more correctly in VrShellDelegate. > > Bug: 829513 > Change-Id: Ie19c55305d0c59ec3f576010ded0f61ae906a084 > Reviewed-on: https://chromium-review.googlesource.com/1004927 > Reviewed-by: Yash Malik <ymalik@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549736} TBR=mthiesse@chromium.org,ymalik@chromium.org Change-Id: I92a56254e933381770a56495553facfbcb2e5c59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829513 Reviewed-on: https://chromium-review.googlesource.com/1007374Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#549886}
-
chaopeng authored
In this CL, we save the kPrecisionTouchpadScrollPhase state in HWNDMessageHandler to avoid query the state of kPrecisionTouchpadScrollPhase on each direct manipulation events. Bug: 779372 Change-Id: Ie97f4cbe180a5f01c7b513263ecb310d7df4b66f Reviewed-on: https://chromium-review.googlesource.com/1005500Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549885}
-
kylechar authored
It looks like int8_t was getting converted to int before being printed as unsigned so negative values were much larger than necessary. Convert the values uint_8 before printing them. Also print in hex so each byte is two characters. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib115475b585ef726e4276a22388dd3b7e5b08a11 Reviewed-on: https://chromium-review.googlesource.com/1005881Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549884}
-
Brian Salomon authored
Use direct maxTextureSize() getter instead. This will allow removal of GrCaps from Skia's public API. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I11e8aa4d6327b72b9882744584d0efae3d9145c5 Reviewed-on: https://chromium-review.googlesource.com/1001709Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549883}
-
Ethan Kuefner authored
We're ready to try again with enabling some chromium.perf benchmarks to upload histograms to the perf dashboard, so let's try with blink_perf. Bug: 744736 Change-Id: I859b63a27ad0b3aaa825a520a20d00bd7afe1ab4 Reviewed-on: https://chromium-review.googlesource.com/1005674Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#549882}
-
David Reveman authored
These shortcuts are useful to some applications (e.g. emacs). Test: ctrl+space is recognized by weston-eventdemo Change-Id: I707d191d5ad7a9e9aa1b96125ace3e8225e478f3 Reviewed-on: https://chromium-review.googlesource.com/1001727 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#549881}
-
Danyao Wang authored
CRWWebController sometimes needs to remove WKWebView (e.g. crbug/770914) and this obliterates the session history when WKBasedNavigationManager is used. This CL adds the ability for WKBasedNavigationManager to temporarily be detached from the web view. Major parts to this CL: 1. NavigationManagerImpl::DetachFromWebView() is a new API that CRWWebController uses to notify the navigation manager before removing the web view. 2. WKBasedNavigationManager implements this API with the help of a new nested class WKWebViewShim. It knows how to cache the items when detaching from a web view and service getter calls in detached mode. 3. Added overrides for FinishReload(), FinishLoadURLWithParams() and LoadIfNecessary() in WKBasedNavigationManager so it can switch back to attached mode when a new navigation starts by restoring the cached navigation items. Also cleaned up unneeded APIs from CRWWebViewNavigationProxy. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b1796731964f021df8c0489d3a6ef56ae390e04 Bug: 815248 Reviewed-on: https://chromium-review.googlesource.com/999054 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549880}
-
stkhapugin@chromium.org authored
Replaces custom clear button with the system one. Bug: 821803 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I870db4da6529ebcca757c5728a4e73658d14e15a Reviewed-on: https://chromium-review.googlesource.com/964422Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549879}
-
Martin Sramek authored
Static variables should use const char[] rather than std::string. This change also uncovered the fact that some of them are actually not used, as most of the tests simply use those strings directly. Bug: None Change-Id: I9b520c08feb5552af453455e42f3db5b0ef5ba75 Reviewed-on: https://chromium-review.googlesource.com/1004957Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#549878}
-
Ian Vollick authored
These previously thought they were clean when they weren't causing stale positions to be applied after repositioning. Bug: 831410,831402 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7b5e1a8023f2231ff68452a43bbb372426b9f2f Reviewed-on: https://chromium-review.googlesource.com/1006355Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549877}
-
Charlie Harrison authored
This CL should not change behavior. Bug: 829992 Change-Id: I29ab5dd2702b32e160b04bd341183d36fefe1bc9 Reviewed-on: https://chromium-review.googlesource.com/999995 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549876}
-
Rohit Rao authored
This allows tests to disambiguate between the Settings button and other navigation bar buttons that happen to also say "Done". This is necessary now because the TabGrid also has a "Done" button, and some tests are confusing that for the Settings "Done" button. BUG=818742 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0db7221f18975277e46fb15ecd781d2b65370ea6 Reviewed-on: https://chromium-review.googlesource.com/1005858 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
This parameterizes AutofillPopupControllerBrowserTest to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. Other tests will be parameterized in follow up CLs. Bug: 768881 Change-Id: I4166d5dc8a1c326b78a88f6d92687505d070d8e4 Reviewed-on: https://chromium-review.googlesource.com/1004923 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549874}
-
Henrik Grunell authored
TBR=dalecurtis@chromium.org Bug: 831566 Change-Id: I3f553de7719c23f38a6fd707357dd406e1cb4928 Reviewed-on: https://chromium-review.googlesource.com/1007078Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549873}
-
Gauthier Ambard authored
This CL adds the "navigate to page" action to the popup menu presenting the navigation history menu. Bug: 831189 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I04f26af28aada63278fa6530f9b8c8efaac42a30 Reviewed-on: https://chromium-review.googlesource.com/1005085Reviewed-by:
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' components`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Tbr: dcheng@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieee129f09e26c25487f68845c510a683aef2fd33 Reviewed-on: https://chromium-review.googlesource.com/1005803Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549871}
-
Martin Sramek authored
The Account ID of the account for which the user granted consent is passed from: - Desktop: SyncConfirmationHandler - Android: ConsentTracker - iOS: ChromeSigninViewController - ChromeOS: ArcSupportHost, ArcTermsOfServiceScreenHandler to ConsentAuditor. In this CL, we only verify that it's not empty. A subsequent CL will pass it to UserEventService which will verify that it's the same account that is currently signed in, to avoid sending consents for account A over an authenticated channel of account B (and associating the consent with B on the server). Bug: 781765 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5179b8932a3ec8fd865e97c2f8164ac2715ac840 Reviewed-on: https://chromium-review.googlesource.com/986293 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' services`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Tbr: rsesek@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I878e7960b4cd4f0b9fdc58f65cf8d17741d0441a Reviewed-on: https://chromium-review.googlesource.com/1005840Reviewed-by: -
Christopher Grant authored
This change allows all sizing and layout operations to run without drawing any textures, and ensures that texture rendering can't tamper with sizing. Along with this comes cleanup to the Text element, which has a somewhat messy relationship between its texture and size. This change adds a setter, SetFieldWidth(), that should be used to size the field. Then, based on the text applied to the field, the element's underlying size will adjust accordingly. We can now better trust profiling numbers for sizing and layout, as there shouldn't be spikes from occasional text re-render operations. BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaeec155e01a66536be82e5788cb5a17950f287df Reviewed-on: https://chromium-review.googlesource.com/1005024 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549868}
-
Charlie Harrison authored
This involves moving the ad tagging Feature into the common layer. The reasoning for this is that a fieldtrial is only "activated" if an associated base::Feature is queried. Since the ad delay experiment relies on ad-tagging, this will ensure that *no* groups (including control groups) will be activated if ad-tagging is disabled. Bug: 829042 Change-Id: I0bae55654ee1e33a55903232b75f9039651f8dc4 Reviewed-on: https://chromium-review.googlesource.com/1005574Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#549867}
-
Gauthier Ambard authored
This CL adds to the tools menu, the "Bookmark this page" action if the page is not bookmarked or the "Edit Bookmark" action if the page is already bookmarked. Bug: 829324 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iddecb6aacb64494c8e2137ee219ee3e03cd6441f Reviewed-on: https://chromium-review.googlesource.com/998356Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549866}
-
Stephen McGruer authored
M67 will be branching soon, and we will not be able to reland the CL to properly handle octothorpes in data URIs by then. Bug: 123004, 823666 Change-Id: Id990326e6a7a968ee0ab8a027ccfea4a6f4ece3f Reviewed-on: https://chromium-review.googlesource.com/1000295Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549865}
-
Henrik Grunell authored
Bug: 826664, 830624 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice35b73f74d572a69815daeedf7a3971ed6493ff Reviewed-on: https://chromium-review.googlesource.com/1005256Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549864}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: I01e5d3c8bd133d8914fd64626494d12531dbcf37 Reviewed-on: https://chromium-review.googlesource.com/955596 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549863}
-
Yuichiro Hanada authored
This reverts commit 6b3d6841. Reason for revert: Please refer to crbug.com/831521 . We need to pass tap events in the drag handle. Original change's description: > Floating Keyboard stops propagation of drag handle events > > If a touch/mouse event occurs and it is interpreted as a floating > keyboard drag event, do not propagate the event to the javascript > keyboard extension as there is no reason to. > > This was causing the drag event to cause the gesture swiping to be > active while dragging the keyboard around, particularly if the keyboard > was bounded to the bottom of the screen and the user's finger is able > to move around on the keys while still moving the keyboard (see > attached bug for repro/video). > > Bug: 826078 > Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2 > Reviewed-on: https://chromium-review.googlesource.com/997195 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548374} TBR=yhanada@chromium.org,blakeo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826078 Bug: 831521 Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c Reviewed-on: https://chromium-review.googlesource.com/1006715 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Hayato Ito authored
Add new performance tests which measure the performance of slot assignment recalc and re-layout in several scenarios where slot assignment changes on a *long slot-assignment-chain*. This CL also cleans up existing functions so that they have common tree structures with added ones. Bug: 776656 Change-Id: Idff494392c13aca5b6eaf1dfeabb34ad41ffa556 Reviewed-on: https://chromium-review.googlesource.com/1005648 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549861}
-
Majid Valipour authored
Bug: 827194 Change-Id: Ib21f0c55e2a196f75f3aa27ee0d0bc997a5b4bd1 Reviewed-on: https://chromium-review.googlesource.com/986750 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549860}
-
Matt Falkenhagen authored
This reverts commit f3236937. Revert "service worker: Remove GetProviderHostIterator()." This reverts commit 8aba3ccd. Reverting the shared worker patch as a suspected culprit of bug 831255. The other patch landed on top of it so has to be reverted too. Original code review: https://chromium-review.googlesource.com/981845 Bug: 831255, 796819 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I106ad40605e6347ec5c2b797142881bace491545 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1006237 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549859}
-
Gauthier Ambard authored
This CL removes the experimental flags and associated code, added to experiment with different toolbar layout of search icons. Bug: 831113 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9a1cbcce2a1536773394c98a5bf31bb6bf2e127f Reviewed-on: https://chromium-review.googlesource.com/1006578Reviewed-by:
-
Gabriel Charette authored
This is cleaner than having individual tests manage their own FileDescriptorWatcher instances and it removes a few existing usages of MessageLoopForIO::current() as a MessageLoopForIO* (which will no longer be legal after : https://chromium-review.googlesource.com/c/chromium/src/+/957760). R=fdoray@chromium.org TBR=sergeyu@chromium.org (c/b/extensions/api/messaging side-effects) TBR=hidehiko@chromium.org (components/arc cleanup) Bug: 825327, 708584 Change-Id: I2c4507cc7a4af073afaf19cd3d802c3bb5fd7f39 Reviewed-on: https://chromium-review.googlesource.com/1005780 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549857}
-
Takuto Ikuta authored
This flag is explained in this article. http://blog.llvm.org/2018/01/improving-link-time-on-windows-with.html I compared link time of some binaries in use_lld = true and is_component = true on Z840 Win10. * use_ghash = true blink_core.dll: 50.4647194s content.dll: 29.0251954s chrome.dll: 37.5983146s * use_ghash = false blink_core.dll: 62.2167861s content.dll: 37.7807734s chrome.dll: 43.1551229s Change-Id: I9d88e76b80e405345971d815097ffff7f6bd05d6 Reviewed-on: https://chromium-review.googlesource.com/1004335 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Zachary Turner <zturner@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549856}
-
Findit authored
This reverts commit fc2d77d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 549780 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZjMmQ3N2Q1MGRjYzVkNDE4YWQxOTc1YjlhMDc4MjZiMTZkODcwOGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5150 Sample Failed Step: ash_unittests Original change's description: > overivew: Animate blur when there are no maximized windows. > > See bug(s) for spec. This CL adds an animated blur on wallpaper when entering/existing > overview when no maximized/fullscreen windows. > > Bug: 823533, 812004 > Change-Id: Icf8bdababedaaefe869f62768aacf7abcb3643d2 > Reviewed-on: https://chromium-review.googlesource.com/979167 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549780} Change-Id: If1226fa286e8f82885cea814f5fb89e0253ef98a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823533, 812004 Reviewed-on: https://chromium-review.googlesource.com/1006894 Cr-Commit-Position: refs/heads/master@{#549855}
-
Gabriel Charette authored
This was extracted from https://chromium-review.googlesource.com/c/chromium/src/+/957760/17 MessageLoopForIO::current() will soon stop returning a raw MessageLoopForIO*. In preparation for this, fix old code to use modern APIs instead of a direct MessageLoopForIO*. This CL was uploaded by git cl split. R=derat@chromium.org Bug: 825327 Change-Id: Ifeac947b8540468fc7c207916769ef0a7f3ac434 Reviewed-on: https://chromium-review.googlesource.com/1005911 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#549854}
-
Max Morin authored
Having four thread checkers and two locks in the same class is a bit extreme. Four thread checkers and one lock seems just right :D. Bug: None Change-Id: I69252bf90c5f1e17b71e2f3a2c068572e90ec648 Reviewed-on: https://chromium-review.googlesource.com/1005253Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549853}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: I316852571bffe939b896d321fe058e58d26cf626 Reviewed-on: https://chromium-review.googlesource.com/1000701 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#549852}
-
