GitLab

GoogleURLTrackerNavigationHelper class was completely removed as part
of https://codereview.chromium.org/808253006/ but a forward-declaration
was left in the code, remove it.

BUG=None
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/929483005

Cr-Commit-Position: refs/heads/master@{#317466}

R=lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/942943003

Cr-Commit-Position: refs/heads/master@{#317465}

Unify UserMediaClientImpl::GetUserMediaRequestFailed and
UserMediaClientImpl::GetUserMediaRequestTrackStartedFailed
and make sure all possible enum values are handled in the
switch.

BUG=459694

Review URL: https://codereview.chromium.org/937293002

Cr-Commit-Position: refs/heads/master@{#317464}

- -p or --publish will now upload and publish.
- only request auth code and oauth token once each (reuse as needed for subsequent calls).
- try closing some more of the httpd socket connections.

Review URL: https://codereview.chromium.org/927543003

Cr-Commit-Position: refs/heads/master@{#317463}

This avoids having to put '::Type' everywhere.

BUG=none

Review URL: https://codereview.chromium.org/948543002

Cr-Commit-Position: refs/heads/master@{#317462}

R=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/927653006

Cr-Commit-Position: refs/heads/master@{#317461}

For now just recording user action for printing with extension and
page count for issued print requests.

Also, add missing histogram for page count when printing with privet.

BUG=None

Review URL: https://codereview.chromium.org/938193003

Cr-Commit-Position: refs/heads/master@{#317460}

"American Express" is still used for filling into the page.

BUG=none

Review URL: https://codereview.chromium.org/936273002

Cr-Commit-Position: refs/heads/master@{#317459}

Part of this is used as a bitmask, but in some cases we assume that the
core part is <= |PAGE_TRANSITION_LAST_CORE|.

See: https://cluster-fuzz.appspot.com/testcase?key=4815416552062976

R=tsepez@chromium.org

BUG=450268

Review URL: https://codereview.chromium.org/945973002

Cr-Commit-Position: refs/heads/master@{#317458}

BUG=

Review URL: https://codereview.chromium.org/950473002

Cr-Commit-Position: refs/heads/master@{#317457}

BUG=428729,444049

Review URL: https://codereview.chromium.org/938883002

Cr-Commit-Position: refs/heads/master@{#317456}

BUG=

Review URL: https://codereview.chromium.org/944153002

Cr-Commit-Position: refs/heads/master@{#317455}

R=tbreisacher@chromium.org
TBR=fukino@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/942193002

Cr-Commit-Position: refs/heads/master@{#317454}

BUG=

Review URL: https://codereview.chromium.org/944133002

Cr-Commit-Position: refs/heads/master@{#317453}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/945073002

Cr-Commit-Position: refs/heads/master@{#317452}

This adds a boolean histogram for whether Chrome assumes the web page is
mobile optimized. It is recorded as soon as the Tab gets the callback
for didFinishLoad(). On every call to didNavigateMainFrame(), the bit
the bit it is cleared again. This is only recorded for the main frame.

The viewport might not be correctly identified when didFinishLoad()
gets called, at which point the stat might be a false negative. This
means that this stat could be considered a lower bound for mobile
optimized pages.

BUG=None

Review URL: https://codereview.chromium.org/943823002

Cr-Commit-Position: refs/heads/master@{#317451}

BUG=447455

Review URL: https://codereview.chromium.org/844503005

Cr-Commit-Position: refs/heads/master@{#317450}

R=michaelpg@chromium.org,stevenjb@chromium.org
BUG=460269

Review URL: https://codereview.chromium.org/941343003

Cr-Commit-Position: refs/heads/master@{#317449}

R=navabi@chromium.org
NOTRY=true
BUG=460630

Review URL: https://codereview.chromium.org/946733002

Cr-Commit-Position: refs/heads/master@{#317448}

The mouse cursor element is positioned relative to the document body (ie, ignoring
the title bar for apps v2). However, its position was being set using the x and y
coordinates of the mouse event, which are relative to the client viewport. This CL
fixes this, using offsetX/Y, which are relative to the target element.

BUG=410473

Review URL: https://codereview.chromium.org/923013004

Cr-Commit-Position: refs/heads/master@{#317447}

This makes the check_includes flag work the way one would expect. Previously we
would only skip include checking if all targets that include a file opt out.
This was coming up in the Android Java enum generator where a header file was
being processed by a script (so includes don't matter and there are no deps)
but that header was also listed as a source in a different target with header
checking enabled (which is always the case for this example).

Improves error messaging for cross-compiling. Previously if you were
cross-compiling and forgot a dependency on e.g. base, you'd get a message "you
must depend on "//base:base" or "//base:base" because it found the files in two
different toolchain builds of base. This patch prunes such duplicates when
possible, and turns on toolchain labels if things aren't all in the same
toolchain.

BUG=

Review URL: https://codereview.chromium.org/946043002

Cr-Commit-Position: refs/heads/master@{#317446}

BUG=

Review URL: https://codereview.chromium.org/936163003

Cr-Commit-Position: refs/heads/master@{#317445}

- It does not need to be virtual.
- Since it is a simple getter accessor it can be inlined in the header
file and thus renamed to just root().

BUG=None
R=dmazzoni@chromium.org,avi@chromium.org
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/940753002

Cr-Commit-Position: refs/heads/master@{#317444}

R=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/945093002

Cr-Commit-Position: refs/heads/master@{#317443}

This only affects one of the two callers. --ignore-certificate-error ends up
causing some metrics to record on all errors rather than just certificate ones,
so we end up recording things based on a default-initialized SSLInfo.

BUG=none

Review URL: https://codereview.chromium.org/947453003

Cr-Commit-Position: refs/heads/master@{#317442}

This cl depends on
Chromium:
  - Introduce AppCacheResponseMetadataWriter to support metadata caching.
    https://codereview.chromium.org/932643002/
Blink:
  - CachedMetadata support for ServiceWorker script.
    https://codereview.chromium.org/929953002/

After https://codereview.chromium.org/929953002/, EmbeddedWorkerContextClient.setCachedMetadata/clearCachedMetadata will be called when V8ScriptRunner calls CachedMetadataHandler.setCachedMetadata/clearCachedMetadata in a ServiceWorker.
This cl implements these methods.

When these methods are called, ServiceWorkerScriptContext sends IPC to the broeser process.
ServiceWorkerVersion recieves these messages and calls ServiceWorkerScriptCacheMap.WriteMetadata/ClearMetadata.
ServiceWorkerScriptCacheMap creates ServiceWorkerResponseMetadataWriter to write/clear the metadata in ServiceWorkerStorage.

ServiceWorkerResponseMetadataWriter is a subclass of AppCacheResponseMetadataWriter which is introduced https://codereview.chromium.org/932643002/.

TEST=content_unittests.exe --gtest_filter=ServiceWorkerResourceStorageTest.*
BUG=449895

Review URL: https://codereview.chromium.org/931173002

Cr-Commit-Position: refs/heads/master@{#317441}

+ Dependent on cr/86724062

* Control the banner appearances via a kill-switch via an experiment.

* The app install alert flag in chrome://flags is now used to enable
  or disable app banners for Play Store apps.  Web app banners are
  only affected by the experiment.

BUG=457417

Review URL: https://codereview.chromium.org/941823002

Cr-Commit-Position: refs/heads/master@{#317440}

R=brettw@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/941863002

Cr-Commit-Position: refs/heads/master@{#317439}

BUG=460572

Review URL: https://codereview.chromium.org/942183002

Cr-Commit-Position: refs/heads/master@{#317438}

BUG=

Review URL: https://codereview.chromium.org/873553004

Cr-Commit-Position: refs/heads/master@{#317437}

BUG=432280,460221

Review URL: https://codereview.chromium.org/946553006

Cr-Commit-Position: refs/heads/master@{#317436}

crrev.com/48bb4848 introduced a new behavior
for menu buttons where they don't enter pushed state if they can be dragged.
Since ToolbarActionView emulates either a LabelButton or a MenuButton depending
whether it has a popup, it should override this.

BUG=458041

Review URL: https://codereview.chromium.org/935163002

Cr-Commit-Position: refs/heads/master@{#317435}

Add a new mode to the JNI generator which emits both native JNI exports
and manual registration code, and use this as the default mode (except
when compiling with clang as a clang bug prevents this from working at
present).

Native JNI exports are stripped from binaries by default to enforce that
the correct manual registration code is called (and to save increasing
the dynamic symbol table size), except for binaries that explicitly opt
in to using native exports (i.e. libwebviewchromium). Native exports are
not compatible with the crazy linker, so cannot be used universally.

The WebView-specific call to InitReplacementClassLoader, required by
native export mode, has been moved to base to make it easy for other
binaries to experiment with that mode.

Manual JNI registration can be disabled with a call to
base::android::DisableManualJniRegistration at the beginning of
JNI_OnLoad and this has been added to WebView. We plan to refactor the
Android library entry points to make it possible to avoid needing this
flag by just not calling JNI registration but the work is still ongoing;
the flag gets us the desired WebView startup time improvement in the
meantime.

BUG=442327

Review URL: https://codereview.chromium.org/920883002

Cr-Commit-Position: refs/heads/master@{#317434}

BUG=457590

Review URL: https://codereview.chromium.org/914963002

Cr-Commit-Position: refs/heads/master@{#317433}

- DRPIOData is a container for IOData lifetime objects, and constructed first.
- DataSaverService is a container for Profile/UI based lifetime objects, and
  constructed second. It can take raw pointers to DRPIOData, since
  DataSaverService is destroyed before DRPIOData.
- DRPIOData (and its classes) then fed a WeakPtr to the DataSaverService.
- DataSaverService is (temporarily) owned by DRPSettings (primarily because
  DRPChromeSettings is the KeyedService) - this will swap in a future CL.
- During KeyedService shutdown, the WeakPtr is invalidated.

Removal of redundant functionality in the DRPSettings:
- I/O thread related functionality (Canary check, IP address change) now lives
  in the Config class, with calls into DataSaverService to use the URLFetcher
- the Settings class no longer is aware of Params, and instead uses the Config
  class for retrieving information - this results in Params construction
  moving from Settings -> DRP IO/Data
- Certain information which is exposed to the UI (via the Settings class) is
  now cached after being retrieved from the Config class (for thread safety)

BUG=452773

Review URL: https://codereview.chromium.org/893003002

Cr-Commit-Position: refs/heads/master@{#317432}

d:\src\cr2\src\url\url_canon.h(737): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\url\url_canon.h(737): warning C4459: declaration of 'empty_string' hides global declaration
d:\src\cr2\src\url\gurl.cc(22): note: see declaration of '`anonymous-namespace'::empty_string'

R=brettw@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/937473003

Cr-Commit-Position: refs/heads/master@{#317431}

R=lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/945903004

Cr-Commit-Position: refs/heads/master@{#317430}

Previous CL was (potentially?) incorrect here.

R=rtenneti@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/946003003

Cr-Commit-Position: refs/heads/master@{#317429}

Sometimes the list of last known positions does not contain the full list of
extensions. Fix one such case, and account for any others.

BUG=460393

Review URL: https://codereview.chromium.org/941373002

Cr-Commit-Position: refs/heads/master@{#317428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8ca446a..8569c5c

TBR=yosin@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/940423003

Cr-Commit-Position: refs/heads/master@{#317427}