- 05 Nov, 2020 40 commits
-
-
Mark Mentovai authored
This includes universalizer.py and the Widevine signing scripts. Depends on: https://chromium-review.googlesource.com/c/2515521 and https://chrome-internal-review.googlesource.com/c/3383223 https://chrome-internal-review.googlesource.com/c/3380436 (DEPS) https://chromium-review.googlesource.com/c/2520327 (DEPS) Code-Word: calamity Bug: 1142017 Change-Id: I83bc47a2edbd031f4d7f291a6b4922d3c862f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518800 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#824392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..df4403112ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If3d9a1db7b8806feb72cad6b94732164cf0ddeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824391}
-
Roberto Moura authored
Tapping the tab switcher button, after the tab grid had been revealed once, while on Peeked state would crash because the scene_controller's displayTabSwitcher would be called when self.tabSwitcherIsActive is YES. The proposed fix is to set self.tabSwitcherIsActive to NO whenever there is a transition from the Revealed state to another state. This CL adds a method to the ThumbStripCoordinatorDelegate protocol to inform that the tab grid has been dismissed. Bug: 1127604 Change-Id: I9ace9a2ff27143eb40774b7ff563c600bdfe4e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463822 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#824390}
-
Sylvain Defresne authored
The linker fails if any object file does not define LC_BUILD_VERSION when linking a binary for "catalyst" environment. As nasm does not create such a section, the build fail if using optimised version of libvpx. As a workaround, use generic implementation instead of the optimized one in that configuration (since it is still experimental anyway). Bug: 1145197, 1138425 Change-Id: I6bf02c499d8e35dcc0fe34f5bb53df230a8449cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517955 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#824389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4403112ffa..744b988ae1b0 2020-11-05 treehugger-gerrit@google.com Merge "Fixed protobuf deprecated API" 2020-11-05 treehugger-gerrit@google.com Merge "Extend export_json to read from memory tables" 2020-11-04 fmayer@google.com Merge "Assert we don't stop reading the shmem." 2020-11-04 hjd@google.com Merge "Parse dpu and g2d" 2020-11-04 delphick@google.com Merge "trace_processor_shell: add .read command" 2020-11-03 treehugger-gerrit@google.com Merge "Improved flow navigation" 2020-11-03 simonmacm@google.com Merge "Work around b/169226092 where we see wrong or truncated process names." 2020-11-03 treehugger-gerrit@google.com Merge "base: Allow message() calls when status.ok() == true" 2020-11-03 fmayer@google.com Merge "Only send on socket when service stopped reading." 2020-11-03 primiano@google.com Merge "SDK: remove spurious ELOG when no error occurs" 2020-11-03 treehugger-gerrit@google.com Merge "Fix parsing of locations that have DEX in subfolder." 2020-11-03 primiano@google.com Merge "Update CHANGELOG for v9.0 release" 2020-11-03 primiano@google.com Merge "CI: fix Stats link" 2020-11-03 hjd@google.com Merge "trace_processor: Handle armv8l syscall traces" 2020-11-03 treehugger-gerrit@google.com Merge "docs: Fix trigger config instructions" 2020-11-03 treehugger-gerrit@google.com Merge "sdk: Rename kCatIndex in track event macro to highlight common error" 2020-11-03 hjd@google.com Merge "trace_processor: support fastrpc event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6f18d6c282ce69a9c6b564b2b725fbea523575c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520532Reviewed-by:
-
Jérôme Lebel authored
Adding: * Signin.SSOIdentityListRequest.FetchIdentitiesWithCallback.Duration Time needed to fetch the identity list * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.Duration Time needed for the callback to be called for RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.Duration Time blocked in WaitUntilCacheIsPopulated() Those metrics are implemented in crrev.com/i/3353162. Design doc: http://go/async-identityservice-api crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl => crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: I83744b7eaec3f7eb4c2515550e6a2638e5c0ec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490110 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824387}
-
Karandeep Bhatia authored
Autogenerated header: https://paste.googleplex.com/6624090682032128 Autogenerated cc file: https://paste.googleplex.com/6206455679025152 BUG=1113513 Change-Id: I1bb4adc0712430e94a1e7874e9ec7a20759f57e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419607 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824386}
-
Arthur Sonzogni authored
This reverts commit 46de280d. Reason for revert: still flaky. See https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/707 Original change's description: > enable FeedNewTabPageCardInstrumentationTest > > Bug: 1143781 > Change-Id: Ic7c1adad83cb472aeaeb8e82534288184a89d544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518183 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824229} TBR=harringtond@chromium.org,wuwang@chromium.org Change-Id: I9ccace6afc3b4193000d094392c78468887a6249 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519975Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824385}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9cecc6f..1028db2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I441918cc39ef07cbaed3b55815787c9047acabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824384}
-
Friedrich Horschig authored
The test has already been disabled for earlier iOS versions. Since it fails frequently, disable it for the remaining bots. TBR=sczs@chromium.org Bug: 1035764, 1145948 Change-Id: I2485c4c9691f302073b6acb89c3bd7dbf8c02509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517469Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824383}
-
Guido Trotter authored
Currently the dialog refers to the device as "Chrome device" instead of "Chromebook/Chromebox/etc". This commit fixes it in three messages. R=rsorokin@google.com Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Fixed: 1023388 Change-Id: I9f4e300587fc978e00e782f99031d55844786f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518854Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824382}
-
Arthur Sonzogni authored
This reverts commit ae52b2a4. Reason for revert: https://crbug.com/1145924 Original change's description: > [WebLayer] Change the return type of Fragment.getActivity() to Activity. > > This CL adds the ability to specify a script in an android_aar_prebuilt > rule that can modify prebuilt jar files, and adds a script to change > Fragment.getActivity() and Fragment.requireActivity() to return an > Activity instead of a FragmentActivity. > > This is the first CL in a chain that will allow us to remove the fake > activity we create when embedding Fragments that cross classloader > boundaries. > > Bug: 1123216 > Change-Id: I4b9d3ca5f9c3a4d86e08d64f49d601c08fca9a70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432413 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823582} TBR=twellington@chromium.org,agrieve@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123216 Change-Id: Ib07ea2150fea59649c50b19d1a27b115d6168627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517489Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d09ab6b6ebf..110009e66adc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1143321 Tbr: Change-Id: I61eb79ecbb4235856d77039ef4ba995c5510ecd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824380}
-
Joel Hockey authored
create_test_main.py script relies on cros_colors.generated.css, so add it as a dep via webui_resources_grd to catch a broader range of generated resources. No-Tree-Checks: true No-Try: true Bug: 1145902 Change-Id: I7fb1681dd7f6db58ca74255eeb5be9ba10b1fa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520483 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824379}
-
Sylvain Defresne authored
Building for "catalyst" environment requires some specific gn settings, so to facilitate the developers' job, add support for this environment to //ios/build/tools/setup-gn.py. Remove support for "fat" build as it is unsupported (since deployment target was bumped to 11.0+). Bug: 1138425 Change-Id: Ia40cb9a7b72a70e46b1a938285c0a020ea95f619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517732 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824378}
-
Pâris MEULEMAN authored
This adds a few browser tests for policy container [1]. With the following objectives: - Verify that the policy container is properly populated (at this stage only the referrer policy is available within the policy container), from the header and from the meta tags. - Verify that the policy container is properly inherited in popups and iframes. - Verify that the inherited policy is the one applied. - Verify the behavior of policy container when an iframe is "created" by a sibling: Even if the script was executed by a sibling, the parent frame is always the creator. [1] https://docs.google.com/document/d/16-bbA-DsO1l3vZnWYemRhcaUJZ8g8SZhMo99MmGFRSs/edit#heading=h.o51zkgcv0thc Bug: 1130587 Change-Id: I37d4cbb9882f72ac041559f15fb06675bb88dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457186 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e494cae8d48..1e59a0e12e6d 2020-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9c36b526 to 3c7580ad (415 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If160f98aa3e284d4098f4998b8e49114317c7eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520525 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Ewann authored
This CL removes the legacy GetUIFont method. Bug: 1131056 Change-Id: I763c1cae6e8d1ce43517f5ba4745c0df961ad05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517488 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Ewann authored
This CL sets the leadingButton title during its initialization which allows the confirmation actionSheet to be correctly anchored. Previously the actionSheet was anchored before the title was configured, causing misalignment. Bug: 1140982 Change-Id: Ie35be2d119585b9512dff5cd9ed347ad02934254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517589 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Tony Price authored
Bug: 982501 Change-Id: I5b25e2b8ce3d7e86527cbb59f9bce3d7e1a24dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498562 Commit-Queue: Tony Price <toprice@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL adds versioning to the digital_godos.mojom file in the blink. This is required because some structs and enums are depended on by a mojom file that is in components/arc/mojom, which is used by the browser to talk to ARC++. There is a chance that the mojom files in ARC++ and Chrome will be out of sync. Bug: 1137688 Change-Id: I5716088509145cbe8c68fc9dfa879f44e1ff85cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503753Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#824372}
-
Arthur Sonzogni authored
This reverts commit b6fcf130. Reason for revert: https://crbug.com/1145937 Original change's description: > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > This reverts commit 9e3dabc4. > > Reason for reland: This CL was not actually the cause of the test failures (https://crrev.com/c/2519333 fixed them). > > Original change's description: > > Revert "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > > > This reverts commit ba7d8814. > > > > Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 > > > > > > Original change's description: > > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > > > Screenshot with feature enabled in light mode: > > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > > > Screenshot with feature enabled in dark mode: > > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > > > Bug: 1135847 > > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > > Commit-Queue: Anne Lim <annelim@google.com> > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > > Reviewed-by: Jared Saul <jsaul@google.com> > > > Cr-Commit-Position: refs/heads/master@{#823710} > > > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com > > > > Change-Id: I5f235bc5843acf4ea504a78762907a019576e656 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1135847 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823942} > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com > > # Not skipping CQ checks because this is a reland. > > Bug: 1135847 > Change-Id: I7d1a7ad2bc6b5c30d2b859c9f68bfee34992ff95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517530 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824006} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com Change-Id: I51a081655c5102711932ea605078348c9503b931 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517468Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d631a67cc8c7..aa14597ebcfa 2020-11-05 alexrudenko@chromium.org Show icons for align-content:start|end If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I641b27595b27df5f53a0ca94af7a9cbc8050f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520526Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6564890116fd..e87a8c466fb1 2020-11-05 jiawei.shao@intel.com DawnTest: only choose one adapter from those with same name and backendType If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic328005542b70db9b9c769510cda2ba18cb969d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520621Reviewed-by:
-
Ewann authored
This CL refactors the Open In toolbar and makes the following changes: - Updates constraints using autoLayout. - Replaces the MDCButton by an UIButton. - Button text is no longer in uppercase. - Cleans unused variables & methods. based on: https://crrev.com/c/2517483 Bug: 1145477, 1136837, 1117398 Change-Id: I636adc502df159c077f3dc44dbf8d86dc6c0cf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517574 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
arthursonzogni authored
They are all failling on Android P bots: org.chromium.chrome.test.pagecontroller.tests... - NewTabPageControllerTest#testIsCurrentPageThis - NewTabPageControllerTest#testOmniboxSearch - NewTabPageControllerTest#testOpenChromeMenu - TabSwitcherControllerTest#testClickTabSwitcher - TabSwitcherControllerTest#testCloseAllTabs - TabSwitcherControllerTest#testNumberOfOpenTabs - TabSwitcherControllerTest#testOpenNewTab Builder: android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel First failing build: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/b8864538237552640896 BUG=1130617,1141179 TBR=aluo@chromium.org Change-Id: Ica537957bf1142de5aa8183261bab49864842b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519974 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Alfonso Castaño authored
Bug: chromium:1145880 Change-Id: I78424a028c02ce78dadefdbab3e5d7edb39665fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519459 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824366}
-
Manuel Rego Casasnovas authored
This patch avoids calling MarginBefore|After().Quirk() if the element has no margins. This is try to improve performance in perf_test/layout/abspos.html, however we're not sure if this will have a real impact as pinpoint tryjobs are not being very clear about the results. BUG=1098231 Change-Id: I48eba7d0f42cc2822556661164e4f42a831b2c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498586Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#824365}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ae0bc9f..d9cecc6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I85107ab66558d5deba8b6dc03be4d692a7b2eb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520335Reviewed-by:
-
Arthur Hemery authored
We are already recording instantiations of SharedArrayBuffer, recorded for approximately 1.7% of page visits. SharedArrayBuffer is going to be gated behind the crossOriginIsolated boolean in M91 and we'd like to know of potential high profile breakages before going forward. To this end, this patch does the following: - Adds a Webfeature, recorded only when a SharedArrayBuffer is instantiated without the appropriate isolation level. - Adds this WebFeature to the list of WebFeatures to be URL-keyed. This new metric would be strictly lower than 1.7% of page loads, close to it at the beginning and progressively going to 0% before M91. Bug: 1143191 Change-Id: I4c093c791c75faf4b5c94ae9f7a5a21c99b3f81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509514Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#824363}
-
Vasilii Sukhanov authored
Bug: 1049200 Change-Id: Ia6a88ff8613096645c11a6b45b8bca2148a67adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518860 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#824362}
-
Sami Kyostila authored
Roll in a newer revision of Perfetto and update the mojo tracing service to match the new error status added to OnTracingDisabled(). Change-Id: I9e1e679919417f53a88da212a70f05cf4909333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517941 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#824361}
-
Francois Beaufort authored
This CL makes sure audio and video tracks information are reflected in HTMLMediaElement audioTracks and videoTracks when source is a MediaStream. Platform features" flag enabled. Test: https://glowing-juvenile-bear.glitch.me/ with "Experimental Web Bug: 894556 Change-Id: Iceac66b1f142d5c28eeaaffefd621c095e65ecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518856Reviewed-by:
-
My Nguyen authored
These names are shown in both tray menu and settings page. Cleaning up strings description in preparation for names update in http://go/cros-input-methods following http://go/cros-input-methods-naming proposal Part 2 of https://crrev.com/c/2518303 Bug: 889763 Change-Id: I345f3304ce744e0a4f218cb4dde3444595f5035b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517225 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824359}
-
Rune Lillesveen authored
We started to update the background color early for color-scheme canvas background adjustments to avoid white background painting for slowly loading sites with <meta name="color-scheme" ...>[1]. This caused us to paint a white background for other cases where the background color was passed from the renderer before starting to commit frames. This cause flash of white regressions. Make sure we only set the content background color for the color-scheme case by passing an argument to the DidChangeBackgroundColor mojo api. [1] https://crrev.com/d14781f8c3d6218c5f2683cccfd3554b07697d84 Bug: 1141290, 1136423 Change-Id: I843446cafefc656f98d8302f3740a3f9d4e3b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517730Reviewed-by:
-
Wojciech Dzierżanowski authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/2387643 by adding a browser test in addition to the unit test. Bug: 1139869 Change-Id: I12514d03216e559ec4449105ac78ebb30c4da1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484793 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#824357}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7da52775714..c2b2b5788575 2020-11-04 jaebaek@google.com Add DebugValue for invisible store in single_store_elim (#4002) 2020-11-04 dnovillo@google.com Fix SSA re-writing in the presence of variable pointers. (#4010) 2020-11-04 afdx@google.com spirv-fuzz: Fixes to pass management (#4011) 2020-11-03 afdx@google.com spirv-fuzz: Add support for reining in rogue fuzzer passes (#3987) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix assertion failure in FuzzerPassAddCompositeExtract (#3995) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix invalid equation facts (#4009) 2020-11-03 vasniktel@gmail.com spirv-fuzz: Fix bugs in TransformationFlattenConditionalBranch (#4006) 2020-11-03 andreperezmaselco.developer@gmail.com spirv-fuzz: Fix bug related to transformation applicability (#3990) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I2b74240570caa853062f6cad97e48fd86d11d0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520620Reviewed-by:
-
Yue Li authored
Bug: b/170769672 Test: None Change-Id: I482d2812b1191df2b5a35a7c57024dadc3f87a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487561 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824355}
-
Francois Beaufort authored
This CL aims to check which Picture-in-Picture browser tests are still flaky. Note that after 4 runs of the CQ, none failed. It's likely that the source of the failure was fixed when Picture-in-Picture logic was moved to the PictureInPictureWindowControllerImpl. Bug: 1001538, 1002489, 1070810, 1058087 Change-Id: Iac75b3731b4785aacff0fbaf102593a27f922970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475058Reviewed-by:
-
Simon Zünd authored
Moving the TrustTokenBrowsertest class into a header will allow DevTools to re-use the functionality in its own browser tests for upcoming Trust Token debugging features. The CL https://crrev.com/c/2516225 is an example where DevTools and TrustToken browsertests are combined. R=davidvc@chromium.org Bug: chromium:1141652 Change-Id: Ibd9d9a75738d17d9eb1cc33359063ad4bd99b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517947 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824353}
-
