- 27 Sep, 2018 40 commits
-
-
Patrik Höglund authored
This should get my new builders side-by-side with the old ones so I can compare them in luci-migration.appspot.com and switch LUCI to prod if it looks good. I realize now it was unnecessary to create the experimental fyi "waterfall" in luci-milo - this is better. Bug: 877018 Change-Id: I3de02a6d94f3349018395a16ede5d0f665a68e0d Reviewed-on: https://chromium-review.googlesource.com/1245466Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#594600}
-
Scott Chen authored
Move NUX backend handlers and string resources to a chrome/ directory. There will be a follow-up CL to move the frontend resources to the same directory. This is to make it possible to reuse chrome/ code for NUX handlers. Bug: 874122 Change-Id: Id9a5fdd0a1ea88c4027139b66aaade0b120b4904 Reviewed-on: https://chromium-review.googlesource.com/1232399 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53d082585814..2fb2f561368c Created with: gclient setdep -r src-internal@2fb2f561368c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: I4fefd54a05caac46e4f817b8bf08d8120cfe3ea6 Reviewed-on: https://chromium-review.googlesource.com/1248165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594598}
-
Mike Wasserman authored
Implement screen coordinate helpers for aura::Window and views::View. Simplify various places that gets screen locations from events. TODO: Simplify more View::ConvertPointToScreen() callers. (this CL focused on aura::client::ScreenPositionClient callers) Bug: 608547 Test: No regressions in event coordinate handling Change-Id: I23e4fef3264e5e7d94211d7520aef7d3392b080e Reviewed-on: https://chromium-review.googlesource.com/1246826Reviewed-by:
-
Kent Tamura authored
This tests parsing behavior for all element types with <template>. Bug: 862826 Change-Id: Iaa1c0f5bdeed26e0a32ae627ae388503b33a972d Reviewed-on: https://chromium-review.googlesource.com/1248064Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f221bac5302a..d9fdc1f5b5de git log f221bac5302a..d9fdc1f5b5de --date=short --no-merges --format='%ad %ae %s' 2018-09-27 tandrii@chromium.org git cl: save description before doing any RPCs during upload. Created with: gclient setdep -r src/third_party/depot_tools@d9fdc1f5b5de The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881860 TBR=agable@chromium.org Change-Id: I1d3b10b7c5c7da20c80b1a9510b3605263e6e60b Reviewed-on: https://chromium-review.googlesource.com/1248161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594595}
-
Xiaohan Wang authored
Bug: 854943,864610 Test: Updated tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I457aeb7aa0297e8576c5936c8f26fc31a06db7a7 Reviewed-on: https://chromium-review.googlesource.com/1239632 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594594}
-
Hayato Ito authored
Some comments are outdated after Incremental Shadow DOM is enabled. Bug: 887827 Change-Id: Icfb10ca01aed8418fce2d7a16b9e03501aa724d7 Reviewed-on: https://chromium-review.googlesource.com/1245342Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#594593}
-
Adam Rice authored
In blink::GlobalFetchImpl::Fetch(), ExceptionState was not checked after calling PassRequestData(). Since it can fail and return null, this led to segmentation faults. Bail out early if an exception was thrown. BUG=882841 Change-Id: I5317560d070df63f97afe78ec9997cfc0ebd92e0 Reviewed-on: https://chromium-review.googlesource.com/1235779Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594592}
-
Stephen White authored
TBR=robertphillips@google.com Bug: 884166, 887103 Change-Id: Ifbe80bf396b04f57b8310e855436d85f7d172446 Reviewed-on: https://chromium-review.googlesource.com/1248262Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#594591}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I3a0dda17a8de02ffdf7fe11a795f72783ca49c11 Reviewed-on: https://chromium-review.googlesource.com/1226476Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594590}
-
Pete Williamson authored
Uses the ExploreSitesFetcher to get the latest catalog from the network, and upload it into our database for use on next run of ExploreSites. Bug: 889104 Change-Id: I2d414e6cea59271252fa735bd59191706dead377 Reviewed-on: https://chromium-review.googlesource.com/1243673 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594589}
-
Anand K. Mistry authored
BUG=None Change-Id: I6e53fd84f1897d2ce5d783b82bd0ce9b88a6bf01 Reviewed-on: https://chromium-review.googlesource.com/1248069Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594588}
-
Nico Weber authored
features::kViewsBrowserWindows was mainly used by ScopedMacViewsBrowserMode to test code in cocoa mode. We've removed all references to that class, and we removed the feature from about:flags, so the only effect of this CL here is that it will disable chrome/mac/cocoa for folks who get the feature through finch. In theory that should be nobody, but we're seeing a handful folks run the cocoa browser still (which by now no longer has a toolbar, tab strip, download shelf, bookmark bar, ...). Bug: 832676, 887392 Change-Id: I0cb7f360616eabb2c96ecfdcb39d665206dcacb2 Reviewed-on: https://chromium-review.googlesource.com/1226299 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594587}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d50fdd753416..3a6b6bda177a git log d50fdd753416..3a6b6bda177a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 kwiberg@webrtc.org AudioCodingModuleTest.TwoWayCommunication: Remove non-automatic mode Created with: gclient setdep -r src/third_party/webrtc@3a6b6bda177a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If20c2f46d4b3926ebe313b614e4f5f7db51b4f18 Reviewed-on: https://chromium-review.googlesource.com/1247505Reviewed-by:
-
Sam McNally authored
When running with DriveFS enabled for the first time, recover any files in the local cache marked as dirty to a folder in Downloads, similar to the existing process for recovering from database errors, and clean up any old Drive client metadata. The existing Drive client code does not expect dirty files to be removed from its cache so clearing its metadata is necessary to limit confusion when switching back from DriveFS. Reset the DriveFS migration pref when running without DriveFS; each first DriveFS after running without DriveFS should migrate pinned files and recover any unsynced files. This should avoid losing data if a user toggles between DriveFS and not multiple times with unsynced files. Move Drive and DriveFS data to separate subdirectories in files app browsertests to avoid interference, in particular in DriveFS migration tests. Bug: 883242 Tbr: slangley@chromium.org Change-Id: I20199ffd04ad7f63cb77ac9a53e49ba1bf830502 Reviewed-on: https://chromium-review.googlesource.com/1242783 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#594585}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a31ac84a0bb..53d082585814 Created with: gclient setdep -r src-internal@53d082585814 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ec99854a7e331e3e955bb2ac751f7bda6012bec Reviewed-on: https://chromium-review.googlesource.com/1247444Reviewed-by:
-
Keishi Hattori authored
Adds UMA metrics to debug slow IncrementalMarkingFinalize. Theshold for slow IncrementalMarkingFinalize is set to 40ms to be around the 99th percentile. Bug: None Change-Id: Ied90405ef408e2917d33d83eba4701f1076936bc Reviewed-on: https://chromium-review.googlesource.com/1233017Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594583}
-
Kent Tamura authored
custom-elements: Do not distinguish V0 custom elements and V1 custom elements in :unresolved and :defined matching. This CL changed the behavior of :unresolved selector for V1-defined custom elements, and the behavior of :defined selector for V0-defined custom elements. The following table shows the current behavior: :unresolved :not(:defined) :defined Built-in false false true Not-defined true true false V0-defined false true false V1-defined true false true After this CL, the behavior is: :unresolved :not(:defined) :defined Built-in false false true Not-defined true true false V0-defined false false* true* V1-defined false* false true V0 custom elements specification defined ':unresolved' and V1 custom elements specification defines ':defined', but we don't need to distinguish V0-defined elements and V1-defined elements for these selectors. The current behavior makes it difficult to migrate V0 custom elements to V1 custom elements gradually. Bug: 889336 Change-Id: I48ecced042fe78314b42da4ea65baddb720e38fc Reviewed-on: https://chromium-review.googlesource.com/1248061Reviewed-by:
-
Xiaocheng Hu authored
This patch converts some layout tests to use testharness instead of plain text dump or js-test.js. It is a preparation for crrev.com/c/1243119. The changed tests have non-trivial text failures with that patch (due to flakes or non-trivial dependency on js-test.js), so we convert them in this CL to reduce noise there, and ensure that there are only newline text diffs in the other CL. Bug: 887148 Change-Id: I46d7508ddde62e32ddfa421e9975b39b73cc06df Reviewed-on: https://chromium-review.googlesource.com/1246902 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
"_MAX" suffix typically represents the last value in an enum, whereas "_COUNT" is more commonly used to count the number of entries. This CL should have no behavior changes. Change-Id: I976c67473f9590a815514ac59758d3a7abc0ad8e Reviewed-on: https://chromium-review.googlesource.com/1245022Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594580}
-
Jordy Greenblatt authored
The specs for this case are in Comment 13 in the bug: https://bugs.chromium.org/p/chromium/issues/detail?id=878644#c13 Screenshot of results of CL: http://screen/KJj4Rxeo84H Note that the font size (13px) and line height (16px) are explicitly spelled out here because the default height without that specification was slightly off. Bug: 878644 Change-Id: Ie93a3c173c3b43b7cab23177a02c8eb8f9c70181 Reviewed-on: https://chromium-review.googlesource.com/1247194 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594579}
-
Sam McNally authored
Bug: 883230 Change-Id: Iab1c421c8a4325c628f915d35b280dc3c8be8a69 Reviewed-on: https://chromium-review.googlesource.com/1240054Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/af8b73c9e632..115e8a2625f5 git log af8b73c9e632..115e8a2625f5 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Vulkan: Store "is packed" in buffer formats. Created with: gclient setdep -r src/third_party/angle@115e8a2625f5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ie8dd83d73e8f24557f260ce2477a8c71968dac93 Reviewed-on: https://chromium-review.googlesource.com/1247981Reviewed-by:
-
Daniel Erat authored
Update PowerManagerClient to pass serialized protocol buffers to powerd's SetScreenBrightness D-Bus method instead of passing native D-Bus arguments to SetScreenBrightnessPercent. This allows passing the reason for the request. Bug: 881786 Change-Id: I753fb19f45f99acf3142d91ba96cf3650699df33 Reviewed-on: https://chromium-review.googlesource.com/1244551Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#594576}
-
Ted Meyer authored
leaving already-called-callbacks in the input_buffer_queue_ was causing crashes when they were called a second time. Bug: 889375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6623f6736aa0551253a23282562721facf06acf0 Reviewed-on: https://chromium-review.googlesource.com/1247421Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594575}
-
Yuzu Saijo authored
OomIntervention should not be re-triggered on the same page if the user declines the intervention once. This CL fixes the bug. Bug: 889131, 887119 Change-Id: Idb9eebb2bb9f79756b63f0e010fe018ba5c490e8 Reviewed-on: https://chromium-review.googlesource.com/1245019 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
During aggregation, SurfaceAggregator marks all resources used for a draw in the resource provider. This has the side effect of deleting unused resources and their textures, generating sync tokens, and returning the resources to the client. This involves GL work which is issued before drawing commands, and gets prioritized by GPU scheduler because sync token dependencies aren't issued until the draw. This CL extends ScopedBatchReturnResources to include all places where the resource provider deletes resouces including marking used resources, and makes Display hold a ScopedBatchReturnResources for the entire duration of draw including surface aggregation. This defers the GL commands for deleting resources to after the draw, and prevents context switching because the scheduler knows sync token dependencies at that time. This has a big impact on WebGL performance in general, and especially on certain older Adreno 3xx devices. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0e0ba47b54c3bb2c0a7bc344f65f2caba7d8c117 Bug: 835353 Reviewed-on: https://chromium-review.googlesource.com/1200414 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594573}
-
Kouhei Ueno authored
This CL introduces signed_exchange_utils::ShouldAdvertiseAcceptHeader, which can be used to query if a origin should be sent "Accept: application/signed-exchange" header. The origins list is managed by the feature "SignedHTTPExchangeAcceptHeader", and a Finch param attached to it. Note: Use the below args to test this: --enable-features=SignedHTTPExchangeAcceptHeader<AcceptHeaderStudy --force-fieldtrials=AcceptHeaderStudy/Group --force-fieldtrial-params=AcceptHeaderStudy.Group:OriginsList/www%2eexample%2ecom The subsequent CL will actually plumb this to the navigation loaders. Bug: 887201 Change-Id: I06cc991e396b28ab0d02e2bbba3a117fd53d4fe5 Reviewed-on: https://chromium-review.googlesource.com/1235473Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#594572}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c8b28b92f6f3..f221bac5302a git log c8b28b92f6f3..f221bac5302a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f221bac5302a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idc60de3856eb55a852c985caca3e95432742a9b9 Reviewed-on: https://chromium-review.googlesource.com/1247503Reviewed-by:
-
Nick Harper authored
Bug: 863877 Change-Id: I15547be6d4ab6367ca5c84f6b7e0b70f7bb70734 Reviewed-on: https://chromium-review.googlesource.com/1244576Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#594570}
-
Katie D authored
UX approved over email. Bug: 833047 Change-Id: I73c5b12d98fa332aa29089d7af23bb420d659436 Reviewed-on: https://chromium-review.googlesource.com/1241995Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#594569}
-
Yoichi Osato authored
This patch extracts MarkSelected at call sites since the function used to be called not directly because of LayoutTextFragment. This patch also shrinks ComputeNewPaintRange not to bring a hashset. Then the hashset appears only at one function. Bug: 889360 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I44a020ccf9172c6159bec5251a3ab3733b7d4868 Reviewed-on: https://chromium-review.googlesource.com/1244699Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#594568}
-
Abhishek Arya authored
R=mmenke@chromium.org,asanka@chromium.org Bug: 865732 Change-Id: I0744cba403f2809c8b09b0b2f5cf6e618ecb2f76 Reviewed-on: https://chromium-review.googlesource.com/1247187 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594567}
-
Robert Sesek authored
- BrowserWindowMacTest tested both modes, and now it only tests views. - PermissionBubbleInteractiveUITest forced Cocoa, but all the tests are disabled, so it doesn't matter that it cannot force a mode. - The ScopedMacViewsBrowserMode is removed from CocoaTest. - In its place, CocoaProfileTest now brings up a ViewsDelegate so that it can properly create a views BrowserWindow. CocoaProfileTest should be removed in favor of TestWithBrowserView. Bug: 832676 Change-Id: I4648d893a71794c2f0b3c108b0afb05d45dc84be Reviewed-on: https://chromium-review.googlesource.com/1246731 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594566}
-
Shimi Zhang authored
There were ownership issue of the file descriptor, use ParcelFileDescriptor instead of raw fd to prevent wrong ownership exchange. Current tests should cover this change. Bug: 882608 Change-Id: I974739f4b3d59c9ac3ba21006f686e7a38244806 Reviewed-on: https://chromium-review.googlesource.com/1244803 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594565}
-
Stuart Langley authored
Calling ReadDirectory() before we have fetched the full corpus will result in multiple calls to the backend to get the data. If this is done repeatedly (which it is) this unnecssarily slows down the initial loading of the app. If we're still loading teh corpus then cache the result of ReadDirectory for 30 seconds before refreshing. Adds test and a better log mesage so we can see what directories are being read. Bug: 783184 Change-Id: I0a1c27dab2244a933f9d43d6ec48ccf0010fc110 Reviewed-on: https://chromium-review.googlesource.com/1237902 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#594564}
-
Xiaohan Wang authored
To remove duplicate code. In another CL, I also need it in ClearKeyCdm. Bug: 169203 Test: No functionality change. Change-Id: I077d0b52780e960f4da6e974405eff6a2dd2fe06 Reviewed-on: https://chromium-review.googlesource.com/1247561Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594563}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ab99ab..d4c562dc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23247f95b25c2f0461f5df0237d380c9d09bd236 Reviewed-on: https://chromium-review.googlesource.com/1247224Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594562}
-
Zhenyao Mo authored
only send back collected bits rather than full GPUInfo BUG=718215 TEST=bots, manual R=piman@chromium.org,magchen@chromium.org,dcheng@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib7c6107057bd39579d3bad95400599c5a84ce8b0 Reviewed-on: https://chromium-review.googlesource.com/1246689 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#594561}
-
