GitLab

Incognito mode doesn't have a sync service.

Additionally, if there is no browser window associated with the main
profile, create one.

BUG=90570, 90466
TEST="Set Up Chrome Sync" from Incognito wrench menu doesn't crash (and opens tab in main profile).
TEST=Test also works if all main-profile windows are closed.
TEST=On Mac, close all windows and select "Set Up Sync" from Chrome menu.


Review URL: http://codereview.chromium.org/7477021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7355011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95380 0039d316-1c4b-4281-b951-d872f2087c98

After some discussion we decided that we no longer want a new profile setup UI.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7563023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91423
TEST=ClientSideDetectionServiceTest


Review URL: http://codereview.chromium.org/7465101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95378 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95371 0039d316-1c4b-4281-b951-d872f2087c98

Set the label and tooltip text.

BUG=90771
TEST=none

R=erg@chromium.org,thestig@chromium.org

Review URL: http://codereview.chromium.org/7564036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7570003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95369 0039d316-1c4b-4281-b951-d872f2087c98

Wrap the link in a div instead of hacking the display to block.

BUG=90939
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7508046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7563017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91619
TEST=Manual

Review URL: http://codereview.chromium.org/7565025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95364 0039d316-1c4b-4281-b951-d872f2087c98

The underlying issue should be fixed as of revision 94160.  Tested with:

tools/heapcheck/chrome_tests.sh -t sync_unit_tests

BUG=88438

Review URL: http://codereview.chromium.org/7508037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88878
TEST=None


Review URL: http://codereview.chromium.org/7484040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91462
TEST=


Review URL: http://codereview.chromium.org/7564023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95361 0039d316-1c4b-4281-b951-d872f2087c98

placeholder.

BUG=80038
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7565021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95360 0039d316-1c4b-4281-b951-d872f2087c98

- Return cryptohome final failure state instead of intermediate ones if
  there is no parallel online attempt (when using oauth login);
- Fix js error when using Gaia sign-in;

BUG=chromium-os:18651
TEST=Verify fix for chromium-os:18651.

Review URL: http://codereview.chromium.org/7562010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95358 0039d316-1c4b-4281-b951-d872f2087c98

This patch modifies LiveSessionsSyncTest::ModelAssociatorHasTabWithUrl so that it is no longer hard-coded to check only windows[0]->tabs[0].  With this change, it iterates through all windows and all tabs, so it will return true if any tab in the given profile has the specified URL.

This change has no immediate effect, but it is intended to be one step towards eventually adding tab/session sync performance tests.

I also added LiveSessionsSyncTest::GetLocalSession to eliminate a little bit of repeated code.

BUG=
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7562020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95357 0039d316-1c4b-4281-b951-d872f2087c98

This also refactors part of ProfileInfoCache into an abstract interface that is
more suitable for testing.

BUG=60105
TEST=Partially covered by unit_tests. No UI changes yet.

Review URL: http://codereview.chromium.org/7544031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7554020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95354 0039d316-1c4b-4281-b951-d872f2087c98

Print a warning about it on startup for now since I expect some bot
somewhere to go bad.

Review URL: http://codereview.chromium.org/7570002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95353 0039d316-1c4b-4281-b951-d872f2087c98

(His comments came in after I had already landed.)

Fix some style nits as well as a copy'n'paste error.

Review URL: http://codereview.chromium.org/7508038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95351 0039d316-1c4b-4281-b951-d872f2087c98

For a detailed description see part #1, http://codereview.chromium.org/6478005/

BUG=61062
TEST=unit_tests, possibly more

Review URL: http://codereview.chromium.org/7465041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95350 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of chrome/test/interactive_ui

BUG=90905
Review URL: http://codereview.chromium.org/7568002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95349 0039d316-1c4b-4281-b951-d872f2087c98

Refactor CreateAppInfo less, since pyauto functional tests for the NTP expect it to still return something for special apps like the Webstore.

original CL at http://codereview.chromium.org/7517019
reverted CL at http://codereview.chromium.org/7553001

BUG=90433
TEST=Crash a packaged app with a background page. It appears on the NTP, and clicking its icon relaunches it. ntp pyauto functional tests also pass.

Review URL: http://codereview.chromium.org/7542027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95348 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95347 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.

This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Autofill datatype to the new model, and contains the following changes:

- LiveAutofillSyncTest no longer inherits from LiveSyncTest, but is renamed to AutofillHelper, and contains a bunch of static methods that perform various operations related to Autofill.
- TwoClientLiveAutofillSyncTest is renamed to TwoClientAutofillSyncTest, and is a subclass of LiveSyncTest. It uses the methods in AutofillHelper by including its header file and attaching itself to the helper.

BUG=88510
TEST=sync_integration_tests, sync_performance_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95263
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95267

Review URL: http://codereview.chromium.org/7536001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95346 0039d316-1c4b-4281-b951-d872f2087c98

Implemented support for GL context share groups in the renderer process.I put all compositor and canvas contexts in the same share group so they can share IDs.
Review URL: http://codereview.chromium.org/7554015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7566022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7551019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95343 0039d316-1c4b-4281-b951-d872f2087c98

Add a template to handle properly issuing completion callbacks. This fixes
some bugs where we forgot to issue completion callbacks in some error cases
in the proxy, and cleans up the cases that were already doing this properly.

This removes the PPB_AudioTrusted_API and folds those functions into the
regular Audio API. I'm trying to merge more things to have a smaller explosion
of APIs and the boilerplate associated with them.
Review URL: http://codereview.chromium.org/7551032

TBR=brettw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95342 0039d316-1c4b-4281-b951-d872f2087c98

bad placement of #endif

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7465107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95338 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a minimalistic configurator

TEST=none
BUG=61602
Review URL: http://codereview.chromium.org/7545004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7484052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91434
TEST=unit tests


Review URL: http://codereview.chromium.org/7551026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95333 0039d316-1c4b-4281-b951-d872f2087c98

We don't want to resolve to the parent texture, as that can cause an accidental swapbuffers when preserveDrawingBuffer is false. Instead create a temporary texture which will stick around for a while.

BUG=55927
TEST=


Review URL: http://codereview.chromium.org/7553018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90857
Review URL: http://codereview.chromium.org/7564029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95331 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7563020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18418
TEST=Ensure bug reporting and screenshots work, system info is only provided when option is checked, and system info includes "mem_usage" entry.

Review URL: http://codereview.chromium.org/7562001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82232,82541,87680,90091
TEST=unittests, these drivers are blacklisted.
Review URL: http://codereview.chromium.org/7519012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51198
TEST=None

Review URL: http://codereview.chromium.org/7549027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18606
TEST=none
Review URL: http://codereview.chromium.org/7554021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95320 0039d316-1c4b-4281-b951-d872f2087c98