GitLab

Bug: 781643
Change-Id: Ic2c7118bc4d63404298b21ae0c85dd4512538881
Reviewed-on: https://chromium-review.googlesource.com/826524
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526544}

In certain non-standard jumbo configurations (very large
jumbo units) there were some symbol clashes that do not
appear in normal jumbo builds. This resolves them by
renaming one test class to better match the test, and by
wrapping the other test in a custom namespace as done in other
places in blink tests.

Bug: 745732
Change-Id: Ic0388e9abd19b24366133c577059f59ef63a6b6b
Reviewed-on: https://chromium-review.googlesource.com/847009Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526543}

tests that depend on ChromeWebClient (for e.g., early script injection) to
run.

web: :WebTest uses an instance of web::TestWebClient by default. This allows
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8e36ac709f5c445392a817219cabc5c5152aa164
Reviewed-on: https://chromium-review.googlesource.com/840300Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526542}

GTK windows have the .maximized class applied when they are maximized.  Child
widgets may be styled differently depending on this state, as the Breeze theme
does with the unmaximize button.

Unlike other themes, the Breeze theme uses a bitmap to render the titlebuttons,
so it was the only theme so far affected by this issue.  With this fix, the
unmaximize button looks like a diamond instead of an up arrow.

BUG=794358
R=thestig@chromium.org

Change-Id: I462d78665e3d1e30d05535af632415c981f3f432
Reviewed-on: https://chromium-review.googlesource.com/842857Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526541}

Bug: 796089
Change-Id: If98d74fdeac2892463f1353da778fb9973b07b86
Reviewed-on: https://chromium-review.googlesource.com/847694Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526540}

This is part of a series of changes to implement the functionality to
change default download location on Android. This CL creates a simple
toggle between internal and external storage locations as a temporary
step while the layout of the final directory selector is being decided.

Screenshot:
https://drive.google.com/file/d/1axW_UAm8JWlAhrQvITsiHCKi1nNoF8Ym

Bug: 792775
Change-Id: I3a5b11c84c3e4dcd79ab941351fdd20c310d569d
Reviewed-on: https://chromium-review.googlesource.com/832822Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526539}

Change-Id: I3336d665aa4a14abdc1d6e60c9141f2bb9374918
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 798548
Reviewed-on: https://chromium-review.googlesource.com/846358
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526538}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b34ee3b25ff3820c03f3b8b2a1ec559a18650c3
Reviewed-on: https://chromium-review.googlesource.com/847644Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526537}

This is a follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/846026.
These tests were rebaselined and are now passing without flakes.

Bug: 626703, 751952
Change-Id: I0497c373ae1b99e728b8f81cc52d11c9521e725e
Reviewed-on: https://chromium-review.googlesource.com/847309Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526536}

After marking the test from skip to pass / fail / timeout in
https://chromium-review.googlesource.com/c/chromium/src/+/845979,
we can see the test is only flaky on the Leak bot:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/devtools/console/console-search.js

Bug: 667560
Change-Id: I0734ef74c65bd067ce7f933ed488b37ecd24fb23
Reviewed-on: https://chromium-review.googlesource.com/847306Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526535}

R=glider@chromium.org

Bug: 790784,797998
Change-Id: I112b606d8f34a616624d99201b6da8b5534148ea
Reviewed-on: https://chromium-review.googlesource.com/846028Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526534}

Note that this CL doesn't add support for filling out the omnibox text field
when the speech recognition result (in case we're not very confident in the
speech).

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I660100011e7ccaaa8a9a85481829c09067f1859b
Reviewed-on: https://chromium-review.googlesource.com/846222Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526533}

To match the spec:
https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly

Bug: 785132
Change-Id: I0cdd6aa9e4ec1129d272e64cc53d12487e3fb256
Reviewed-on: https://chromium-review.googlesource.com/846159Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526532}

Using wpt-import in Chromium 5edcf150.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9456

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: Iaa1bc72df228516e25226ee08436e55b9ca7eece
Reviewed-on: https://chromium-review.googlesource.com/847281
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526531}

This link is sometimes used as a free text field and can be quite long.

Bug: 795226
Change-Id: I46e8f324f2467801dfa5a1ade8df45de8d0587de
Reviewed-on: https://chromium-review.googlesource.com/829594Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526530}

TBR=nednguyen@google.com
NOTRY=true

Bug: 798465
Change-Id: If3972194b9ccdbf677a6570c4bce34963eeb41e5
Reviewed-on: https://chromium-review.googlesource.com/846307Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#526529}

The crash occurs in the following situation:
- Navigation is performing which results in Frame detach from DOMWindow
- PerformanceObserver::disconnect is called from PromiseReactionJob micro task

In this case, this call graph is executed:

blink::(anonymous namespace)::EndOfTaskRunner::DidProcessTask()
  v8::internal::Isolate::RunMicrotasks()
    v8::internal::Isolate::RunMicrotasksInternal()
      v8::internal::Isolate::PromiseReactionJob()
        ... some V8 magic to call browser API from JS ...
          blink::PerformanceObserver::disconnect()
            blink::PerformanceBase::UnregisterPerformanceObserver()
              blink::Performance::UpdateLongTaskInstrumentation()
                blink::LocalFrame::GetDocument() const

and, given that Frame has been detached, GetDocument() is called with this
equal to nullptr, which leads to segfault.

Bug: 793720
Change-Id: Id3cd67e3ebb5a197024b8ac269eebfc241cf2fc7
Reviewed-on: https://chromium-review.googlesource.com/825022
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526528}

Bug: 598854, 568664
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I65e453144c9d465579101269e0963cd4319abc33
Reviewed-on: https://chromium-review.googlesource.com/838281Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526527}

Everything went well with the experiment so make it permanent.

Bug: 782879
Change-Id: I340fc590d994bac2e50f17b25890558430136365
Reviewed-on: https://chromium-review.googlesource.com/847417Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526526}

Nothing currently prevents a WebView application calling
setWebMessageCallback multiple times.

If a handler has previously been set via setMessageCallback, then it is
currently impossible to reset it back to null, meaning that the effect
of passing null for handler differs depending on previous calls.

Bug: 798449
Change-Id: I93dd8fbb3a5dce7be0b787ee78fecf739f7c4199
Reviewed-on: https://chromium-review.googlesource.com/847486
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526525}

X11 headers create a lot of macros using fairly normal names which
causes collisions in code that was written without X11 headers in
mind.

DeviceMode is also a type in components/policy and if that and
X11 includes end up in the same translation unit, there will be
compilation errors.

This was encountered in non-standard jumbo configurations and will
not affect currently supported code.

Bug: 782184
Change-Id: I84f9874d2858fc60c7e7c0e017d028dc8b710661
Reviewed-on: https://chromium-review.googlesource.com/847577Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526524}

The new flag enables SSH port forwarding from the host to the VM. It
will be useful for layout tests to start VM with --no-autorun and
then start and communicate with content_shell over SSH.

Bug: 778467
Change-Id: Ied45b3dd0a5f545def85274a91cc96cae2399832
Reviewed-on: https://chromium-review.googlesource.com/843481
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526523}

There are two sets of kDataPrefix and kMetadataPrefix in
components/sync and they have different values. In non-standard
jumbo configurations (much larger jumbo chunks than normal) those
will end up in the same translation unit and clash.

This renames one set of constants, leaving the other one as is
since its name already matches the use well.

Change-Id: I3640f1c1e7bc599c7d20317cd60d2f1ac7d90b15
Reviewed-on: https://chromium-review.googlesource.com/847593Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526522}

To help jumbo compilations, this code has already renamed
Children -> LayerChildren so this follows the same pattern
to help some other jumbo configurations where the plurality
of ChildAt and Parent methods caused problems.

Bug: 786926
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I086022931622b1bb670bc1313987ff69182c0990
Reviewed-on: https://chromium-review.googlesource.com/847473Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526521}

This fixes some short bookmark button titles getting truncated.

Bug: 796836
Change-Id: I7bf68b5b5ccc7d48923da231feccb97f9c0caa34
Reviewed-on: https://chromium-review.googlesource.com/845821Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526520}

Following bot results are included.
2736 2744 2747 2751 2753 2755

Manual rebaselines for css1 and css2.1.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I63b309df9edcbe77d9ad1d59ff9719af5f27ed3d
Reviewed-on: https://chromium-review.googlesource.com/846653
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526519}

Change-Id: Ifb6e45ae0a53af02a7b03ca3f1da404f40fea76e
Reviewed-on: https://chromium-review.googlesource.com/846808Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#526518}

This CL fixes a one-character typo in the method name of one of the new
TabModelObserver methods in the BVC.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1b1f72d4053452a3e11c6b283f99b8214def4d39
Reviewed-on: https://chromium-review.googlesource.com/847006Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526517}

Bug: 792315
Change-Id: I2809ba53f68694092535500b299f05a270d45119
Reviewed-on: https://chromium-review.googlesource.com/841725Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526516}

Make private mLock member and ensureChromiumStartedLocked() method package accessible
in order to use them downstream in a subclass inside the next/ layer.

This patch needs to land before:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/530279

BUG=781249

Change-Id: I6795fc45fa1d5e1ec8bdadad5bd1b62e577e8bb5
Reviewed-on: https://chromium-review.googlesource.com/843027
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526515}

Now that VideoFrame's ReleaseMailboxCB is called for mojo video
decoders, MCVD can use it.

This cl also converts VideoFrame::ReleaseMailboxCB => OnceCallback.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ice3031090cbfd43d10374294d9443f440a03b2f8
Reviewed-on: https://chromium-review.googlesource.com/815139
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526514}

Bug: 796913
Change-Id: I34cbb6075a33cc529ccd511199d5f274cb0ec735
Reviewed-on: https://chromium-review.googlesource.com/847454Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526513}

This CL reimplements Back button handling in AccountFirstRunFragment -
it no longer recreates every fragment in ViewPager, updating
AccountSigninView instead. This removes the need for custom
getItemPosition implementation.

Bug: 783344
Change-Id: Iaaa580802729551bb549c9848af8da9f7e9f7bd4
Reviewed-on: https://chromium-review.googlesource.com/844794Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526512}

This change fixes small issues in the U2F BLE classes.

Bug: 763303
Change-Id: Ib4b54b05d6952dbecb35b18ee53601b8d8c0ea67
Reviewed-on: https://chromium-review.googlesource.com/847477Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526511}

ProxyResolvingClientSocket accesses socket pools, http auth cache,
client certs cache directly.  As a part of the network servicification
effort, all interactions with //net need to be done using mojo APIs.
Socket usage will also be through mojo APIs. This CL moves this class to
services/network so the API surface that we need to export is smaller.

This CL:
- Moves ProxyResolvingClientSocket to services/network.
- Adds a few additional unit tests.

See design doc:  https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit?usp=sharing.

Bug: 721401

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbc0cb2e3a9713ef111ddd8b5845f27b1445574e
Reviewed-on: https://chromium-review.googlesource.com/763651
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526510}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bfbaf6ac..bb5733a4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ie4c2628fca6c2c44d7080cd778cba9355ab74dea
Reviewed-on: https://chromium-review.googlesource.com/847419Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526509}

They've been working in this codebase for a while now and this can help
expedite reviews for simple cases.  Obviously defer to dominickn@ if
unsure

Change-Id: I77eeaa91ec4e9690b7fedd8fa5dc3167416e3017
Reviewed-on: https://chromium-review.googlesource.com/817619
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526508}

It was being reversed in build_configs, then again in
process_resources.py

Bug: 782316
Change-Id: I654a77d8e859f068101fadf99400c26582844d82
Reviewed-on: https://chromium-review.googlesource.com/842950Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526507}

This CL removes the last usages of
SigninPromoController.arePersonalizedPromosEnabled and the method
itself.

Bug: 792430
Change-Id: Ib169667f755d87fc170b121654c59d50cb5d2b8e
Reviewed-on: https://chromium-review.googlesource.com/844318Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526506}

Makes a few updates to about:gpu.

* Add a "Copy to Clipboard" button, and removes the "To properly save
  this page" instructions. (797440)
* Fixes blacklist URLs on CrOS: fall back to the 0.0.0.0 version
  identifier whenever the 40-char hash is not available. (786605)
* Print the date in ISO format, rather than localized format, so that
  Chrome developers will be able to read it consistently. (no bug)

Bug: 786605
Bug: 797440
Change-Id: I6ab25b19248c49e8ba16bedad5060a48dc16b8b8
Reviewed-on: https://chromium-review.googlesource.com/846283Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526505}