GitLab

CBOR{Reader|Writer|Value} were renamed in b4f12f9a to remove the “CBOR”
prefix. This change reflects that in the filenames.

(TBR for webpackage code since this is just renaming headers of
an underlying library.)

TBR=kinuko@chromium.org

Change-Id: I0262c827181fe8ab51cd08ad41fce14aa1aed331
Reviewed-on: https://chromium-review.googlesource.com/c/1303177
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603583}

Adds the "browser_switcher.use_ie_sitelist" boolean pref. When set to
true, BrowserSwitcherService will download IE's sitelist after 60s.

Once the sitelist XML is downloaded, the rules are parsed and applied.

Bug: 884837
Change-Id: Ib7a6c374526c56c42265187667ea2d6febc3628b
Reviewed-on: https://chromium-review.googlesource.com/c/1286288
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603582}

Get it building and enable it on Windows to increase our coverage of
skia on Windows.

Change-Id: If88d332d8dcc2fb39e80850a654682fc92530aed
Reviewed-on: https://chromium-review.googlesource.com/c/1305208Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603581}

This test was added by https://crrev.com/c/1293171 and it is failing on
KitKat Phone Tester (dbg) builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Phone%20Tester%20%28dbg%29/10119

TBR=bokan@chromium.org

Bug: 898987
Change-Id: I82fe04a5d11cbe09a2794fc6daadb33ce5b1463e
Reviewed-on: https://chromium-review.googlesource.com/c/1305316Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603580}

Updates crostini installer browser test setup to use fake cros component
manager implementation.

BUG=None
TEST=cq passes

Change-Id: I85e19ffeade2a932678ddaee92db8329b0bde426
Reviewed-on: https://chromium-review.googlesource.com/c/1303036Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603579}

Bug: 898212
Change-Id: I83a8f9e355f2b527db8eabfba40625f60a78822f
Reviewed-on: https://chromium-review.googlesource.com/c/1303949
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603578}

This fixes SurfaceLayer kOnDemand mode to work with
webmediaplayer_ms when the player starts in PIP.

Previously, the player wouldn't use SurfaceLayer, since it would
wait to enter PIP.  Now, it checks if the client is already in PIP,
and switches to SurfaceLayer immediately in kOnDemand mode.

Bug: 891619
Change-Id: I669003b512152cc22c3e0d1f7d69133304669108
Reviewed-on: https://chromium-review.googlesource.com/c/1301958Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603577}

views::TouchSelectionMenuRunnerViews::Menu should be better by
separating it on their own class, this CL introduces
TouchSelectionMenuViews.

Bug: None
Test: Build.
Change-Id: I6e23c379abc7eb746713dde1b9224389a98014e6
Reviewed-on: https://chromium-review.googlesource.com/c/1300054
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603576}

conformance2/vertex_arrays/vertex-array-object-and-disabled-attributes.html
on Linux AMD

conformance/attribs/gl-disabled-vertex-attrib-update.html
on Nexus 5

conformance/reading/fbo-remains-unchanged-after-read-pixels.html
conformance/reading/read-pixels-pack-alignment.html
conformance/reading/read-pixels-test.html
on Nexus 6

TBR=kbr@chromium.org

Bug: 899754
Change-Id: Icb1db2a029fa20897baf925609a2ed4dd00cf132
Reviewed-on: https://chromium-review.googlesource.com/c/1305206Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603575}

https://pdfium.googlesource.com/pdfium.git/+log/b7c4a0243e82..ea08d171755b


git log b7c4a0243e82..ea08d171755b --date=short --no-merges --format='%ad %ae %s'
2018-10-29 tsepez@chromium.org Fold virtual CPWL_Wnd::OnCreate into subclass constructors.


Created with:
  gclient setdep -r src/third_party/pdfium@ea08d171755b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I30edbacb27ea609d7357f68f0ce62e43b1f55316
Reviewed-on: https://chromium-review.googlesource.com/c/1305295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603574}

This reverts commit 10a10dd9.

Reason for revert: Suspected for flaky crashes affecting Chromium CQ.

Original change's description:
> Oilpan: Enable HeapCompaction for incremental marking
> 
> Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC.
> 
> Bug: 864425
> 
> Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8
> Reviewed-on: https://chromium-review.googlesource.com/c/1297782
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603477}

TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org

Change-Id: Ie72a2eb04571945b3515ee7374a75a1ab87275c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864425, 899809
Reviewed-on: https://chromium-review.googlesource.com/c/1305833Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603573}

ChromeVox has "force flush" behavior when it receives user input via qwerty keys, braille keys, and touch (explore/gestures).
It also has programmatic queue behaviors via Output.withQueueMode.
By default, ChromeVox is ready to queue all other output.

This will help ChromeVox be flexible when receiving events and not dropping output. For example, when pressing Ctrl+l, we receive focus on the omnibox and quickly after, a selection event on the listbox option auto completion.

This is a separate change to ensure we don't miss any corner cases and have to revert.

Test: existing tests/manually on omnibox.
Change-Id: Iba069c5794fe8cc2b3318c64a87dbd4cc7df6385
Reviewed-on: https://chromium-review.googlesource.com/c/1302414
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603572}

This CL shouldn't change behavior.

Bug: 899790
Change-Id: Ia59af2fafaa95130dfbb2138356c8783c22030b7
Reviewed-on: https://chromium-review.googlesource.com/c/1305493Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603571}

https://chromium.googlesource.com/angle/angle.git/+log/4a22f4b04619..25224e786ffe


git log 4a22f4b04619..25224e786ffe --date=short --no-merges --format='%ad %ae %s'
2018-10-29 syoussefi@google.com Vulkan: add GPU trace events


Created with:
  gclient setdep -r src/third_party/angle@25224e786ffe

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I20bae53b68a653e7e4ee4f607a254074b5532e12
Reviewed-on: https://chromium-review.googlesource.com/c/1304914Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603570}

It is fairly common to have one or two baseline requests (see
NGConstraintSpace::CreateFromLayoutObject,
NGBlockLayoutAlgorithm::CreateConstraintSpaceForChild and others),
so give the vector some inline capacity to avoid memory allocation
in the common case.

This can actually save memory, because Vector will allocate space
for 4 elements when adding the first element (see wtf/Vector.h,
kInitialVectorSize)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7d1c67a53f0c76ab1804ad5ff7d140b4772e79de
Reviewed-on: https://chromium-review.googlesource.com/c/1265130
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603569}

This CL moves tests for the mixins feature into its own suite. It also
moves the test data inputs for those tests near this.

Change-Id: Id0e2c97ee59497e239231cc53e300d2f1f655b5c
Reviewed-on: https://chromium-review.googlesource.com/c/1303046Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603568}

It's been at 100% experimental for a while now and it doesn't appear
to be blowing out our capacity.

Bug: 876494
Change-Id: I90a4fda3350bd96a03244d9b53b0471ce66923a8
Reviewed-on: https://chromium-review.googlesource.com/c/1301971Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603567}

If the media session feature is enabled then use the
media session service to control playback when the
next/previous track media keys are pressed.

BUG=894255

Change-Id: I0bd99bad14ce9973d10f2c4567dd487bda0ac436
Reviewed-on: https://chromium-review.googlesource.com/c/1289149
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603566}

https://chromium.googlesource.com/catapult.git/+log/00755b36f6d2..625dca84765d


git log 00755b36f6d2..625dca84765d --date=short --no-merges --format='%ad %ae %s'
2018-10-29 taylori@google.com Handle perfetto protobuf files


Created with:
  gclient setdep -r src/third_party/catapult@625dca84765d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2f310189c8c9eaf06b8ab3682028ad68702ebf0d
Reviewed-on: https://chromium-review.googlesource.com/c/1305233Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603565}

This reverts commit 8fe65f6f.

Reason for revert: Suspecting that it's causing these tests
to fail:

services_unittests
MemoryTracingIntegrationTest.GenerationChangeDoesntReenterMDM

content_browsertests
MemoryTracingTest.BrowserInitiatedDump

See bug 899813

Original change's description:
> Introduce base::trace_event::TraceArguments helper class.
> 
> This CL introduces the TraceArguments helper class to simplify
> the way TRACE_EVENTXXX macro named arguments are passed to the
> trace log. By using a small dedicated data structure, it is
> possible to generate less code at each trace call site,
> compared to the old way that relies on passing 5 specially
> crafted arguments to TraceLog methods.
> 
> For example, this optimization can save about 12 kiB in
> libmonochrome.so for the 32-bit ARM build of Chrome on Android.
> For more details, see corresponding bug entry.
> 
> This CL does the following:
> 
> - Introduce the new class in base/trace_event/trace_arguments.h
> 
> - Move the definition of TraceValue to trace_arguments.h and
>   augment the union with templated methods to support easy
>   initialization from a large set of C++ value types.
> 
> - Add new TraceLog methods to add trace events using an
>   optional TraceArguments parameter, instead of a bag of
>   5 ones (count + names + types + values + convertables).
> 
> - Simplify internal templates using C++11 universal references
>   and std::forward<> to remove special-casing convertable
>   arguments in trace event calls.
> 
> - Remove the now obsolete TraceValueUnion type from trace_event.h
> 
> - Make the TraceEvent class fully C++11 movable, to simplify
>   its usage (this removes the Initialize() and MoveFrom() methods).
> 
> - Update base/trace_event/ code to use TraceArguments and the
>   new TraceEvent move operations.
> 
> - Note that this keeps a few forwarding data types, values and
>   methods to avoid other direct callers from the Chromium tree,
>   these will be updated in future CLs. One Blink header needs
>   to be modified though because it specializes a template
>   defined in trace_arguments.h, to support sending WTF::CString
>   references as trace arguments.
> 
> BUG=898794
> R=​oysteine@chromium.org,chiniforooshan@chromium.org,alexiln@chromium.org
> TBR=primiano@chromium.org,torne@chromium.org
> 
> Change-Id: I8fe2225974f7044515a2f64bdc67f6d36abfe004
> Reviewed-on: https://chromium-review.googlesource.com/c/1298997
> Commit-Queue: David Turner <digit@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603500}

TBR=digit@chromium.org,primiano@chromium.org,torne@chromium.org,chiniforooshan@chromium.org,oysteine@chromium.org,alexiln@chromium.org

Change-Id: I165b96fde68d927f966bdb4ed8649dd7bb4dd0f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898794, 899813
Reviewed-on: https://chromium-review.googlesource.com/c/1305250Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603564}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fea579b6e9b..6d65cf959e1d


Created with:
  gclient setdep -r src-internal@6d65cf959e1d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6de17b91d44dd7bda7f7a7589f7fd8ea29b686fa
Reviewed-on: https://chromium-review.googlesource.com/c/1305238Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603563}

Previously, the if/else block was missing the NOTRUN status. Since the statuses
are already represented by strings, this CL converts the strings to be expected
outputs. This allows us to remove the entire if/else block.

Bug: 895027
Change-Id: Ieb426eb268c30dd07a6642dcfd97122cdb07c926
Reviewed-on: https://chromium-review.googlesource.com/c/1305414Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603562}

conformance/rendering/gl-scissor-fbo-test.html
deqp/data/gles2/shaders/swizzles.html
on Win NVIDIA Passthrough Vulkan Debug.

TBR=kbr@chromium.org

Bug: angleproject:2939, angleproject:2940
Change-Id: I8b388eb464b42def465c231d5986852a6517e19a
Reviewed-on: https://chromium-review.googlesource.com/c/1305237Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603561}

We previously used these two terms semi-interchangeably, which
a) was confusing, and b) hindered code search for backdrop-filter
related code. I checked carefully - this CL is a pure rename
operation. No functionality should change.

I did not touch "background blur" and "background zoom" in ash
or ui::Layer. Those are similar concepts and names, but don't
appear to use the same machinery as CSS-based backdrop-filter.

Change-Id: I8f5473c4014ba47b2bbc354126c1a10f4aebc61a
Reviewed-on: https://chromium-review.googlesource.com/c/1300035Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603560}

Increases total time sleeping from 30s to 62s.

Bug: 892670
Change-Id: Ib4d631da6c24fb3bb2f9f3a9c692ed82d699b397
Reviewed-on: https://chromium-review.googlesource.com/c/1305413
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603559}

We need to report Last Text Paint and Largest Text Paint to UKM
and UMA. This CL uses mojo to send the metric from web performance
(Blink) to the page load metrics (Browser). The browser then
reports the metric to UKM and UMA.

Bug: 869924
Change-Id: I44ac017cd06df6dc5bae264442f27900a027bbe7
Reviewed-on: https://chromium-review.googlesource.com/c/1301966
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603558}

I don't want to be CCed on everything.

Change-Id: I14d2af4906be4626827c7cbca7ee59fbe86a8420
Reviewed-on: https://chromium-review.googlesource.com/c/1305633
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603557}

Before this change, WebController::ElementExists always checked for both
existence and visibility.

With this change, WebController::ElementExists checks for existence, and
WebController::ElementVisible for visibility. Element existence is used
for preconditions, visibility is used for all other cases, such as when
waiting for dom or waiting for an element to act on.

This change also simplifies BatchElementChecker a bit by keeping element
existence, visibility and field checks completely separate.

Bug: 806868
Change-Id: Ibd232c317aff4ba4640e5c47a0a93a2b4637ec76
Reviewed-on: https://chromium-review.googlesource.com/c/1301783
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603556}

- win_chrome_official moved to luci.chrome.try
- chromium.chrome bots are moving to luci.chrome.ci

R=hinoka@chromium.org

Bug: 790153,790158,790159,790163,731383
Change-Id: Ida6dbf9cc2b7dd6d7dcd944e641863443e562946
Reviewed-on: https://chromium-review.googlesource.com/c/1302862Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603555}

Skia has revised the SkImageGenerator interface. SkYUVSizeInfo
has been expanded to support alpha and renamed to SkYUVASizeInfo.
In addition, the API adds the struct SkYUVAIndex to represent the
mapping from a YUVA channel to the texture index and RGBA channel
that represents it. This allows interleaved formats (e.g. NV12) to
be represented.

This CL updates Chromium to use the new interface.

Bug: skia:7903
Change-Id: I64a7056e535a114b4cfc0f86c93f5e6cd2c91bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1297254Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Jim Van Verth <jvanverth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603554}

ArcAppDataSearchProvider used to be created and called
unconditionally which is not optimal.

Play Store search is already protected by a (disabled by default)
feature. Adding a flag makes it easier to debug and test.

Bug: 818902
Test: manual, AboutFlagsHistogramTest
Change-Id: Ifb20d90de4e1f977b320fd4f14079570bff367bf
Reviewed-on: https://chromium-review.googlesource.com/c/1300293
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603553}

The "toolbar" component would be most accurately called the
"location_bar" component. However, we don't have any location bars in
Chrome that are not also an Omnibox.

Colloquially, most users and engineers refer to the whole location bar,
not just the textfield as the "Omnibox".

Moreover, the toolbar model provides data that feeds both into the
"Omnibox" text portion as well as the exterior "Location Bar".

A followup CL will likely rename ToolbarModel to OmniboxModel.

Bug: 898347
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7123286da779afe6485f7c324b7fb84a72889601
Reviewed-on: https://chromium-review.googlesource.com/c/1297632
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603552}

TBR=fmalita@chromium.org

This will guard https://skia-review.googlesource.com/c/skia/+/165766.

Change-Id: I6cf70a5d2e0eab1698c534bf8ccf8fdc6f81e19a
Reviewed-on: https://chromium-review.googlesource.com/c/1305153Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603551}

Create a new function in shell_util_win.mojom to replace the old
CallGetOpenFileName and CallGetSaveFileName functions that are no
longer implemented.

Make use of that function in chrome_select_file_dialog_factory

Bug: 73098,884075
Change-Id: Ia3176fe3aefe26ea08f518332454e5637796b410
Reviewed-on: https://chromium-review.googlesource.com/c/1241563
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603550}

With recent fixes of myself, this test now succeeds.

BUG=890071
TEST=none
R=sky@chromium.org

Change-Id: I73e8918771225d9855cbf6299d3c852476adf707
Reviewed-on: https://chromium-review.googlesource.com/c/1305194Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603549}

Matches what we do in SVGIntegerOptionalInteger::CalculateAnimatedValue,
and avoids undefined overflow.

Bug: 899445
Change-Id: I1250a05482713780f707301ed29e015fd81e65f2
Reviewed-on: https://chromium-review.googlesource.com/c/1304483Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#603548}

Make sure to retain a ref to the ContextProvider so that it gets
destroyed on the thread it is bound on.

BUG=898842

Change-Id: Iefcab772acb4cf530ff4a3e7c64e9b66e35b3f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1304068Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603547}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d2036a9f..ca9994a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibf5f71746c2f689b06c51cf23c1d61e378163879
Reviewed-on: https://chromium-review.googlesource.com/c/1304933Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603546}

This reverts commit 0a8ce562.

Reason for revert: crbug/899732

Original change's description:
> Reland "[vr] On-demand install VR dynamic feature module"
> 
> This is a reland of 0275d360 with a fix
> for x86 builders, which have VR disabled.
> 
> Original change's description:
> > [vr] On-demand install VR dynamic feature module
> >
> > With this CL we initate the module install once the user enters VR on a
> > WebXR/VR page. In more detail this CL
> >
> > - Introduces native VrModuleDelegate used to request VR module from
> >   native,
> >
> > - Refactors GvrDevice to request the VR module as part of its
> >   initialization flow,
> >
> > - Adds native side of the VrModuleProvider for Java-native
> >   communication.
> >
> > Bug: 862689
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1241458
> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Reviewed-by: Bill Orr <billorr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602922}
> 
> TBR=tedchoc@chromium.org,billorr@chromium.org
> 
> Bug: 862689
> Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/c/1301568
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603100}

TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862689, 899732
Change-Id: I89de56edc6c300955534a701deb92178cf50683e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1305093Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603545}

This is a reland of 01ccf727

Original change's description:
> Enable the pixel by pixel comparison test for Mac OS.
> 
> 1. Tested on Mac and verify everything works as expected.
> 2. Removed the unnecessary call of GetNativeWindow().
> 
> Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c
> Reviewed-on: https://chromium-review.googlesource.com/c/1279301
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601879}

Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a
Reviewed-on: https://chromium-review.googlesource.com/c/1296811Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603544}