- 27 Aug, 2020 40 commits
-
-
Alice Wang authored
This CL handles the account picker bottom sheet backpress - When account list is expanded, backpress leads to collapsed account list; - In other cases, backpress dismisses the bottom sheet. Bug: 1113653 Change-Id: I4d380cf7ae27b3da03a828960224efde72857f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374650Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802339}
-
Joshua Pawlicki authored
It was accidentally added the default archive in https://chromium-review.googlesource.com/c/chromium/src/+/2374513 Bug: 1058102, 1122538 Fixed: 1122538 Change-Id: I18ba7213aa72800a234a29576c5163820890c2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380133 Commit-Queue: Michael Moss <mmoss@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#802338}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.8-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5f00d9f761a3f18cb997d3c0834bda3d9261c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802337}
-
Xianzhu Wang authored
Previously composited scrollbars were always placed above all descnedants if they were not reordered, causing the scrollbars to cover non-scrolling stacked descendants. Now place non-overlay scrollbar layers at the bottom of the child layers, which is the same as how we paint non-composited scrollbars in the background paint phase. Bug: 984167 Change-Id: I1cd9b0bcd1559ad0811bc83af8959b33b3739b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370716Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802336}
-
Ana Salazar authored
Holding space keyed service now observes downloads. As new downloads are completed, they are added to the holding space model. Bug: 1111995 Change-Id: Id45b276a3ada06d94f7efd42bc35cf89cc3fe070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378648 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802335}
-
Robbie McElrath authored
This CL replaces the PreferenceFragmentCompat and PreferenceDialogFragmentCompat classes in the AndroidX preference library with the version from master, which has a change needed for WebLayer. The preference library maintainers say they won't create a new release just for this fix, so to get it we'll have to pull it in ourselves. Bug: 1092986 Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802334}
-
Jérôme Lebel authored
FirstRunTestCase.testTermsAndConditions doesn't close correctly FRE at the end of the test. This patch adds the right taps to close correctly the FRE at the end of FirstRunTestCase.testTermsAndConditions. Fixed: 1122680 Change-Id: I5ef93c30df91941c63eae7a5dcefc5e52d228a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379837 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802333}
-
Andrew Comminos authored
Adds basic tests for continuous and discrete pointer events being detected by isInputPending with same-origin and cross-origin frames. Note that these do not currently work with content_shell (see crbug.com/893480). Bug: 910421 Change-Id: I93a0b2f7c47d7444069b157dcc55f9f04856eba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236693Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#802332}
-
rbpotter authored
From https://chromium-review.googlesouce.com/c/chromium/src/+/2368821 by dpapad@ Adding these hooks will be used to run tests with the PDFViewerUpdate flag on or off in future CLs. Bug: 1120279 Change-Id: I2e85e156e71f4e95db8754e13ca9c0bb944a81e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380260 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802331}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.8-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56a5c61478d3b6188f1743ae39c6386df4811ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380046Reviewed-by:
-
Alfonso Garza authored
Note that the icon disappearing while editing and a non-empty text is working as inteded from TableViewTextEditItem logic. https://drive.google.com/file/d/1DOpGNuQI2dTOmniSvUHvcYYpmtdOfESJ Bug: crbug.com/1121563 Change-Id: I5c659da440d1bb655a47cc6895318a7688def407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377417Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#802329}
-
Alex Gough authored
Change-Id: I235813405df5f0b8ea0f1bee97b826977ce11215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379416 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802328}
-
Michael Thiessen authored
native_java_unittests are going away, so these tests need to be migrated to javatests. Bug: 1103344 Change-Id: I1a987b6fbacd2464a9a3113282accdde1eb2e500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364699 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#802327}
-
Sammie Quon authored
First CL to allow chaining keyboard shortcuts. This CL adds chaining of keyboard shortcuts behind a feature flag. 1. With flag disabled, desk animations work as they do today 2. When jumping back and forth between the original start and end desk, animation works as expected. 3. When the animation involves a third or forth desk that was not the original start or end desk, the animation is funky (as expected as that part is not changed in this CL), but at animation end the correct target desk is set. Modifies RootWindowDeskSwitchAnimator to support storing screenshot layers and replacing animations. More will be added in the future to make 3. work. For example, while we take a new screenshot when a new desk is targeted, we do not yet stitch it onto the animation layer, nor do we try to realign the animation layer. Unit tests to be done in a follow up. Test: manual Bug: 1111445 Change-Id: I84f7e7559dfe1f19f1aded4754b1bea5a76820db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354798 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802326}
-
Thomas Anderson authored
This reverts commit c332bdd0. Reason for revert: needed to fix linux-lacros-rel Original change's description: > Roll sysroots > > This is needed after [1] changed the libwayland-client symbols file. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674 > > R=msisov > > Change-Id: Iffada22847663b5a9ca3973d45f7a0a2c93fedd5 > Bug: 1116384 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380370 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#802266} TBR=thomasanderson@chromium.org,msisov@igalia.com Change-Id: Icd1f62117bab878a63af1e1fdb5670444394db0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380432Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802325}
-
Tim Song authored
BUG=1115697 Change-Id: If6de4e180b482f58244125a7344f0c506d088219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351949Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#802324}
-
Haiyang Pan authored
This reverts commit 4d9450df. Reason for revert: Likely caused the test PartitionAllocTest.DumpMemoryStats failing consistently in android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1084 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1992 Original change's description: > [PartitionAlloc] Use reciprocal multiplication to speed up GetSlotOffset > > Currently, the "get offset of a pointer within its allocated slot" > functionality, which is used extensively by several MiraclePtr > implementations, performs an expensive modulo operation. This commit > replaces it with a cheaper sequence of multiplications and bit shifts. > > Bug: 1092288 > Change-Id: I866689a79fff704b5f83fc07d8f28b3386ef644d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335443 > Commit-Queue: Sergei Glazunov <glazunov@google.com> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802194} TBR=haraken@chromium.org,lizeb@chromium.org,bartekn@chromium.org,glazunov@google.com Change-Id: Iaed8d78231201dd69a880e8a30028ddd64bead94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380107Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#802323}
-
Fredrik Söderqvist authored
Reduces the estimated size from ~9.28M to ~2.14M. Bug: 242216 Change-Id: Ibfa4ba9f9ecd57e97a0efffb553d153402abed84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379756 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#802322}
-
Andrew Grieve authored
This reverts commit 69a6e031. Reason for revert: Producing bad dex (crbug.com/1122436) Original change's description: > Android: Enable vertical class merging in R8 > > Bug: 1040534 > Change-Id: Ic9873612462612e510b91d713c24c046e017cafb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368510 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801359} TBR=agrieve@chromium.org,smaier@chromium.org Bug: 1040534, 1122436 Change-Id: Ib4e204210ddcb0c41cb5ba9cdedca69036064fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380081Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11944f7122cf..8e6246dafe61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I59cb325cb42f920331435941152f097c62cf2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380190Reviewed-by:
-
Scott Little authored
This reverts commit f1d35ca2. Reason for revert: Looks like this broke the linux-lacros-rel bot: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel?limit=200 Original change's description: > linux sysroot: fix libwayland-client-symbols file. > > I initially generated it by myself and made a huge mistake by > setting base version to a single version. However, some symbols > only appeared after certain version. Thus, fix that problem by > copying and using the symbols file from wayland packages > in https://git.launchpad.net/ubuntu/+source/wayland. > > Bug: 1116384 > Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674 > Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802226} TBR=thomasanderson@chromium.org,msisov@igalia.com Change-Id: Ia285ce4239ba8e9841476fd5dc890252a713f8fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380105Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802319}
-
Liquan (Max) Gu authored
Reason for revert: The tests were disabled on Marshmallow because they were caused by crbug.com/1094008. Now that the root issue has been fixed, I am reenabling the tests. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2376465 Bug: 1102320 Change-Id: I687d099b28815518348650a3a24cb19e3b511acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380091Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802318}
-
Austin Eng authored
Currently, this callback is processed entirely on the client, so it doesn't require a flush. It will be updated to be server-side for consistent callback ordering. In order to ensure the server receives the callback in finite time, we force a flush after the command is sent. Bug: dawn:516 Change-Id: Ibfa64b142331663e818c1142021ec2db1eeb9f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380026Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#802317}
-
Livvie Lin authored
Remove testing config and update tests to check for new default behavior. Launch bug: crbug.com/997972 Change-Id: I25672fa149cd73ee32ada35b6a374d0bcac47db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367742 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802316}
-
Kyle Horimoto authored
This class provides an interface for the Phone Hub UI to ring the connected phone as part of the FindMyDevice feature; additionally, it provides an API for checking whether the phone is currently ringing. The implementation of setting/retrieving the phone ringing state will be part of a future CL. Bug: 1106937 Change-Id: Ia100f320bd782e307fdae85581ef45b43bcc1c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378728 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802315}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c589cca4eff..1fd76f85b10e 2020-08-27 vidorteg@microsoft.com Reland "Localization: creating and integrating i18n module" 2020-08-27 tvanderlippe@chromium.org Fix harmless problems reported by VS Code 2020-08-27 tvanderlippe@chromium.org Typecheck console_counters/WarningErrorCounter.js with TypeScript 2020-08-27 tvanderlippe@chromium.org [globals] self.UI.inspectorView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie85149656035976ca3f3b3f1eb4f1266b6480391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380350Reviewed-by:
-
Scott Little authored
TBR=miu@chromium.org Bug: 1122654 Change-Id: I69baee39a766f1fe0395d3a817d0d5c908b8b3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380078Reviewed-by:
-
Xiaoling Bao authored
Change-Id: Id9957cbc9d5bf4a459e86627bc224c3ea53a6fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380079Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802312}
-
Lei Zhang authored
Also move appended entries to where they belong. Change-Id: I81bb398a4da90471ed778621b5f3b5b6b46e581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380258Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802311}
-
Kyle Horimoto authored
This class tracks whether DND (Do Not Disturb) is enabled on the phone and notifies observers when the DND state has changed. It also provides an API so that clients (i.e., the Phone Hub UI) can request a change in the DND state. The implementation of setting/retrieving the DND state will be part of a future CL. Bug: 1106937 Change-Id: I80b2fa881ed2959ea5d17a7331cee46275fbe74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378853Reviewed-by:
-
Eric Lawrence authored
Previously, the HTTP_AUTH_CONTROLLER entries in the NetLog did not mention if an AuthHandler was not initialized because the specified scheme was disabled or did not exist. This CL adds a scheme attribute to the NetLog when creating or failing to create an AuthHandler. Bug: 1121644 Change-Id: I3571a31b0655232f22140f0eb4e7a778468f5363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376207 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#802309}
-
chrome://resources/dpapad authored
Moving some tests such that there is a matching folder structure under ui/webui/resources/ and chrome/test/data/webui/. Bug: 1119707 Change-Id: Ia366f5597bde40ae0eace30e467272f8e3699dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379097 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802308}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I7046001140264bdfc89480c8ca3cb965f00cc732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380334Reviewed-by:
-
Alan Screen authored
Noticed during mojoification preparation for PrintBackend that the max value for a printing::ColorModel was reflective of an old value that didn't get automatically adjusted for new additions. Update to use the value attached to the last color model, to always be up-to-date. Bug: 809738 Change-Id: I288ce3a6ab89c3e7ba7eeebb17e78df42f8870dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355589Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Noah Rose Ledesma authored
This change adds IPC message declarations, senders, and receivers for communicating between the renderer and browser that audio device changing is no longer possible. When the audio output device cannot be changed, the Global Media Controls UI should not display a device picker. This change is a part of a series of changes for appropriately hiding this UI. Bug: 1120620 Change-Id: Ib5610fa95d56f284e1957c59bd4f098112c1a81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368285 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#802305}
-
Becca Hughes authored
Add two css variables for the color and text size of module content. BUG=1121360 Change-Id: Ie1bcbad8c05895d1cc546811b471df1fc6c5324e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380023Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#802304}
-
Shik Chen authored
Bug: 1122444, b/166523553 Test: Revert https://crrev.com/c/2377019 and check the bug is caught. Change-Id: I152a05bbd3e078e7d5ed6cfe6e91a28927e93482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379433 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802303}
-
Noah Rose Ledesma authored
This change has the WebMediaPlayer register a callback with the WebAudioSourceProviderImpl to be called when it is no longer possible to change audio output devices. When the audio output device cannot be changed, the Global Media Controls UI should not display a device picker. This change is a part of a series of changes for appropriately hiding this UI. Bug: 1120620 Change-Id: I9b65a78e57bc08358b5cfc0ff46733ca545df825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369439 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802302}
-
Xing Liu authored
This CL removes the metric "Download.PageTransition". The enum in enums.xml is also deprecated since all metrics using it are deprecated. Bug: 1088734 Change-Id: Ic80130f2e15dad45b797700b43aec0c29714eefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363667Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Enable the test for the specific unit test instead. Based on the feedback in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0. TBR=mgiuca@chromium.org Bug: 1121839 Change-Id: Id658ae6aa645b7a6a89306997acb10b1fefee46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376067 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
