- 19 Jun, 2018 40 commits
-
-
Steven Holte authored
Bug: 854206 TBR=rdevlin.cronin NOTRY=true Change-Id: I7788b389478f47bbd37e8336ae1379c6dbad88df Reviewed-on: https://chromium-review.googlesource.com/1106776Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568589}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c765d2ac8676..e005dc33c31a git log c765d2ac8676..e005dc33c31a --date=short --no-merges --format='%ad %ae %s' 2018-06-19 tsepez@chromium.org Move fxcrt::{Byte,Wide}Strings with std::move(). 2018-06-19 tsepez@chromium.org Speculative fix for segv destroying CPDF_PageObjectHolder::m_GraphicsMap Created with: gclient setdep -r src/third_party/pdfium@e005dc33c31a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852273 TBR=dsinclair@chromium.org Change-Id: Ibc6333c972cc6e3ad4048c6fbd36ef975df32b36 Reviewed-on: https://chromium-review.googlesource.com/1106560Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568588}
-
Tatiana Gornak authored
Mirrors the InvalidationClientCore from cahceinvalidation library. This CL is one of the spilt-CL for https://chromium-review.googlesource.com/c/chromium/src/+/1090722 Bug: 801985 Change-Id: Ibea970772b4292116fcc4ae4947ce9f3dca9427a Reviewed-on: https://chromium-review.googlesource.com/1100471 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568587}
-
Gabriel Charette authored
This count only matters when reaching MessageLoop::DoIdleWork() at which point the TriageQueue is empty by definition (and tasks in the DeferredQueue do not matter). This CL is therefore a no-op behavior wise. In an upcoming change, the thread-safe |incoming_queue_| will move to MessageLoopTaskRunner and dropping unecessary hi-res counts now will make this transition simpler. This also allows disconnecting DelayedQueue and DeferredQueue from their outer class. R=danakj@chromium.org, kylechar@chromium.org Bug: 708584, 854237 Change-Id: Icf36f1e425a8320fb14a4c561c529a9ea2389e0f Reviewed-on: https://chromium-review.googlesource.com/1103120 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568586}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4ce4cb826374..0ff6498e4181 git log 4ce4cb826374..0ff6498e4181 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 lalitm@google.com trace_processor: don't add swapper slices to trace storage Created with: gclient setdep -r src/third_party/perfetto@0ff6498e4181 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:110195632 TBR=perfetto-bugs@google.com Change-Id: I375d0c8228bd7f45ea1884c6fb305f292aa69ac1 Reviewed-on: https://chromium-review.googlesource.com/1106558 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568585}
-
Eric Stevenson authored
Was caused by the task finding the total size of the downloads directory taking too long on some devices. To avoid this, we update the ui after each task finishes so that there are no dependencies between tasks. This means that if one of the tasks takes a long time, the user could see an incorrect value (0.0 KB), but we don't hit an ANR. Bug: 828033 Change-Id: I57ab7df3c058373424a0ed2525ee80695e1cf6cf Reviewed-on: https://chromium-review.googlesource.com/1091532Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568584}
-
Xianzhu Wang authored
For SPv175, LocationInBacking is just PaintOffset, so remove LocationInBacking() and let callers use PaintOffset instead. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id776902e6b378b5414330df06f1fec6898d0cf96 Reviewed-on: https://chromium-review.googlesource.com/1081469 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568583}
-
Mark Pilgrim authored
TBR=sky@chromium.org Bug: 714018 Change-Id: Iae2eaaf9c313d25f0f434265148126ba5098a623 Reviewed-on: https://chromium-review.googlesource.com/1104390 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568582}
-
Luna Lu authored
Bug: 804645 Change-Id: I9e433bcbdd2ca63ac38777469da093f035f44fca Reviewed-on: https://chromium-review.googlesource.com/1102351Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#568581}
-
mark a. foltz authored
This CL changes the presentation URL for Media Router integration tests to https:, so we can implement proper scheme handling in Blink in a future patch. This is patch #3 in a five-patch change: Patch #1 (google3): Deprecate test: in mr.TestProvider Patch #2 (Chromium): Roll DEPS in Chromium Patch #3 (Chromium): This patch Patch #4 (google3): Remove test: from mr.TestProvider Patch #5 (Chromium): Roll DEPS again Bug: 825927 Change-Id: I8574be618a8005c52567750c62b1945ee9d413f7 Reviewed-on: https://chromium-review.googlesource.com/1106555Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568580}
-
Matthew Jones authored
Since the scrim is now created programmatically, it takes a bit of extra time after chrome starts to be able to get access to it. In the case of the location bar, its design allows users to focus it prior to the rest of chrome being loaded. Because of this, it is possible to get the omnibox focused without the scrim, locking up the page under it. This change explicitly sets the scrim when it becomes available in ChromeActivity and then calls the scrim update method in case it is needed. Bug: 850848 Change-Id: Ia0a25a0c6e8f9c2d64c914ebca5bbcf9e14601ad Reviewed-on: https://chromium-review.googlesource.com/1101963 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568579}
-
Kevin Bailey authored
We used to highlight the tab switch button when focused. The spec now asks for a focus ring instead of highlighting. This change allows the background to return to following the mouse state. Bug: 780835 Change-Id: Ie2a3c4b7bbe4c357855f19956f880c5cef01da21 Reviewed-on: https://chromium-review.googlesource.com/1106282Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568578}
-
John Budorick authored
Bug: 854114 Change-Id: Ic42770080e733e976c213c52cbcb47b226a54998 Reviewed-on: https://chromium-review.googlesource.com/1106708Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568577}
-
glevin authored
Enables Harmony dialog styling by default on Chrome OS dialogs. Also see launch bug crbug.com/839559. Bug: 783540 Test: Summon any dialog (blockers of 783540) that has been Harmonized. Verify that it has the Harmonious styling. Change-Id: I2c9340d33d0d404edec2b110fe4dd9d6727bc645 Reviewed-on: https://chromium-review.googlesource.com/1072727Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568576}
-
James Darpinian authored
This reverts commit 5a49da30. 2nd try due to http://crbug.com/853194 1st try was here: https://chromium-review.googlesource.com/c/chromium/src/+/1093580 Destroying a transfer buffer now requires only an ordering barrier, not a full flush. This removes a source of unnecessary flushes and makes resizing the transfer buffer more efficient. Bug: 850271, 835353, 828363, 853194 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibc5e72fcf4538a3f10022a613e9d0f15e4e7a95a Reviewed-on: https://chromium-review.googlesource.com/1105466Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#568575}
-
Francois Doray authored
Previously, "zero" was used as the last active time for tabs open in the background, which made them immediately eligible for proactive freeze and discard. With this CL, their creation time is used as the last active time, which will prevent them from being proactively frozen or discarded for at least 10 minutes after creation (note: except when the number of tabs is considered excessive, see tab_manager_features.cc). Bug: 854272 Change-Id: I5398b24fadbd073bd224e2a9e98c8ae610b26e92 Reviewed-on: https://chromium-review.googlesource.com/1106612Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#568574}
-
Thomas Tangl authored
Change-Id: I3df8e8dce2c62f623db78e7278390802f363aa5d Reviewed-on: https://chromium-review.googlesource.com/1106381Reviewed-by:
-
Krzysztof Olczyk authored
The content::ScopedWebCallbacks class is a helper for blink::WebCallbacks and does not do anything strictly related to //content. Moving it to //third_party/blink/public/platform makes it possible to use it in all blink platform consumer, also the ones outside of //content, such as //media/blink. One example is //media/blink/webmediacapabilitiesclient_impl.cc which before had to use specialized local copy of it. This also adds two modifications to ScopedWebCallbacks: * Make make_scoped_web_callbacks take a unique_ptr to WebCallbacks, instead of raw pointer that gets silently WrapUnique'ed inside, to make ownership passing more explicit, * Modernize it to operate on OnceCallback, instead of Callback, * Use default move constructor and move assignment. Bug: 847211 Change-Id: I3d9b8a660dbfd66cf8721331777f36ea42c04bc8 Reviewed-on: https://chromium-review.googlesource.com/1104356 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568572}
-
Yafei Duan authored
This doesn't decode the JSON, just grabs it from the appropriate endpoint. The CL was originally uploaded by dewittj@. This CL is fixing the test failure and re-uploading to land since dewittj@ is out of office. Bug: 852075 Change-Id: Ib8adc7cad661665c884a2d058c27c99f40ac0a58 Reviewed-on: https://chromium-review.googlesource.com/1105018 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568571}
-
Robbie McElrath authored
RegisterIOHandler calls CreateIoCompletionPort and will currently fail silently. This adds a return code and propagates it up. Bug: 845612 Change-Id: Ie0685cb7fb6d21a5e23489337158ee0ba0b75154 Reviewed-on: https://chromium-review.googlesource.com/1101644 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568570}
-
Paul Miller authored
Chrome turns on the studies specified in fieldtrial_testing_config.json for testing purposes. It doesn't respect the difference between android and android_webview platforms, so WebView gets all of Android Chrome's studies enabled, including UseSurfaceLayerForVideo which breaks WebView. As a workaround, disable the test config. BUG=853832 Change-Id: Ib8453ac163c7ce71419d25fc5433d3b31b89e894 Reviewed-on: https://chromium-review.googlesource.com/1105608Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568569}
-
Kyle Horimoto authored
Initialization of the service is asynchronous due to the need to fetch the Bluetooth adapter asynchronously. This class allows clients to make requests of the service before it is fully initializes; queued requests are then passed on to the rest of the service once initialization completes. Bug: 824568, 752273 Change-Id: I79b5940070b7c3ff6e0a9ed3f7ef4dff8f260038 Reviewed-on: https://chromium-review.googlesource.com/1105616Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568568}
-
jonross authored
Currently all viz and surface sync tests on the Mojo Android FYI bot are hitting shard timeouts. This updates the tests to use filter lists, to remove tests that were causing the shards to timeout. This also remove viz_content_unittests as I'm currently seeing infra failures from it. It will require local debugging. TEST=surface_sync_content_browsertest, viz_content_browsertests Bug: 849746 Change-Id: I237aab39e1c4a016584940fa0362a39db4be3434 Reviewed-on: https://chromium-review.googlesource.com/1102699Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568567}
-
Nate Fischer authored
No change to logic. This creates an AndroidManifest.xml file with only a minSdkVersion, which we use to configure lint to correctly verify the boundary interfaces compile down to the support library's minSdkVersion. This code will continue to only be called on >= 21 (Lollipop). R=torne@chromium.org Bug: 828184 Test: code compiles and passes lint Test: code doesn't compile with @TargetApi annotations in BoundaryInterfaceReflectionUtil Change-Id: I270f0f5732c1134ba77b912ece31cf188ee6cb5f Reviewed-on: https://chromium-review.googlesource.com/1105697Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568566}
-
Nate Fischer authored
No change to production logic. This adds a test for shouldInterceptRequest with server-side redirects because this was previously untested. R=boliu@chromium.org Bug: 768631 Test: run_webview_instrumentation_test_apk -f AwContentsClientShouldInterceptRequestTest#testNotCalledForHttpRedirect Change-Id: I3eccada1e249269a4f66395a8d10a107001e1231 Reviewed-on: https://chromium-review.googlesource.com/1105630Reviewed-by:
-
David Valleau authored
Change-Id: Ie400a16a7d6c91850245dfe1ada290d03697a7cd Reviewed-on: https://chromium-review.googlesource.com/1106640Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#568564}
-
Bailey Forrest authored
Bug: None Test: Doesn't show up in git status Change-Id: Ia74bba8d5c1c4df6b626784abe65d275eff8ec79 Reviewed-on: https://chromium-review.googlesource.com/1106699Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#568563}
-
Stuart Langley authored
Steps I followed: autoninja -C out/Default chrome tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json cd out/Default /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-emplace-back \ -header-filter=chrome/browser/chromeos/extensions/file_manager/* \ -fix chrome/browser/chromeos/extensions/file_manager git cl format No logic changes, No new tests. Bug: 841659 Change-Id: Ie194e7cc68289e6ec8d04e699ba7bdaeed5c5c07 Reviewed-on: https://chromium-review.googlesource.com/1106580Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#568562}
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I63150a67d17d898ef00f3d32270c8b8119306814 Reviewed-on: https://chromium-review.googlesource.com/1106418 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568561}
-
Quan Nguyen authored
Bug: 836861 Change-Id: Ib480dfa25b45a1cc6dd1424e8f84d0891eec1a0e Reviewed-on: https://chromium-review.googlesource.com/1092095 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#568560}
-
dpapad authored
Specifically fixing: MaterialHistoryItemTest.All MaterialHistoryMetricsTest.All MaterialHistoryRoutingTest.All MaterialHistorySupervisedUserTest.All MaterialHistorySyncedTabsTest.All MaterialHistoryToolbarTest.All Polymer.dom(element).querySelector no longer returns an Array. Instead it returns an NodeList, and therefore there is no advantage of using it, compared to using the native querySelector. MaterialHistoryRoutingWithQueryParamTest.All will be addressed in separate CL. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic46c25c87b7d9fcbd06ef21de4c07090e4014ba6 Reviewed-on: https://chromium-review.googlesource.com/1105488Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568559}
-
Yiming Zhou authored
These tests are the first step in building a test framework for testing chrome autofill on complex, real-world sites pages. Since interacting with live sites are flaky and vulnerable to updates to the sites' features, this framework interacts with captured sites. Sites are captured with the Web Page Replay (WPR) tool. Prior to running the test, the browser test will start WPR locally on the machine using a capture file. The test then navigates to the test site, interact with the site's checkout workflow, and verifies that autofill correctly completes the address and payment information. Tests for 5 sites are included in this code change: Amazon, Zappos, Apple, Ebay and Walmart. This change fixes the build breaks caused by the earlier change, 963800, and it also changes the tests from being driven by test code to being driven by test recipe files. The test recipe files will be generated by a chrome automation extension recording user actions. Bug: 847905 Change-Id: Ib255d52d8870744ff8304a3b908d54d039218dbb Reviewed-on: https://chromium-review.googlesource.com/1091473 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568558}
-
Katie D authored
This is phase 3 of a refactor that allows Select-to-Speak to work with Sticky Keys, see go/sts-with-sticky-keys for more on the background for this change. Not only are EventHandlers ordered by priority across all EventTargets, but also the later an EventHandler was added to its EventTarget, the earlier it will appear in the resulting list of EventHandlers. This is a change for kDefault handlers, but kAccessibility and kSystem already had this behavior. This is for consistency across all types and requires a large change to event_dispatcher_unittest. Also adds an additional debugging function to TestEventHandler to get that handler's name. This was useful in writing the unittests for this change and may be useful to others as well. Bug: 819860 Change-Id: I4c5002fdc2cd26f0df5e94600183c3cc0cc2ff56 Reviewed-on: https://chromium-review.googlesource.com/996456Reviewed-by:
-
Lindsay Pasricha authored
This will allow for waterfall coverage with uirefresh off. Bug: 853015 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9be170bdfbb66f678bd0bd040c1d53d0cfbf9ba Reviewed-on: https://chromium-review.googlesource.com/1105059Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#568556}
-
Mikel Astiz authored
Intrusive patch that migrates session sync on Android to identify tabs by a new ID type: Android tab IDs. No direct user-facing changes expected except a) improved robustness due to reduced data redundancy, and b) a one-off loss of placeholder tabs (because no migration path is implemented) in "Tabs from other devices". Design doc (Google employees only): https://docs.google.com/document/d/1gMtPXTmvKnhJQpzSLYNoqBajWtOGYAoBNQ74XmmFe7I The proposed change is feasible after, recently with crbug.com/823798, session IDs increase monotonically (i.e. are not reused across restarts) on all platforms. This means SyncedTabDelegate can now trivially guarantee that there will be no collisions (even across browser restarts) across tab IDs (exposed by SyncedTabDelegate::GetSessionId()), as documented in this patch. On Android, there's yet another concept of tab IDs which adheres to that property and in addition get restored. By migrating to these IDs altogether (i.e. only expose Android tab IDs to sync), there's no need to support sync IDs at all, because the whole purpose of sync IDs is to be able to associate open placeholder tabs (without web contents loaded). Hence, let's simplify the code and avoid all issues related to data redundancy. Bug: 851905,843554 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icda054906e654c18238b47e7788d4523790e09f3 Reviewed-on: https://chromium-review.googlesource.com/1096942 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568555}
-
Jan Krcal authored
Before this CL, there was a race condition in addressing DB errors in HistoryBackend. When HistoryBackend::DatabaseErrorCallback got called, it immediately notified TypedURLSyncBridge and posted a task to kill the database. Before the database gets really killed, some other tasks can run such as tasks from the expirer that result in the bridge being notified about history deletions. The bridge does not expect backend notifications after being notified about DB error (which makes sense). This CL resolves this bug and delays the notification to the bridge so that it happens synchronously with killing the DB. This is a merge candidate for M68 Beta. Bug: 853395 Change-Id: I03d1a5c49254184e430c1619049e66895bf6dcfe Reviewed-on: https://chromium-review.googlesource.com/1105821 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5ef6d834a15..f704817cbbab git log c5ef6d834a15..f704817cbbab --date=short --no-merges --format='%ad %ae %s' 2018-06-19 dtu@chromium.org [pinpoint] Increase functional significance thresholds. Created with: gclient setdep -r src/third_party/catapult@f704817cbbab The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9d5f3470880c9d034546537550d6f125a01c3ca2 Reviewed-on: https://chromium-review.googlesource.com/1106359Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568553}
-
Christian Fremerey authored
Currently, TestConnectorFactory does not release the Service when it requests to be quit. This CL adds this functionality in order to allow testing of service shutdown behavior using TestConnectorFactory via observing the destruction of the service implementation class instance. Concrete example for which this was added: https://chromium-review.googlesource.com/c/chromium/src/+/1089921 Bug: 829581 Change-Id: I662c531329810fdb3dd1af5603628a0cb0dbba38 Reviewed-on: https://chromium-review.googlesource.com/1097991 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568552}
-
Yafei Duan authored
If BrowserActionActivity is invoked without Chrome loaded, download notifications will not be shown since the notification bridge hasn't been created. Calling OCANBUiFactory to create an instance after native initialization is done will fix the issue. Bug: 852741 Change-Id: I1aa8b33a7d8e49e96e4cf892bc1e23ef6b535cdc Reviewed-on: https://chromium-review.googlesource.com/1102089Reviewed-by:
-
Stuart Langley authored
Steps I followed: autoninja -C out/Default chrome tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json cd out/Default /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-make-unique \ -header-filter=chrome/browser/chromeos/extensions/file_manager/* \ -fix chrome/browser/chromeos/extensions/file_manager git cl format No logic changes, No new tests. Bug: 841659 Change-Id: Ia04e2880847d34dcc11b071c53c610a7c9afb4fb Reviewed-on: https://chromium-review.googlesource.com/1106579Reviewed-by:
-
