- 29 Oct, 2019 40 commits
-
-
Tom Anderson authored
The Glib documentation [1] states that "It is a programmer error to give a key that isn't specified as having a string type in the schema for settings." Therefore, we must check if the settings schema has the key before actually getting any settings. If we do not do this, glib will terminate chrome with this error message: GLib-GIO-ERROR **: Settings schema 'org.cinnamon.muffin' does not contain a key named 'button-layout' Also increase the glib requirement to 2.40 since that's the minimum version that provides g_settings_schema_has_key. This version is available on all supported distros all the way back to Ubuntu Trusty. [1] https://developer.gnome.org/gio/stable/GSettings.html#g-settings-get-string BUG=1017974 R=thestig Change-Id: I46f95bd7a242e48e1d9dc910f6b1f3ed114e7d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880567 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#710152}
-
dpapad authored
This is in preparation of migrating to Polymer3. Bug: 1012533 Change-Id: Iab0d6d25a5c5df4ba5c19deccb98ad3ee968a982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881842 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710151}
-
Dominic Mazzoni authored
This is a new attempt at fixing bug 657157, previous attempts were reverted due to regressions. When setting accessibility focus to a node, auto-focus it if it's a link. This is needed for some sites that have skip links that are only visible when focused. In addition, when following a same-page link, move accessibility focus to the new target location on the page only after a short delay. This avoids a race condition due to focus also changing at the same time. Tested manually on three pages mentioned in bug 657157: 1. getbootstrap.com, which has a same-page link that's only visible when focused 2. http://jsfiddle.net/mev0c4dt/show/ - a test page for a regression that happened with a previous attempt to fix this bug 3. https://codepen.io/artesea/pen/jVdLXP - a test page for a regression that happened with a previous attempt to fix this bug Bug: 657157 Change-Id: I791544af3074f5aac5116c6695332d8178da21d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873964Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710150}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ibef33353dda58d8ffe31e4c252f6560e815d9a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884511Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#710149}
-
Will Harris authored
This is to allow time for third party vendors who currently inject into Chrome renderer processes to update their software. This will be re-enabled in a future release of Chrome. BUG=750886 Change-Id: I081a44a39ff499b86d02a637cb56ce4b6ff2c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885226Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710148}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1018887 Change-Id: Ifb7b963111c36b594c482314ca294e5f2fdf970a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884519 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710147}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/77b752951550..01a21f71f427 git log 77b752951550..01a21f71f427 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9109135d..7ce02641 (709913:710014) Created with: gclient setdep -r src/third_party/webrtc@01a21f71f427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I51584eb08372962899ab91db00f1abb092a931dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710146}
-
Brian Sheedy authored
Disables the XR browser tests on the RX 550 tester, as the tests randomly hang indefinitely on this hardware configuration. TBR=ynovikov@chromium.org Bug: 1018896 Change-Id: Ie874c7df846d5133cd91fcf03eb7592e4c2b1347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884278Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#710145}
-
Peter Wen authored
Rather than depending on system provided rt.jar, check one into cipd and use that one instead for hermetic builds. The one used is from openjdk-8-jdk. Add myself to OWNERS under //third_party/jdk and update README.chromium with instructions for updating the extras subdirectory. Bug: 693079 Change-Id: I65361bd11aa0edd60dceb102b45082848dac6244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884367 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710144}
-
shrekshao authored
Remove import from upload module. Upload doesn't seem to be actually used. Simply removing it will make the script work again. Bug: 1018475 Change-Id: Ib30850f1c7b4a0ad2cb1596b1051662651514be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885096 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710143}
-
Joel Hockey authored
Refactor ReturnEarlyIfAborted function to only call abort_callback_ if it is not already called since it is possible that OnVmShutdown could call it, and then another delayed callback could also call it. Bug: 1013059 Change-Id: I33108b158ccc60e405c5ecf09d4cec3d65b3edec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880242Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#710142}
-
Mitsuru Oshima authored
Apply layer blur on the layer that has wallpaper, but not the widget because the solid color is a part of widget's layer. Bug: 1015886 Test: covered by unittest. Also tested manually with blur change reverted. Change-Id: Iaf0f2faaa1e92285a3f8b45083027a7fccf0bc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885219Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710141}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=khushalsagar@chromium.org Bug: 1018887 Change-Id: I0ff68808f1b026c7f705926367281a2c152e8f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884517Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710140}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/054ab2be..a0b89dfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf7aaa1a6fe22b0703f5eb3b2ba833f0532f6bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885290Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710139}
-
siyua authored
messaging experiment code Bug: 961082 Change-Id: I45ea1a98d66921217045bda865bc833b48d35b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881714Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#710138}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Iec40ef6edd087f2ae5277b2e0996bddd92675570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884598Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710137}
-
Jan Wilken Dörrie authored
This change implements showing the soft keyboard if the Touch To Fill sheet gets explicitly dismissed by the user. This required making RenderWidget::ShowVirtualKeyboard() available from PasswordAutofillAgent, which is done by exposing a corresponding API on RenderFrame and implementing it in RenderFrameImpl. Bug: 1014043 Change-Id: I46d0c6a8c4abcde47c905797d2c7d39242dd8ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879928 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710136}
-
Matt Simmons authored
Bug: 1017977 Change-Id: I73b6f34d05f85a0ecce22b3d74e2ea8177533b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879763Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#710135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f71802b4404..6f23b4b7038e git log 2f71802b4404..6f23b4b7038e --date=short --no-merges --format='%ad %ae %s' 2019-10-28 mmynttinen@mozilla.com Fix MinGW include: s/VersionHelpers.h/versionhelpers.h/ 2019-10-28 jmadill@chromium.org Plumb more logic for ANGLE_get_image. Created with: gclient setdep -r src/third_party/angle@6f23b4b7038e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I0b9f56f367af32ecfc33c760647258f8e15570ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884527Reviewed-by:
-
Miyoung Shin authored
This CL converts KeySystemSupport{Ptr, Request} in content to the new Mojo type. Bug: 955171 Change-Id: I84b54952523842d408f13515eeae0649c73895e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882200Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#710133}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1018887 Change-Id: Idb34b1c7731f9494d8ebc6aa471bc26f16f72619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884995 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710132}
-
Miyoung Shin authored
This CL cleans up unused using aliases of MirrorServiceRemoter{Ptr, Request} and MirrorServiceRemotingSource{Ptr, Request} in cast_remoting_connector_unittest.cc since old Mojo types of them was already converted. Bug: 955171 Change-Id: I0f7fc2717418b9f752728435541d8f466593e625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882261Reviewed-by: -
Gauthier Ambard authored
The idea is to log when the user is opening a URL (from another app) which is already opened in the app. Having this metrics will allow us to know if it is impactful to handle this special case. Bug: 1014964 Change-Id: I94c7b7810eb66c81ec310057d1b4b991dad55ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869412Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#710130}
-
Karan Bhatia authored
Simply moves RequestParams to its own file. This is a pure refactoring change. BUG=974391 Change-Id: Id02ae3f33847617ea65ad2e5d757094015d22bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881494 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710129}
-
Miyoung Shin authored
This CL converts OutputProtection{Ptr, Request} in media and chrome to the new Mojo type. Bug: 955171 Change-Id: Ie7dfdb8fe46b2aec18a576eb6435122b662c1fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882263Reviewed-by: -
Ce Chen authored
1. Allows to enable on device head suggest in incognito w/o enabling it in non incognito first. 2. Removes request delay in incognito since there is no server suggestion which we need to cope with. Bug: 925072 Change-Id: I344ecc2c620cb95c3b5f7c929cac0d9287b3c05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881978Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#710127}
-
Livvie Lin authored
Matches the about_flags.cc implementation. Bug: 1008219 Change-Id: I3755cf4f7b968fc347acc0ae5ab6ef31c70223bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884755Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710126}
-
Ali Juma authored
WKWebView and iOS do not permit navigation to arbitrary files on a device's file system. Attempting to load such inaccessible files in WKWebView can later trigger broken behavior (see crbug.com/1010526 for more details). To prevent this brokenness, disallow these navigations right away, rather than waiting for WKWebView to disallow them. Bug: 1010526 Change-Id: Ieefb5befad659669a38efad127dfdb6e0179a165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881667 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
-
Qingsi Wang authored
disabled in WebRTC. This policy gates the effectiveness of chrome://flags/#enable-webrtc-hide-local-ips-with-mdns. Only when a URL is not whitelisted by the policy and the feature flag has the value 'Enabled', local IP addresses are concealed with mDNS hostnames in WebRTC ICE candidates. Bug: 1012945 Change-Id: I7782db6f1196921361c12738e00e471282e64058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857184Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710124}
-
Tricia Crichton authored
Several tests that require features not supported on Android were added to the ANDROID_NEGATIVE_FILTER. Fixed: chromedriver:3191 Change-Id: I3c30057df11a008b59100e4e1aae91a1f90d754d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884284Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#710123}
-
rbpotter authored
Also fixing some tests that fail due to the addition of the assert. cr.js is included by default in the extraLibraries of the PolymerTest base class, so test classes that do not override extraLibraries and import cr.m.js cause the webUIResponse/webUIListenerCallback to be set twice. Bug: 1004967 Change-Id: I7c31cc4df5119556f62e1afe7ebf1b85cb0c6722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885230Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710122}
-
Jarryd authored
The only place where this event was fired has been removed. https://crrev.com/c/1369551/ shows in site_entry.js that the event was removed, and a search of cs for the event turns up no results. Change-Id: Id1b198382cfbd004c7fbd6035e2ec7cbc656e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869017Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710121}
-
Julie Jeongeun Kim authored
This CL converts Producer for VideoCaptureServiceTest and MockProducer to new Mojo types using PendingReceiver and Receiver. Bug: 955171 Change-Id: Iccc4ad2e500c6a2dc55fa0467b851cb63efe2836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882264Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710120}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for DevicesChangedObserver from VirtualDeviceEnabledDeviceFactory. Bug: 955171 Change-Id: I3cac65b00124e0735a8656190fe9c2cbdd9c3e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882266Reviewed-by:
-
Nick Diego Yamane authored
XEvent raw events are currently being "leaked" to views' DWTHX11 so that they can be forwarded to ATK. This CL moves the platform specific part of that process into platform_window level, which consists of translating XEvent into AtkkeyEventStruct, and adds a callback into PlatformWindowDelegateLinux to handle ATK key events, thus making it more aligned with Ozone design and removing more platform specific code from views. Bug: 990756, 965991 Change-Id: I9a3ba12969dcd5582f79f118cc12879d55a56388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864783Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Chong Gu authored
Added checkout_aemu to gclient_gn_args. Check checkout_aemu when generating runner scripts, and only download AEMU if the value is true. Bug: b/142756812 Change-Id: Ic08b0abe945703ee5d6cddbc661831bbbdce784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879819 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710117}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in InterfaceFactory::CreateCdm and InterfaceFactory::CreateDefaultRenderer. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert mojo::StrongBindingSet to mojo::UniqueReceiverSet. Bug: 955171 Change-Id: I5f26b7efddf75ab48f6b6a5f02d84f91e027ba9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883447Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#710116}
-
Brian Sheedy authored
Disables several tests derived from ExtensionMessageBubbleTest due to flakiness that is preventing unrelated CLs from getting through the CQ. TBR=rdevlin.cronin@chromium.org Bug: 836332 Change-Id: Ide21a20e639f26e1d4a3d740cdb3e660b155e28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884581Reviewed-by:
-
Jamie Madill authored
conformance/ogles/GL/struct/struct_001_to_008.html conformance/ogles/GL/step/step_001_to_006.html conformance/ogles/GL/sqrt/sqrt_001_to_006.html Bug: 1017162 Change-Id: I1b633cb37a25539f238d2290ba7aa3a2f783416e Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884601Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL: - Stops passing the "share_target">"params">"url" JSON parameter from the Web Manifest to the WebAPK server - Stops using the "share_target">"params">"url" in determining whether the WebAPK needs to be updated BUG=993651 Change-Id: Iaca496e9acccaad8edb590d496cb40b559a3a9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759050 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#710113}
-
