- 30 Jul, 2019 40 commits
-
-
Caitlin Fischer authored
Bug: 988089 Change-Id: I69bcbcbf3bd18181db15304711f8b17ce8104eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721083Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#682360}
-
Wei Li authored
Add back the product icon as the bubble title icon. Also align the bubble's content area to the beginning of the title text instead of the the title area. BUG=979530 Change-Id: Iea4132d713dc43a13f4871ed85ae5ee09c66ecb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723303Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#682359}
-
Ahmed Fakhry authored
BUG=988530 TEST=Manually Change-Id: Ifbd2b8184490b14e146bb822791347de4b36a975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724121 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682358}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7b57c5bb770f..35ad5221fb55 git log 7b57c5bb770f..35ad5221fb55 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bryan.bernhart@intel.com Resource Management 3: Buddy allocator Created with: gclient setdep -r src/third_party/dawn@35ad5221fb55 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0cf420fdd9fe4cbe79c69e346f8593be1b0233fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682357}
-
Clark DuVall authored
This also merges UIThreadExtensionFunction and ExtensionFunction since there's no need for them to be separate anymore. This was made possible because WebRequest has moved to the UI thread, and it was the only API using IOThreadExtensionFunction. Follow up CL will remove references to UIThreadExtensionFunction. Bug: 980774 Change-Id: Ibe9a4433d1d564877b4277cf5e36734c46f53695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718990Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682356}
-
Ken MacKay authored
Bug: internal b/138645210 Change-Id: I9de9df6663290767bcb4657a9f8e7cd09346fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726629Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682355}
-
Kehuang Li authored
As crbug/946657 has been fixed, fulfill the TODO in the unittest. Bug: internal: 133880006 Test: Run unit tests. Change-Id: I7cbc5ac0ea18b19cf584c8842b1d3405fb663e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724930Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#682354}
-
Vaclav Brozek authored
This CL teaches CSVPassword to unescape CSV values. Bug: 934326 Change-Id: Id99e89b6e84f9b47216e6eac0f735fc4084a9cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698403Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682353}
-
Varun Khaneja authored
R=drubery, holte Bug: 975560 Change-Id: I2aaa33f95a249aaf14fadddf5672b2ce9d82ced6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721461 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#682352}
-
Sam Sebree authored
This change implements the EvaluationSteps Callback which is intended to be used by v8 during SyntheticModule::Evaluate. ValueWrapperSyntheticModuleScript::EvaluationSteps is responsible for setting the default export of the provided module to the value wrapped by the ValueWrapperSyntheticModuleScript Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=967018 Change-Id: I07b3be40832b9497169ed0a38a1fcc251e681f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725472Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682351}
-
Natalie Chouinard authored
There are no longer any non-support library Alert Dialogs in Preferences, so this theme can be removed from this activity (but is still necessary on other activities). The other preference-specific styles removed here were applicable only to framework preferences and are no longer used now that all preferences have been migrated to the support library. Bug: 967022 Change-Id: Id367c240486b8f4bf6b892f859cd1aba5d16da73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711146Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682350}
-
Steven Bennetts authored
This replaces networkingPrivate calls for everything except setProperties and forgetNetwork (neither of which have been migrated to mojo yet). Bug: 853953 Change-Id: I7f0ddbf180dad6a79a282b38a721e795ed0976d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717747 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682349}
-
Rohan Pavone authored
Moves logic of permission overrides to DevToolsPermissionOverrides class in PermissionControllerImpl, while automatically maintaining PermissionManager's override state by expanding the PermissionControllerDelegate interface. This removes the need for //chrome/browser's BrowserHandler::GrantPermissions, BrowserHandler::ResetPermissions, and other related logic, because all override state is maintained from one central point. Design doc: go/permission-controller-refactor Tested: Already existing unit tests. Bug: 986605 Change-Id: I0e44485bb569547b95538a047e5aad57b5372b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716018 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682348}
-
Koji Ishii authored
Ellipsis fragments have associated LayoutObject indicating the object it truncated. This is normally LayoutText or atomic inline, but sometimes it can be LayoutInline. This is very rare while it requiers special casing in several places. Running tests hit some DCHECK failures in paint and hit-testing. This patch stops generating such fragments, so that ellipsis fragments always have text or atomic inlines. DCHECK in NGLineTruncator is changed to check the condition accordingly. Bug: 988541 Change-Id: I4787091512cb8b330824952e97fa9481cf7905fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725629Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682347}
-
Justin Cohen authored
Given that these work on iOS13 iPhone simulators, it appears this is a beta 5 bug. Bug: 983776 TBR: rohitrao Change-Id: Ibee3f125301d878c1dc0ace32d122eb3eea682e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726429 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae9673f68e84..968d1d819bc0 git log ae9673f68e84..968d1d819bc0 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 fmayer@google.com Merge "Add proto for managed heap graphs." 2019-07-30 treehugger-gerrit@google.com Merge "ui: Fix long trace config generation" 2019-07-30 eseckler@google.com build: Attempt to fix chrometto roll 2019-07-30 eseckler@google.com Merge "Revert "Reland: build: Attempt to use system includes for gtest/mock in chromium"" 2019-07-29 treehugger-gerrit@google.com Merge "trace_processor: rename Table -> SqliteTable" 2019-07-29 kodiobika@google.com UI: Added timeline scrubbing to video components 2019-07-29 treehugger-gerrit@google.com Merge "Ignore Bazel build artifacts" 2019-07-29 treehugger-gerrit@google.com Merge "protozero: Fix moving a protozero decoder" 2019-07-29 rsavitski@google.com Merge "tmux script: tee to log files; add -s (skip converters) -l (tmux layout) options" 2019-07-29 taylori@google.com Merge "perfetto-ui: Track data request changes" 2019-07-29 treehugger-gerrit@google.com Merge "Fix a few typos" 2019-07-29 treehugger-gerrit@google.com Merge "trace_processor: add tracks table" 2019-07-29 fmayer@google.com Merge "Dump on StopDataSource rather than on Flush." 2019-07-29 skyostil@google.com Merge "client api: Add a way to trace directly to a file" 2019-07-29 fmayer@google.com Merge "Count invalid packets in TraceStats." Created with: gclient setdep -r src/third_party/perfetto@968d1d819bc0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:135278534 Change-Id: I26244ac71d40f4c52db7a36227dae9484a9f6f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726231Reviewed-by:
-
Will Cassella authored
The <span> element inside modern-media-controls-text-track-list-item was blocking the :hover selector, preventing highlighting. This CL fixes that by disabling pointer events on all children. Previously only <input> children had pointer events disabled. Bug: 959112 Change-Id: Icf7c34d71edd131735bf545456c8da2b48af8a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724803Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#682344}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/afb67c64981e..e73fe02a406e git log afb67c64981e..e73fe02a406e --date=short --no-merges --format='%ad %ae %s' 2019-07-30 perezju@chromium.org Reland "[Telemetry] Do not allow iterating over results while running stories" Created with: gclient setdep -r src/third_party/catapult@e73fe02a406e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:973837 Change-Id: I6fe408cf7b18b516a6f69dcdf7b8cccbc9d35069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726233Reviewed-by:
-
Jianfeng Wang authored
Evaluate the mapping between the count of in-flight requests to the peak queueing delay by computing a score for samples. The score is the percentage of samples that conform to the rule: the more in-flight requests, the higher peak queueing delay. The score is the metrics that evaluates whether the queueing delay prediction algorithm is effective. Change-Id: I1d6fdb9cccc9b52ff5b8d7849ae358d465dce73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717565Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Jianfeng Wang <jfwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682342}
-
Jeffrey Cohen authored
Bug: 966413 Change-Id: I29fe887806b07a51d7490603aaf81415a5a349cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721379 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682341}
-
David Black authored
User agent is now set via internal config, not InternalOptions. This CL cleans up the deprecated InternalOptions code path. During the transition, ARC was also accidentally omitted from the new user agent config so this CL restores that. Bug: b:138583234 Change-Id: Ifa4f94f9b3a5b76f4f737fa83ff70dc870d2e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725100Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#682340}
-
Emily Andrews authored
mojo::internal::ValidateStruct is not able to fold properly even though almost 90% of the disassembly of the defined template specializations is the same because the call to T::Validate is unique. This change slightly modifies the internals of mojo::internal::Validate* to call a new helper function which pulls out most of the similar functionality. While the helper function is also templated, because the compiled specializations are identical, the compiler is able to fold all the calls to the same function. This reduces the overall size of chrome.dll and chrome_child.dll by 24 KB each for a total of 48 KB in disk space savings. If there are other dlls that compile in mojo, these will experience similar benefits. Other approaches considered included: - creating an interface which defined helper functions within T:Validate. While this did allow all the functions to fold for 400 KB savings, this also opened us to a security risk because the *_Data objects are sent via IPC and could be coming from anywhere. - Including the ScopedDepthTracker call in the helper. This resulted in bugs since the ScopedDepthTracker takes advantage of deconstructors to keep track of how far down we've recursed through Validate function. - Generalize the header validation code generated in T:Validate. This resulted in a size increase. The reason is that we know the number of loops at compile time, so the compiler is able to take advantage of loop unrolling. Bug: 988151 Change-Id: I80e8d35005dc3ec1a8c09762bf14b0823af7c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723023Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682339}
-
Jun Mukai authored
AppsContainerView stops changing its state on closing, which causes to remain the suggestion chips on inconsistent state with its view. I believe it is still good to keep the suppressing the state change, but we need to reset the suggestion chip state on re-show. Bug: 988566 Test: manually Change-Id: Iddb2a4a69c17f601a66e80419ce58f28df4ca18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725236Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#682338}
-
Ahmed Fakhry authored
Previously this used to crash on a DCHECK. Now we should explicitly disallow this, since an active window (requested to be moved to another desk via shortcut for example) might be an always-on-top window, or a pip. BUG=988886 TEST=Added new test Change-Id: Iacb3562e8cb8bd789b9e3a88ac6b977242a79c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725549 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#682337}
-
Dominic Battre authored
The LogBuffer had some surprising behavior: // This would DCHECK; LogBuffer buf1; buf1 << "Foo" << Tag{"div"}; // This would create two nested divs instead of a sequence of two divs: LogBuffer buf2; buf1 << Tag{"div"} << CTag{} << Tag{"div"} << CTag{}; This CL fixes these problems by introducing fragments - the equivalent to the DOM DocumentFragment. The root of each LogBuffer is now a fragment that can host an arbitrary number of children of type text and element. Some optimizations occur: A LogBuffer with a single child in the fragment will return this child when LogBuffer::RetrieveResult() is called. Similarly, streaming a LogBuffer into another one will inline the children of the first into the second instead of appendin the fragment. Due to these optimizations, the JavaScript handler in the WebUI can be sure that only the outer most Node is a fragment. Bug: 928595 Change-Id: I0eed2f1e900a5aca9511c771d18ee1e264a503e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724674 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: -
Matt Jones authored
This patch introduces ViewLookupCachingFrameLayout with the intent of making frequent lookups for views much quicker. The new layout adds a method "fastFindViewById" that can be used in place of findViewById. Once the initial lookup has occurred, the view is stored in a map by its ID until it changes location in the hierarchy, removed, or a view with a matching ID is added or removed. This class will help accomplish what was typically done for ViewHolders in RecyclerView. Bug: 982075 Change-Id: I8f4b4f304649b62dcf15c6af748f9fda02b3f8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696172Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#682335}
-
Stephane Zermatten authored
This change adds an experimental action WaitForDocument for waiting for the main document or a document in a frame to reach a certain ready-state. This is similar to what happens implicitly in the click action, but gives us more control and better understanding of what's going on. This is experimental, because it's unknown whether and how much it'll improve the scripts. The action has been designed to allow extra control over its operation and report the start and end ready state, for monitoring and debugging. Bug: b/137176709 Change-Id: Ief95a5f7644e243625f698385010dfdc08b1aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713519 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#682334}
-
Natalie Chouinard authored
The usage of R.id.list here causes problems when updating support library version. Switch to the PreferenceFragmentCompat.getListView() method instead. Also add some clarification about when to use getShowShadowOnScrollListener in preference fragments, and document the lack of such listener on SearchEnginePreference with a TODO. Bug: 987748 Change-Id: Ieb76455e6744ec1ed0f300c8fe0914ed630e3562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725099Reviewed-by:
-
Orin Jaworski authored
This CL reworks the interop mechanism for obtaining version info from VersionHandler in about:version. Instead of relying on chrome.send to result in several asynchronous callbacks, the parts are requested using cr.sendWithPromise and handlers are explicitly called by JS. The original chrome.send mechanism is left intact for use by platform-specific derived classes. Bug: 964528 Change-Id: Ia68e95beb68b38201d29d5d51448ee989bdf333f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717483Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#682332}
-
Vadym Doroshenko authored
This CL is a part of username first flow implementation. The server sends prediction SINGLE_USERNAME for a field which is a single username in a form (i.e. the first part of sign-in process). This CL implements that in case of receiving SINGLE_USERNAME prediction FormParser chooses this field as a username field, and chooses no other fields as passwords. Bug: 959776 Change-Id: I2d62b488c041ace1d525f5627bab8c97aa9ccd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726030Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#682331}
-
Colin Blundell authored
This CL changes all methods that obtain the extended AccountInfo associated with an account with a refresh token to start with FindExtendedAccountInfoForAccountWithRefreshToken(). TBR=eugenebut@chromium.org Bug: 970295 Change-Id: Ie76e40d02e88af575686d530879e9119c1bafff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725634Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682330}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4c2c8d173f38..fa0175c0988d git log 4c2c8d173f38..fa0175c0988d --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bclayton@google.com Add missing #include <string> Created with: gclient setdep -r src/third_party/swiftshader@fa0175c0988d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie478c02d52c44aa8cd023ae2bcb2528bed202d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726292Reviewed-by:
-
Sean Harrison authored
Bug: 960513 Change-Id: I2c1782e5e2699ded65939e77b0ce3e90b11ef575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684448 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#682328}
-
Robert Flack authored
The timeline uses TimeTicks but animation timestamps use doubles, this can result in slight imprecision when performing calculations. This relaxes the currentTime assertions in the playback rate tests to allow for this. Bug: 986019,986666 Change-Id: Ie22b0884bd98a4617c3094100897609ab3154bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721289 Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682327}
-
Rahul Arakeri authored
The original CL was reverted because one of the content_browsertests (ScrollLatencyCompositedScrollbarBrowserTest.ScrollbarThumbDragLatency) got flaky. This failure was not caught because all TryJobs passed the dry run on retries (crbug.com/988443) Reason for the flakiness: This CL exposed a pre existing race condition. The issue only now came to light because this CL changes how thumb drag takes place. ScrollbarController::HandleMouseMove now calls ComputeScrollDelta for calculating the clamped delta. ComputeScrollDelta is where execution aborts due to the scroll_node being null. The reason the scroll_node is sometimes null here is because the mousemove reaches ComputeScrollDelta before GSB has had a chance to set up the scroll_node (due to queueing). See crbug.com/988308 for more details. Reverted CL is crrev.com/c/1684532 Reverted CL is in PS2. New CL is in PS6. [Description from the original CL]: Fixes an issue with thumb drags for compositor threaded scrollbar scrolling. When you click and drag the thumb past the track and then reverse your drag direction, the pointer no longer sticks to the thumb and instead, maintains a constant offset with the thumb as it moves. The reason this happens is because the scroll offset calculation in the ScrollbarController simply uses 2 factors to calculate the delta. One of them is the previous_pointer_position_ and the other is the current pointer location (i.e position_in_widget). There is no logic to check if the difference between these 2 factors should indeed generate a GSU or not. The fix is to make the thumb drag delta calculation relative to the layer and then use LayerTreeHostImpl::CanConsumeDelta to determine if a scroll should be initiated. Bug: 1684532 Change-Id: I4a12729ae77725f4a7aac0b02c4b7a3368d8e935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722157Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682326}
-
Owen Min authored
GetAllPolicyValuesAsArray is replaced with ArrayPolicyConversions. Enable policy value conversion. Use default settings that includes user policies, disable device data, enable pretty print and convert policy types to string. GetAllPolicyValuesAsDictionary is replaced with DictionaryPolicyConversions. All config is set to defaults. Pretty print, policy type conversion and user policies are enabled. Device data and policy value conversions are disabled. Bug: 983174 Change-Id: I75d8f59a2f268145d762dad6793d8966c0f80592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725031 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#682325}
-
Jacob DeWitt authored
For now, it will always be an empty array. Populating the array will come in a later CL. Bug: 979250 Change-Id: I7dabbec261f280d6937d57a9076033b3b7e09f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724277Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#682324}
-
Alison Maher authored
This change exposes the previously-deprecated CSS system color keywords on Windows that are used for high contrast style overrides. This will give users the ability to customize their sites with the relevant system colors for high contrast. Bug: 970285 Change-Id: I73f746d24f57b494a2f39e7a175715a98bdd4dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689961Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682323}
-
Varun Khaneja authored
They are required to keep track of whether the Safe Browsing database is being written to and read back from the disk correctly. R=mpearson Bug: 975127 Change-Id: I7464762a40caecd9c95b6be370c6ff9b0d8090a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721008 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682322}
-
Raymond Toy authored
If the buffer offset lies outside the boundaries of the AudioBuffer , silently do nothing instead of throwing an error. This is a change in behavior where we used to throw an error if the offset was greater than or equal to the size of the AudioBuffer. Spec issue: https://github.com/WebAudio/web-audio-api/issues/1884 Bug: 987295 Change-Id: I61955108af0fa3072a2c7174889827781c06747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717185Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#682321}
-
