- 28 Jul, 2020 40 commits
-
-
Keith Lee authored
The committed text length will be used by InputMethodChromeOS to determine the number of characters committed by users. Bug: 1109604 Change-Id: I476539fc38f35f3986a9a05de22f7b8fa9ecd0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318892 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792177}
-
Hitoshi Yoshida authored
This reverts commit 414b62b0. Reason for revert: Regresses a test on Mac. Bug: 1110239 Original change's description: > Set initial focus on session restore > > Issue: > - When On startup setting is set to "Continue where you left off", > the initial focus is not set after launching the browser. > - Users have to press Tab to focus the window. > - This affects users who rely on screen readers since the window > information is not announced on launch (on UIA mode). > > More context: > - The line calling SetInitialFocus was previously in the code but got > removed after a startup focus refactor: > https://chromium-review.googlesource.com/c/chromium/src/+/1313728 > - The refactor added the call to RestoreFocus on > BrowserView::OnWidgetActivationChanged if the property > restore_focus_on_activation_ is set to True. This property gets set > during BrowserView::Show, but only in the case of session restore, > Show gets called after OnWidgetActivationChanged so RestoreFocus is > never called. > - The inverted call stack on session restore is because AddRestoredTab > on browser_tabrestore calls Activate before showing the window. > > Fix: > - Similar to what we currently have for MacOS, only call Activate > in AddRestoredTab if it is not |from_session_restore|. This way Show > will be called before Activate and thus focus will be set as > expected. > - This change is only made on Windows due to a couple of reasons > 1) crbug.com/1102685 is only present on this platform. > 2) Making this change on Linux would re-introduce crbug.com/1019048. > > Bug: 1102685 > Change-Id: I6e62ebad7693eb5d908770364ba7c8d755ccaa70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284382 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Maria Villarreal <mavill@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791950} TBR=xiyuan@chromium.org,sky@chromium.org,fdoray@chromium.org,mavill@microsoft.com Change-Id: I258891124447cb71b163b35452b84b999857cf96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322266Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792176}
-
Alex Danilo authored
CL:1490354 removed a touch-mode flag. As part of that removal, a potentially useful comment was removed. Reinstate the removed comment. Bug: 934467 No-try: true Change-Id: If4ed10e4361d27d115137ad7e90d5c569bc183a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321911Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#792175}
-
Rainhard Findling authored
* This CL supersedes the previously failed attempts to land those tests (see crrev.com/c/2285386). * Test that each possible CCT status results in the corresponding safety check child status and display string. * Test that CCT being enterprise managed is handled correctly. Bug: 1087263 Change-Id: If13b4458c60b6a5a6c82f1e42e41ebec95d81da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292213 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792174}
-
GioVAX authored
Change-Id: I7e3bb2e1a8a9bc848f3663e8b8edc2c2860dee16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320609Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Giovanni Pezzino <giovax@google.com> Cr-Commit-Position: refs/heads/master@{#792173}
-
Jan Wilken Dörrie authored
This change simplifies wstring_embedded_nulls.mojom by removing the union and making it a simple struct wrapping an uint16 array. Bug: 911896 Change-Id: Idd4042f6a7bee8f066f6ce6477d6e5967b4d12be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320571 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792172}
-
Hitoshi Yoshida authored
This reverts commit e2d335fb. Reason for revert: This CL triggers a compile error. Bug: 1110221 Original change's description: > Mac SxS: Don't ask to take default from other Chromium channels > > If another channel of Chromium is already default, don't ask to > become default. > > Bug: 1109417 > Change-Id: I095410b47a64731c7ca7fbafa5f3e3427ec89d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318193 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792144} TBR=avi@chromium.org,mark@chromium.org Change-Id: I59a405e113cca1abc28c9c01c34166d572c60c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322008Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1f16229c9be9..c11a19145f1f 2020-07-28 jiawei.shao@intel.com Support buffer lazy initialization before CopyTextureToBuffer 2020-07-27 enga@chromium.org Update max storage buffer bindings per stage to 6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I44bd4e012494bb54277fd0509149b13afde20d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792170}
-
Eric Roman authored
Bug: 1103764,1109329 Change-Id: I281784e3a1dfd22b2a62f6940d3544aa1060dad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317751Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792169}
-
Mikel Astiz authored
If the browser is shut down while in BACKUP_DISPATCHED (i.e. the task was posted but didn't complete yet), then prior to this patch there was a risk that BookmarkStorage was destroyed before the intended save took place, because there was no scheduled write in ImportantFileWriter. This situation should be rare in practice because making a backup is fast, but does lead to test flakiness, and can be reliably reproduced (e.g. with BookmarkBrowsertest.EmitUmaForDuplicates) if an artificial delay is introduced when generating the backup file. While fixing the issue, a few implementation details have been simplified: 1) Backup-generation does not require waiting until it completes before scheduling a regular write, since a SequencedTaskRunner guarantees the ordering in which the tasks will run (and copying a file is a synchronous operation). 2) There is no need to manually implement SaveNow(), since ImportantFileWriter does the same in DoScheduledWrite(). Change-Id: Ib1de11935b4e37d44e4ad79eb77365cfefb4ff7b Bug: 1108803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320869 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Honglin Yu authored
BUG=chromium:1086044 TEST=python pretty_print.py TEST=python validate_format.py Change-Id: Ia9636b12c195d52627d29e2c1ca0a24ba71bf136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320392Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792167}
-
Marc Treib authored
(as in, whether the actual database files exist on disk) This lets us delete the store (if the corresponding feature flag got disabled) only if it actually exists. This is an alternative (and maybe better) implementation of crrev.com/c/2300439. Bug: 1079297 Change-Id: I3ae84eb87b53e1e7b1e69a20afe68402a7095326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320278Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792166}
-
Wolfgang Beyer authored
Change-Id: I185fd95debae1b80e578fbf061f076cd490938b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316866Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792165}
-
My Nguyen authored
This allows for tracking the opportunity for emoji suggestions. Bug: 1108251 Change-Id: Iffbf3b52f0abcde442e203a63c634e710765c6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318487 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792164}
-
Mathias Bynens authored
Downstream DevTools CL that impacts the expected results: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257 No-Try: true Bug: chromium:1103854 Change-Id: I9ba181977ca662f53d8bbd35b3f2753eb3be859d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320612 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#792163}
-
Jan Wilken Dörrie authored
This change adds a wstring.mojom to chrome_cleaner, renames string16_embedded_nulls.mojom to wstring_embedded_nulls.mojom and makes WStringEmbeddedNulls an alias for String16EmbeddedNulls. Bug: 911896 Change-Id: I9fbf8cb4e0252eb21f66fc89610438da44bd9df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316357 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389, 1108111, 1109761 Change-Id: I67612b91346b98e6503ebb693b45ce1d9f8f0306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320391Reviewed-by:
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/LmieCUDR23kDvDwIcb-H4-WhIUhmeI0M330ACBOQZIYC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200727_RC00.html Bug: b/161847066, b/161687144, b/162047051, b/161959336, b/161405432, b/162183843 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaf451beb875056c83daeb35fd98a852e8c6abd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320909Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#792160}
-
Avi Drissman authored
5d1c71c83e95 Update buildtools to 9e121212d42b and mini_chromium to 85e41f6b6cb5 6c96d8fb7809 fuchsia: Move crashpad_tests to injected-services 1a64e1cdc658 [fuchsia] Add tests group 13fd1561dc05 [fuchsia] Mark tests group testonly f9549d1ffefe [fuchsia] Avoid underscores in package names ad3ad354d3c9 android: fix executable name test e89ba0d1d66f linux: fix timer test 4ae896bad0af Migrate to OS_MAC and OS_APPLE in Crashpad This spuriously triggers on a test file that matches a regex of security-sensitive filenames; removing presubmit. Bug: 1105907 No-Presubmit: true Change-Id: I2f304b087ddafd851e6364c7b421d59bace9afcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321792 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#792159}
-
Katie D authored
Bug: 1108171 Change-Id: I037f79720373b1d5d948109bbc283aeea2b8807e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313379 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792158}
-
Sara Kato authored
crrev/c/2291552 changed focused node computation to remain unchanged if the adjusted node was invalid. However this meant that nodes with no name that should be focused, did not receive focus. Controls (such as seekbars), don't always have a name, but they should be focusable. This CL adds such a condition, to allow controls to receive focus. AX-Relnotes: n/a. Bug: b:160107299 Test: AccessibilityNodeInfoDataWrapperTest.controlIsFocusable Test: AXTreeSourceArcTest.ControlReceivesFocus Test: manual. Check that settings app does not have regression Test: tast run DUT_IP arc.AccessibilityEvent passes Change-Id: I562d70c319974d900b1d48afcc135e64f1181533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310219 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792157}
-
Shik Chen authored
Recently the spec is updated to require a successful getUserMedia() before running enumerateDevices(). Otherwise the deviceId and label fields would be empty. See https://crbug.com/1101860 for more details. Bug: 1103303, 1101860 Test: tast run <nocturne> camera.CCAUI* Change-Id: I61b4278d20720bf6424dada24a1d4e4b73f8c5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321907Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#792156}
-
François Degros authored
This will allow to mount encrypted ZIPs. Enhanced unit test FileManagerJsTest.VolumeManagerTest to check that the password is correctly passed by VolumeManager to chrome.fileManagerPrivate. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.VolumeManagerTest" Change-Id: Iaddff192feed91e1e42557c89618e2a18d2f1369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303413 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792155}
-
Jan Wilken Dörrie authored
This change extends the PasswordManager.TimeBetweenStoreAndServer histogram and swaps the roles of jdoerrie@ and battre@ as primary and secondary owner. Fixed: 1066050 Change-Id: I27f32491f786cbd4f19548e2a7a895a669e093d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320597 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792154}
-
edchin authored
Bug: 1099646 Change-Id: I2b88eb75acc48c02d58b3febdea380410a74861f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321213 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of local_frame_view.h by 1.64MB. This CL has no behavior changes. Bug: 242216 Change-Id: I97eb1498e7bb7cd40810e54f05ed99d8fa63faca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320711 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792152}
-
Minoru Chikamune authored
blink::UserMediaProcessor::OnLocalSourceStopped() is called after ExecutionContext was destroyed. In this case, blink::LocalFrame::GetBrowserInterfaceBroker() will access to LocalFrame::client_, and it will be null already and it will cause a crash. To avoid the crash, this CL checks the Frame::Client() doesn’t return null. Bug: 1105842, 1049056 Change-Id: Idc942b4a59b6d0e220bd58dfeb4a53df0730dca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318502Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#792151}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee995bcb..f31e5f45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibaf02f3169f30fdebc17ae5f153fcfd57745d908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321449Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792150}
-
Kai Ninomiya authored
And: - Deprecates mapReadAsync, mapWriteAsync, and createBufferMapped. - Updates one other usage of the old mapping API. - Add GPUBufferUsage.QUERY_RESOLVE for compatibility with tests I'm writing. Bug: 1069302 Change-Id: I4710883d6ae1f66d3cd0f8216bc335d1e751472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299538 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#792149}
-
Charlie Harrison authored
Right now the conversions UI just looks at presence / absence of the ConversionManager to determine whether the feature is enabled. This isn't enough since we allow the embedder to disable at run-time. Bug: 1109987 Change-Id: Icf0622e5c21bba2a4995ba0dbde4a8ae5bf76e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321238Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792148}
-
Xianzhu Wang authored
Most of the code is copied from perf_tests/paint/select-all-words.html Change-Id: I3d231a67f8162ac3145f070df38875de1a72dfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321233 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1d870649dd5..43f111af3540 2020-07-27 primiano@google.com install-build-deps: clean node_modules when updating node 2020-07-27 dproy@google.com build: Update the nodejs version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Test: Test: manual on mac Change-Id: I009e5610e8fc3793d7832ab5eaf6374e5c64f706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321634Reviewed-by:
-
Brian Sheedy authored
Re-enables the Telemetry minidump symbolization tests on CrOS Betty devices, as the failures that caused them to be disabled appear to no longer be an issue. Bug: 1038043 Change-Id: Ibe335c60cb85ed29bd478dbfe6369d7e40d5c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321402Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792145}
-
Avi Drissman authored
If another channel of Chromium is already default, don't ask to become default. Bug: 1109417 Change-Id: I095410b47a64731c7ca7fbafa5f3e3427ec89d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318193Reviewed-by:
-
Ben Schwartz authored
This hides all the server choice fields when "Choose another provider" is not selected. It also adjusts the label and removes the bottom horizontal line, as requested. Bug: 1106095 Change-Id: Ib362f5f2507235dd63c76d1fd857943425bb7f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320131Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792143}
-
Sicheng Li authored
1. Adds the CustomTabOrientationController in SharedActivityCoordinator 2. Calls the setCanControlOrientaton() in the SharedActivityCoordinator#updateUi() 3. Implements the CustomTabOrientationController#setCanControlOrientaton() 4. Modifies the method of mapping orientation from AndroidX (convertOrientationType()) to chromium as we now take int as parameter instead of String 5. Imports ScreenOrientationLockType class to handle lock type 6. Adds a method as ScreenOrientationProviderImpl#setOverrideDefaultOrientation() to get the default screen orientation lock for TWAs or WebAPKs. Bug: 812797,989606 Change-Id: If07122814a7ca0e68f40fa70d9df24c68e3c5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276255Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sicheng Li <scli@google.com> Auto-Submit: Sicheng Li <scli@google.com> Cr-Commit-Position: refs/heads/master@{#792142}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia859e9e047f269cc301f938cfdb14ba1618757b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321968Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792141}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0307e9114c30..b3038f8cb5c5 2020-07-28 johnstiles@google.com Remove layout(key) support for rects and points. 2020-07-27 johnstiles@google.com Update DataEntry struct to properly support move semantics. 2020-07-27 johnstiles@google.com Allow GLSL processor keys to use floats with full precision. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Idd39a70ff7f79e56292c7d166b9f04a000ecc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321633Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/478f7fed94ec..0dde0b31cf31 2020-07-27 kahinds@microsoft.com Convert localized URL-only strings to normal strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10a6cd911f113480c1b096210b181a906cdfacea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321629Reviewed-by:
-
Chris Harrelson authored
Tables always paint collapsed borders, even if the rows are seprately composited. While we don't need to invalidate paint for the table (because the row is the DisplayItemClient for the borders), we do need to cause repaint for its painting layer, because the table paints those borders. See also (*), which removed the code that previously had the same effect. There was previously no test for this code. (*) https://chromium-review.googlesource.com/c/chromium/src/+/2317848 Change-Id: I269101d3bf28445c0ec3d1f6bcad1a23cf3e46d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792138}
-
