GitLab

Convert the last ramining instances of MessagePumpObservers into
PlatformEventObservers, and remove support for MessagePumpObservers
from non-Windows platforms.

BUG=354062
R=sky@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/233653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263158 0039d316-1c4b-4281-b951-d872f2087c98

build/android/screenshot.py was creating a DeviceUtils. Then grabbing
it's old_interface (i.e. an AndroidCommands) and calling screenshot on
that. That then called TakeScreenshot from
build/android/pylib/screenshot.py passing itself. But
build/android/pylib/screenshot.py expects a DeviceUtils, not an
AndroidCommands. So wrap the AndroidCommands back into a DeviceUtils
first.

build/android/screenshot.py could probably just call into
build/android/pylib/screenshot.py directly.

TBR=jbudorick
NOTRY=true

Review URL: https://codereview.chromium.org/234533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358998

Review URL: https://codereview.chromium.org/217423018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263156 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263155 0039d316-1c4b-4281-b951-d872f2087c98

Putting chrometrace.log in the current working directory is not
useful on Android. Generate a filepath on the sdcard instead the
same way we do it for intent triggered tracing.

R=piman@chromium.org, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/232053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297026, 361784
R=mukai@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/231723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263150 0039d316-1c4b-4281-b951-d872f2087c98

Experimental bionic toolchain had incorrect definition for getcwd.
This change only affects the experimental build of NaCl SDK.

BUG=none
R=binji@chromium.org
TEST=build_sdk.py

Review URL: https://codereview.chromium.org/233773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263149 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/233633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360274

Review URL: https://codereview.chromium.org/229893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263147 0039d316-1c4b-4281-b951-d872f2087c98

These tests were disabled due to issue 349526. Now this issue is fixed and this
CL reenables them.

R=ddorwin@chromium.org,shadi@chromium.org
BUG=349526
TEST=The enabled tests pass locally.

Review URL: https://codereview.chromium.org/232273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263146 0039d316-1c4b-4281-b951-d872f2087c98

r262292 accidentally broke android_gyp. Unbreak it for a while, by using
an env var with a long name that hopefully nobody will refer to from anywhere
in the 3-4 weeks it's going to be in the tree.

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/234223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263143 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/232023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263141 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, TextView.setCompoundDrawablesRelative() is a no-op on JB
MR1 if the text view has ever been measured. This is fixed in JB MR2
onwards, but causes some ugly bugs in Chrome on JB MR1: e.g. the
favicons often don't appear on the bookmarks page.

BUG=361709
NOTRY=true

Review URL: https://codereview.chromium.org/232083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263137 0039d316-1c4b-4281-b951-d872f2087c98

Add --path_to_config parameter to run script. This is needed if the config is located in another depot.

BUG=301552
NOTRY=true

Review URL: https://codereview.chromium.org/232083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361215
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/229033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263135 0039d316-1c4b-4281-b951-d872f2087c98

We detect a context conflict using the version value, and if detected force the
getupdates to retry.

BUG=360280

Review URL: https://codereview.chromium.org/232003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263134 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263132 0039d316-1c4b-4281-b951-d872f2087c98

R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/232563009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263130 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171290:171300&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/228703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263129 0039d316-1c4b-4281-b951-d872f2087c98

Update unit tests that call SyncData::CreateLocalData to call the new
version.

Add AttachmentServiceProxyForTest to reduce boilerplate in tests.

Add a MessageLoop to ManagedUserSyncServiceTest, DomDistillerStoreTest,
and SyncChangeTest because AttachmentServiceProxyForTest needs one.

Format modified lines with clang-format.

TBR=pam,droger,asargent,pkasting,pkotwicz,cjhopman

BUG=353296

Review URL: https://codereview.chromium.org/213003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263128 0039d316-1c4b-4281-b951-d872f2087c98

-Adds the audio input device id and name to the stream generation message.
-Re-enables the no_data_timer in AudioInputController for logging. The NO_DATA_ERROR is ignored and will not stop capturing.
-Adds a AudioPowerMonitor to WebRtcAudioCapturer to log the audio power level.

R=vrk@chromium.org,xians@chromium.org,tommi@chromium.org

BUG=360756

Review URL: https://codereview.chromium.org/229573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361616
R=tim@chromium.org

Review URL: https://codereview.chromium.org/231203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263126 0039d316-1c4b-4281-b951-d872f2087c98

The documentation describes usage of the "Install Param" for external extensions.

BUG=267510

Review URL: https://codereview.chromium.org/216473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263125 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Passes on daisy-spring (ARM device).

Review URL: https://codereview.chromium.org/231843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263121 0039d316-1c4b-4281-b951-d872f2087c98

RasterWorkerPool class has a lot of implementation specific details
that the tile manager and the delegate should not be affected by.
Moving implementation specific parts into a separate class and file
makes it clear what is part of the interface used by the tile
manager and what are details of the implementation. ie. changes to
implementation specific files alone should not affect or require
changes to the tile manager.

BUG=269841

Review URL: https://codereview.chromium.org/228173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263120 0039d316-1c4b-4281-b951-d872f2087c98

Adding some missing #includes to autofill_messages.h.

BUG=362057

Review URL: https://codereview.chromium.org/233173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/233073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263118 0039d316-1c4b-4281-b951-d872f2087c98

Skia roll was reverted.

> Fix GN Build after Skia roll.
> 
> Skia introduced a new define that is required to build.
> 
> TBR=djsollen@chromium.org
> 
> Review URL: https://codereview.chromium.org/234203002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/234283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263115 0039d316-1c4b-4281-b951-d872f2087c98

Skia roll was reverted.

> Fix Skia link errors in the GN build
> 
> TBR=djsollen@chromium.org
> 
> Review URL: https://codereview.chromium.org/234123004

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/234313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263114 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263113 0039d316-1c4b-4281-b951-d872f2087c98

Broke iOS Simulator (dbg):
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/15778

Ld /b/build/slave/iOS_Simulator__dbg_/build/src/xcodebuild/Debug-iphonesimulator/components_unittests.app/components_unittests normal i386
[...]
Undefined symbols for architecture i386:
  "SkSSE2ProcCoeffXfermode::SkSSE2ProcCoeffXfermode(SkReadBuffer&)", referenced from:
      SkSSE2ProcCoeffXfermode::CreateProc(SkReadBuffer&) in libskia_library.a(SkXfermode.o)
ld: symbol(s) not found for architecture i386

> roll skia DEPS to 14128
> 
> Chromium base revision: 262955 / 
> Old Skia revision: 14102 
> New Skia revision: 14128
> Control CL: https://codereview.chromium.org/233193002/
> 
> Bypassing commit queue trybots: 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/232783004

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/234103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263112 0039d316-1c4b-4281-b951-d872f2087c98

In bionic, open, access and dup2 are wrappers of openat, faccessat and dup3 instead of real syscalls.

BUG=166704

Review URL: https://codereview.chromium.org/226923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263107 0039d316-1c4b-4281-b951-d872f2087c98

TBR=djsollen@chromium.org

Review URL: https://codereview.chromium.org/234123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263106 0039d316-1c4b-4281-b951-d872f2087c98

With the conversion of GetAllNodes in r262193, there are no longer any
uses of the Sync JS framework's request + reply framework.

The generic framework was useful when we could guarantee that the
requests would be handled in order, in the SyncManager, and on the sync
thread, but new requirements have forced us to re-implement much of this
functionality in other ways.

Since no one uses this code, and no one plans to use this code, and it
depends on some semi-deprecated concepts (WeakHandle), the best course
of action seems to be to delete it.  We can always fetch it from SVN
history and clean it up if we find another use for it.

BUG=328606,357821

Review URL: https://codereview.chromium.org/231013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263105 0039d316-1c4b-4281-b951-d872f2087c98

Because the Animate() method was recently changed to pass the current
frame's tick time in r259735, getting the diff between it and the fling's
start time would often result in a negative time delta. This caused the
fling to report no scrolling and the scroll would stop. We still want to
start flinging immediately where possible so instead of letting Animate()
always set the startTime and losing a frame, we do it only for a
non-positive time delta.

This does not affect Android since its gesture fling ignores the passed
delta and uses gfx::FrameTime::Now().

BUG=360633

Review URL: https://codereview.chromium.org/232683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
TEST=modal dialogs still work

Review URL: https://codereview.chromium.org/229693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297026
R=ben@chromium.org

Review URL: https://codereview.chromium.org/231733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98

Skia introduced a new define that is required to build.

TBR=djsollen@chromium.org

Review URL: https://codereview.chromium.org/234203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263100 0039d316-1c4b-4281-b951-d872f2087c98

Internal code gets around this by calling ContentView.hideSelectActionBar.
Remove the hop as the ContentView variant is going away.
BUG=360664
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/232963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/231313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263098 0039d316-1c4b-4281-b951-d872f2087c98