Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 15 Jun, 2018 9 commits
    • Ken Buchanan's avatar
      DrawQuad hit testing should query renderer whenever it hits a Surface · e1186494
      Ken Buchanan authored 
      SurfaceHittest finds a target Surface for a point and signals whether
there should be additional hit testing done in the renderer.

Currently this only happens if there is a Surface quad and a
non-Surface DrawQuad under the point, in which case the browser
sets query_renderer in order to get a more confident target.

However, in cases where the Surface is occluded by a RenderPass that
has no DrawQuads in that location, it doesn't set query_renderer
because there does not appear to be a reason to do so. Instead, it
incorrectly thinks the RenderPass is the correct target. This is
problematic because layer squashing can create layers that are much
larger than the elements within them.

This CL changes this behavior so that it always queries when there is a
Surface at the given point.

This will increase the number of asynchronous hit tests that are
performed in general.

Bug: 851802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4e878101533e2794fc44cd16f36ea5cd104e59e2
Reviewed-on: https://chromium-review.googlesource.com/1101579Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567500}
      e1186494
    • Khushal's avatar
      gpu: Move skia_utils to raster_sources in gpu/command_buffer/common. · 8a9bb7e9
      Khushal authored 
      R=piman@chromium.org

Bug: 844207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5b324498db07afdb342d555982781f922a3e3b94
Reviewed-on: https://chromium-review.googlesource.com/1101458Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567499}
      8a9bb7e9
    • Chong Zhang's avatar
      Telemetry: Disable loading.desktop/Kenh14 on Linux and Mac · 6a6e785e
      Chong Zhang authored 
      Disable due to failings on linux-perf, Mojo Linux Perf, and
mac-10_13_laptop_high_end-perf.

See bug for sample builds.

Bug: 852980
Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68
Reviewed-on: https://chromium-review.googlesource.com/1101836Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567498}
      6a6e785e
    • Robbie McElrath's avatar
      Add NetworkServiceClient::OnFileUploadRequested method. · ee14fa1e
      Robbie McElrath authored 
      This is the start of a larger refactoring to the way file uploads are
handled when the network service is enabled. Currently a file path is
given to the network service, which then opens the file and uploads
its content. It doesn't currently check if the requester has access
to the file, and won't even be able to open files once it's sandboxed,
so the plan is to make the network service ask the browser process to
open the file for it. The renderer or browser process (whichever
wants to do the upload) will pass a file path to the network service,
which will then call a new method on NetworkServiceClient. This method
will take the file paths that it wants to upload, validate that the
originator of the request has permission to open those files (via
ChildProcessSecurityPolicy), open the files, and return the handles
back to the network service to upload them.

This CL defines just the new method, OnFileUploadRequested. Future CLs
will add its implementation.

Bug: 845612
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9f7d0622db198a33e8f6dcdf9b8f4373d9156e2a
Reviewed-on: https://chromium-review.googlesource.com/1095653
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567497}
      ee14fa1e
    • Robert Sesek's avatar
      [Mac] Enable the MacV2Sandbox in content_shell. · 878c88fd
      Robert Sesek authored 
      The main executable now invokes the SeatbeltExecServer when the feature
is enabled.

This also sets up the OuterBundle and BaseBundleID overrides, which are
required to properly find the rohitfork port.

Bug: 850735, 749839
Change-Id: Ic02df574a209213d1ca560ab2d1e947be5ae5136
Reviewed-on: https://chromium-review.googlesource.com/1099643Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567496}
      878c88fd
    • catapult-chromium-autoroll's avatar
      Roll src/third_party/catapult 42e9609fc92e..b520f6298c3e (3 commits) · 414404c3
      catapult-chromium-autoroll authored 
      https://chromium.googlesource.com/catapult.git/+log/42e9609fc92e..b520f6298c3e


git log 42e9609fc92e..b520f6298c3e --date=short --no-merges --format='%ad %ae %s'
2018-06-14 csharrison@chromium.org Add support for profile_files_to_copy in PossibleAndroidBrowser
2018-06-14 sullivan@chromium.org Added apps scripts to mail perf sheriffing info to experimental/
2018-06-14 benjhayden@chromium.org Support multiple story tags in ChartJsonConverter.


Created with:
  gclient setdep -r src/third_party/catapult@b520f6298c3e

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:823982
TBR=sullivan@chromium.org

Change-Id: I57109c7cae486eef0e69974e9cdb99dedb801c78
Reviewed-on: https://chromium-review.googlesource.com/1101719Reviewed-by: default avatarcatapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567495}
      414404c3
    • James Darpinian's avatar
      GPU: Don't flush when destroying transfer buffers. · 7a59e081
      James Darpinian authored 
      Destroying a transfer buffer now requires only an ordering barrier, not
a full flush. This removes a source of unnecessary flushes and makes
resizing the transfer buffer more efficient.

Bug: 850271, 835353, 828363
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9bfe43c46c00f8e9fc29e6450da788f86e74bc52
Reviewed-on: https://chromium-review.googlesource.com/1093580Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567494}
      7a59e081
    • kristipark's avatar
      Add fallback icon support to MV tiles · cf42dd28
      kristipark authored 
      Tiles with missing/small favicons will display fallback icons instead, which consists of a colored circle and the first letter of the tile title. The fallback color will either be gray for missing favicons or the dominant color of the small favicon.

This change depends on https://crrev.com/c/1096670.

Screenshot: https://screenshot.googleplex.com/dbu8dxk97sX.png

Bug: 837798
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie6ddf538396bcf8fbfd11cb9e9f0bad075301edd
Reviewed-on: https://chromium-review.googlesource.com/1096680
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Reviewed-by: default avatarEmily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567493}
      cf42dd28
    • Nasko Oskov's avatar
      Fix session history navigations and reloads which change SiteInstance. · aee2f86a
      Nasko Oskov authored 
      Reloading an URL usually does not change its SiteInstance, however there
are a couple of exceptions - hosted apps and recently isolation of error
pages. In both of these cases, a commit for a specific URL can happen
in SiteInstance A and a subsequent reload results in a change to
SiteInstance B. With error page isolation, this can happen easily due
to timeout or some other transient network error on the initial navigation
to the URL, which ends up in an error page process. A later successful
reload then results in a different SiteInstance for the same URL.

Session history navigations are similar in behavior. When navigating
back/forward, the navigation can be redirected cross-site, resulting
in a SiteInstance change.

This CL changes ClassifyNavigation to account for these and classifies
them as NEW_PAGE with replacement. It ensures that when an entry's
SiteInstance changes, which means the security context has changed,
we don't reuse and update the existing entry, but rather we replace it
with a newly constructed one.

The CL adds a specific test for session history navigations that are
redirected and adds session history length checks to the existing test
of reloading a hosted app, which changes SiteInstances.

Bug: 840485, 848446
Change-Id: Iabacc60ce5726d5d919877b6e65e5d2f51dff3e2
Reviewed-on: https://chromium-review.googlesource.com/1086876
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567492}
      aee2f86a
  3. 14 Jun, 2018 31 commits