- 28 Apr, 2020 40 commits
-
-
wutao authored
This patch renames AssistantImageDownloader to ImageDownloader and share it with Ambient mode. Bug: b/153499730 Test: passed current unittests Change-Id: I9fc2a875381184f4f370f400c27597b8ba5964d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148129 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763562}
-
manuk authored
*Rich autocompletion background* Currently, autocompletion is limited to when the user types a prefix of the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Rich autocompletion will allow autocompletion even when the input is from the suggestion title or not the beginning of the URL. E.g. 'thecoo' and 'awesome reci' will also autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Design doc with further details: go/richomniboxautocompletion *This CL* This is the 2nd CL for rich autocompletion. As a prerequisite for non-prefix autocompletion, e.g. allowing 'y' to autocomplete '[x]y[z]', this CL adds support for multiple discontinuaous selections to the Textfield view class and its underlying TextfieldModel and RenderText classes. Multi-selection is not used at the moment, and thus this CL will not have user facing changes. Followup CLs will use the feature and will be behind flags. Bug: 1062446 Change-Id: I6e1e6a8bc44b3e3a6ef8dcd45537edc2d683ac0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108780 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#763561}
-
Robert Liao authored
CreateCombobox is now known as CreateAndAddCombobox. Change-Id: I6143d33c0ee9efdf7c0a63d20deb6d23e9bb969d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169377 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#763560}
-
Bo Liu authored
Last call was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1162438/ Change-Id: I606f03de97b4b4239d8ca202d61501025b76ed53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171318 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#763559}
-
Yoav Weiss authored
Aligns the implementation with the spec. https://github.com/WICG/ua-client-hints/issues/77 discusses which Task type it should be queued on. Bug: 1070934 Change-Id: I3461f7f1a2e6346717e568008b9879f20d39a82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166103Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#763558}
-
Abhishek Bhardwaj authored
Chrome OS doesn't use or support the old wake on WiFi flag. This change removes all associated code. BUG=chromium:1074118 TEST=Compile. Change-Id: Ice29ea77301ddbdcffdc34eedaa65254ec3bdb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163040 Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#763557}
-
Morten Stenshorne authored
The first idea was to allow |limit| in HitTestCulledInlineAncestors() to be nullptr and just exit when we reach the first LayoutBox ancestor, but that wasn't good enough, as that would still trigger DCHECK failures in LayoutInline::HitTestCulledInline(), because neither ContainingNGBlockFlow() nor NGInlineCursor work if the container is a fragmentainer. Therefore, just skip hit-testing of culled inlines that are contained by a fragmentainer / column for now. This is needed by CL:2134294 Bug: 829028, 1043787 Change-Id: I22348d69b5159de56614fe28ce5456b87643afe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170000Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#763556}
-
Yi Gu authored
crrev.com/c/2084088 implemented the necessary plumbing from blink to cc to support composited scroll-linked animations. This patch completes the ticking logic in cc. Major changes include: - Passing ticking_animations_ to cc::AnimationTimeline and ticking animations from AnimationTimeline such that cc::Animation does not need to be aware of upper level concepts such as ScrollTree. - Splitting ticking methods for time/scroll linked animations. - Using KeyframeEffect::Pause() instead of Tick() for scroll linked animations. - Updating KeyframeEffect::last_tick_time_ to base::Optional to be compatible with both time/scroll linked animations. Bug: 1023508 Change-Id: Ic1952c06205dea6ef2eaed37eceb86ae35db9c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106820 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#763555}
-
Tommy Li authored
This reverts commit 5f5008fc. Reason for revert: Seems to be breaking the build: https://bugs.chromium.org/p/chromium/issues/detail?id=1076167 Original change's description: > Add runhooks to download PGO profiles and allow query profile path > > This CL: > 1. Adds gclient runhooks to download PGO profiles. > 2. Allows the build system to query the path to the current profile. > > Bug: 1071576 > Change-Id: I6b8954f81b61ef7362f28ca2bf585abd84e1a799 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165448 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763123} TBR=thakis@chromium.org,dpranke@chromium.org,estaab@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org Change-Id: If5e17b4c564b5049dea1e22c7419747504608121 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071576, 1076167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171619Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#763554}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d70aa16fd5af..b806e17eb278 git log d70aa16fd5af..b806e17eb278 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 ehmaldonado@google.com git-drover: Don't attempt to decode output of check_call. Created with: gclient setdep -r src/third_party/depot_tools@b806e17eb278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1074357 Tbr: agable@chromium.org Change-Id: I69cbbb1159ace283d9616715cf046b69bc9d0976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763553}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ifa25b7c95f8f5e8283c14e550d0fb394aac301c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169874Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763552}
-
Kevin McNee authored
When we cancel an existing navigation upon portal activation, we've also been inadvertently canceling navigations initiated immediately following the predecessor's call to activate. We now only cancel the existing navigations. This also unearthed some issues that occur when a navigation which started when orphaned commits. We also fix those. Bug: 1058455 Change-Id: I78cdb0ebf548d6b9710ab8315f232ca1179817e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166386Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#763551}
-
Sinan Sahin authored
If we show or hide the offline indicator when the omnibox is focused, the omnibox loses focus. This is because the toolbar's visibility changes during the animation (compositor offsets change), which clears the view's focus. The fix (or workaround) this CL introduces is to wait until the user unfocuses the omnibox before showing/hiding the offline indicator. Bug: 1069552 Change-Id: Id462d76390895b02226c6404bcb432f0d74948db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165872 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#763550}
-
Xiyuan Xia authored
- LayerTreeHostImpl processes pending tracker info in CommitComplete to start/stop custom sequence tracking; - When a kCustom FrameSequenceTrackers finishes data collection, the data is picked up in LayerTreeHostImpl::DidPresentCompositorFrame and sent through LayerTreeHostImpl -> Proxy -> LayerTreeHost -> ui::Compositor -> reporting callbacks; Note this CL only implements the reporting code path for ui (i.e. single threaded mode). Tbr: dtapuska@chromium.org Bug: 1021774 Change-Id: I2f9af3f360cbb28a71c02908a288b85059048cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022353Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763549}
-
Saurabh Nijhara authored
This policy is not ready for usage. Hence, marking it with future flag so that it is not included in the documentation. When the policy is ready for use, this flag will be removed. Bug: 1048607 Change-Id: Iefd022161d5f6710da99c8c1404e7b7eb6190f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165748 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763548}
-
wutao authored
This patch adds an access token controller for ambient mode. It will refresh the token when entering lock screen. The following requests to backdrop server will reuse the cached token before it expires. Bug: b/148463064 Test: new unittests Change-Id: Icf882b2d0938e29e06900b4bbffea8cdc5ba1af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149948 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
-
David Tseng authored
https://chromium-review.googlesource.com/c/chromium/src/+/1779430 introduced the section role, which is essentially just a region. In particular, we want to honor its announcements when landing on one of their descendants (an output rule's enter rule); get this by making it inherit from abstractContainer. R=dmazzoni@chromium.org Fixed: 1075615 Change-Id: I920346c2423f1b24e300456ce585421a385776e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168513Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#763546}
-
Xida Chen authored
We are seeing OOM crashes from FrameSequenceTracker, and suspect that a tracker may never be terminated. This CL adds some debugging instrumentation to investigate what happens after a tracker is scheduled to terminate. Bug: 1072482 Change-Id: Ifb96ba4e00a014cdd3d7cd83c453f6f799737ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169761 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763545}
-
David Black authored
Problem: To add polish, SearchController closes the app list view when opening search results. Newly added Assistant search results (surfaced as launcher chips) often desire to stay in launcher(-embedded Assistant) UI which is broken by this behavior. Solution: Make it optional whether SearchController should dismiss app list view eagerly or not. Bug: b:154152631 Change-Id: Ic37220b4a8bddb45277cbce4544cfae8ac69be56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163853 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Akihiro Ota authored
Bug: 684762 Change-Id: Iba524b75bbceafd69ca0af04461b5badb1a2ebd7 Relnotes: Launch ChromeVox search menus feature. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168795 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#763543}
-
mhasank authored
The UMA is sent in session manager daemon when starting ARC fails and we create backup of ARC bug report. CL of session manager daemon: https://crrev.com/c/2168746 BUG=b:149874690 TEST=None Change-Id: I532488eaf068d103cc9f3d718a247d2c5b968d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168638 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#763542}
-
Andrew Grieve authored
No longer needed after recent R8 roll Change-Id: I1821bf2335f4da02db5f614361755fef24e9b185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170559 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#763541}
-
Tanmoy Mollik authored
Use SigninTestUtil to add test accounts instead of ChromeSigninController. Bug: 1074309 Change-Id: Ifa737a5425e348e2ea68f4d80698c94416e5f69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165785Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763540}
-
Travis Skare authored
Change-Id: Iac5cbeb49c3de10f9bb77a6d02abc7be50eaebc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163574Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#763539}
-
Pavol Marko authored
These tests should not be flaky after CL:2161032. Also fix WebviewProxyAuthLoginTest to not crash if it would be re-enabled, but actually re-enabling it will happen in another CL because its flakiness may have been due to other issues. Bug: 830337, 949511, 1022034 Test: browser_tests Change-Id: Idc66e8516f7c1c381f0c76a8e820500a0a04924e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171097 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763538}
-
Rune Lillesveen authored
FlatTreeNodeData is cleared on insertion so that nodes moving between shadow trees do not keep stale parent information since we use the FlatTreeNodeData ancestor to mark ancestors style dirty without updating the slot assignment. This is normally fine since inserting a child node of a shadow host will mark the host for slot re-assignment, and the slot re-assignment will update FlatTreeNodeData accordingly. The diffing of flat tree children in NotifySlottedNodesOfFlatTreeChange will mark the inserted node for style recalc via FlatTreeParentChanged. There is however a glitch which can happen if a node is removed from a shadow host, inserted into a different node, and then moved back into the original shadow host without having any re-slotting happening in between. If the node ends up in the same flat tree position, we will not be able to detect that it needs FlatTreeParentChanged to be marked for style recalc. Example: <div id="host"> <:shadow-root> <slot></slot> </:shadow-root> <span>PASS</span></div> <div id="other"></div> <script> // Make everything clean. FlatTreeNodeData ancestor for the span is // the slot. host.offsetTop; let slotted = host.querySelector("span"); // The span is removed, the layout object is detached, and the // ComputedStyle is cleared. slotted.remove(); // Insert span into the #other element, FlatTreeNodeData for the span // is cleared. The host is marked for slot re-assignment. other.appendChild(slotted); // The span is re-added as a child of #host, but nothing is marked // style dirty since the #host has a shadow root and the span is not // yet part of the flat tree. host.appendChild(slotted); // Slot re-assignment happens, but the result of slotting is the same // as for the last lifecycle update, and nothing is marked dirty. That // results in the span not getting a ComputedStyle nor a LayoutObject. host.offsetTop; </script> The solution is currently to do a FlatTreeParentChanged for the case where we: 1. Already have a FlatTreeNodeData. 2. The FlatTreeNodeData ancestor is null before the slot assignments. 3. The node is assigned to a slot. It is definitely correct and necessary that we call FlatTreeParentChanged in this case, but we end up doing it twice for other elements which were added to the host, which used to be a child of another host (FlatTreeNodeData being non-null), and will also have FlatTreeParentChanged being called in the diffing as well. The question is if that will cause perf regressions, typically in microbenchmarks. Bug: 1072475 Change-Id: I5e697570b74599b0a3e01ca869eac022105fc6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160930 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#763537}
-
Sebastien Marchand authored
This integrates the PGO build config with the new gclient hooks added in https://chromium-review.googlesource.com/c/chromium/src/+/2165448 Bug: 1056189 Change-Id: Ie165c3355496ac539836ee36903a51a1e585cbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107728Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#763536}
-
John Lee authored
This CL replaces the layout mixin uses with just the expanded CSS properties. See [1] as reference. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/polymer/v3_0/components-chromium/iron-flex-layout/iron-flex-layout.js?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 973674 Change-Id: Ifcbe09ad7f424a6b74a00c304b7101a66e1d5873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168808Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#763535}
-
Hesen Zhang authored
Keep GetTiles as async call but return the copies of tile data. Bug: 1066550 Change-Id: I0b2eddd7063c5f6ded269c4223cd3e67da2aedf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161479 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763534}
-
Robert Flack authored
When authors add will-change: transform hints, we expect the transform to change and should attempt to not change the raster scale unless higher resolution tilings are needed. Bug: 1074055 Change-Id: Ica3daff2a093617602aff8785568e5c29d5b6210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164152Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763533}
-
Tommy Li authored
This adds an about:flag entry for On-focus Suggestions for the Contextual Web. Find it here: chrome://flags/#omnibox-on-focus-suggestions-contextual-web Bug: NONE Change-Id: I04d085a4d2416de6df2f1962d250e1e4908d0fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166382 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#763532}
-
Patrick Noland authored
This removes setFindToolbarManager and getActionModeControllerCallback in favor of injecting FindToolbarManager to ToolbarManager's constructor, which is enabled by instantiating ToolbarActionModeCallback in RootUICoordinator. Bug: 865801 Change-Id: I0c08a63c1576bf3449de8d040a184ca4e8cb059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165656 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Sharon Yang authored
Add a minimally-privileged sandbox. This is used by the VideoCaptureService under Fuchsia, but is equivalent to no sandbox on other platforms. Bug: 998310 Test: CQ Change-Id: I418d05b96e7489ab2bb0db6f7c360db7390d7c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161618Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#763530}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/784cc7b22b21..88040c56ba07 git log 784cc7b22b21..88040c56ba07 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 tsepez@chromium.org Null check not needed for CFX_GEModule::GetFontMgr() return value. 2020-04-27 thestig@chromium.org Disable deflate TIFF support. 2020-04-27 thestig@chromium.org Replace BIT_INDEX_TO_BYTE and BIT_INDEX_TO_ALIGNED_BYTE macros. 2020-04-27 thestig@chromium.org Disable OJPEG style TIFF support. 2020-04-27 thestig@chromium.org Remove unnecessary fx_string.h usage. 2020-04-27 thestig@chromium.org Add a regression test for bad Type3 font glyphs. Created with: gclient setdep -r src/third_party/pdfium@88040c56ba07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1371,chromium:966263 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7f9e2e302b8e3dd96c125e8491f26c45d5bbd3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170803Reviewed-by:
-
Moe Ahmadi authored
Otherwise the generated mojom-lite.js files will contain definitions such as chrome.mojom.AutocompleteMatchSpec = {...} which won't closure compile since |chrome| is defined as a constant namespace in third_party/closure_compiler/externs/chrome.js: /** * namespace * @const */ var chrome = {}; Bug: 1041129 Change-Id: I4c5664f796e029738ec37f519a9345c69f69f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167427Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763528}
-
Koji Ishii authored
This patch fixes a DCHECK failure for when hit-testing culled inlines inside of a column box. It fails because |NGPhysicalFragment::GetLayoutObject()| returns |nullptr|. This patch adds |GetSelfOrContainerLayoutObject()| to return its parent |LayoutObject| for when the fragment is not a CSS box; i.e., line box or column box. Bug: 829028, 1043787 Change-Id: I81098a6969f8c5c2100195e533d7d509a92b2fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170371Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#763527}
-
Alexander Timin authored
Consolidate cookie callbacks (OnCookiesRead and OnCookieChanged) into a single OnCookieAccess and pack all parameters into a single struct for easier plumbing. This removes a bunch of duplicated logic and makes it easier to do clean up attribution later. R=kinuko@chromium.org,engedy@chromium.org,csharrison@chromium.org BUG=1061899 Change-Id: I4616de9b56955fdaadbe8b95205df360e0f8a22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159430 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#763526}
-
Ken MacKay authored
Change-Id: I2fd3135e9596d772e384a8d62c6fa84a782fc7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171316Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#763525}
-
Tommy Li authored
This reverts commit 4ffa6a29. Reason for revert: Breaking Mac build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/24148 Original change's description: > Add unittest for Lax-allowing-unsafe behavior under SameSite-by-default > > Improve test coverage: verify that cookies with the default SameSite > behavior under SameSite-by-default-cookies can be sent on top-level > cross-site POST requests if less than 2 minutes old. > > Bug: 953306 > Change-Id: I642f4df702f0cad62310a4d442f69a293096cab6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169574 > Commit-Queue: Lily Chen <chlily@chromium.org> > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > Auto-Submit: Lily Chen <chlily@chromium.org> > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763451} TBR=morlovich@chromium.org,chlily@chromium.org Change-Id: I18ddfd96efc61555fc99a717f44f1ad4f45706e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170597Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This cl adds a new os_settings_resources_v3.grdp file, in preparation of migrating to Polymer 3. Bug: 1045266 Change-Id: I55103ba896586f7322498449e2c5b2eed7f70a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167803 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763523}
-
