- 25 Jun, 2020 40 commits
-
-
Omer Katz authored
Tracing assumes the entire backing store is safe to access. To guarantee that, tracing a backing store starts by marking the whole backing store capacity as accessible. With concurrent marking enabled, annotating size changes could conflict with marking the whole store as accessible, causing a race. This CL wraps ANNOTATE_CHANGE_SIZE with MARKING_AWARE_ANNOTATE_CHANGE_SIZE that checks whether marking is currently active and keeps the entire store annotated accessible if it is. Bug: 1092468 Change-Id: I87c506ad925fc33cb25d62495d2786704822afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266674Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782571}
-
Kyle Horimoto authored
(1) When opted out of Crostini, clicking the "Crostini" result should lead users to the Crostini *section*, not the Crostini *subpage*. (2) Fixed wording from "setup" to "Set up". Fixed: 1096865 Change-Id: I61d521c4a3bccc3a4e91ecdbda5511f23ecd1e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267441 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782570}
-
Connor Moody authored
Currently, FileHandlerManager unconditionally updates OS file handlers in AppRegistrarObserver methods. Because Mac file handlers are connected to the app shim, this update causes the finder to display through RevealAppShimInFinder. This change prevents the finder from being displayed for apps without file handlers. Eventually, a more robust uninstallation for file handlers should also prevent the finder from being displayed during WebApp uninstallation, however, the necessary infrastucture for that approach does not yet exist. Bug: 1088434 Change-Id: Ia1fffdf3446d6331228a3a5b62b7986e134c2333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264884 Commit-Queue: Connor Moody <connor.moody@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#782569}
-
Kyle Horimoto authored
When the Google Assistant is disabled, we should not show search results for various settings within that subpage. The only action we should show is "Turn on Assistant". Fixed: 1096872 Change-Id: Idb3018a800c5a8268451717c20f205d1185457b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267408 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
This caused a timeout during the |assistant.OpenSettings| tast test, which is currently ignored but increases the test duration and the chance of the test overrunning its total allotted runtime. Running this locally: // without the change it takes 11 seconds [10:04:35.731] Launching Settings app with Assistant query and waiting for it to open [10:04:46.210] Closing precondition "chrome_logged_in" // with the change its down to 2 [10:14:51.282] Launching Settings app with Assistant query and waiting for it to open [10:14:53.398] Closing precondition "chrome_logged_in" Bug: 1080366 Test: Ran assistant.OpenSettings tast test with and without the change. Change-Id: Ie5cd8353f4c10514c9818ea734566d92503461bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267837 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#782567}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4d9a224d037..f798f83c7a90 2020-06-25 treehugger-gerrit@google.com Merge "docs: Add documentation for TRACE_EVENT_{BEGIN,END}" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9674946a68c6ae5a7eae5d3f16d717189a507b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782566}
-
Yue Zhang authored
Currently, when a new tab A is added to tab model with TabLaunchType != FROM_RESTORE, we check if A has a parent tab B and if so, we put A to B's tab group by setting A's root id to B's root id. Later when we move A out of this group, we set A's root id back to A's id. Above logic has an issue when A is ungrouped from B and then tab reparenting happens. Since tab is reparented by adding back to tab model with its original launch type, the addition of A will put it back to B's tab group even if it has already been ungrouped before reparenting. To fix above issue, we take advantage of the fact that addition caused by tab reparenting happens before tab model restore, and add a check to skip the merging to parent tab's group when tab model is not restored. Bug: 1092837 Change-Id: I363026c3bbfb7aa914bae102498efb97387581e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254343Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782565}
-
Alex Ilin authored
A recent CL https://crrev.com/c/2255472 changed the way how the reauth dialog treats load errors. ReauthTabHelper no longer returns kLoadFailed result and lets the dialog display the error page. Presumably, the user will close the dialog after seeing the error, so Reauth returns kDismissedByUser result. To make metrics clearer, reauth should return kLoadFailed in the load failure case if the error was displayed to the user. Bug: 1045515 Change-Id: I6fb886835633f54c3822fce08f98c9da4049be7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267379 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782564}
-
Shakti Sahu authored
This CL adds scheduled downloads to download infobar. Bug: 1097996 Change-Id: I875728b1606e9cf26472fe13b0523896bffc8641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265425 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782563}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1522811c8f8f..e9a7aeca54da 2020-06-25 bsheedy@chromium.org [Telemetry] Fix CrOS screenshots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098450,chromium:1098485 Tbr: oysteine@google.com Change-Id: Ifd5b6a2658327ad6bb8e48ba4a79a22d4b6baa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267415Reviewed-by:
-
Chris Lu authored
This change adds UserActions to the FindInPage logic. Bug: 1046224 Change-Id: I163cf607f7ceb68eb17d9135dcf0167ba12cdb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252619 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782561}
-
Ella Ge authored
TBR=yusufo@chromium.org Bug: 1097003 Change-Id: I7fffddb2675729657b8b4c39520c9bf865e3efca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267759Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#782560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1cf9ff4772f..ab90f3a64a2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1031540,chromium:1070150 Tbr: cmumford@google.com,eirage@google.com Change-Id: I75902ff83727c5c5e96d2e7371f899a254b3d403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782559}
-
Jason Chase authored
In anticipation of third-party OT support being ready for M85, this adds the necessary configuration for Trust Tokens. Bug: 1069623 Change-Id: I566bbfb65194a0ff1bd1b5d43a25d2c730a4607d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264464Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#782558}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593093524-eca3f18b377a6e052315321864c4c4c2bda6f5fd.profdata to chrome-win64-master-1593097140-08659fb2dab2f981f5f09b831574debe8a1a216c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifa6e862434988e3124fd5c5a50d01ff30f129a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267416Reviewed-by:
-
Rakib M. Hasan authored
This CL is causing the wpt_expectations_updater.py script to have an exception when reading results. The script does not expect the results to be the layout test specific results. After integrating typ into results and expectations handling in blinkpy the results need to be set to FAIL for test failures. The results viewer already has code which transforms the generic FAIL result to the layout test specific result based on the artifacts dictionary contents. Bug: 937369, 1050760, 1050754 Change-Id: I52c5daeacf58ba32339ecfbc5638ac63c1e841ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264021Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#782556}
-
Jeroen Dhollander authored
This will make debugging easier. We already log most Assistant responses, but the device actions were not logged yet. Test: manually executed Bug: b/157144814 Change-Id: If660305094fb3d668e91ce0a167a9f70f512c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261358 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#782555}
-
Ravjit Singh Uppal authored
Discarded or ignored patterns will be displayed in the site settings page with a strike through Bug: 1073883 Change-Id: If4229555acfac5fb0ed454161aec8db60f772368 TBR: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232370 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782554}
-
Tommy Martino authored
Bug: 1099268 Change-Id: I46858e92b3c6d9eb9dfba51760bca621eca3e894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267018Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#782553}
-
Natalie Chouinard authored
The MultiWindowUtils implementation was upstreamed in crbug.com/805938, so it no longer needs to reside in AppHooks. Bug: 1098518 Change-Id: Iabee2370748dfa678919d9721aff10366d3e03ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261793Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Patrick Noland authored
Bug: 1062645 Change-Id: Id0d0611fbb1217bc2bcdad3fd3c762c7bf2387c1 Tbr: dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267721Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782551}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/259221d526e2..ea70630494ad 2020-06-25 cnorthrop@google.com Capture/Replay: Fixups for draw surface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: Capture and replay sample of gfxbench Change-Id: I81b1e2f1859f051594699c3b5a72eca7d0fdcf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267402Reviewed-by:
-
John Abd-El-Malek authored
Change-Id: Ifc1bc49ef02062519447606e34abebbbb6d76164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265446 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#782549}
-
Yao Xiao authored
Per conversation with the endpoint owners, we decided to use cookie for authentication. In a multi-login situation, cookies alone wouldn't be sufficient to tell which is the sync-ed account, but for the PoC we could discard those situations and the server is supposed to return error/false. Remove the OAuth logic. Change the resource request’s credentials mode from kOmit to the default kInclude and set site_for_cookies to enable sending cookies. Bug: 1062736 Change-Id: I7a2c9620f1ace34989175263cc7dcd54facf54de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228064 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782548}
-
Becca Hughes authored
This is a reland of 79b65e58 Original change's description: > Switch on Kaleidoscope in Chrome builds > > We are now at a point with Kaleidoscope where > we can switch on the build flag in Chrome official > builds. > > BUG=1044741 > > Change-Id: I8131da21714056cd34f5d944795317088b8e0d47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261231 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782267} Bug: 1044741 Change-Id: If91a617a3bd65b1a62f3c10879ce3504391ea983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266391 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782547}
-
Stephen Chenney authored
Add the feature flag for cross-origin PaintHolding. It is disabled and will remain so until its impact is determined via field trials. Test the correct flag operation in a unit test. Bug: 1069799 Change-Id: I930576820bd5246312d73f198df8abfe0bf0d6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261815 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782546}
-
Robert Sesek authored
This effectively reverts 668c097f. Bug: 1097376 Change-Id: I6dfe3300315bbee65bcc0d18fb26a0afa46a61f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252466 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#782545}
-
Jonathan Backer authored
I believe this is what we do in practice with command buffers (i.e. ContextCreationAttribs::lose_context_when_out_of_memory is true for display and raster). I was not able to trigger GL_OUT_OF_MEMORY on a variety of devices (N5X, Pixel3, S10E). Android LMKD always killed GPU process first. Bug: 1093997 Change-Id: I849125e155310239e6450db5aea99eaed7c536f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242255 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#782544}
-
Patrick Noland authored
Bug: 1096214 Change-Id: If925373d6c907832b2222295ad18c89e8c2bab37 Tbr: ntfschr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267638Reviewed-by:
-
Patrick Noland authored
Bug: 1096656 Change-Id: Iae99bef9e5640c8db53de6061afe664f189fe549 Tbr: carlosk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267841Reviewed-by:
-
Andrew Grieve authored
Removes option to add pydeps via build_utils.WriteDepfile(). TBR=agrieve # Refactored method signature Bug: None Change-Id: I5fb2d4e15c2739344bcb89ebd1906efb10a7c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265504 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782541}
-
Li Lin authored
When clicking on the retry button, we recreate the QuickAnswers view which already exists. Check before creating the view. Bug: b/159663772 Test: manual test Change-Id: Ie70971a17721d7298c9bb625e9824e32b7430769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265246 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782540}
-
wutao authored
Need to combine the feature flag and pref value to guard this feature. Bug: b/159678673 Test: manual Change-Id: Ibe646d21b4ed8751de0b15d66f1430c7ce182bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259774Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Ella Ge authored
TBR=majidvp@chromium.org No-try: true Bug: 1099346 Change-Id: Icb71166bf7ef36068b320724785c7bcc364af6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267426Reviewed-by:
-
Natalie Chouinard authored
Bug: 1098518 Change-Id: Ibe6afb2693c684baeb660f0ee84369028804f0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261714Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Mike Wasserman authored
The original change missed this suffix from the original mocks. https://chromium-review.googlesource.com/c/chromium/src/+/2174969 Caught in UX implementation review (not shipping in M85, so no rush!): https://docs.google.com/presentation/d/1iSdJI3MhMMOeXr9Qzp3a5NlgT-l0AXdUAyJKylA-KgE/edit?ts=5ee124cc#slide=id.g88508b5609_1_50 Test with chrome://flags#enable-experimental-web-platform-features Also fix some other string descriptions. Bug: 897300 Test: chrome://settings/content/windowPlacement shows suffix Change-Id: I21942ca99980df9dac033f1739d7ddfc802df47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264465 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782536}
-
Akihiro Ota authored
This change: 1. Replaces all instances of "whitelist" and "blacklist" with "allowlist" and "denylist", respectively. 2. Fixes a closure compiler error in common/chromevox.js. 3. Does clean up and changes all instances of "disallow" to "deny". Bug: 1099282 Change-Id: Iad7a410817b27e6f5cf703bcef7d8252d9ae563e AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257559 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782535}
-
kylechar authored
The DCHECKs that |exposed_pixels_| is smaller than the client area doesn't hold when restoring a minimized content_shell window. On restore the height of the window gets larger but the height of the client area shrinks a bit. Since the height of the window was almost zero before being restored exposed_pixels_.height() > cr.bottom and the DCHECK fails. I believe this is because content_shell lets Windows draw the title bar, so it is non-client area, and the title bar wasn't drawn when the window was minimized. It doesn't seem problematic that area to be filled is potentially larger than the client area, since FillRect() is already clipped by ps.rcPaint. HwndMessageHandler also tells the delegate to repaint everything in ps.rcPaint immediately the fill. As such, removing the DCHECKs seems safe. Trying to account for window frame size changes would add more complexity with no clear benefit. Bug: 1084625 Change-Id: Ibb7966e5780d4d221d2b4e8fbb82eb5e37aa93b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267501 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#782534}
-
Fredrik Söderqvist authored
This setting has not been doing anything since 0f40bb89. Before that it would force image orientation to be applied on <img> elements. Bug: 158753 Change-Id: Ic8e77f728bbb478c83469399b01abbd1e83cf02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264332Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#782533}
-
Daniel Cheng authored
Change-Id: I91ca4da65c8a3bdad31f8feff122d13467e72261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253463Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
