- 11 Dec, 2020 40 commits
-
-
Sreeja Kamishetty authored
This reverts commit 583f52a3. Reason for revert: Following browser_tests failing on Linux MSAN bot All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToMatchingEntryStreaming/1 All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToNonMatchingEntryStreamingCancels/1 More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26573/overview Original change's description: > Search Prefetch Streaming requests can be cancelled after headers > > The goal of this CL is to allow unneeded requests to be cancelled > when they are unlikely to be navigated to. This is achieved through > a few avenues of change: > > -- When the user navigates to something in omnibox, the URL is reported > to Search Prefetch Service to be able to mark it as likely to be served > (using kCanBeServedAndUserClicked when the request is kCanBeServed). > This occurs before the omnibox is closed and all results are wiped. > -- kCanBeServed are wiped when omnibox closes. > -- Streaming requests will no longer pause the mojo channel, so they can > witness the Complete event to be able to make the request as complete. > -- As part of above, we store the response body in memory instead of > just handing off the data pipe. Data pipes have a 500k data limit, which > search requests typically go over. Net won't send the complete event > until all data is in the pipe. Therefore we store the data and create a > pipe to navigation if needed. > -- Full body implementation now reports kComplete where it used to > report kCanBeServed. > > Bug: 1156325 > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835897} TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I130213d5d9d72641b12be31192f51461957cd15b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584426Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836038}
-
David Van Cleve authored
Downside of writing comments in strings: Tricium doesn't catch typos! TBR=csharrison@chromium.org Change-Id: I06aa20fb9369f0e6d5ef43e9a3cae3a5b8d27934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586316Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836037}
-
Satoshi Niwa authored
Design doc : go/arc-project-quota BUG=b:171847983 TEST=Check if valid value is returned Change-Id: I808fa4d5da78858a7f7d7266c7caf08fee21e579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546503Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#836036}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d774788..59248a61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1436d7dcb42e75cef95cf5e3b72240600a931119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586015Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836035}
-
Marc Treib authored
- Remove getNumberOfSyncedDevices which was unused. - Merge init() into the constructor. - Add a few comments/TODOs where the Java PSS still diverges from the native version. - Add warning comments to some potentially dangerous methods (notably getChosenDataTypes and getPreferredDataTypes). - Mark getPreferredDataTypes as deprecated. Its only usage was an error (see crbug.com/1157046). Bug: 1135552 Change-Id: I8d0d1e8165086ef6af498a2010a887ba25ae7efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582083Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#836034}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/19bfdf4583d4..fea01bf21b37 2020-12-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic1e54ef858ca01fd3b9db23dfd263898f36a5779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836033}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607612331-9abd6632cfb32a4e513da1b46025c0e77c15ae02.profdata to chrome-win64-master-1607644656-7adc1a9108854fa8e662531b0c0fa8127d30765c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ec17bcc877d146aa1f601679a9e6c4c65857718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586561Reviewed-by:
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachineDelegate to signin.ui target. Bug: 1155132 Change-Id: Icea2dc2f77573d55e6cccfe8e7a73e425871995a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582325Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836031}
-
Ramin Halavati authored
Extensions will be disabled in the first experiments of ephemeral Guest profiles. WebStore private APIs are updated to treat ephemeral Guest profiles similar to the off the record ones. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: If4b4711d133f8e429b2ced09fdf6747cb0c31491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580805Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#836030}
-
Noel Gordon authored
Add PopulateLoadTimeData helper to setup files app load time data. Add CreateTrustedAppDataSource to add trusted resources and load time data and initialise security policy for the metadata Shared Worker. Bug: 1113981 Change-Id: Ic507af120de1a8c8ff19429bcfe864291a0f2a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586637 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836029}
-
Hirokazu Honda authored
No existing ChromeOS arm device supports non 8 bit stream decoding. VaapiVideoDecodeAccelerator implementation doesn't support non 8 bit stream decoding. We have relied on underlying implementations (e.g. drivers and firmware) to filter non 8 bit streams. AcceleratedVideoDecoder has a getter function for the bit depth of an input stream. This CL filters out non 8 bit streams in chrome by calling the getter function. Bug: b:174798524 Test: video_decode_accelerator_tests test-25fps.vp9_2 on scarlet and atlas Change-Id: I9071649740cd0ddab889887f09cabf598d38ec09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576298 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836028}
-
Jan Wilken Dörrie authored
This change removes the PRESUBMIT check for NULL, since it is rendered obsolete by the modernize-use-nullptr clang-tidy checked introduced in r709137. The latter check produces less false positives, since it only runs on changed lines, rather than across changed files. Bug: None Change-Id: I0ee29c95e1e53a6f421377932a85edff1466b6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584162 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836027}
-
Leo Lai authored
We are replacing tpm status APis by cryptohome with tpm manager service. Though the change to the workflow is implemented UserSessionManager is supposed to operate almost the same way, before and after this CL. Below the behavioral changes are highlighted: 1. TpmIsBeingOwned is removed as a factor from the state machine. TpmIsBeingOwned is no longer supported and always returns `false` now. Removing it is a trivial change. 2. As for execution order, `PrepareFinalizeProfile()` is separated totally from the preparation of TPM device. The justification comes from the fact that `CryptohomeClient::CanAttemptOwnership()` only triggers TPM initialization by tpm manager w/o waiting for it to complete; it doesn't make sense to just wait for a trigger w/o checking its result. Clearing owner password is in best effort and the result is not checked even in cases where any remaining owner password dependencies stops the password from being cleared. 3. TPM status checking is made asynchronous after this CL to make sure UI thread doesn't get blocked. 4. Upon failure of calling tpm_manager, `DCHECK` is replaced by logging error message. It doesn't make sense to just crash upon the error, and in production it doesn't make any difference anyway. BUG=b:172748724 BUG=b:172775884 TEST=unit_tests (filter: *UserSessionManager*) TEST=browser_tests (filter: *ExistingUserController*) TEST=asan + msan builder trybot passes. TEST= perform first login, check if the password exists/gets wiped before/after the login. Change-Id: I66c5ef3faae8c78d9f2cb304ccf59ca7a8f80c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560087 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#836026}
-
Frédéric Wang authored
According to [1], URLs whose scheme is "data" should be treated as potentially trustworthy. This CL performs the change to align with the specification and remove unnecessary special handling in various places of the code. This CL does not contain significant behavioral changes, and has no web-facing API changes. However, an intent email has been sent [2] and a chromestatus page created [3]. Owners of the files from which network::IsUrlPotentiallyTrustworthy is called were informed and indicated the change is fine: - NetworkFetcherImpl::DownloadToFile: Not exposed to the web at all. Used by an automated software updater which checks with a hardcoded Google endpoint for updates to certain Chrome modules. - IdpNetworkRequestManager::Create: This code has been implemented recently and is not released yet. - content_security_policy.cc's UpgradeInsecureRequest: already exits early for non-HTTP schemes. - security state's GetSecurityLevel: already exits early for data scheme. - password_manager_ios_util.mm: data URLs are not supported on other platforms so it should be excluded on iOS too. This is already the case since only localhost hosts, file: and cryptographic schemes returns true. - CookieChangeSubscription, CookieAccessDelegateImpl: should be fine because code excludes data schemes (on non-iOS platforms) as well as opaque origins (like data:). Moreover, data: doesn't go over http. - InsecureInputTabHelper: used to include data schemes in the past [4], uploaded [5] to preserve current behavior. - sec_header_helpers.cc: Only matters for HTTP requests. - TouchToFillController: Removed in [6]. - RemoteCopyMessageHandler::HandleImage: This is guarded by IsImageSourceAllowed. kRemoteCopyAllowedOrigins, defaults to "https://googleusercontent.com" and having a real use case where someone adds a "data:" host seems unlikely. [1] https://w3c.github.io/webappsec-secure-contexts/#potentially-trustworthy-url [2] https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/Hb1-VLwq54Y [3] https://chromestatus.com/feature/5634194258526208 [4] https://chromium-review.googlesource.com/c/chromium/src/+/1986072 [5] https://chromium-review.googlesource.com/c/chromium/src/+/2580067 [6] https://chromium-review.googlesource.com/c/chromium/src/+/2574743 Bug: 1119740, 1153336 Change-Id: I4db1b71ab0dc4d7a0635e8524a3757dc4388edf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563683Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#836025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/311cd5bfef93..dd549ceda1d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858 Tbr: calamity@google.com Change-Id: I9146e60e5c4caf083d12fc0bc2edb8a06aea9799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586773Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836024}
-
Danan S authored
- Add Family Management scope - Remove scopes irrelevant to EDU Coexistence Bug: 1157119 Change-Id: I0964a956aefa0d7361f10946c42aa0ba9da3aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581884 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#836023}
-
Tal Pressman authored
MojoBindingContext encapsulates the necessary information for binding Mojo interfaces, enabling parts of platform/ that provide them to associate the interfaces with the correct context(e.g., ExecutionContext). The CL also uses the MojoBindingContext to convert the FileUtilitiesHost interface to be associated with an ExecutionContext. Change-Id: Ia89cdfb728a9b5473478df2abceb68ce60d9564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575304Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#836022}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8e3a4ab1fe23..5a9d7eaa74ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I878ce51479ab25304cc6679c88da5a9d4cdd2937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586754Reviewed-by:
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I13dcc051e303800bf993bf4d5a372ef366adefb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585958 Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
-
Daniel Cheng authored
This is a problem even without RenderDocument. Bug: 1148793 Change-Id: Ia8e3dd7a78c07a512ad9d862b3f6fca61866b272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561790 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836019}
-
Lei Gao authored
When invoking MediaPlayer's setDataSource() API, cookies may not retrieved. In some case the media will playback failed if the required cookies absent. This CL will check whether the cookies are retrieved before call this API. API call will be pending until cookies retrieved. Bug: 1157376 Change-Id: I43f04461af86c83e53a169bb4df35cbe20419b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584203 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#836018}
-
Maxim Kolosovskiy authored
Reason: the launch was deferred. Bug: 1153757, 1095627 Change-Id: I7d0bf7257a721c0be9e46d7f0706d8985df50637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584022 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836017}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9912971cf9b3..c75473c2cf88 2020-12-11 cclao@google.com Vulkan: Generalize FlipRotationSpecConst to SpecializationConstant 2020-12-10 courtneygo@google.com Vulkan: clean up comments, rename per request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I39373fcc2836421bb72fee250787427ddce3ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586565Reviewed-by:
-
Min Qin authored
experiments Change-Id: Id60801cab5eac50f90819b88bfe82f3699aca9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578870Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836015}
-
Zhi An Ng authored
We have: 1. kExperimentalWebAssemblyFeatures, and 2. kEnableExperimentalWebPlatformFeatures Currently, both of them will turn on Wasm SIMD and Threads. This is slightly confusing. Change it so that only 1 will turn on these Wasm features. (Turning on the feature specific flag will continue to turn on these flags.) Bug: chromium:1149796 Change-Id: I46c9a0daf248b07333a67fe3816bb3f1981b28de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583583Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836014}
-
Eric Willigers authored
We use a bool g_skip_copying_for_testing, instead of a pointer to a member function. Suggested by loyso@ in https://chromium-review.googlesource.com/c/chromium/src/+/2581704 Bug: 1153215 Change-Id: I8f34eefe9edc9bbb3e8c39a6ff3061bb0529aeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586446 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#836013}
-
Luciano Pacheco authored
Change SWA main.js to wait for the fakes to load before loading the Files app legacy UI. Bug: 1113981 Change-Id: I56da89ee49b4512066e2533b967da99cfb758032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586498 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#836012}
-
Yuki Shiino authored
Through a discussion, we concluded that it's more practically important and effective to follow the naming convention than giving the exactly unique names because the possibiliy of name conflicts is considered really low. Changes the names accordingly. Bug: 839389 Change-Id: Ie0463e05ed2579f125ec9f041dd9f501588460e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585244Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#836011}
-
Luciano Pacheco authored
Files: - //u/f/base/error_counter.js - //u/f/f/f/j/metadata/mock_metadata.js - //u/f/f/f/j/metadata/thumbnail_model.js - //u/f/f/f/j/metadata/thumbnail_model_unittest.js Bug: 1133186 Change-Id: If544f64be1ae9f2c8ba69189fc0345a8ee57d99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583594 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836010}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4324.9-1606733211-benchmark-89.0.4339.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4343.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I01fca1bcb9602441e5282f5de2e6175249f06a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585963 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic902c12f471dc4f6e4e1559e5a15afb120151c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586557Reviewed-by:
-
Frank Tang authored
Sync w/ https://github.com/whatwg/html/pull/3047 Bug: 1144403 Change-Id: I67694714ee5799e2e731b4d0534a7c182871fc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574533Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836007}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ic07d5a810cb03b70813940efe87d83e33791e6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585249 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
A framerate change test case fails if kepler is used. A rate controller exists in a firmware in kepler and the kepler driver implementation delegates the framerate to the firmware. Since kepler is released long time ago, it is hard to ask the vendor to fix the rate controller. Hence, we skip the test case when kepler is used in order to get a green dashboard. Additionally, we don't support dmabuf input frame in kepler. The test case is also skipped by this CL. Bug: b:170790027 Test: video_encode_accelerator_tests on atlas and rikku Change-Id: I4a2a85eaba840656665b54486db65ed58214b64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532140 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#836005}
-
Jérémie Boulic authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2579932 For the non-js module version, the `importer` variable still potentially has to be declared. Bug: 1133186 Change-Id: Ie5bd2e9bff24608238dc2eb2062b809f4723c719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae492241ec80..311cd5bfef93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858,chromium:1156346,chromium:790886 Tbr: calamity@google.com Change-Id: I4733d7ad2057ae99088a1d24c21c12e1e875a8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586673Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b5da31f17214..19bfdf4583d4 2020-12-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifbb2034ec0b0f7efda945ff44cd532d71e22864d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586562Reviewed-by:
-
Melissa Zhang authored
This CL was originally reverted due to a heap-use-after-free error in Linux Chrome OS asan builder. The error occurred in SharesheetServiceDelegate where is_bubble_open_ was set to false after the object had already been deleted in the previous line. (OnBubbleClosed). This has been removed and a comment added such that this error will not be made again. SharesheetBubbleViewBrowserTest has also been updated to be more robust. Original CL: https://crrev.com/c/2563010 Bug: 1155058 Change-Id: I1cb15e2218999f9d027b2f5368ec6ce8d95d53ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573697Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836001}
-
Trent Apted authored
This better mimics a "real" orientation in a file, so that other layers between can do their own header machinations. Bug: 1145029 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I45e6174d1ef49ac207965680fbbaa48155d91a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581631Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f83a0f03ccf4..5a9d7eaa74ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idadb7e0c2596ab3d950acdb3d541ea90bc1bf673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586655Reviewed-by:
-
