GitLab

Revert of Aura on Android: Remove unnecessary dependencies on ui/android. (patchset #6 id:100001 of https://codereview.chromium.org/1460633005/ )

Reason for revert:
Reverting, since Android Aura has been cancelled.

Original issue's description:
> Aura on Android:Remove unnecessary dependencies on ui/android.
>
> BUG=NONE
>
> Committed: https://crrev.com/d2ff47131f1a53a712adf860275a2f7320d9da9f
> Cr-Commit-Position: refs/heads/master@{#360835}

TBR=sievers@chromium.org,moshayedi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=NONE

Review URL: https://codereview.chromium.org/1646693002

Cr-Commit-Position: refs/heads/master@{#371928}

https://chromium.googlesource.com/skia.git/+log/9ce4110a29b0..bbb6dc80fdfe

$ git log 9ce4110a2..bbb6dc80f --date=short --no-merges --format='%ad %ae %s'
2016-01-27 mtklein kill SkValue
2016-01-27 mtklein sketch hooking into PNG_FILTER_OPTIMIZATIONS

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1646713002

Cr-Commit-Position: refs/heads/master@{#371927}

Too many per-file rules with the addition of files like
icon_with_badge_image_source.*.  Substitute them for a comment in the file.

BUG=None

Review URL: https://codereview.chromium.org/1645683002

Cr-Commit-Position: refs/heads/master@{#371926}

This CL adds a flag in GPU capabilities that represents if the
extension CHROMIUM_ycbcr_420v_image is available.

BUG=524582

Review URL: https://codereview.chromium.org/1636123002

Cr-Commit-Position: refs/heads/master@{#371925}

This is a speculative fix for crashes observed under the
--isolate-extensions trial. A RenderWidgetHostViewGuest currently only
clears its RenderWidgetHostInputEventRouter entry when the BrowserPlugin
is detached. However, there are other paths for destruction that cause
detachment, which might enable it to receive input events after
DestroyGuestView() has been called, potentially leading to the
observed null pointer crashes. This should be avoided by calling
UnregisterSurfaceNamespaceId() before clearing the host_ pointer.

BUG=571092
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1642743002

Cr-Commit-Position: refs/heads/master@{#371924}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/778c5a60..497b8970

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1647673002

Cr-Commit-Position: refs/heads/master@{#371923}

Requests are not sorted by Method in network panel of DevTools.

BUG=581313

Review URL: https://codereview.chromium.org/1641633002

Cr-Commit-Position: refs/heads/master@{#371922}

BUG=516825

Review URL: https://codereview.chromium.org/1587723007

Cr-Commit-Position: refs/heads/master@{#371921}

In the ozone drm platform, the ChannelObserver watches for changes
on the IPC channel. However, ozone/drm will soon support execute in
an in-process mode for MUS and the existing multi-process mode.
Rename the class to reflect this.

BUG=558602

Review URL: https://codereview.chromium.org/1603213002

Cr-Commit-Position: refs/heads/master@{#371920}

Without this flag InspectorFrontendHost can call callbacks while devtools on pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1639973003

Cr-Commit-Position: refs/heads/master@{#371919}

Revert of Introduce AndroidFocusRules and NativeWidgetAndroid (patchset #13 id:560001 of https://codereview.chromium.org/1403293003/ )

Reason for revert:
Reverting the CL as the Android Aura project has been cancelled.

Also removing menu_config_android.cc which was added in https://codereview.chromium.org/1477253002.

Original issue's description:
> Introduce AndroidFocusRules and NativeWidgetAndroid
>
> NativeWidgetAndroidis very similar to NativeWidgetAura. It
> owns a WindowTreeHost and FocusController which initialized
> from AndroidFocusRules. Aura on Android should use this
> native widget for top level windows. It should create and host
> the Widget in a native Android window.
>
> BUG=507792
>
> Committed: https://crrev.com/31db6ee3532c748f40d2ae00514b5d91031d78e7
> Cr-Commit-Position: refs/heads/master@{#360645}

TBR=sadrul@chromium.org,sky@chromium.org,bshe@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=507792

Review URL: https://codereview.chromium.org/1639003002

Cr-Commit-Position: refs/heads/master@{#371918}

This patch is another effort to make Character::isCJKIdeographOrSymbol
faster.

The previous CL[1] made it faster by ~90% for codepoints below U+2020,
but codepoints abvoe U+2020 were not as fast. This CL makes all
codepoints faster, as fast as ICU functions.

      Before  After Improve ICU
All    2569 => 292    88%   298
ASCII    68 =>  68     0%   160
Han    2958 => 263    91%   344
Hira    258 =>  11    95%    14
Arabic   37 =>  32    13%    44
* # of code points and iterations vary by rows.

The previous CL[1] clarified that binary search is not as fast as ICU
functions such as uscript_getScript(). This patch changes to use
UTrie2, which is the data structure ICU property functions use.

In addition in this patch:
* U+2763 and U+2764 are added as requested by drott@.
* Character::isUprightInMixedVertical() was switched to UTrie2 too.
* Character::isCJKIdeograph() was removed because it is no longer used.

[1] https://codereview.chromium.org/1545073002

BUG=571943

Review URL: https://codereview.chromium.org/1541393003

Cr-Commit-Position: refs/heads/master@{#371917}

BUG=chromedriver:1249

Review URL: https://codereview.chromium.org/1642773002

Cr-Commit-Position: refs/heads/master@{#371916}

This way clients won't need to wait for OnEmbed() before they can
start using windowtree. This also better isolates the apps.

I haven't updated the client lib to take advantage of this. I will do
that next.

BUG=566155
TEST=covered by tests

Review URL: https://codereview.chromium.org/1639223003

Cr-Commit-Position: refs/heads/master@{#371915}

Remove ScrollBlocksOn from ScrollTree:
It will be moved from the code base soon, will work
to integrate the "passive event handler" if that
depends on layer tree hierarchy.

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1626513003

Cr-Commit-Position: refs/heads/master@{#371914}

Return true from ShouldDescendIntoChildForEventHandling so
sub surface events are generated relative to the sub surface
rather than the top level shell surface.

BUG=549781
TEST=exo_unittests --gtest_filter=PointerTest.OnPointerMotion

Review URL: https://codereview.chromium.org/1641773004

Cr-Commit-Position: refs/heads/master@{#371913}

BUG=478864
nopresubmit=true

Review URL: https://codereview.chromium.org/1645773002

Cr-Commit-Position: refs/heads/master@{#371912}

  Install the extension right away (no chrome restart).

For registry changes, we only look at 32-bit registry values
for extensions, see
https://developer.chrome.com/extensions/external_extensions#registry

A lot of the changes in this CL is to make ExternalProvider-s be
  able to discover new external extensions at times other than
  chrome start up. The added method is
  OnExternalProviderUpdateComplete(), which provides a list of
  a. Extensions that were added via update_url,
  b. Extensions that were added via crx,
  c. Extensions that were removed.

BUG=581756
Test=While chrome is running, add a registry entry for an extension
under HKLM or HKCU as described in
https://developer.chrome.com/extensions/external_extensions#registry

Now observe that external install would appear for that extension
in chrome shortly.

If you had some extension installed this way, removing the registry
entry would cause the extension to be uninstalled too!

Review URL: https://codereview.chromium.org/1495403002

Cr-Commit-Position: refs/heads/master@{#371911}

mirroring https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/BUILD.gn&l=53

BUG=581707
NOTRY=true
NOTREECHECKS=true
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1648503002

Cr-Commit-Position: refs/heads/master@{#371910}

One of the Client Hints tests contained an outdated comment about mutation
related issue that was since solved, as well as a workaround for that issue.

This CL removes the comment and makes sure that the test doesn't work around
that no-longer-relevant bug.

BUG=

Review URL: https://codereview.chromium.org/1644503002

Cr-Commit-Position: refs/heads/master@{#371909}

CookieMonster tests post a
base::MessageLoop::QuitWhenIdleClosure task which
could be run at the start of some other test, since
the unit tests are invoked in the same fixture on
Android. This CL converts these CookieMonster tests
to use base::RunLoop so they don't influence other
tests.

BUG=568282

Review URL: https://codereview.chromium.org/1634803004

Cr-Commit-Position: refs/heads/master@{#371908}

This CL mostly implements the sync confirmation dialog that is shown at
the end of the tab modal signin flow described in the associated bug. It
allows the user to make an explicit decision about starting sync before
it's started and before sign in is completed.

TEST=
1. Enable the --enable-password-separated-signin-flow flag in
   chrome://flags and restart Chrome
2. In a non-signed in Chrome Profile, select "Sign in to Chrome" from
   the User Menu.
3. Enter valid credentials to sign in to Chrome, the sign in window
   should close and the sync confirmation window should be shown
4. From that window, clicking "Got it" should close the window and leave
   the user signed in with sync started. Clicking "Undo" should close
   the window and leave the user signed out with sync not started.

BUG=533004

Review URL: https://codereview.chromium.org/1487283005

Cr-Commit-Position: refs/heads/master@{#371907}

Profile::IsOffTheRecord() surprisingly does not imply incognito; it also covers guest profiles.

BUG=none

Review URL: https://codereview.chromium.org/1638063003

Cr-Commit-Position: refs/heads/master@{#371906}

This is a companion to https://codereview.chromium.org/1645633003/ (Hide SkPixelXorXfermode from Chrome)

Review URL: https://codereview.chromium.org/1644703002

Cr-Commit-Position: refs/heads/master@{#371905}

skia::ImageOperations::Resize needs pixels, and we were passing dp.

Also, ignore the icon size key and just use the icon size itself. This fixes a bug (evidenced again by Shoptagr) where an icon size such as

"19": "icons/19.png"  // 19.png is actually 50x50

would be scaled incorrectly. At this point, the API should take a list rather than a dict, but it's probably not possible to change that and maintain backcompat.

BUG=581232
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1637763002

Cr-Commit-Position: refs/heads/master@{#371904}

Alt-Svc is currently disabled in Cronet (in
components/cronet/android/*url_request_context_adapter.cc), until this feature
is thorougly tested in Chromium.  It should also be disabled in Crnet.

Review URL: https://codereview.chromium.org/1643463004

Cr-Commit-Position: refs/heads/master@{#371903}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fd3f2b38d1fb..8283c4a90352

$ git log fd3f2b38d..8283c4a90 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1641773003

Cr-Commit-Position: refs/heads/master@{#371902}

Revert of Aura on Android: Fix link errors when building content_unittests_apk. (patchset #1 id:1 of https://codereview.chromium.org/1466463004/ )

Reason for revert:
Reverting, since Android Aura has been cancelled

Original issue's description:
> Aura on Android: Fix link errors when building content_unittests_apk.
>
> * Do ui::RegisterUIAndroidJni() only when not using Aura.
> * Exclude desktop_aura from the build.
>
> BUG=507792
>
> Committed: https://crrev.com/ce62351f189643118e9d09bf06e128b75345ef36
> Cr-Commit-Position: refs/heads/master@{#360942}

TBR=sievers@chromium.org,sadrul@chromium.org,bshe@chromium.org,moshayedi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=507792

Review URL: https://codereview.chromium.org/1647663002

Cr-Commit-Position: refs/heads/master@{#371901}

https://chromium.googlesource.com/skia.git/+log/2bbc343c1482..9ce4110a29b0

$ git log 2bbc343c1..9ce4110a2 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 jcgregorio skiaserve: Enable /cmd endpoint.
2016-01-27 msarett Revert of Consolidate SkStream copying methods (patchset #1 id:1 of https://codereview.chromium.org/1640793002/ )
2016-01-27 msarett Suppress jpeg valgrind errors
2016-01-27 jcgregorio skiaserve: Set 303 status code on redirect.
2016-01-27 kjlubick Make fuzz output the words success for a 'clean exit'
2016-01-27 joshualitt Wire up JsonCanvas in skiaserve
2016-01-27 scroggo Consolidate SkStream copying methods

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1643743002

Cr-Commit-Position: refs/heads/master@{#371900}

Notification snackbars are low-priority snackbars that are stored in a
queue, contrary to tranditional "action" snackbars that ought to be
shown immediately and are stored in a stack.

When a queue snackbar is showing, a stack snackbar can always kick in
and override the snackbar; however when a stack snackbar is showing, a
queue snackbar will wait till the stack is cleared.

Queue snackbars are not dismissed in batch; instead, they will be shown
one by one, in FIFO order.

BUG=579347

Review URL: https://codereview.chromium.org/1635753002

Cr-Commit-Position: refs/heads/master@{#371899}

This is a first part of the fix for 573120. When Begin/End
are called again for a completed query that already has an
instance of GLFenceNV, the existing GLFenceNV instance is
reused rather than creating a new one.
For each frame that saves one call to glGenFencesNV and
one call to glDeleteFencesNV .
My estimation is that that saves about 0.2 Wt when playing
1080p @ 60Hz h.264 content.

The second part of the fix will add reusing instances of
CommandsCompletedQuery.

BUG=573120

Review URL: https://codereview.chromium.org/1637293002

Cr-Commit-Position: refs/heads/master@{#371898}

BUG=543161,561867

Review URL: https://codereview.chromium.org/1640503003

Cr-Commit-Position: refs/heads/master@{#371897}

Layout Tests dump page contents (to compare against expected results).
The dump can include frame contents (i.e. dump as text, dump as markup,
dump scroll positions with extra flavors like dump as printed, dump line
box trees, etc.).  Since renderer process is (for security / by design)
not able to see frame contents of remote frames, it means that old
Layout Tests code is not able to dump frame contents when site isolation
is enabled (i.e. when running with --additional-drt-flag=--site-per-process).

This CL is a step toward making layout tests compatible with site
isolation.  After this CL, if recursing over all frames is required,
then BlinkTestRunner::CaptureDump will ask the browser process for
stiching together the frame contents, before continuing with the other
dump flavors in BlinkTestRunner::OnLayoutDumpCompleted.

The above means testRunner.notifyDone() might no longer perform dumps
synchronously.  This is okay, because:

  - The dumps were already performed asynchronously in some cases:
    - pixel dumps (i.e. see how dumping is resumed after
      BlinkTestRunner::CaptureDumpPixels aka OnPixelsDumpCompleted),
    - ShouldDumpBackForwardList (i.e. see how dumping is resumed after
      BlinkTestRunner::OnSessionHistory),
    - the case where notifyDone is called from a secondary window (i.e.
      see how BlinkTestRunner::TestFinished asks the browser to continue
      in the main window).

  - The synchronous dumps are still performed if the test didn't ask for
    recursing over all the frames.  Retaining the synchronous behavior
    in this case is needed, because in some tests the dump is captured
    while the frame is being detached (and would no longer be present
    after an extra hop to the browser process).

This CL doesn't affect the following dump modes (which for now remain
potentially incompatible with OOPIFs): dump as audio, dump as custom
text, dump pixels, dump back/forward list).  Additionally, setting and
reading of dump modes is done in a renderer process (which can be
incompatible with OOPIFs when testRunner.dumpAsText() and
testRunner.notifyDone() are called in cross-site frames running in
different renderer processes).

BUG=477150
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1589643003

Cr-Commit-Position: refs/heads/master@{#371896}

BUG=551522
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect

Review URL: https://codereview.chromium.org/1641833002

Cr-Commit-Position: refs/heads/master@{#371895}

MenuMessagePumpDispatcher is used on Windows to handle keyboard events
and some other events in menu message loops. In order to have fully
async menus, we need to get rid of it. Instead, we can use
MenuKeyEventHandler which is used on Chrome OS and Linux with some
modifications. Following are messages that are handled in
MenuMessagePumpDispatcher and how they can be handled after removing
this class:

 - WM_KEYDOWN: This will be handled in MenuKeyEventHandler::OnKeyEvent.

 - WM_CHAR: This is used to handle "translated" characters for mnemonics
   according to the active keyboard layout. We can achieve this in
   MenuKeyEventHandler by using event->GetCharacter() instead of
   ui::DomCodeToUsLayoutCharacter().

 - WM_SYSKEYDOWN: This happens when Alt or F10 keys are pressed
   (according to MSDN). We can handle these keys in MenuKeyEventHandler.

 - WM_CANCELMODE: This is already handled in
   ActivationChangeObserverImpl::OnCancelMode() which is used in
   MenuMessageLoopAura.

BUG=564255,566019

Review URL: https://codereview.chromium.org/1625313002

Cr-Commit-Position: refs/heads/master@{#371894}

BUG=141518

Review URL: https://codereview.chromium.org/1645723002

Cr-Commit-Position: refs/heads/master@{#371893}

Crash occurs because we are referencing a member variable left_button_down_on_caption_ after the DefWindowProc call for WM_NCLBUTTONDOWN, which could destroy the window and in
turn the HWNDMessageHandler instance.

Fix is to reset the left_button_down_on_caption_ member before the DefWindowProc call.

BUG=581341
TEST=Covered by views_unittest WidgetTest.DestroyInSysCommandNCLButtonDownOnCaption

Review URL: https://codereview.chromium.org/1636183003

Cr-Commit-Position: refs/heads/master@{#371892}

This is a resubmission of https://codereview.chromium.org/1631313002/.
Since then, the //device/serial dependencies have been fixed.

This tool will also be used by the Chromium trace controller to find
any connected BattOrs.

TBR=zhenw@chromium.org,sky@chromium.org
BUG=542837

Review URL: https://codereview.chromium.org/1642763002

Cr-Commit-Position: refs/heads/master@{#371891}

Summary of changes:
1. Fails QUnit.test() it doesn't return within 5 seconds.
   Timing dependent tests should use fake timers instead.
2. Adds an option to disable the timeout when debugging failed tests
   locally.
3. Logs the current test to the console to ease debugging.

NOTRY=true

Trybots failing on tests that has already been deleted.

Review URL: https://codereview.chromium.org/1638753003

Cr-Commit-Position: refs/heads/master@{#371890}

This is a precurser to deleting tools/telemetry so we don't break the perf
presubmit when that lands.

BUG=478864

Review URL: https://codereview.chromium.org/1646653002

Cr-Commit-Position: refs/heads/master@{#371889}