GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284294 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178454:178494&mode=html
TBR=abarth@chromium.org,johnme@chromium.org
BUG=

Review URL: https://codereview.chromium.org/405433012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284293 0039d316-1c4b-4281-b951-d872f2087c98

On the Settings page, when you change a slider (input type="range") by
touch, we don't save the associated preference.

Listen to touchend and touchcancel, and add a test for this.

BUG=394938
R=estade@chromium.org

Review URL: https://codereview.chromium.org/400993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284292 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284291 0039d316-1c4b-4281-b951-d872f2087c98

b72977f  Build with exceptions enabled on Windows too.
98a44a1  Fix the potential integer overflow from "offset + size".
5ffacd6  Fix bounds checking in CJS_PublicMethods::MakeRegularDate().

BUG=393831,382667
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/401883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284290 0039d316-1c4b-4281-b951-d872f2087c98

Seeing this almost certainly indicates a bug in the "user's" code.
Arguably, this should be a MOJO_DCHECK instead, but I'm keeping it as a
MOJO_CHECK since it'll make tests crash-fail on bots instead of hanging
(and then timing out).

(We'll see this failure due to the bugs listed below.)

R=yzshen@chromium.org
BUG=394884,394886

Review URL: https://codereview.chromium.org/401963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382931
R=mark@chromium.org

Review URL: https://codereview.chromium.org/404893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284288 0039d316-1c4b-4281-b951-d872f2087c98

This is intended to add personell who can do harfbuzz rolls
when needed. Bashi and I mostly did them recently, we should be able 
to commit them after review.

R=eae,eseidel,behdad
BUG=

Review URL: https://codereview.chromium.org/407583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284287 0039d316-1c4b-4281-b951-d872f2087c98

This fix changes representation of some disabled datatypes on about:sync page.
There are two special cases supported by this fix:
1) When a datatype needs to be disabled due to configuration constraints,
   for example, when sync to need to disable delete directives when
   encryption is enabled.
2) When a datatype isn't ready to start yet (was disabled with
   SyncError::UNREADY_ERROR).

To implement the fix, SyncError class was extended with severity() property,
which is based on the error type. The purpose of severity is to determine
logging severity of the error and the representation on about:sync page.
Sync errors of UNREADY_ERROR and DATATYPE_POLICY_ERROR types are logged with
LOG_INFO level rather than LOG_ERROR. In the UI errors of these types are
displayed on gray background rather than red.

DATATYPE_POLICY_ERROR is a new error type used for a few cases when a type
is disabled by policy (i.e. configuration constraints). Other than its
severity it is treated the same as DATATYPE_ERROR.

I added an overload for DisableDatatype function which allows to specify
an error type. By default, the error type is DATATYPE_ERROR which is
consistent with the current implementation.

BUG=380446,392110

Review URL: https://codereview.chromium.org/388003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284286 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284285 0039d316-1c4b-4281-b951-d872f2087c98

This roll:
- Allows libwebm to build using clang-cl.
- Allows removal of a workaround from libwebm's BUILD.gn.

R=thakis

Review URL: https://codereview.chromium.org/403063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284284 0039d316-1c4b-4281-b951-d872f2087c98

Preivously we relied on the SyncBackendRegistrar's last configured types to
decide which types have been recently disabled. Now we just purge all disabled
types that exist in the directory, as recorded by their progress markers (which
should never be deleted unless the type has been purged).

BUG=386778

Review URL: https://codereview.chromium.org/398813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284283 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284281 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/400303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/408493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284279 0039d316-1c4b-4281-b951-d872f2087c98

Expose enabling and disabling record whole document behavior as a public
webview api. The default is still record whole document for
compatibility.

BUG=390702

Review URL: https://codereview.chromium.org/406683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284278 0039d316-1c4b-4281-b951-d872f2087c98

We use experimental app-list view for centered layout, and then
use athena's own view for bottom view.

BUG=387227
R=oshima@chromium.org, sadrul@chromium.org, xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/397343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284275 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/408543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395187
TBR=erikchen@chromium.org

> mac: Load the system hotkeys after launch.
>
> Shortly after launch, the system hotkeys are loaded and parsed. If a hotkey is
> reserved by the system, it is not passed to the renderer. This allows system
> hotkeys like (cmd + `) to work even if a flash plugin is selected.
>
> Add a histogram to ensure that the system hotkey plist is being correctly
> loaded and parsed.
>
> BUG=383558
> TEST=Open 2 Chrome windows. Navigate one to www.twitch.tv. The site should
> include a flash plugin that automatically starts playing a video. Select the
> flash plugin. The hotkey combination (cmd + `) should switch between the open
> windows. The hotkey combination (cmd + L) should have no effect (it is a Chrome
> hotkey, not a browser hotkey).
>
> Review URL: https://codereview.chromium.org/370293004

Review URL: https://codereview.chromium.org/406693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284273 0039d316-1c4b-4281-b951-d872f2087c98

I think someone added a usage of athena_resources after I did the patch
and then I missed this on rebase.

BUG=None
TEST=None
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/405753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284271 0039d316-1c4b-4281-b951-d872f2087c98

This also goes and changes a lot of "if (obj.get())" to "if (obj)".

BUG=394639

Review URL: https://codereview.chromium.org/405653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284269 0039d316-1c4b-4281-b951-d872f2087c98

That way we free a slot for when we add an athena_resources.grd.

BUG=None
TEST=None
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/404683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284268 0039d316-1c4b-4281-b951-d872f2087c98

Split up the monstrously large platform_crypto_nss.cc, platform_crypto_openssl.cc into multiple files.

-----------
Overview:
-----------

* algorithm_implementation.h:

This defines a base class AlgorithmImplementation, which has virtual methods for synchronous encrypt/decrypt/generatekey. All of the information about an algorithm is now encapsulated by an AlgorithmImplementation. So for instance the JWK specific knowledge, key usages for each key type are pulled into this interface.

* algorithm_registry.cc:

Contains a mapping from WebCryptoAlgorithmID --> AlgorithmImplementation, stored by a singleton.

* algorithm_dispatch.cc:

Given parameters from Blink, looks up the appropriate AlgorithmImplementation in the registry and dispatches the operation. Also implements wrap/unwrap in terms of encrypt/decrypt.

* structured_clone.cc:

Contains the code related to structured cloning (which still needs some cleanup, and is implemented in terms of import/export).

* nss/*, openssl/*:

Contains the AlgorithmImplementation concrete classes for each algorithm.

This reorganization also unintentionally fixes a few bugs.

  * ExportKey() for spki/pkcs8/raw uses the already serialized key data rather than re-exporting
  * Some exception codes were fixed.

BUG=389325,389342,389327,374912
R=jochen@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/379383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284267 0039d316-1c4b-4281-b951-d872f2087c98

Replaces MacSandboxTest.NSSAccess. With this, content_unittest links and this
new test passes (modulo BoringSSL switchover fixes still pending).

BUG=395231

Review URL: https://codereview.chromium.org/400293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276784

Review URL: https://codereview.chromium.org/400013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393750

Review URL: https://codereview.chromium.org/398913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284264 0039d316-1c4b-4281-b951-d872f2087c98

The 'repeat' state of a DOM KeyboardEvent was always false. The
Aura->blink event modifier mapper was not plumbing it through. Do so!

BUG=263724,394907
TEST=document.body.onkeydown=function(e){console.log(e.repeat);};

Review URL: https://codereview.chromium.org/402613010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395183

Review URL: https://codereview.chromium.org/402993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/368733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284259 0039d316-1c4b-4281-b951-d872f2087c98

<code> blocks are sometimes embedded in text so it doesn't 
make sense to always turn into a block.

BUG=383630

Review URL: https://codereview.chromium.org/402963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284258 0039d316-1c4b-4281-b951-d872f2087c98

Update linux-rel and xp size expectations after ICU 52 roll. The size increase was signed off by laforge.

Perf dashboard does not have any other size with regression due to ICU 52
update available even though I expect a similar size increase (140 - 200 kB)
on Linux-rel-64 and Mac.

BUG=132145
TEST=No perf size failures
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/403723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284257 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed.

BUG=308740
R=scottmg@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/404443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284256 0039d316-1c4b-4281-b951-d872f2087c98

Use the same path to get font rendering settings on desktop
Linux and Chrome OS: query the LinuxFontDelegate if it's set
and then query Fontconfig.

Also make the LinuxFontDelegate interface return a
PangoFontDescription directly (as opposed to an opaque
string that's actually a stringified PangoFontDescription)
and make it return a cached FontRenderParams struct instead
of exposing separate methods for looking up individual
properties.

Finally, add a missing build dependency on ui_test_pak, which
is needed to get the default font resource when running
gfx_unittests on Chrome OS.

BUG=125235,393067

Review URL: https://codereview.chromium.org/400193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284255 0039d316-1c4b-4281-b951-d872f2087c98

Adds an InfoBar and a description in Settings to inform users
that they are part of a data reduction proxy field trial. This
trial only includes users that enabled the data reduction proxy.

BUG=383988

Review URL: https://codereview.chromium.org/384853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284254 0039d316-1c4b-4281-b951-d872f2087c98

This CL addresses some feedback from Jamie regarding unit test naming conventions and organizations.
1. Renames test_eventSource.js to base_unittest.js.
2. Groups the modules by class instead of by function.
3. Adds extra test cases for base.js

Review URL: https://codereview.chromium.org/403663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284252 0039d316-1c4b-4281-b951-d872f2087c98

I'm adding signin_scoped_device_id to DeviceInfoSpecifics.
This value is available from SigninClient, the rest of code is to pass
value from syncBackendHostImpl where SigninClient is availble to
SyncedDeviceTracker where value is passed to protobuf.

Also there is small change to how commandline flag is handled.

BUG=382968
R=rlarocque@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284234

Review URL: https://codereview.chromium.org/395013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284251 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284249 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r284079.

BUG=395271

Review URL: https://codereview.chromium.org/406693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284248 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/405523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284246 0039d316-1c4b-4281-b951-d872f2087c98

As functional dependencies on -fsanitize=null are removed for -fsanitize=vptr
(Clang r213393), removing the -fsanitize=null option accordingly.

BUG=174801
R=aarya@google.com

Review URL: https://codereview.chromium.org/402983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284245 0039d316-1c4b-4281-b951-d872f2087c98