- 27 Nov, 2018 40 commits
-
-
Ruslan Burakov authored
Currently there is only one non-standardized statistics "jitterBufferFlushes which will be exposed under the following origin trial: https://docs.google.com/document/d/1stYIZhEmDZ7NJF9gjjsM66eLFJUdc-14a3QutrFbIwI/edit?ts=5bf5535c# However, note that any other non-standardized statistics added later would be also exposed under this origin trial. Bug: chromium:907113 Change-Id: I4036dd1fceae3b68d33f9ae2666a0e2d942fb345 Reviewed-on: https://chromium-review.googlesource.com/c/1344433 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611189}
-
Matt Falkenhagen authored
Because provider hosts can be for workers as well as documents. Also rename UpdateURLs to UpdateUrls for typing ease and alignment with the style guide (acronyms are treated as a normal word). Bug: 908311 Change-Id: Ie4c7edaed41f8d89315a2ae4514880e8b3fdd2b0 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/c/1350422 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611188}
-
Tien Mai authored
- Implements crashpad support for GCPW installer - Implements crashpad support for the actual credential provider dll and runs the crashpad handler directly in the dll as an entry point Bug: 890348 Change-Id: I5b256b4d6ad8ee7153fd22e4d13f1a1791fa6d65 Reviewed-on: https://chromium-review.googlesource.com/c/1344210 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611187}
-
Dave Tapuska authored
API was using 64 bit integers which caused narrowing to access the arrays. Adjust the paint chunk API to use the correct type. BUG=879657 Change-Id: Ibbe16bd43937788fe3a706773826570e0626eb80 Reviewed-on: https://chromium-review.googlesource.com/c/1348989Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611186}
-
David 'Digit' Turner authored
This is a small cleanup of the TraceEvent class performed which is part of a larget bug allowing cleaning up and reducing the generated machine code for TRACE_EVENTXXX() macro calls (see related bug). A first CL to perform this refactor was submitted as [1], but later reverted because it made some tests fail mysteriously (see http://crbug.com/899813). So the original CL was split into several independent ones. A first CL was submitted as [2], which actually fixed some potential dangling pointer issues that were created from the Initialize() and MoveFrom() methods. This second CL removes this methods by making TraceEvent a proper C++11 movable type, which should prevent (or at least make it more difficult) introducing invalid states for its instances. The goal is to see if this introduces new unexpected test failures (which would indicate that there are still invalid instance states used in the code base). The third CL is [3] and re-introduces the TraceArguments helper class on top of this one. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 BUG=898794 R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org Change-Id: I2b36885e2485d23cca199c48b2bd07d5745b00c5 Reviewed-on: https://chromium-review.googlesource.com/c/1346305 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611185}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1c194decd51..6b3d18164b4a git log f1c194decd51..6b3d18164b4a --date=short --no-merges --format='%ad %ae %s' 2018-11-27 terelius@webrtc.org Remove unused BWE field trial strings. 2018-11-27 kron@webrtc.org Add setters to ColorSpace class 2018-11-27 crodbro@webrtc.org Specific pacing configuration. 2018-11-27 ilnik@webrtc.org Various VP9 high fps fixes 2018-11-27 danilchap@webrtc.org Populate VideoSendTime extension network2 field when configured 2018-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 208bb982..81c26a09 (610939:611047) 2018-11-27 mbonadei@webrtc.org Fix wrong forward declaration namespace. 2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 00f78b5b..208bb982 (610831:610939) 2018-11-26 michel.promonet.1@gmail.com add cstring include need for strncmp 2018-11-26 steveanton@webrtc.org Small cleanup to mediasession_unittest.cc 2018-11-26 ouj@fb.com Rebase std::is_trivially_* with absl::is_trivially_* 2018-11-26 jonasolsson@webrtc.org Bump variable sizes in response to fuzzer bug 2018-11-26 saza@webrtc.org Add AudioProcessingCaptureStats and a level estimator replacement 2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7579fcbc..00f78b5b (610728:610831) 2018-11-26 nisse@webrtc.org Delete ChannelSend::RegisterTransport, replacing by construction argument 2018-11-26 phoglund@webrtc.org Add magjed as owner of rtc_tools. 2018-11-26 danilchap@webrtc.org In ReceiveStatistics use monotonic clock instead of ntp clock 2018-11-26 robin@opticaltone.com Add a new Task Queue for WinUWP. 2018-11-26 saza@webrtc.org Delete the WebRTC.Call.TimeSendingAudioRtpPacketsInSeconds metric 2018-11-26 danilchap@webrtc.org In ReceiveStatistic require callbacks during construction 2018-11-26 emircan@webrtc.org Reland Profile 2 to default profiles Created with: gclient setdep -r src/third_party/webrtc@6b3d18164b4a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:904909,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1848d2b4a6fc7fd65655128454244ec7f0916727 Reviewed-on: https://chromium-review.googlesource.com/c/1352235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611184}
-
Clark DuVall authored
These are about to expire, and we will probably want to collect data for a little longer. Bug: 904568 Change-Id: I9ebe814cd5ebe5de3dec10eca3efedb2c7bb94bb Reviewed-on: https://chromium-review.googlesource.com/c/1351586Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611183}
-
Xi Cheng authored
Bug: 903972 Change-Id: Ib70702de4cda80970454fd5d8c296855673698cb Reviewed-on: https://chromium-review.googlesource.com/c/1347145Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Mike Wittman authored
Reporting has been enabled at 100% server-side for ages. This flips the client default so we can avoid sending the experiment state. Change-Id: I2c88ce73fbf23c83e4572d9db3c72bbda28a8243 Reviewed-on: https://chromium-review.googlesource.com/c/1351379Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611181}
-
Justin Cohen authored
- Work around pushState changes that overwrite the navigation item title on pushState. The root cause of the bug is crbug.com/908173. - Correctly set navigation item titles on restore. Bug: 854174, 872211 Change-Id: Ife407429d7f2723fc9dac6458bf81bdb1ae64ff8 Reviewed-on: https://chromium-review.googlesource.com/c/1349776 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611180}
-
Xi Cheng authored
Change-Id: I58a6a878b511e9ab2c27088ffc0c8069cf39b473 Reviewed-on: https://chromium-review.googlesource.com/c/1347311Reviewed-by:
-
Wez authored
Enable re-use of these helpers across different test suites, by putting them in their own header & cc. Bug: 893229 Change-Id: I1d239baf708226d08a25a0aa741e8c5f6d0cf1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1334559 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611178}
-
Mihai Sardarescu authored
This CL fixes a condition that triggers clearing the primary account when the SigninManager initializes if there is no primary account set. Bug: 907114 Change-Id: I0f6c515b53cad2e6c12804469fd5b952bd05ca68 Reviewed-on: https://chromium-review.googlesource.com/c/1345079Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#611177}
-
agrieve authored
Based on java@ discussion: https://groups.google.com/a/chromium.org/d/topic/java/9WZLCc14oss/discussion Bug: 149440 Change-Id: Ie36166fe2282af564daafb13fbcb91af1a4ab6c1 Reviewed-on: https://chromium-review.googlesource.com/c/1344889Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611176}
-
Ben Smith authored
All methods that have a parameter with the FlexibleArrayBufferView extended attribute support AllowShared. In other words, it is possible to use them with an ArrayBufferView backed by an ArrayBuffer or a SharedArrayBuffer. This CL makes this an explicit requirement in the IDL file. Currently only WebGL APIs use the FlexibleArrayBufferView extended attribute. Bug: chromium:905449 Change-Id: I52f23d4ee07c169a525243f00dd8a96a58ce7075 Reviewed-on: https://chromium-review.googlesource.com/c/1345125 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611175}
-
Yoav Weiss authored
This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1345269 (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339 Bug: 908181, 908414 Reviewed-on: https://chromium-review.googlesource.com/c/1350950Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#611174}
-
Raphael Kubo da Costa authored
On release builds, GCC complains that |slot_size| is set but never used, and rightfully so. Move the code setting |slot_size| and |raw_size| within the DCHECK_IS_ON() block, which is the only part that actually uses it. Change-Id: Icfa5b7814685ebc6d66e42e27cc8e01f0878cdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1352178Reviewed-by:
-
Stephane Zermatten authored
Without this patch, the browser was never available when talkback was on, because the web view detected the presence of the overlay and assumed that the page was not available. With this patch, the overlay is fully disabled when talkback is activated if either: - partial overlay is on (there is a touchable area, a portion of the page is available) - the full overlay is off (the full page is available) In these two cases, the page can be accessed via talkback. Limitations: - Controls are not available to talkback when full overlay is on. - There is no filtering of the elements available to talkback when partial overlay is on yet. Bug: 806868 Change-Id: I77f88c8b4ba784a02306f14adf7e68d776e789ef Reviewed-on: https://chromium-review.googlesource.com/c/1352171Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#611172}
-
David Jean authored
Also adds AutofillManualFallbackPhaseTwo to test bots. Bug: 845472 Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d Reviewed-on: https://chromium-review.googlesource.com/c/1337347Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#611171}
-
W. James MacLean authored
ViewHostMsg_DidCommitAndDrawCompositorFrame and ViewHostMsg_DidFirstVisuallyNonEmptyPaint don't seem to be used anywhere ... removing them. Likely these got orphaned by https://chromium-review.googlesource.com/c/chromium/src/+/1278285 . Bug: none Change-Id: Id58e93c97ca66761238a874afcac3e04c6df09b8 Reviewed-on: https://chromium-review.googlesource.com/c/1351576 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611170}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/voice. This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 589840 Change-Id: I23e975d07b48897c6c10949a9fde8f9053356f87 Reviewed-on: https://chromium-review.googlesource.com/c/1351077Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611169}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/store_kit. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 589840 Change-Id: I3eb75e5a3316c7da05abab6e99b3a727c4f92ce4 Reviewed-on: https://chromium-review.googlesource.com/c/1351958Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611168}
-
erikchen authored
The test was enabled here: https://chromium-review.googlesource.com/c/chromium/src/+/1258249/ The test deterministically fails when run by itself. This failure is reproducible on both trybots and a local device. This CL reverts the change made by the CL mentioned above. It intentionally sets a super broad set of TestExpectations as I have not investigated the behavior of the test on platforms other than Windows. The test was observed to be flaky on Linux -- this CL removes that TestExpectation. The test was observed by Find-It to be flaky on macOS. See https://bugs.chromium.org/p/chromium/issues/detail?id=908517#c3. Bug: 908517, 789139 Change-Id: Idfa9603b093c9abc4c337c33a4a3e061482d9dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1351491Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611167}
-
Michael Spang authored
When the GPU process restarts we need to re-send the cursor bitmap since all GPU process display state is lost. It looks like it may have been broken all the way back to d818104f ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a different issue but also caused the message that was intended to restore the cursor (in CommitBoundsChange) to not get delivered. Bug: 908682 Test: kill $(pgrep -f type=gpu-process), cursor restored Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc Reviewed-on: https://chromium-review.googlesource.com/c/1351903Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#611166}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98cb15912130..4f83c59eea19 git log 98cb15912130..4f83c59eea19 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5552cdf032dd..471b8d4c7383 (1 commits) 2018-11-27 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-27 reed@google.com migrate to passing paint/ctm for bounds 2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 573f76b3eebf..5552cdf032dd (7 commits) 2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-26 bungeman@google.com Use width instead of weight for width on mac. 2018-11-26 csmartdalton@google.com Fix AA outset in GrAAFillRRectOp lower left corner 2018-11-26 halcanary@google.com tests: do not crash with missing resources. 2018-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d689d1c05272..4ad2322aa9cf (1 commits) 2018-11-26 brianosman@google.com Add tiled rendering option to viewer 2018-11-26 bsalomon@google.com Remove SkCanvas::experimental_drawImageSetV0 2018-11-26 csmartdalton@google.com Disable instanced rendering on Skylake 2018-11-26 jvanverth@google.com Reland Reland "Remove use of integers for atlas indexing" 2018-11-26 brianosman@google.com Remove xform canvas mode from Viewer, simplify color management 2018-11-26 kjlubick@google.com Fix multiplication of maxIterations in PolyUtils 2018-11-26 scroggo@google.com Update libwebp to v1.0.1 2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-26 rmistry@google.com Make lunch/mmma targets configurable and add new Android compile bot Created with: gclient setdep -r src/third_party/skia@4f83c59eea19 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I8c7d4833f4c7fad3672dac38b947c39d139476e8 Reviewed-on: https://chromium-review.googlesource.com/c/1352232Reviewed-by:
-
kyle Ju authored
Address the edge case where when a CL no longer has exportable changes, the PR should be closed and the branch should be deleted. Bug: 852014, 750942 Change-Id: I86adf85a3dcec7a9fac088fa42e2e357bbf1285a Reviewed-on: https://chromium-review.googlesource.com/c/1349471 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#611164}
-
Anthony Vallee-Dubois authored
Bug: 901864 Change-Id: I5d86a6017d4d3fd45169af7daf58899158d7a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/1351384 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611163}
-
Fabrice de Gans-Riberi authored
Bug: 908633 Change-Id: If37d2920cc2b71d002b3674490d1d8e3d8d76b62 Reviewed-on: https://chromium-review.googlesource.com/c/1351902Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#611162}
-
Xida Chen authored
This is due to implicit cast from double to int, add static_cast would fix it. Bug: 904333 Change-Id: I91a5120e67cd5e2eab7d0ea373b826cc3cbff104 Reviewed-on: https://chromium-review.googlesource.com/c/1350331Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611161}
-
Mike Wittman authored
The additional representational overhead imposed by the new profiler is approximately 1.1k bytes/uncompressed encoded profile, which is sufficiently small given the additional capabilities it supports. Bug: 851163 Change-Id: Iecddca885dac528fd305ecbb9692a824ec4280db Reviewed-on: https://chromium-review.googlesource.com/c/1351387 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#611160}
-
edchin authored
Change-Id: I14071613a5ff40d4d7cb3e2921766948fb53a56e Reviewed-on: https://chromium-review.googlesource.com/c/1335728Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
-
James Darpinian authored
ClusterFuzz found a case where the transfer buffer could be resized after we finish using a ScopedResultPtr but before it goes out of scope. This cleans up the dangling pointer by reducing its scope. Bug: 905889, 906409 Change-Id: I9e4aec8ed8f66df15404719c2589f775b433c3cd Reviewed-on: https://chromium-review.googlesource.com/c/1351783Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#611158}
-
Carlos Caballero authored
This lock covers way too much code. Restrict it to the minimum needed. Change-Id: I8a1e12b99f0cc9a9f1e25ce6e5b827d8714c7753 Reviewed-on: https://chromium-review.googlesource.com/c/1352313Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611157}
-
Ken Rockot authored
This reverts commit 7b6a767f. Reason for revert: [sheriff] Seeing failures such as these https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9195 Original change's description: > Navigation Predictor: Preconnect on tab foreground > > When the tab is brought to the foreground, preconnect to the > origin of the main frame request. This preconnection is done > at most once, and is helpful in case user clicks on a link. > > Change-Id: I6786c14ad7be0921bb309aabac5a75cff9819db8 > Bug: 908725 > Reviewed-on: https://chromium-review.googlesource.com/c/1350209 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611107} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: If108b83423fd3db0a673ea70c4f6b226e6288406 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908725 Reviewed-on: https://chromium-review.googlesource.com/c/1351946Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611156}
-
Friedrich Horschig authored
This CL adds 12 screenshot tests for three states of the accessory: - the accessory without opened tab - the accessory with opened password tab - the accessory with opened password tab scrolled to the bottom Each of these states will be handled for 4 different configurations: 1. Current state of the accessory 2. Current state of the accessory for RTL layouts 3. UX rework of the accessory 4. UX rework of the accessory for RTL layouts How to inspect current screenshots: => Select one of the dry runs below (e.g. android-kitkat-arm-rel) => Find section "chrome_public_test_apk [...]" => Follow the link at ui_screenshots => Filter the list by Test Class ("[...].ManualFillingUiCaptureTest") => You can add tags to inspect V1/V2/RTL/LTR of the accessory only To make the screenshots consistent, there are minor bug fixes that do not change how the UI looks like on any platform but seems to be relevant for tests: * The scroll shadow of the accessory sheet becomes View.INVISIBLE instead of View.GONE (absolute position; no impact on layout) * The RTL layout is applied to the general layout of the accessory bar. Devices with RTL language or dev override work -- tests don't Why sleeps: Without the sleep before taking a screenshot, the UI would display artifacts from time to time: disappearing home button, blank sheets or blank content areas. Usually, ViewTests don't seem to be bothered by this and Espresso won't detect it -- but in screenshots, it prevents flakiness. Change-Id: I7c195f52ea9c3f2a4d5548c89345fc8895dd7fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1344054Reviewed-by:Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#611155}
-
Peter Kasting authored
This feels inconsistent to me, but seems to be the best match for existing practice and API documentation. The other choice would be to use screen coords everywhere, but this will require fixing up more tests. This is a necessary precursor to using the configured screen position client by default; right now, root window and screen coords are equivalent, so being inconsistent about this doesn't matter. One side effect here is that when constructed with a root window but no specific starting point, the event generator's initial position will now be the origin of the root window instead of the origin of the screen. Bug: none Change-Id: I9b9138a2fbd44ddf5c585f04db9927c4f052eb00 Reviewed-on: https://chromium-review.googlesource.com/c/1347587Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#611154}
-
Peter Kasting authored
This passes on Windows. Bug: 302156 Change-Id: I5cc2048eeb76be8846419b02b145834956b56a14 Reviewed-on: https://chromium-review.googlesource.com/c/1351101Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#611153}
-
Carlos IL authored
This reverts commit 8d41f8c9. Reason for revert: This CL reverts the revert, and fixes the flakiness in the test by allowing one or two requests in the test. Bug: 904108, 902727 Original change's description: > Revert "Variations service now checks explicitely if previous attempt was HTTP." > > This reverts commit 91d24688. > > Reason for revert: This CL made ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange flaky (crbug.com/904108) reverting while investigating why. > > Original change's description: > > Variations service now checks explicitely if previous attempt was HTTP. > > > > Variations service now sets a flag if the last request was an HTTP > > retry, and uses it to decide whether to retry again, instead of > > relying on the scheme of the final URL. Also, retries are now disabled > > if the fallback url is HTTPS. > > > > Bug: 902727 > > Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c > > Reviewed-on: https://chromium-review.googlesource.com/c/1325035 > > Commit-Queue: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#607022} > > TBR=asvitkine@chromium.org,carlosil@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 902727 > Change-Id: I67036ea20097f889e71de5179a2e4510a201388d > Reviewed-on: https://chromium-review.googlesource.com/c/1334421 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607882} Change-Id: I5618dd7c48849ddf1fc8cd8f613ba7d83ebc66c0 Reviewed-on: https://chromium-review.googlesource.com/c/1335666 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Not explicitly disabling row selection would cause Voice Over to read "selected" on double taps. Bug: 845472 Change-Id: If41b29356a86b6ae2bad9ffd365c68a46c7c5cb1 Reviewed-on: https://chromium-review.googlesource.com/c/1352158Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611151}
-
Jared Saul authored
Change-Id: I74313b9162e28de1f6fcb6a2d88a4462caa54ece Reviewed-on: https://chromium-review.googlesource.com/c/1351786Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#611150}
-
