GitLab

This reverts commit 5d480c70.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 556549 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVkNDgwYzcwNDk5NGVhODJjNGYzY2ExZmQ5NGIxNzYxNjY4YzY4NDkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5560

Sample Failed Step: browser_tests

Original change's description:
> Mash - Support for browser themes in window frame.
> 
> 1. Move BrowserFrameHeaderAsh to //ash/frame and rename to
>    CustomFrameHeader.
> 2. Use CustomFrameHeader for browser windows (in HeaderView).
>    Continue to use DefaultFrameHeader for other windows.
>    Possible TODO: share more code between the two FrameHeader classes.
> 3. Transport frame images over mojo so Mash can apply them
>    via CustomFrameHeader.
> 
> For now, only the active frame image is propagated (as a POC).
> The inactive image, overlay images, and frame colors are TODO.
> Ideally, there should be no behavioral changes in classic Ash.
> 
> BUG=704942,836992
> 
> Change-Id: I15b2d357bd3c8b60b6656ebce910d476ce107b44
> Reviewed-on: https://chromium-review.googlesource.com/1043221
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556549}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=704942,836992

Change-Id: Ibe6fc13c61d33eac241fed00edb194cc248429de
Reviewed-on: https://chromium-review.googlesource.com/1049145
Cr-Commit-Position: refs/heads/master@{#556631}

Bug: 835150
Change-Id: Ic13db9c50bcfb46adcf5118bdfbd85be11347153
Reviewed-on: https://chromium-review.googlesource.com/1048412Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556630}

Also stop experimental win_chromium_x64_rel_ng.

BUG=731502,731378

Change-Id: I86aaebcafd10634c4146aebd8939cb8a0e969d23
Reviewed-on: https://chromium-review.googlesource.com/1048870Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556629}

- BookmarkEditVC subclasses ChromeTableVC instead of CollectionVC.
- BookmarksEditVC, BookmarkFolderVC and BookmarksFolderEditor hide or show the toolbar on
viewWillAppear.

Screenshots:
Old: https://drive.google.com/open?id=18hYFEmdmXv5WemJbwmx3jcP8e4zZRRf_
New: https://drive.google.com/open?id=1cJbQeEGIwMWKiulLk-geEIBVn1_cB-wN

Bug: 839460
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4ce83e551b45fbfce10399f39eadba74add5449b
Reviewed-on: https://chromium-review.googlesource.com/1045887
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556628}

Previously we couldn't test any code that touched RebootNow
because it would trigger an abort and crash our test. Now
we include a function for providing a callback that is used during
tests to assert that a reboot would be performed in production.

Bug: 79121456
Test: unit tests included
Change-Id: Ifef296e05e188a3b008895c62edeae8e50f9046a
Reviewed-on: https://chromium-review.googlesource.com/1048058
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556627}

R=holte@chromium.org

Bug: 728273
Change-Id: I9ee37fb2f49799c8e4a9b56b0d581fa20d079900
Reviewed-on: https://chromium-review.googlesource.com/1047992Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556626}

'Store as global variable' path for LocalJSONObject (e.g. JSONView)
was not tested, and broke because:
- LocalJSONObject did not override unserializableValue()
- ToCallArgument returned instead of invoking unserializableValue()

Bug: 840313
Change-Id: I19c7e5eda2d788fdbba397e00af2eecfab7b2888
Reviewed-on: https://chromium-review.googlesource.com/1048105
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556625}

This is a followup for:
https://chromium-review.googlesource.com/c/chromium/src/+/1032238

BUG=837155

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5dbca02b6a2eb2433a497f2a1d589fe5c477c38d
Reviewed-on: https://chromium-review.googlesource.com/1046161Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#556624}

Bug: 840394
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I197ac6b82a8e36e648f1c166fb9dd9bd986fef49
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1048209Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556623}

Monochrome.apk_Dex
        +2 entries fields
       +11 entries methods
        +3 entries types
        +5 entries strings
Monochrome.apk_Breakdown (+10,324 bytes)
       -75 bytes Zip Overhead
      +211 bytes Non-compiled Android resources size
    +8,432 bytes Native code size
       +47 bytes Package metadata size
      +205 bytes Java code size
    +1,504 bytes Compiled Android resources size
Monochrome.apk_Specifics
   +11,224 bytes normalized apk size
        +1 zip entries file count
    +8,432 bytes main lib size
      +900 bytes main dex size

R=fgorski@chromium.org

Change-Id: Ib76359940366ba1c0c56e24d9011430fb551758c
Reviewed-on: https://chromium-review.googlesource.com/1048143Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556622}

https://chromium.googlesource.com/angle/angle.git/+log/9f394f8cdf43..3b9b027c59f3

$ git log 9f394f8cd..3b9b027c5 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 geofflang Add basic tests of (unsafe) multithreaded contexts.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I1f400b82218b708cd1a97ae71f8c7404ea189c69
Reviewed-on: https://chromium-review.googlesource.com/1048321Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556621}

Original: http://crrev.com/c/1041210
Reverted: http://crrev.com/c/1046026

This reverts commit c2b950ab.

Reverted because of flakes in interactive_ui_tests:
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5528

This change removes interactive_ui_tests that test for cancelling speech because
there is no time between the mock speech monitor starting speech and ending it,
so tests about cancelling in-progress speech are flaky. This change also adds
a listener for Select-to-Speak state change so we can ensure that the button tap
in ash has completely propagated through the extension before doing the next
part of the test.

Original change description:
> Fully integrate the Select-to-Speak tray button with the extension.
>
> This change lets taps to the tray button control changes in the Select-to-Speak
> extension page. It also adds integration tests.
>
> A large part of this change is adding a mojom test API to allow the ChromeOS
> integration test to find and tap the Select-to-Speak button in Ash.
>

TBR=dcheng@chromium.org,jamescook@chromium.org,dtseng@chromium.org

Bug: 753018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8cd83216d6292d05ccb0d2d6b3a9747a877067a0
Reviewed-on: https://chromium-review.googlesource.com/1047646
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556620}

run_web_tests.py doesn't use PrettyPatch any longer.

Bug: 672651
Change-Id: Ia57fc68aaf81b8b60e98f4c6e68bf84b507a3391
Reviewed-on: https://chromium-review.googlesource.com/1045958Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556619}

Bug: 836391
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I844b84c905601490519d943158a17bc79c2ac446
Reviewed-on: https://chromium-review.googlesource.com/1048177
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556618}

Bug: 714018
Change-Id: Icf71c24297709c96513db23e7f562dce298e6374
Reviewed-on: https://chromium-review.googlesource.com/1048070Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556617}

Clean up a couple of Safe Browsing finch features that have already been
ramped up to 100%:
kGaiaPasswordReuseReporting
kGoogleBrandedPhishingWarning
kDispatchSafetyNetCheckOffThread
kAppendRecentNavigationEvents

Bug: 824497
Change-Id: I4243a768512eda284e3dfa8fef593753fa9240c7
Reviewed-on: https://chromium-review.googlesource.com/1045306
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556616}

This change includes an implementation of the KeyboardHook class for
Linux/X11 which allows for intercepting system level shortcuts.  It
builds on a previous CL which integrated KeyboardLock functionality
into RenderWidgetHostViewAura and the base X11 KeyboardHook impl.

BUG=680809

Change-Id: I7fc4b5856870eff4a10ea2f15c1cfe1c68044c76
Reviewed-on: https://chromium-review.googlesource.com/981126
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556615}

This reverts commit c422bd5a
(reviewed on crrev.com/c/934923).

The CL was to reduce number of paint property nodes and paint operations
for objects with border-radius and overflow-clip and the clip rects are
the same.

Revert because:
- Border radius with overflow clip is rare;
- Hiding ObjectPaintProperties::OverflowClip() and exposing
  OverflowOrInnerBorderRadiusClip() was confusing, and I would not like
  to hide OverflowClip() again after crrev.com/c/1026941;
- The relationship between omitting OverflowClip and clip for hit
  testing is complex and tricky. Sometimes omitting OverflowClip causes
  full subtree property update when we just need a clip for hit
  testing. The cost is much bigger than saving just one paint property
  node and 3 paint operations.

Cluster-telemetry shows only 0.39% increase of paint op count with this
CL: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180506194029/html/index.html

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7c25a727d2f0bfa52dda4151e817ac71d5feb5c7
Reviewed-on: https://chromium-review.googlesource.com/1046152
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556614}

Bug: None
Change-Id: I11c89039ad565e30f531c72d5daa85de3d27c3f8
Reviewed-on: https://chromium-review.googlesource.com/1048318Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556613}

This CL does not introduce any functionality change, but makes
it easier to add a new category of RTTs by combining similar
methods in Network Quality Estimator (NQE).

Bug: 834119
Change-Id: I60623ad51733c9339168993cb8b10202c0a68adf
Reviewed-on: https://chromium-review.googlesource.com/1040913Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556612}

https://webrtc.googlesource.com/src.git/+log/d5ef6ff258da..31dbc246d744

$ git log d5ef6ff25..31dbc246d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I318726a1ab0073b24e8945609fa9ff220968c97d
Reviewed-on: https://chromium-review.googlesource.com/1048314
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556611}

fdio_transfer_fd() was returning number of returned handles, while
LaunchProcess() was expecting 0 on success. Also added a unittest.

Bug: 826018
Change-Id: Iebc4457449036cc9bfe4eb2203363edde98d75af
Reviewed-on: https://chromium-review.googlesource.com/1045558
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556610}

BUG=840381

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id48c1ea24bbbc642a3f70501ea19767ac83aec0a
Reviewed-on: https://chromium-review.googlesource.com/1047686Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556609}

changes:
This CL add app shortcut items to shelf context menu. Executing app
shortcut item menu entry would launch the corresponding app shortcut.
This CL is shelf side change.
The app list side changes are: crrev.com/c/1029412, crrev.com/c/1041574.

Bug: 803291
Test: tested on device with Android CLs; video: go/appshortcuts-demo-2
Change-Id: I278bdcdc20b1dd48e3c6ac21d18ad98c8b184ecf
Reviewed-on: https://chromium-review.googlesource.com/1045841
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556608}

https://skia.googlesource.com/skia.git/+log/2a943df011ef..9a9c25b36ce5

$ git log 2a943df01..9a9c25b36 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 336cdd903..d4e488eb6 (1 commit)
2018-04-10 halcanary SkAdvancedTypefaceMetrics: simplify more
2018-05-07 kjlubick Trim down T8888 configs
2018-05-07 mtklein make SkColorSpace::MakeICC strict as skcms
2018-05-04 brianosman Handle failure to create SkColorSpaceXform in SkConvertPixels
2018-05-07 herb Make sure the ScalerContextRec is dense

Created with:
  roll-dep src/third_party/skia
BUG=chromium:838115


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I602ef190a5deff01e7d762624f3a50e4b4ba2bff
Reviewed-on: https://chromium-review.googlesource.com/1048273
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556607}

This CL makes {Weak}WrapperSharedURLLoaderFactory available to builds that
shall not depend on //content/ (namely ios/chrome builds).

In practice, it moves wrapper_shared_url_loader_factory.* and
weak_wrapper_shared_url_loader_factory.* out of //content/common and
//content/public/common, respectively, into services/network/public/cpp/.

The various callsites are updated, but no functionality changes are
expected.

The dependency chain looks like this:

- WeakWrapperSharedURLLoaderFactory (weak_wrapper_shared_url_loader_factory.*) depends on
- WrapperSharedURLLoaderFactoryInfo (wrapper_shared_url_loader_factory.*), which depends on
- WrapperSharedURLLoaderFactory (wrapper_shared_url_loader_factory.h).

BUG=773295

TBR=boliu@chromium.org,blundell@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If6a1c9ac1197e1eafe17c4ba9d4136b52803a5f8
Reviewed-on: https://chromium-review.googlesource.com/1046306
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556606}

This CL:
- Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
  mojom::TCPConnectedSocket can perform TLS connect on top of an already
  connected tcp client socket.
- Adds a tls_socket.mojom file which includes the interface definition of
  TLSClientSocket.

Other changes to support implementing UpgradeToTLS():
- Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
  socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
  side in preparation for UpgradeToTLS() without worrying that data might be
  buffered by the tcp socket.
- Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
  socket to cancel a pending ReadIfReady() and unregister their event watchers.

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
Reviewed-on: https://chromium-review.googlesource.com/1034080
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556605}

https://chromium.googlesource.com/catapult.git/+log/e54b6ffb6dad..e853531767d2

$ git log e54b6ffb6..e85353176 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 nednguyen Remove deadcode related to old test disabling system in Telemetry story runner
2018-05-04 dtu [pinpoint] Look in new location for perf results file.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:796340,chromium:836037


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Id4ca3154cc36c121ee3a7b9347df5053decf30f3
Reviewed-on: https://chromium-review.googlesource.com/1048307
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556604}

PowerMonitorBroadcastSource receives mojo power notifications on IO
thread, and can use PowerMonitor after it's destroyed on main thread.
Disabling power notifications on the IO thread prevents this data race.

Bug: 834312
Change-Id: I1677b6098d158ecc18dfce60eaeed9590110a962
Reviewed-on: https://chromium-review.googlesource.com/1041215
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556603}

R=enne@chromium.org

Bug: 839711
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib6e45db4752533219a9dbabb82187f4422afd697
Reviewed-on: https://chromium-review.googlesource.com/1048127Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556602}

Bug: None
Test: build locally, no check error
Change-Id: I243982950572ff4250e6aea02799b10afc2dbbf1
Reviewed-on: https://chromium-review.googlesource.com/1048030
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556601}

We should only reset the deadline when ui is resizing because OS is
guttering us anyways. In other cases use the real deadline.

Bug: 834449, 672962
Change-Id: I95a29e3cf8a508d0d1cd614df79c0e12183f1487
Reviewed-on: https://chromium-review.googlesource.com/1048206Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556600}

As in each app, the service keeps two seed files: "variations_seed" and
"variations_seed_new", and uses them the same way. New seeds are written
to "variations_seed_new" and then "variations_seed_new" is renamed to
"variations_seed". The service uses the "variations_stamp_file"
similarly as well; while apps use it to rate-limit their requests to the
service, the service uses its own stamp file to rate-limit requests to
the variations seed server.

AwVariationsSeedFetcher (named to avoid confusion with the existing
VariationsSeedFetcher) is a JobService which downloads the seed on
behalf of the service. The job is scheduled whenever an app requests the
seed, and the last job ran at least one day ago. Since WebView is used
frequently, the job will be effectively periodic (with a period of one
day) as long as the device is in use and has network access.

VariationsSeedHolder managers the WebView service's copy of the seed.
Work on the seed is done by posting Runnables (SeedWriter and
SeedUpdater) to a certain background thread, to ensure mutual exclusion.
A SeedWriter job is posted whenever an app requests the seed from the
service; the SeedWriter writes the service's seed to the provided file
descriptor. A SeedUpdater job is posted to update the seed with a newly
downloaded one.

BUG=733857

Change-Id: I40763a2cdbb2d70889a8547349c1f550488d5ff5
Reviewed-on: https://chromium-review.googlesource.com/1036852
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556599}

Bug: b:79359468
Test: locally build and run
Change-Id: I031c85fd1aad7647b84741f638b9dac385ea560a
Reviewed-on: https://chromium-review.googlesource.com/1048121Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556598}

Instead add a function. This is easier to use in calling code.

BUG=837686
TEST=none

Change-Id: I0b9b8e973d9d454f18a7711f2d8ab6a6540144fa
Reviewed-on: https://chromium-review.googlesource.com/1045466Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556597}

In LayoutNG, HasPercentHeightDescendants() does not produce correct results
and it is difficult to get it to produce correct results. Accordingly, let's
disable this optimization for now.

Bug: 635619, 839661
Change-Id: I766ea2fbea647eb9d0f3767b64788b678d328953
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1043009
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556596}

Switch SnapshotAllCompositorKeyframes implementation to *always* check the dirty
bit and make that an internal details instead of relying on clients to check.

To this end, we explicitly invalidate the snapshots when viewport was zoomed or
resized. Also now we correctly set the dirty bit when a new keyframes are set.

TEST: third_party/blink/renderer/core/animation/keyframe_effect_model_test.cc

Change-Id: I9b941abf68f3e6897b2ab349a2afc6264d25bf96
Reviewed-on: https://chromium-review.googlesource.com/1033575Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556595}

Change-Id: I4079e769b46f16d3635c25276beb832ced10107b
Reviewed-on: https://chromium-review.googlesource.com/1041076Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556594}

Error 22 (EINVAL) is often associated with use-after-frees.
I've seen multiple developers independently spending cycles figuring
this out. Add a hint for everyone once and for all in POSIX's LockImpl

Issues where this may be useful:
https://bugs.chromium.org/p/chromium/issues/list?q=%22Check+failed%3A+rv+%3D%3D+0+(22+vs.+0)%22

Sadly I couldn't find a way to test this. I tried to write a death
test on a manual use-after-free but the error is unreliable.

R=dcheng@chromium.org

Bug: 818163
Change-Id: I2f9a3aeadebd8bd7b32e2a28d1ba4b801efed9ff
Reviewed-on: https://chromium-review.googlesource.com/1040586Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556593}

-Wno-deprecated-declarations is no longer needed after
http://crrev.com/689599319903ef86.

Bug: 752720
Change-Id: Ief8b8d62b9d503c597e05534009ca728786e764d
Reviewed-on: https://chromium-review.googlesource.com/1046405Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556592}