GitLab

DataReductionProxyStatisticsPrefs is instantiated on UI thread and then
its ownership is passed to IOThread. This causes weak_factory_ to be
invalidated on a different thread from the one it is created on. This
cl explicitly invalidates it on UI Thread.

BUG=428931

Review URL: https://codereview.chromium.org/669783004

Cr-Commit-Position: refs/heads/master@{#302175}

These tests do not need the full power of browser_tests and API tests
like these will eventually be moved out of app_shell_browsertests into a
new extensions_browsertests target that takes advantage of the lighter
app_shell framework.

BUG=

Review URL: https://codereview.chromium.org/695613002

Cr-Commit-Position: refs/heads/master@{#302174}

Missing enhanced bookmark owners coverage from https://codereview.chromium.org/682103003

NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/691853003

Cr-Commit-Position: refs/heads/master@{#302173}

BUG=

Review URL: https://codereview.chromium.org/687873003

Cr-Commit-Position: refs/heads/master@{#302172}

Add Spdy4Experiment group which can be kept at the same size as Spdy4Control,
while Spdy4Enabled can be arbitrary.  This allows enabling SPDY/4 on more than
50% while having a group the same size as Spdy4Control for convenient
comparison.

BUG=428690

Review URL: https://codereview.chromium.org/689923002

Cr-Commit-Position: refs/heads/master@{#302171}

CVC isn't recognized.

TBR=isherman@chromium.org
BUG=428926

Review URL: https://codereview.chromium.org/691073002

Cr-Commit-Position: refs/heads/master@{#302170}

I think this is a fix to this CL: https://codereview.chromium.org/656383002/
One of the internal bots has the following error:
  PullProfile at tools/telemetry/telemetry/core/platform/android_platform_backend.py:455
    self._ProfileDir(package), output_profile_path)
AttributeError: 'AndroidPlatformBackend' object has no attribute '_ProfileDir'
There does not seem to be a _ProfileDir, but there is a _GetProfileDir.

BUG=417542

Review URL: https://codereview.chromium.org/664583009

Cr-Commit-Position: refs/heads/master@{#302169}

The GetAnyChromePath and GetChromePathForInstallationLevel functions
previously returned the official Google Chrome executable path, even on
Chromium. Now on a Chromium build, they will return the installed path
to Chromium, if any.

BUG=428600

Review URL: https://codereview.chromium.org/686383002

Cr-Commit-Position: refs/heads/master@{#302168}

setsockopt() can now be called with these options:
  SO_RCVBUF
  SO_SNDBUF

BUG=none

Review URL: https://codereview.chromium.org/304373008

Cr-Commit-Position: refs/heads/master@{#302167}

Currently metadata record only contains size and it is not used anywhere.
In the future size will be used for storage management by datatypes.

Next step is to add crc to metadata record.

BUG=424304
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/690723004

Cr-Commit-Position: refs/heads/master@{#302166}

Revert "Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://codereview.chromium.org/637323005/)"

This reverts commit 1491f336.

BUG=415774
TBR=yfriedman

Review URL: https://codereview.chromium.org/693613003

Cr-Commit-Position: refs/heads/master@{#302165}

TBR=isherman@chromium.org
BUG=428930

Review URL: https://codereview.chromium.org/688373002

Cr-Commit-Position: refs/heads/master@{#302164}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/058f01e..e228ba3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/693493005

Cr-Commit-Position: refs/heads/master@{#302163}

This CL links the it2me host to the Chrome binary on ChromeOS
behind a flag.
The following changes are made to the it2me host so that it can be run in the browser process.
1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
   Implements policy_watcher on ChromeOS using policy services.
4. Re-use existing threads, url request context getters and policy service on ChromeOS.
5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.

BUG=334087

Committed: https://crrev.com/54dde6f02d121ff745e66b57205583087ff720ec
Cr-Commit-Position: refs/heads/master@{#302034}

Review URL: https://codereview.chromium.org/639233002

Cr-Commit-Position: refs/heads/master@{#302162}

BUG=338884

Review URL: https://codereview.chromium.org/687833002

Cr-Commit-Position: refs/heads/master@{#302161}

Use NSWindowDidChangeOcclusionStateNotification (new in 10.9
Mavericks) to detect when the application is hidden, the window is
minimized or obscured by another window.

Send the WasHidden to the WebContentsImpl, because this will
take into account tab capture.

When RenderWidgetHostViewMac::WasHidden is called, the previous
behavior was to destroy the BrowserCompositorViewMac. This has
the undesirable effect of creating a white flash when a hidden
window is re-exposed.

To prevent this, only destroy the BrowserCompositorViewMac when
the the RenderWidgetHostViewMac is removed from all NSWindows.
Manage the state of BrowserCompositorViewMac explicitly as being
Active (previously whenever it existed), Suspended (the new state
where it is kept around, but the RWH and DFH are hidden), and
Destroyed (previously wherever it did not exist).

Move some 10.7 APIs to base because they belong there, not in
content.

BUG=310374

Review URL: https://codereview.chromium.org/684343002

Cr-Commit-Position: refs/heads/master@{#302160}

- add a protobuf for WiFi credentials
- add a ModelType for syncing WiFi credentials
- add UI for controlling whether or not WiFi credentials are synced
- add new data type to testserver

While there:
- update comment in sync_setup_overlay.js
- fix ordering of arguments to EXPECT_EQ in CheckBool
  (sync_setup_handler_unittest)
- move GetSelectableTypeNameMap from sync_setup_handler.cc to model_type.cc

BUG=chromium:422045
TEST=ProfileSync, SyncSetup, SyncModel, ModelType, NigoriUtil,
     ProtoEnumConversions, ProtoValueConversions,
     SyncEncryptionHandlerImpl

Review URL: https://codereview.chromium.org/674633002

Cr-Commit-Position: refs/heads/master@{#302159}

Consumers of this class (powerd) might want to know if it actually can
wake the system from suspend so that they can try alternatives if it
doesn't have this ability.

BUG=chrome-os-partner:31970
TBR=derat

Review URL: https://codereview.chromium.org/685503006

Cr-Commit-Position: refs/heads/master@{#302158}

There are now files in the primary locations for flac and trace-viewer.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/690613004

Cr-Commit-Position: refs/heads/master@{#302157}

Disable data reduction proxy by deleting user level proxy prefs only if
the proxy is known to be a data_reduction_proxy. Remove duplicate
implementation in off_the_record_profile_impl.cc.

BUG=426220

Review URL: https://codereview.chromium.org/669163003

Cr-Commit-Position: refs/heads/master@{#302156}

BUG=411543

Review URL: https://codereview.chromium.org/691123002

Cr-Commit-Position: refs/heads/master@{#302155}

We should not assume that the underlying decoders
keep their state after a Seek.
So for example, the SPS/PPS should be added again.

BUG=140371

Review URL: https://codereview.chromium.org/683573002

Cr-Commit-Position: refs/heads/master@{#302154}

TBR=vsevik
BUG=

Review URL: https://codereview.chromium.org/690553004

Cr-Commit-Position: refs/heads/master@{#302153}

BUG=412150

Review URL: https://codereview.chromium.org/691883002

Cr-Commit-Position: refs/heads/master@{#302152}

Revert of Windows video capture: Remove duplicated code from GetDeviceSupportedFormats* (patchset #3 id:200001 of https://codereview.chromium.org/558503003/)

Reason for revert:
See https://code.google.com/p/chromium/issues/detail?id=428958

Original issue's description:
> Windows video capture: Remove duplicated code from GetDeviceSupportedFormats*
>
> The code for GetDeviceSupportedFormatsMediaFoundation and GetDeviceSupportedFormatsDirectShow are already implemented in video_capture_device_mf_win.cc and video_capture_device_win.cc respectively. This CL refactors the implementation so that video_capture_device_factory_win.cc can make use of that code.
>
> Committed: https://crrev.com/b6dae80f8f10b8af1e3026de9f5af4f3128e812a
> Cr-Commit-Position: refs/heads/master@{#301891}

TBR=mcasas@chromium.org,perkj@chromium.org,tommi@chromium.org,magjed@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/691143002

Cr-Commit-Position: refs/heads/master@{#302151}

we can determine whether the data_reduction_proxy was used or not for
PLT UMA.

BUG=374264

Review URL: https://codereview.chromium.org/686313002

Cr-Commit-Position: refs/heads/master@{#302150}

It's now up to the caller to avoid calls to
::Begin/FinishDrawingFrame when it makes sense to do so.

BUG=428071
R=danakj

Review URL: https://codereview.chromium.org/678113004

Cr-Commit-Position: refs/heads/master@{#302149}

Currently, touch selection quick menu buttons have the fixed size of
63x38. In some languages, texts need more space; so those buttons should
be expanded to fit the whole text.

BUG=417254

Review URL: https://codereview.chromium.org/693583002

Cr-Commit-Position: refs/heads/master@{#302148}

Previous instrumentations showed that TemplateURLService::ChangeToLoadedState
alone is responsible for 2.74 janks per hour in UI thread in Win (8.15 on Mac). I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers.

BUG=422460

Review URL: https://codereview.chromium.org/684333002

Cr-Commit-Position: refs/heads/master@{#302147}

Some of the functions are direct wrapper to WebContents methods. In this
patch, taken care of removing those dependencies and added extra validation to prevent run time crashes.

BUG=398263

Review URL: https://codereview.chromium.org/639703004

Cr-Commit-Position: refs/heads/master@{#302146}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6500760..058f01e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/680833004

Cr-Commit-Position: refs/heads/master@{#302145}

TBR=isherman@chromium.org
BUG=428892

Review URL: https://codereview.chromium.org/682223005

Cr-Commit-Position: refs/heads/master@{#302144}

Revert of Allow POSIX callers to specify a new file's mode. (patchset #1 id:1 of https://codereview.chromium.org/689713006/)

Reason for revert:
This seems to have broken the Linux MSan test bot.

[ RUN      ] FileUtilTest.WriteFileWithMode
../../base/files/file_util_unittest.cc:2164: Failure
Value of: status.st_mode & 0777
  Actual: 384
Expected: mode
Which is: 420
[  FAILED  ] FileUtilTest.WriteFileWithMode (1 ms)

Original issue's description:
> Allow POSIX callers to specify a new file's mode.
>
> Retain the tight 0640 mode for most existing callers, but honor the user's
> umask for downloaded files.
>
> This is a re-land of https://codereview.chromium.org/639253004/.
>
> BUG=409416, 362887
> TBR=asanka,mdempsky,rvargas
>
> Committed: https://crrev.com/931e35070097af9837f79ff19f8668e45b92ed3a
> Cr-Commit-Position: refs/heads/master@{#302113}

TBR=palmer@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409416, 362887

Review URL: https://codereview.chromium.org/693493004

Cr-Commit-Position: refs/heads/master@{#302143}

Original CL: Review URL: https://codereview.chromium.org/686503002

BUG=425996
TBR=oshima, sadrul, tbarzic

Review URL: https://codereview.chromium.org/690943003

Cr-Commit-Position: refs/heads/master@{#302142}

BUG=417090

Review URL: https://codereview.chromium.org/627573002

Cr-Commit-Position: refs/heads/master@{#302141}

Method AccountTracker::StartFetchingUserInfo is executed in browser's UI thread, and it causes jank.
In Canary 40.0.2201.2 on Win, 19.9 jph is caused by AccountTracker::StartFetchingUserInfo,
which average execution time in UI thread is 227 ms. On Mac, we have 17.7 jph and 71.1ms avg. I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=422460

Review URL: https://codereview.chromium.org/690073002

Cr-Commit-Position: refs/heads/master@{#302140}

BUG=

Review URL: https://codereview.chromium.org/681103002

Cr-Commit-Position: refs/heads/master@{#302139}

Previously, when generate_v14_compatible_resources.py encountered an
invalid XML file, it showed an error message that didn't tell which
file it was processing. E.g.:

  Traceback (most recent call last):
    ...
    File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
      parser.Parse(buffer, 0)
  ExpatError: unbound prefix: line 6, column 0

Now it also prints the name of the file that couldn't be parsed. E.g.

  Traceback (most recent call last):
    ...
    File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
      parser.Parse(buffer, 0)
  ExpatError: unbound prefix: line 6, column 0
  Failed to parse XML file: chrome/android/res/layout/my_layout.xml

Review URL: https://codereview.chromium.org/661433005

Cr-Commit-Position: refs/heads/master@{#302138}

BUG=423229

Review URL: https://codereview.chromium.org/686803003

Cr-Commit-Position: refs/heads/master@{#302137}

Push Notifications not only support Ask already, it is the default value, so this should match that reality.

BUG=425698

Review URL: https://codereview.chromium.org/689993002

Cr-Commit-Position: refs/heads/master@{#302136}