- 14 Feb, 2019 40 commits
-
-
Jay Harris authored
The BoxLayout doesn't seem to deal with label eliding properly (the origin of the text moves around). This moves to the new FlexLayout, which handles the resizing correctly. Bug: 929944 Change-Id: Ie66f399cc85e500b5318d987d4759954e972c1b8 Reviewed-on: https://chromium-review.googlesource.com/c/1460197 Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#632399}
-
Dave Tapuska authored
The interface was only used for tests. Move the tests into blink and remove the interface. BUG=591921 Change-Id: I738449a5acd01adf1cf24ed48d84a2dbc447c5fa Reviewed-on: https://chromium-review.googlesource.com/c/1472853 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#632398}
-
Elly Fong-Jones authored
NaCl development has been transitioning to WebAssembly for some time, and NaCl is deprecated for some use cases. This change removes these nacl-related flags: enable-nacl enable-nacl-debug force-pnacl-subzero nacl-debug-mask allow-nacl-socket-api The corresponding nacl switches are still present; if you are developing using one of these flags, migrate to using the command-line switch instead. The force-pnacl-subzero and allow-nacl-socket-api switches are themselves slated to be removed soon. Bug: 918376 Change-Id: Ied029b6f8bd001fdacb5f0734bd1c5f4cf3d322a Reviewed-on: https://chromium-review.googlesource.com/c/1473834 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632397}
-
Xiyuan Xia authored
- Make InputMethodMus not forwarding synthetic key events as InputMethodChromeOS does not expect to receive them; - ChromeVirtualKeyboardDelegate to insert char to the correct ui::TextInputClient instance; Bug: 931931 Change-Id: If783fcf53c833c360d6a733d22b5b30308528363 Reviewed-on: https://chromium-review.googlesource.com/c/1474635Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632396}
-
Maggie Cai authored
Currently the overflow menu will not work on second click if we never go to the dialog. This is due to a early return cross check in the code. If the overflow menu is exits by clicking somewhere else, it will close without clear the actionMenuModel_. This is the same in the history_list. BUG=931969 Change-Id: Ia67886212ac6b09cdf0e7a0813ee98db8df34926 Reviewed-on: https://chromium-review.googlesource.com/c/1471972Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#632395}
-
Scott Violet authored
If WindowTreeHostMus::SetBounds() is called with no LocalSurfaceIdAllocation (as happens when views calls SetBounds()) and the size hasn't changed, then the current LocalSurfaceId should be used. BUG=931878 TEST=covered by test Change-Id: I135dca75ce04220796c41dd9d49042127d5dcfc5 Reviewed-on: https://chromium-review.googlesource.com/c/1474252 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#632394}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0444f9acb88d..43a449fd3566 git log 0444f9acb88d..43a449fd3566 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 dgarrett@google.com chromeos_config: Add octopus factory branch. 2019-02-14 ihf@chromium.org Revert "default PreCQ: Remove betty-arcnext-pre-cq" 2019-02-14 kerrnel@chromium.org cros deploy: Fail if the package is not actually emerged. 2019-02-14 pprabhu@chromium.org config: Migrate auron_paine-paladin and bob-paladin to Skylab Created with: gclient setdep -r src/third_party/chromite@43a449fd3566 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3edd03431f59a32fea400a0139d4b47ab7a4d942 Reviewed-on: https://chromium-review.googlesource.com/c/1474552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632393}
-
Kurt Horimoto authored
This CL updates the default behavior of FullscreenUIUpdater to use |-updateForFullscreenProgress:| as a fallback for when the optional FullscreenUIElement selectors are not implemented. Bug: 932215 Change-Id: I4e2e5f0efd2b81e3c946161e45cb75f444510537 Reviewed-on: https://chromium-review.googlesource.com/c/1474092 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#632392}
-
Aleks Totic authored
Tests buggy code paths in NG and Legacy. Bug: 907911 Change-Id: I38f22f3673576a776fbe7e89f1cc8452b99d3ded Reviewed-on: https://chromium-review.googlesource.com/c/1471384Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632391}
-
Marcin Wiącek authored
1. remove units in the RecordHistogram methods and TimesHistogramSample (they're always using milliseconds) 2. replace some methods with DateUtils constants / shared constants in TimeUtils TBR=fgorski@chromium.org,caitkp@chromium.org Change-Id: Ifd4e8f4e5af7051647c45cf310c1bc253b59eab2 Reviewed-on: https://chromium-review.googlesource.com/c/1444831 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#632390}
-
Yulun Wu authored
Bug: 922649 Change-Id: I7148f5145e99d88bfed9066677841f96faccf04d Reviewed-on: https://chromium-review.googlesource.com/c/1415298Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632389}
-
Robert Ma authored
More logging in hope of shedding some light on issue 929413 (content_shell outliving run_web_tests). Bug: 929413 Change-Id: I47117a85a083158d13527a535dab312774220001 Reviewed-on: https://chromium-review.googlesource.com/c/1474630Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#632388}
-
David Bienvenu authored
This broke chrome cast mirroring from a minimized browser window. This changed in https://chromium-review.googlesource.com/c/1326621 Bug: 930429 Change-Id: I0e212da02b66eed3f4b6d64c0d37fb61f1a6e840 Reviewed-on: https://chromium-review.googlesource.com/c/1468762Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632387}
-
Adrienne Walker authored
Change-Id: I9c0585f678eb98d6d5b758036e11859675f659e4 Reviewed-on: https://chromium-review.googlesource.com/c/1474094 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632386}
-
Raphael Kubo da Costa authored
This fixes the GCC build which was failing like this: ../../base/scoped_observer.h: In instantiation of ‘void ScopedObserver<Source, Observer>::RemoveAll() [with Source = TabStripModel; Observer = TabStripModelObserver]’: ../../base/scoped_observer.h:26:5: required from ‘ScopedObserver<Source, Observer>::~ScopedObserver() [with Source = TabStripModel; Observer = TabStripModelObserver]’ ../../chrome/browser/ui/views/extensions/extension_popup.h:115:70: required from here ../../base/scoped_observer.h:45:20: error: invalid use of incomplete type ‘class TabStripModel’ sources_[i]->RemoveObserver(observer_); ~~~~~~~~~~~~~^~~~~~~~~~~~~~ This is caused by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89311 ("Brace initialization needlessly invokes destructor"), i.e. having something like ScopedObserver<T, U> observer_{this}; in a header declaration requires T and U to be fully declared because ScopedObserver's destructor references them. In a few cases, T was only forward-declared. Bug: 819294 Change-Id: Ie5b9dc2745e27d4532c5539e3845a8c9147a0595 Reviewed-on: https://chromium-review.googlesource.com/c/1472576 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#632385}
-
Antonio Gomes authored
This CL adds a common factory method named BuildChromeSigninClientWithURLLoader to chrome/browser/signin/chrome_signin_client_test_util.cc|h to create a ChromeSigninClient instance supplying the test's URLLoaderFactory to it. This avoids GCMSFactory::GetInstance to be referenced from various places for similar purposes. In the end, there is no functionality change since GCMS fetches its URLLoaderFactory instance from SigninClient when needed. c/b/signin/gaia_cookie_manager_service_test_util.cc|h is removed. This includes the following files: - chrome/browser/ui/cocoa/test/cocoa_profile_test.mm - chrome/browser/extensions/api/identity/identity_apitest.cc - chrome/browser/ui/views/frame/test_with_browser_view.cc - chrome/browser/metrics/ukm_browsertest.cc - chrome/browser/sync/test/integration/secondary_account_helper.cc|h - chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc - chrome/browser/sync/test/integration/single_cl TBR=treib@chromium.org (Marc has reviewed //c/b/sync changes in CL_1466606 that got reverted due to another problem). BUG=930745 Change-Id: I4887f10f0a66b7c60d21bc7fd97f1b0d8f01a84b Reviewed-on: https://chromium-review.googlesource.com/c/1471790Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#632384}
-
Rakina Zata Amni authored
Adds the boolean "activatable" flag to DisplayLockOptions, which is false by default. Signifies whether the lock can be activated by the browser when needed, in cases like find-in-page, tab order navigation, URL fragment anchor, etc. This CL also renames the "IsSearchable" method in DisplayLockContext to "IsActivatable", to be consistent with the option name. The actual activation & "beforeactivate" event will be implemented in another CL. See doc: http://bit.ly/2RXULVi Bug: 882663 Change-Id: I259ff7f2fed2e3e1f446fa33f202ed2d81a76ad7 Reviewed-on: https://chromium-review.googlesource.com/c/1466544Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#632383}
-
Robbie McElrath authored
This migrates chromeos::UserSessionManager from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 887047 Change-Id: I814311aa08ab2dafa7bf9b4ac59b3dab0e0a984e Reviewed-on: https://chromium-review.googlesource.com/c/1237553 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f806ca6b..3c4ae81e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2667b8c45fc4d51781a2f8b9e3b5ba2db0f7b30d Reviewed-on: https://chromium-review.googlesource.com/c/1473839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632381}
-
Robert Ma authored
This is a code-health cleanup following discussions in https://crrev.com/c/1462139/13/chrome/test/chromedriver/test/run_webdriver_tests.py#30 This is a mechanical substitution in blinkpy excluding third_party. Change-Id: Ib546bb5fea743484186f62fd6fc1ea561700d610 Reviewed-on: https://chromium-review.googlesource.com/c/1473845Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#632380}
-
Vladimir Levin authored
This patch adds OWNERS for display locking. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I694dd98886d25f061e8541f85eea888968e99e9a Reviewed-on: https://chromium-review.googlesource.com/c/1474330Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#632379}
-
Nico Weber authored
This CL was uploaded by git cl split. R=dahollings@chromium.org Bug: 926235 Change-Id: I84ffed30ef9dd93d3a09ca6e9c07c775d60ca11b Reviewed-on: https://chromium-review.googlesource.com/c/1463461 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632378}
-
David Bokan authored
This CL fixes the ScrollFocusedEditableIntoView method when the focused element is inside a root scroller. This method is used to scroll an editable input box into view on Android/ChromeOS when the user taps on it and the virtual keyboard appears, potentially obscuring it. The first fix is in LayoutBox::ScrollRectToVisibleRecursive. For this use case we have a special option to avoid scrolling the layout viewport that assumed it would always be the root LayoutView. We avoid scrolling the layout view since ScrollFocusedEditableIntoView will queue a smooth animation to scroll and zoom so we'd like to use that. We still perform the ScrollRectToVisibleRecursive so that if the element is obscured by other nested content it'll be put into view. The second fix is in ComputeScaleAndScrollForEditableElementRects. This method calculates how much scroll and zooming is needed. The results are applied to the layout viewport correctly; however, the input is in document coordinates. This means we're calculating the amount of scroll incorrectly since the content space we care about is that of the root scroller. If we have a root scroller, the document is guaranteed to be unscrollable so document coordinates == frame coordinates. We can simply adjust the coordinates by the root scroller's offset to get into the scroller's content space. Bug: 925245 Change-Id: I383a4a8e1a3a3c7fdd7cb894989a015a9eb25e5a Reviewed-on: https://chromium-review.googlesource.com/c/1469071Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632377}
-
Yining Wang authored
Remove unnecessary functions for single tab mode feature. Bug: 929386 Change-Id: I5a7729e6d7f456b7cca6d0ea088d03b14fe1566e Reviewed-on: https://chromium-review.googlesource.com/c/1469650 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#632376}
-
Saman Sami authored
This CL introduces ParentComponent in LocalSurfaceId which is the bundle of parent_sequence_number and embed_token, fixes some things that go wrong when parent_sequence_number is reset, and adds TODO for the breakages that aren't fixed yet. Bug: 931801 Change-Id: I21dadac5fd152579312fd9e3d717169f2fdc5351 Reviewed-on: https://chromium-review.googlesource.com/c/1470739Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#632375}
-
Joel Hockey authored
CrostiniExportImportUIAllowed is a user policy that controls whether the export / import UI is shown to a user where they can export and import container images in crostini. Bug: 912638 Change-Id: Ia28d1d43ca5bfbb047c6f870a1de7b4d46605fe8 Reviewed-on: https://chromium-review.googlesource.com/c/1468223Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#632374}
-
Alexei Filippov authored
... and remove the latter as it was the last client. BUG=916303,913570 Change-Id: Ida37eda8bcc61ca3382769e650f30165cd184c93 Reviewed-on: https://chromium-review.googlesource.com/c/1465145 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#632373}
-
Benoît Lizé authored
zlib uses malloc() to allocate temporary data. Unfortunately, on Android, jemalloc (malloc()'s underlying implementation) caches temporary data after free() in a thread-local cache. As renderers don't allocate from malloc() often in background threads, this data is not reclaimed. This increases memory usage by up to 256kiB per background compression thread, which is the cause for a sizable malloc() memory regression from foreground string compression (see linked bug). The deeper reason for the regression is more complex, see details in the linked bug, and https://docs.google.com/document/d/1aRIifaHF5l9relq9vHirTOWt2AZoAkDNqHiYZrWGE9A/edit?usp=sharing It involves some interaction between: - jemalloc implementation and memory accounting - Android's configuration of jemalloc - Chrome's allocation and threading patterns - zlib's allocation patterns Nevertheless, the regression is real, and to mitigate it, use PartitionAlloc to allocate zlib's temporary data. This is not necessary for decompression, as the allocation patterns are not the same, and the main thread doesn't have the same issues. As such, only do it for compression, to avoid a needlessly complex CL. On PartitionAlloc vs malloc(): The only path using partition alloc in this CL in from the renderer process, where it is already widely used. The issue is less likely to appear in the browser process as malloc() is more widely used there, though further investigation may reveal issues. Android vs everywhere: The issue is present at least with jemalloc(), that is Android. However thread caches and arena-allocators are used on other platforms as well, and as the allocation is not performance-sensitive, using PartitionAlloc everwhere makes the code simpler, and protects against potential issues (as we know that this specific issue does not arise with PartitionAlloc). Bug: 931553, 924164 Change-Id: I9e94e9cea5d51fac67b04fdb1681427e57bfbe1f Reviewed-on: https://chromium-review.googlesource.com/c/1472578 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632372}
-
Karan Bhatia authored
Introduce RulesetSource struct to be used for indexing code. This should help make the indexing code a bit more generic since it does not need to assume the location of the json and indexed ruleset files. BUG=930961 Change-Id: I9f6f63434adbe8d3fbc0e5148c466c578c3dd422 Reviewed-on: https://chromium-review.googlesource.com/c/1466281Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632371}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452a49f4b699..3ab00a7d068b git log 452a49f4b699..3ab00a7d068b --date=short --no-merges --format='%ad %ae %s' 2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@3ab00a7d068b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I04ef2e71f5f17a57dfde673f62d5d965702092b9 Reviewed-on: https://chromium-review.googlesource.com/c/1473875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632370}
-
Nico Weber authored
This CL was uploaded by git cl split. R=japhet@chromium.org Bug: 926235 Change-Id: I46f54cabb463e6322effde6316335e8d5e04abb8 Reviewed-on: https://chromium-review.googlesource.com/c/1464130 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632369}
-
Daniel Bratell authored
There are two namespaces in extensions named GetRefererrChain and in jumbo builds the identically named namespace aliases create for them clashed. This just uses the full namespace name instead of using aliases so that it's always clear (to compiler and humans) which one is used. Bug: 914411 Change-Id: I43336e962a82756bf4be7db74417c6a1fc78e889 Reviewed-on: https://chromium-review.googlesource.com/c/1472571Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#632368}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6fe9b9821a1a..1541c8ba7a7e git log 6fe9b9821a1a..1541c8ba7a7e --date=short --no-merges --format='%ad %ae %s' 2019-02-14 enga@chromium.org Remove |start| and |size| from buffer mapping 2019-02-14 enga@chromium.org Split wire tests into multiple test files 2019-02-14 cwallez@chromium.org QueueSumit: Validate commands != nullptr before checking they are valid Created with: gclient setdep -r src/third_party/dawn@1541c8ba7a7e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931880 TBR=cwallez@chromium.org Change-Id: If917d0170c30ee1d2cbb1bf8b9e621edc9e1aadd Reviewed-on: https://chromium-review.googlesource.com/c/1473879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632367}
-
Yuri Wiitala authored
This moves TabCapturePerformanceTest and CastV2PerformanceTest into browser_tests. By default, they have been changed to run in a quick- check mode. When run for performance testing on the perf bots, the additional --full-performance-run command line switch will be required. The performance_browser_tests isolate config has been changed to run browser_tests with the --full-performance-run switch, gtest filters, and timeout overrides. Also, the old performance_browser_tests GN test target has been turned into a simple group target that groups the necessary data dependencies for running on the perf bots. This change also includes some changes to allow the tests to complete in the absence of tracing data when in quick-check mode. While most bots do collect a reasonable amount of tracing data in a few short seconds, one or two don't always do so. Unfortunately, we can't justify making the CQ run longer to force data collection in all cases. Bug: 804191 Change-Id: I2de6c0b94453981fb0d9015f6b3f0e42f57cc2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1428399 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#632366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/126ac6365c3c..10f3c40674e4 git log 126ac6365c3c..10f3c40674e4 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 bungeman@google.com Don't respect FontConfig matrix for bitmap fonts. 2019-02-14 fmalita@chromium.org [SVGCanvas] Clean up public factories 2019-02-14 bungeman@google.com Defer loading particle effect to load time. 2019-02-14 robertphillips@google.com Baulk at creating wait semaphores if we can't always delete them 2019-02-14 michaelludwig@google.com Add blendmode to GrRTC::drawTexture 2019-02-14 egdaniel@google.com Use kRGB_888x_SkColorType when importing R8G8B8X8 AHB. 2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1f0e830f..b698b62f (516 commits) 2019-02-14 halcanary@google.com resources: add text for testing shaper 2019-02-14 egdaniel@google.com Add kRGB_888X_GrPixelConfig Created with: gclient setdep -r src/third_party/skia@10f3c40674e4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I06dfd4e1a0a633f695e0a4008d02f7f77ed5f377 Reviewed-on: https://chromium-review.googlesource.com/c/1473874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632365}
-
Alexandros Frantzis authored
It's likely that at some point in the past Exo didn't properly emit release events for buffers that were still attached to a surface when that surface was destroyed. Add this test to check that Exo now provides the expected behavior and ensure we don't regress in the future Change-Id: Ic73a49aebd9693b701c77580645d49e32dd96aca Reviewed-on: https://chromium-review.googlesource.com/c/1458258Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#632364}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffa447f419e1..0444f9acb88d git log ffa447f419e1..0444f9acb88d --date=short --no-merges --format='%ad %ae %s' 2019-02-14 manojgupta@google.com chromeos_config: Make {arm64-generic|kevin64}-paladin important. 2019-02-14 cjmcdonald@chromium.org chromeos_config: Enable internal manifest for goma-full builder 2019-02-14 dgarrett@google.com default PreCQ: Remove betty-arcnext-pre-cq 2019-02-14 evanhernandez@chromium.org cros branch: Validate version after syncing. 2019-02-14 evanhernandez@chromium.org cros branch: --force overrides version check. 2019-02-14 evanhernandez@chromium.org cros branch: Final cleanup. 2019-02-14 evanhernandez@chromium.org cros branch: Users confirms generated branch name. Created with: gclient setdep -r src/third_party/chromite@0444f9acb88d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia2c7e5d2d9ef7a8dba0808aaad32e0c8e6aa6b8d Reviewed-on: https://chromium-review.googlesource.com/c/1473873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632363}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0167a20b0af8..1b0047f21017 git log 0167a20b0af8..1b0047f21017 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 stevenperron@google.com Add pass to remove dead members. (#2379) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b0047f21017 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idef7a1d3aa1d0201af32934afa3275925caa16f6 Reviewed-on: https://chromium-review.googlesource.com/c/1473871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632362}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52047de4d41f..77874e2ca341 git log 52047de4d41f..77874e2ca341 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 timvp@google.com Vulkan: Reduce Default Descriptor Pool Max Sets Created with: gclient setdep -r src/third_party/angle@77874e2ca341 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I12682e011aa292292d5f04bf459dac8e9bf3b541 Reviewed-on: https://chromium-review.googlesource.com/c/1473872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632361}
-
Eugene But authored
Previously this class was used for SadTab presentation. Bug: 616244 Change-Id: I8f8fcf722e79a723dd279c0be5f4348e3876069e Reviewed-on: https://chromium-review.googlesource.com/c/1467983Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#632360}
-