- 18 Apr, 2013 2 commits
-
-
mmenke@chromium.org authored
and update the mouseover help. BUG=116601 Review URL: https://codereview.chromium.org/13725016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194731 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The test verifies that the autocomplete list is shown properly. BUG=179976 TEST=none Review URL: https://codereview.chromium.org/14312009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194730 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Apr, 2013 38 commits
-
-
apatrick@chromium.org authored
Review URL: https://codereview.chromium.org/14111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194729 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=232851 Review URL: https://codereview.chromium.org/14225020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194728 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=232950 TEST=see bug Review URL: https://codereview.chromium.org/14093019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194725 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
OSNAME was being used before it was set. BUG=None TEST=trybots Review URL: https://codereview.chromium.org/14235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194724 0039d316-1c4b-4281-b951-d872f2087c98
-
dtu@chromium.org authored
BUG=222657 R=dtu@chromium.org Review URL: https://codereview.chromium.org/12742009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194723 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Removes force-posting and DoXXX() methods since they're unnecessary. Also removes stream_type_ member variable since it can be easily retrieved from demuxer_stream_->type(). Review URL: https://codereview.chromium.org/14232017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194721 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=232924 TBR=mnissler@chromium Review URL: https://codereview.chromium.org/14225019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194720 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
Delete webkit directory on initial sync as well, as the previous bisection may have left the depot with an old copy of Webkit lying around. BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14265008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194718 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
BUG=232877 Review URL: https://codereview.chromium.org/14205019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194715 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
Currently we animate icon status every time the user opens a new window. This CL changes the low severity update status to only animate for the first window. BUG=180107 TEST=Ran Chrome with --simulate-upgrade. Verified that the low severity status was not animated when a new window was opened. Review URL: https://codereview.chromium.org/14245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194714 0039d316-1c4b-4281-b951-d872f2087c98
-
shishir@chromium.org authored
BUG=232625 Review URL: https://codereview.chromium.org/14161020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194713 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. Also: 1. Removed RendererAudioOutputDevice class, since it's no longer necessary to manage asynchronously associating a render view with a stream. 2. Clean-ups: Applied several changes/bug fixes to bring the audio input classes/impls up-to-date w.r.t. the audio output classes/impls. Filed bug 179597 for follow-up. 3. Added missing plumbing for associating audio input devices created by WebRtcAudioCapturer to render views. 4. Updated unit tests. BUG=166779 TEST=media_unittests, content_unittests, TSAN, chrome/test/functional/webrtc_*.py, and manual testing described in http://codereview.chromium.org/11359196/ Review URL: https://codereview.chromium.org/12383016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194711 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
auto_login_info_bar_delegate.* -> auto_login_infobar_delegate.*, for consistency with rest of codebase. BUG=none TEST=none Review URL: https://codereview.chromium.org/14312005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194709 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=222681 For browser_process_impl.cc: TBR=sky@chromium.org Review URL: https://codereview.chromium.org/14017013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194708 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown. Currently, this generally happens at construction. Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase. Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much. BUG=none TEST=none Review URL: https://codereview.chromium.org/14327008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194707 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=ilevy@chromium.org BUG= NOTRY=True Review URL: https://chromiumcodereview.appspot.com/14330011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194706 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
Things like swap are concepts of an OutputSurface, not a context. Moving the callbacks to OutputSurface will also reduce cc's knowledge of the context guts and let us swap out the GL interface. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194394 Review URL: https://codereview.chromium.org/12545018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194700 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=224974 Review URL: https://codereview.chromium.org/14198004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194699 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
Because open/close will change the notification status (read/shown), it should send Updated to the observers. BUG=232030 TEST=manually (see repro steps in the bug) R=dewittj@chromium.org Review URL: https://codereview.chromium.org/14299007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194698 0039d316-1c4b-4281-b951-d872f2087c98
-
bshe@chromium.org authored
BUG=226680 Review URL: https://codereview.chromium.org/13483011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194697 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
This should be = now. TBR=nduca@chromium.org BUG= Review URL: https://codereview.chromium.org/14161019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194696 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
TBR=stevenjb@chromium.org BUG=232924 Review URL: https://codereview.chromium.org/14093018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194695 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
In immersive fullscreen the "top container" holding the tabstrip and toolbar can slide down over the web content. Instant extended shows suggestions in an overlay web view, this must be adjusted to match the omnibox position when the top container is revealed. Instant extended also shows a suggestion+result page in the active web view, which must also be adjusted to align with the omnibox. BUG=169414 TEST=Added to interactive_ui_tests BrowserViewTest and also manual. On Chrome OS, enable the flags for instant extended and immersive fullscreen. Open a normal tab and one to the NTP. Test omnibox suggestions in both tabs, ensure they align with the omnibox. Hit F4 to go into fullscreen, do the same tests. Select "Show Bookmark Bar" and repeat both sets of tests. TBR=sreeram@chromium.org for instant_extended.html changes Review URL: https://codereview.chromium.org/13684002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194694 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
string_piece.h was moved into base/strings/ in r191206 - https://chromiumcodereview.appspot.com/12982018/ TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14272007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/14178005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194692 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
Review URL: https://codereview.chromium.org/14023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194691 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@google.com authored
Provides a 3x speedup on all platforms for subsequent kernel creations with only an extra 8k in memory. BUG=none TEST=media_unittests Review URL: https://codereview.chromium.org/13741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194690 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
A 0 mask resource means we don't use a mask, it's a valid value. Don't iterate over it, because we never want to send 0 to the parent, nor do we want to look up 0 in the child->parent map. BUG=None Review URL: https://codereview.chromium.org/14167007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194689 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=231523 Review URL: https://codereview.chromium.org/13925019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194688 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
This allows us to have multiple instances of a specific component, for example each renderer will have a separate main thread and compositor. BUG=155367 Review URL: https://codereview.chromium.org/13874002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194687 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
The creation date in GetChildPids is in the form <date>[-+]<timezone>. The old code only handled negative timezones. This updates it to handle both. BUG=232254 TEST=morejs page cycler on windows with timezone set to israel NOTRY=True Review URL: https://codereview.chromium.org/14328005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194686 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
For some reason, the offline load page is not picking up the default system font but instead defaulting to Times New Roman. This CL fixes it by explicitly setting the font style for the page body. R=dbeam@chromium.org BUG=223934 TEST=Go offline and verify that the font used is the ChromeOS system font. Review URL: https://codereview.chromium.org/14311003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194685 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
Bluetooth mice are not required to be paired, but we attempt to pair to them anyway because some mice, namely the Apple magic mouse, require pairing. Some other mice do NOT support pairing or pretend to support it without doing it properly. This patch adds a small database of bluetooth mice known to not support pairing and tries to connect to them without pairing. BUG=210518 TEST=Attempt to pair with a Verbatim mouse. No pincode should be ask and the mouse should just work. Review URL: https://codereview.chromium.org/13933012 Patch from Alex Deymo <deymo@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194684 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=none TEST=compiles Review URL: https://codereview.chromium.org/14225012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194683 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
- frame called ::SetCapture - mouse down on menu button - menu opens and calls ::SetCapture - Windows notifies frame that it's lost capture - The DesktopCaptureClient release its internal capture state, but also releases native capture - which releases the menu's capture, not its capture. This makes sure that the window that's releasing capture is really the one that has it. R=ben@chromium.org BUG=232155 Review URL: https://codereview.chromium.org/14312007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194682 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/14101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194681 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
C++11 provides unique_ptr<T[]>, and Chromium has implemented scoped_ptr<T[]> to match its behavior during the transition period. As a result, scoped_array<T> is now redundant and is being removed. BUG=171111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194649 Review URL: https://codereview.chromium.org/14081006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194680 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
See https://codereview.chromium.org/13950005/ for where it's required. R=thakis@chromium.org BUG=232421 Review URL: https://codereview.chromium.org/14093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194679 0039d316-1c4b-4281-b951-d872f2087c98
-