- 28 May, 2019 40 commits
-
-
Lindsay Pasricha authored
Change-Id: Ie54bfcfc27cb89fb4a32af4f5d7e2b37f96a4aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632773Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#663872}
-
Philipp Hancke authored
Avoids race conditions by first setting the remote description before setting the local description. ICE will only start checking (and generating candidates) after SLD. Also avoids the case that candidates arrive before a remote description is set since its always set first. BUG=960718 Change-Id: I38e69f625c8aba82711422812fc9634af647d056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632470 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#663871}
-
Michael Giuffrida authored
chrome/browser/autofill/internal is no longer used. Bug: None Change-Id: I2dd0ec3860ee44062813d4fd9968abad37ba7d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629129 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663870}
-
Saman Sami authored
This reverts commit 03d55735. Reason for revert: fails in debug builds https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)(32)/58947 Original change's description: > Enable the rest of Vulkan viz_unittests > > Except for the video tests, the rest of the tests now pass with Vulkan. > > Bug: 960795 > Change-Id: Ie27b7228934c5540aaf0e670f55e77da96c1f0c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629692 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Auto-Submit: Saman Sami <samans@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663834} TBR=backer@chromium.org,samans@chromium.org Change-Id: I778429685958a2363d9cb3ccbaab41d729cffcc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632874Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#663869}
-
Archana Simha authored
Bug: 948767 Change-Id: Iff94edda9604b9efa7e9792b7bc5ff224525cd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597540Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Archana Simha <archanasimha@google.com> Cr-Commit-Position: refs/heads/master@{#663868}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 887407 Change-Id: I4b3c95cb3f51a1cbab7b67b01c6c1b47fe643a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632162Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#663867}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/07fc398ca8d7..ce33b6a4cfa0 git log 07fc398ca8d7..ce33b6a4cfa0 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 hbos@webrtc.org Implement QualityLimitationReasonTracker and expose "reason". Created with: gclient setdep -r src/third_party/webrtc@ce33b6a4cfa0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I06edbe25762d957c20f882c7f0e65521eb6b367b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/778c7f117aee..c5b8a73247c4 git log 778c7f117aee..c5b8a73247c4 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@c5b8a73247c4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4263c751d67fd3517281a034735c396cc663a0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632790Reviewed-by:
-
Yun Liu authored
For code coverage tool, we need to specify the src root path refers to a file in code base. proto defined here: https://cs.chromium.org/chromium/infra/appengine/findit/model/proto/code_coverage.proto?q=code_coverage.pro&sq=package:chromium&g=0&l=92 There are auto-generated java files which doesn't exist in the code base but generated at build time e.g. https://cs.chromium.org/chromium/src/out/android-Debug/gen/chrome/android/chrome_java/generated_java/org/chromium/components/security_state/ConnectionSecurityLevel.java https://cs.chromium.org/chromium/src/out/android-Debug/gen/mojo/public/java/bindings_java/generated_java/org/chromium/mojo/bindings/pipecontrol/DisconnectReason.java Skip these generated files coverage info for now. Bug: 966918, 843307 Change-Id: I799e56a863580f649701babbbb359c62519818e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628967 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#663864}
-
behdad authored
At the latest stages of updating the clustering scripts, a bug was found which changes the chosen representatives. This cl updates the pages which fall under representative_mobile story tag. Bug: chromium:963573 Change-Id: I2595c37f24779a7e3e2db0fdc7ba46a8c16c5ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628485Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#663863}
-
Victor Costan authored
Bug: 960603 Change-Id: If242cdce46717cb3e60fdf81b317bb30432b2a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629930 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663862}
-
Mario Bianucci authored
I added a UseCounter in crrev.com/d3116a1e last week, but did not check if the executing window or document were null before accessing them, which caused crashes over the weekend. I'm adding these checks now to avoid those crashes. Bug: 967349 Change-Id: I2f4717338b9731a1aaeae23833153074b51b7661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630711Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663861}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 887407 Change-Id: I9206c2ed05b021f5357b6644dcf8cdf0c10b3267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631284Reviewed-by:
-
rbpotter authored
Print Preview Handler was only observing the identity manager if mirror was enabled. However, mirror is now generally disabled, so Print Preview never actually received any notifications about cookie jar changes. This CL changes PrintPreviewHandler to always add this observer unless cloud print is disabled (in which case Print Preview does not need login information). With the observer, the callback after sign in completion is no longer necessary. If the user signs in to cloud print successfully, IdentityManager::Observer::OnAccountToCookieCompleted() will be called. The reload-printer-list event fired from this function triggers a call to onDestinationsReload(), which is the same call that happens after the sign in promise is resolved. The only expected behavior change from this CL is that if the destinations dialog is open when a user signs in or out in a different tab, the destinations should refresh. Bug: 932692, 958767 Change-Id: Ibdabf382f4eb8f6c438376b2f2415c27f4e9c586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626933Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#663859}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46fe0e4be950..5a808b86d890 git log 46fe0e4be950..5a808b86d890 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 geofflang@chromium.org GL: Allow BlitGL to copy from external textures. 2019-05-28 geofflang@chromium.org D3D: Use the ProgramD3D::GetExecutableTask context for loading program binaries 2019-05-28 syoussefi@chromium.org Vulkan: Have a cubemap as 2D-array view handy Created with: gclient setdep -r src/third_party/angle@5a808b86d890 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967410,chromium:962439 TBR=cwallez@google.com Change-Id: I4254d55ac34703d576bb1800295abde2e5f79f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632673Reviewed-by:
-
Miguel Casas authored
This CL enumerates minigbm supported formats for GBM_BO_USE_TEXTURING, and creates a vector that can be obtained through SurfaceFactoryOzone GetSupportedFormatsForTexturing(). This CL also wires that to a new GpuInfo entry supported over Mojo (and dumped in chrome:gpu). This CL is used in e.g. crrev.com/c/1590464 in GLES2DecoderImpl's GetCapabilities() (vicinity of [1]) to indicate if the platform supports or not P010 (and will possibly be used to address the TODO in [2] where a gles2 FeatureFlag is hardcoded). [1] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?gsn=ContextGroup&g=0&l=4266 [2] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/feature_info.cc?type=cs&g=0&l=1102 Bug: 911754, 646148 Change-Id: I49d6002a06d1f4585956f8f0746ab5349e2714e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612041Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#663857}
-
Alan Cutter authored
This CL makes a distinction between the web app installability code path and the native app (Play) installability code path used by Android using the names "InstallableWebApp" and "InstallableNativeApp" respectively. This also rejigs the WeakPtrFactory arrangement to not require the base class to have subclass only methods. There are no behavioural changes made by this CL. Bug: 964314 Change-Id: I1b1d0d3edf91889da4e3caf673208b9a8671fbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626056 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#663856}
-
Clark DuVall authored
- TrustedWebActivityTest.launchesTwa has been fixed - OverviewListLayoutTest.testCanSwipeClosed has the @RetryOnFailure annotation, so is expected to fail once in awhile (see http://crbug.com/943835) - AccessorySheetViewTest.testRemovingTabDeletesItsView does not exist anymore at that location so wasn't doing anything - I will monitor AutofillAssistantUiTest.testStartAndAccept to see if it continues to flake Remaining tests in this file are either related to test-only ContentMockCertVerifier issues with the WebAPK tests or expected failures in the Features test which expect no features to be enabled. Bug: 943847, 943835, 943829 Change-Id: I4cc051fd6c8e27c7ffe866664397da452c1f9c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632715Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663855}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/78b2b18661fc..5a06fa466186 git log 78b2b18661fc..5a06fa466186 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 zoddicus@users.noreply.github.com Add fuzzer for Vulkan->WebGPU spirv-opt passes (#2626) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5a06fa466186 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I0436e125ccac660aff77cd3cbf630ecefe86271d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632675Reviewed-by:
-
Eugene But authored
This CL makes changes to the files, so they either compiled without (or with fewer) errors with EG2. Updated EG1 build target with proper EG1 defined. This CL does not add files to EG2 target, because tests are failing because of EG2 helper absence. Bug: 922813 Change-Id: I0fbb023d5861405a7324521c0f34f114ec29868e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632591 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Julien Isorce authored
It was working few days ago but broken with the following CL https://chromium-review.googlesource.com/c/chromium/src/+/1601616 that moved some files from media/gpu to components/chromeos_camera. ERROR at //media/gpu/vaapi/vaapi_jpeg_decoder.cc:24:11: Can't include this header from here. -> include "media/parsers/jpeg_parser.h" Linux Desktop lost vaapi_jpeg_encode_accelerator.cc:VaapiJpegEncodeAccelerator as now it inherits from chromeos_camera::JpegEncodeAccelerator but hopefully it can get back in later. The most important is the decoder and at least it is still there. Bug: 946366 Change-Id: I1b0809beb1d930a4d8e0e84177dfe9295225acda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628110 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#663852}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53146121b8ab..d04aaa3a841a git log 53146121b8ab..d04aaa3a841a --date=short --no-merges --format='%ad %ae %s' 2019-05-28 halcanary@google.com PDF example 2019-05-28 michaelludwig@google.com Reland "Update GrRTC to use GrFillRectOp::MakeGeneric" 2019-05-28 halcanary@google.com experimental/editor: minor change Created with: gclient setdep -r src/third_party/skia@d04aaa3a841a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I44a22676d73847a6cb86d541c6973ec68d3ffb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632672Reviewed-by:
-
Mark Cogan authored
This CL collects various files in the //ios/web/public/ tree that have been deprecated into //ios/web/public/deprecated/. These files consist of (among other things) the public APIs for the non-WebFrames-based JavaScript injection system, and the native content system. The test doubles for these two systems are also (transitively) deprecated, so they are moved into a dedicated :test_doubles source set. The bulk of the changes in this CL are autogenerated updates to include paths. BUILD deps are also updated. Bug: 942244 Change-Id: Iac388492a6ce5ed60e0e6b43deafb09e05030b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631590 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663850}
-
Dominik Laskowski authored
ApplyContentProtection submits an ApplyContentProtectionTask that aggregates existing per-client per-display requests, plus the new request on the given display. The per-client per-display requests are updated when the task succeeds. The ContentProtections passed to ApplyContentProtectionTask may omit displays, which means that protection is not requested and should be disabled. This logic is flawed: submitting two successive requests enabling protection on one display and disabling it on another one results in protection being disabled on both. This notably happens when a window with protected content is dragged across displays. This CL fixes this by tracking requests as long as their client is registered. It also adds validation for client IDs so that pending callbacks don't run if the client is unregistered in the meantime. Bug: 929449 Test: Check HDCP status with modetest in above/other scenarios. Test: display_unittests Change-Id: Id03702fd9673cee2b925b5ba043d086256b4e360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587655Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e01e4e0d6b7..3971b19ba242 git log 7e01e4e0d6b7..3971b19ba242 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 chrisforbes@google.com Fix accidentally considering Workgroup to be explicit layout 2019-05-28 bclayton@google.com Reactor: Add swizzle op for UInt4. Created with: gclient setdep -r src/third_party/swiftshader@3971b19ba242 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133509497 TBR=swiftshader-team+autoroll@google.com Change-Id: I47ed07d6257c69a843ae7f433e6fe8d0a2d7d91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631146Reviewed-by:
-
jonross authored
WindowTreeHostPlatform supported bounds changes where the source of the LocalSurfaceIdAllocation was external. This was to support Mus, where the Window Service would allocate new ids when triggering resizes. On other Aura platforms there were DCHECKs that no other source was setting these ids. As WindowTreeHostPlatform is intended to be the root allocator. With the removal of Mus this is no longer needed. TEST=aura_unittests, manual testing of unified mode Bug: 958239 Change-Id: I595a147cb38c454e3199e9cab9d180719adc9711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625801Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#663847}
-
Tommy Steimel authored
This CL adds a check in the popup menu click handling to only assume an item was selected when the click target is not the popup menu itself. This fixes an issue where the popup would close when a user clicked and dragged between two items (since this sends a "click" event with the parent as the target). Bug: 934225 Change-Id: I67b7079b0a8a0d1d6405953808f805cfed0c83ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632421Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#663846}
-
Raphael Kubo da Costa authored
IWYU rather than relying on it being included implicitly by other headers. This fixes the libstdc++ build: In file included from ../../third_party/blink/renderer/modules/push_messaging/push_subscription_callbacks.cc:5: In file included from ../../third_party/blink/renderer/modules/push_messaging/push_subscription_callbacks.h:9: ../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:19:23: error: no member named 'unique_ptr' in namespace 'std' WebCallbacks<std::unique_ptr<WebPushSubscription>, const WebPushError&>; ~~~~~^ ../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:19:34: error: 'WebPushSubscription' does not refer to a value WebCallbacks<std::unique_ptr<WebPushSubscription>, const WebPushError&>; ^ ../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:16:8: note: declared here struct WebPushSubscription; ^ Bug: 957519 Change-Id: I0394ebe989e62545f5ca0b440204c66b2292c763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631411 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#663845}
-
Doug Arnett authored
It is not actually used yet - just laying some groundwork. Bug: 965277 Change-Id: If453ba2be84c96af1130a83a36eba7fc0c3a7f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628025 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#663844}
-
Jazz Xu authored
This CL prevent fullscreen button and mute button in overflow menu from swallowing event which causes the issue. Bug: 941451 Change-Id: I0e0dc1203df86b0979110da0d78f24d391ae8efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626398 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#663843}
-
Lucas Tenório authored
We want to be able to test the eligibility fetch separately from the Supervision Onboarding flow itself. Bug: 958995 Change-Id: I2ba41fab2446980c2ccd554d6da1492447136250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630983Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#663842}
-
Marcelo Almeida authored
We already separated child and enterprise reporting, by having different implementations for each: respectively ChildStatusCollector and DeviceStatusCollector. Now we are separating the ActivityStorage class, which currently has mixed internals. Notice that there are some side effect refactorings, as with this change the DeviceStatusCollector no longer counts child time (since it is now using the EnterpriseActivityStorage), so we had to remove child related tests from DeviceStatusCollector browser tests. We can also remove child related code from DeviceStatusCollector itself, but since that is a long change by itself, it will be a follow up. Bug: 827386 Change-Id: Ice81fefdabb49a63365af313feb9501272358870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612042 Commit-Queue: Marcelo Almeida <marcelocra@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#663841}
-
Yi Su authored
This CL moves web_kit_constants.* into //ios/web/navigation. Bug: 956511 Change-Id: If4f9e93f7a138577c9719443e7a953beb1b84410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631372Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663840}
-
Roman Sorokin authored
Bug: 967600 Change-Id: I312ccfd2e11cb1c2290ae05a1c32270035dff7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632157Reviewed-by:
-
Brian White authored
Without this, the compiler emits ctor/dtor code to convert constant strings to std::string making the call about 100x larger in size and almost 2x the size of a caching macro instantiation. According to the Android binary-size try-bot, saves about 4K... Specifics: -4,096 bytes main lib size -4,738 bytes normalized apk size InstallSize: -4,122 bytes APK size -4,122 bytes Estimated installed size (Android Go) -4,122 bytes Estimated installed size InstallBreakdown (-4,066 bytes): +28 bytes unwind_cfi (dev and canary only) size -4,096 bytes Native code size +2 bytes Package metadata size Bug: 944842 Change-Id: I4b9bdff28acfa7b0e5146de74fd922a5c8245b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630968Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#663838}
-
Andrew Luo authored
Bug: 607350 Change-Id: I5f936eec76511e5f9956aad1917eb823f79120fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630031Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663837}
-
Xiyuan Xia authored
- Remove app_list_view.mojom and its reference; - mffr mojom::AppListViewState AppListViewState; Bug: 958134 Change-Id: I2c4855b40a5b060fd82231cf3e99abf10fbccdaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628876Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663836}
-
Xianzhu Wang authored
Previously in many geometry functions, kApplyContainerFlip controlled whether the input (when mapping from local to ancestor) or the output (when mapping from ancestor to local) is in flipped blocks direction for now boxes. Many geometry mapping functions forced the flag by default, while others allowed the caller to specify the flag, which was inconsistent. Now remove the flag and let the functions always deal with physical coordinates, and let the callers to meet this requirement. Change-Id: I02c0da9d27fca1a0e2849bde3213c69791e2ad2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614448Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663835}
-
Saman Sami authored
Except for the video tests, the rest of the tests now pass with Vulkan. Bug: 960795 Change-Id: Ie27b7228934c5540aaf0e670f55e77da96c1f0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629692Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#663834}
-
Guido Urdaneta authored
Change-Id: Ie6e60da92860bc8fdee7e10a2e90b563ea7bec7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632242Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663833}
-
