GitLab

TBR=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/510653003

Cr-Commit-Position: refs/heads/master@{#292166}

exitFullScreen() might be call without a prior call to
enterFullScreen() if a "misbehave" app overrides onShowCustomView
but does not add the custom view to the window. This fixes a
crash by returning early from exitFullScreen in that case.

BUG=408133

Review URL: https://codereview.chromium.org/501093007

Cr-Commit-Position: refs/heads/master@{#292165}

BUG=none
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/506313003

Cr-Commit-Position: refs/heads/master@{#292164}

BUG=407860
NOTRY=True

Review URL: https://codereview.chromium.org/480563003

Cr-Commit-Position: refs/heads/master@{#292163}

In the near future, Crashpad (the new Mac crash reporter) will be integrated,
and it should be integrated/exposed transparently to the users of this
component.

BUG=406410
R=blundell@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/485893007

Cr-Commit-Position: refs/heads/master@{#292162}

BUG=408089

Review URL: https://codereview.chromium.org/511863002

Cr-Commit-Position: refs/heads/master@{#292161}

It's trying to use a member variable which doesn't exist, and thus throwing an
exception every time it's used.

The brokenness was introduced by r290923 (
https://codereview.chromium.org/404803003/ ).

BUG=

Review URL: https://codereview.chromium.org/508923002

Cr-Commit-Position: refs/heads/master@{#292160}

Missing GL_TEXTURE_RECTANGLE_ARB definition if gl.h or glext.h is
not included.

Review URL: https://codereview.chromium.org/511793002

Cr-Commit-Position: refs/heads/master@{#292159}

It looks like a SetBorder(NULL) crept into
https://codereview.chromium.org/324393002, and the result is that the chevron
hover effect (i.e., draw a border) is overridden. Remove the call to
SetBorder().

BUG=407518

Review URL: https://codereview.chromium.org/492373004

Cr-Commit-Position: refs/heads/master@{#292158}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#292157}

This CL adds support for collecting tracing data during the execution of browser tests. It is currently not possible to do so, yet it is very useful to be able to collect this data and analyze it without having to step through with debugger.

BUG=

Review URL: https://codereview.chromium.org/506113002

Cr-Commit-Position: refs/heads/master@{#292156}

https://skia.googlesource.com/skia/+log/5e8dbd31de0dff44aff83295bdfe518477a5a088..4473be874f70d4a8833180a7aebcc9d8a0b1de9e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/508113002

Cr-Commit-Position: refs/heads/master@{#292155}

This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.

Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57

Review URL: https://codereview.chromium.org/411913002

Cr-Commit-Position: refs/heads/master@{#292154}

It turns out specifying a "when" option is required, or it throws an
exception :(

BUG=

Review URL: https://codereview.chromium.org/512683002

Cr-Commit-Position: refs/heads/master@{#292153}

Reason for revert:
I should've checked sooner; this is apparently still used by Flash. (See go/UMA, histograms, Pepper.InterfaceUsed)

Original issue's description:
> Remove unused PPB_View_Dev
>
> TBR=binji@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2210d5fb49cd4b75972f2e304b29637c050de4f1

TBR=binji@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/512703003

Cr-Commit-Position: refs/heads/master@{#292152}

If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.

This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.

BUG=404884
TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html

Review URL: https://codereview.chromium.org/501823002

Cr-Commit-Position: refs/heads/master@{#292151}

BUG=None

Review URL: https://codereview.chromium.org/456793002

Cr-Commit-Position: refs/heads/master@{#292150}

Update to a recent version of AOSP master. The primary effect on
Chromium is that the android_aosp bot will now use a recent version of
clang when building chromium targets for host and thus we no longer need
to support using gcc 4.2 or 4.6 to compile host code here.

BUG=377684
NOTRY=true

Review URL: https://codereview.chromium.org/514653002

Cr-Commit-Position: refs/heads/master@{#292149}

Add missing variables (android_ndk_*) for building Chromium for MIPS64.
In addition to this, set default mips_arch_variant-s for different MIPS
platforms.

BUG=400684

Review URL: https://codereview.chromium.org/494713002

Cr-Commit-Position: refs/heads/master@{#292148}

HostZoomMap will be moving from BrowserContext to StoragePartition soon
as part of fixing this bug. Many sites will still want to access the
default HostZoomMap for a BrowserContext, so we will rename this
function in order to be clear about that.

BUG=335317

Review URL: https://codereview.chromium.org/506073002

Cr-Commit-Position: refs/heads/master@{#292147}

ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate

Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.

BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/506483002

Cr-Commit-Position: refs/heads/master@{#292146}

BUG=395622

TEST=automated

Review URL: https://codereview.chromium.org/454173002

Cr-Commit-Position: refs/heads/master@{#292145}

BUG=

Review URL: https://codereview.chromium.org/512713002

Cr-Commit-Position: refs/heads/master@{#292144}

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180903:180956&mode=html

TBR=gavinp@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/513753002

Cr-Commit-Position: refs/heads/master@{#292143}

Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo originally landed in https://codereview.chromium.org/442313002/

The only difference is that the test has been disabled on
DrMemory since it times out. Notice that many WebRtcBrowsertests are disabled due to the same reason.

BUG= 403070, 398844

Review URL: https://codereview.chromium.org/478543004

Cr-Commit-Position: refs/heads/master@{#292142}

We're getting away without checking bounds today because we're building
and checking a bounding-box hierarchy at record time; draws outside the
picture bounds happen to never be recorded.

This isn't a guarantee of the recording API, and indeed doesn't happen if you
record without a bounding-box hierarchy.  We want to lean on this lack of
guarantee a bit more.  To cut down on time spent recording, we may move around
when we build a bounding box hierarchy.  The upshot is that the SkPicture may
contain commands that won't draw anything, and AnalysisCanvas might receive them.

In short, the safe thing to do is quickReject just like SkCanvas does.

tested: cc_unittests, unit_tests

(Background: found this when debugging PicturePileImplTest.AnalyzeIsSolid* failures from  http://crrev.com/504823003)

BUG=

Review URL: https://codereview.chromium.org/505263002

Cr-Commit-Position: refs/heads/master@{#292141}

BUG=None

Review URL: https://codereview.chromium.org/504183005

Cr-Commit-Position: refs/heads/master@{#292140}

Cr-Commit-Position: refs/heads/master@{#292139}

This CL switches CryptohomeAuthenticator's mount code from the old
MountAsync() method that takes a password to a MountEx() that takes a
Key for authentication.

BUG=367847
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/488633003

Cr-Commit-Position: refs/heads/master@{#292138}

Revert of mojo: generate Proxies and Stubs for java bindings. (patchset #16 of https://codereview.chromium.org/411913002/)

Reason for revert:
Fails license check on android bot:

http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64641

Original issue's description:
> mojo: generate Proxies and Stubs for java bindings.
>
> This CL allows to generate Stub and Proxy of mojo service in java. This
> allows to call interfaces method through message pipes.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57

TBR=ppi@chromium.org,rmcilroy@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/511543005

Cr-Commit-Position: refs/heads/master@{#292137}

This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.

Review URL: https://codereview.chromium.org/411913002

Cr-Commit-Position: refs/heads/master@{#292136}

Having both username and password empty is incorrect. We should find out where they come from.

BUG=404012

Review URL: https://codereview.chromium.org/514573002

Cr-Commit-Position: refs/heads/master@{#292135}

This reverts https://codereview.chromium.org/493123002. There were too many generated crashes.

BUG=407767

Review URL: https://codereview.chromium.org/512673002

Cr-Commit-Position: refs/heads/master@{#292134}

Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)

Reason for revert:
Build failure on Google Chrome ChromeOS:

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164

Original issue's description:
> Remove the last piece of deprecated synchronous IO code.
>
> BUG=337096
> TEST=bots
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193

TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=337096

Review URL: https://codereview.chromium.org/509893002

Cr-Commit-Position: refs/heads/master@{#292133}

BUG=337096
TEST=bots

Review URL: https://codereview.chromium.org/460373002

Cr-Commit-Position: refs/heads/master@{#292132}

BUG=404818

Review URL: https://codereview.chromium.org/498653003

Cr-Commit-Position: refs/heads/master@{#292131}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/507773002

Cr-Commit-Position: refs/heads/master@{#292130}

This callback is needed to measure the performance of booting ServiceWorker.

BUG=401389
TEST=N/A

Review URL: https://codereview.chromium.org/493373002

Cr-Commit-Position: refs/heads/master@{#292129}

predictor.

R=asvitkine@chromium.org, jkarlin@chromium.org

Review URL: https://codereview.chromium.org/498223002

Cr-Commit-Position: refs/heads/master@{#292128}

The file can be moved into the component as-is.

BUG=373245

Review URL: https://codereview.chromium.org/506863003

Cr-Commit-Position: refs/heads/master@{#292127}