- 04 Aug, 2020 40 commits
-
-
Scott Violet authored
Specifically if the url is the same as the last page and the navigation is a same-document navigation, then FaviconHandler need not do anything. This scenario happens when using history.replaceState() and the like (which is used on the SRP). BUG=none TEST=covered by test Change-Id: Ida3aabeefb1cef033b68b667049fa724efe7b4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335024Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794559}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I35fabb6b626d8763b37ce71e6bd01505cf5b74ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331417 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#794558}
-
Elly Fong-Jones authored
Currently, feature initialization looks like this: 1. The pref store is initialized (which contains saved flag states) 2. A FlagsState instance is initialized from that prefs store a. FlagsState computes which switches and features should be in what states based on flags b. FlagsState excludes switches and features from flags that are currently expired 3. A FeatureList is initialized from that FlagsState Unfortunately, deciding whether a flag is expired or not requires knowing the state of the various TemporaryUnexpireFlagsM$M features, which aren't initialized until step 3, so step 2b doesn't actually work properly. During step 2b, every unexpiry feature is treated as if it was in its default state (i.e. disabled), which means that every flag whose expiration has passed is treated as expired, regardless of the state of the unexpiry flag. As a result of *that*, when the FeatureList is initialized at step 3, any such flag's configured value gets ignored. The fix for this is deeply unfortunate: at step 2b, add a special case in checking whether a flag should be considered expired or not. Specifically, consider not just the state of the unexpiry feature (which may not have been initialized yet) but also the state of the backing unexpiry *flag*. To enable this, pass a FlagsStorage into the FlagsState::Delegate. Change-Id: Ia2b6423357d24318baaeb3ca34208d1a2f1c36aa Bug: 1101828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302925Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#794557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d14d99cd75b8..46b0d8780f66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I583f21fe009238abe16fd7454c6b90ea4aa0f62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794556}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6 2020-08-04 hjd@google.com Merge "Support armv7l in system_probes_parser" 2020-08-04 lalitm@google.com Merge "tp: switch from dict to list of pairs in descriptor generation script" 2020-08-04 hjd@google.com Merge "Call sendfile in a loop to handle short writes" 2020-08-04 lalitm@google.com Merge "ui: fix searching for data bounds on tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36af41efbcb71eba7c1b942c3c89e1fc9d2712e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336765Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: Id709ff4a489dd156ef6dd1daed24292eae0c9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331439 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I5a0fb2249ccea2f240ba6031859fdcd8736b44d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331381 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#794553}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: Ia2d55b24d2b9fd458d01ae2a44471f6a0eebe340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331380 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Sicheng Li authored
1. Adds junit test -- CustomTabIntentDataProviderTest#defaultOrientationIsSet. 2. Adds new instrumentation test -- TrustedWebActivityOrientationTest. Bug: 812797, 989606 Change-Id: If7ee74c1d65bb3300132696dc4a78063579a7dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327611 Commit-Queue: Sicheng Li <scli@google.com> Auto-Submit: Sicheng Li <scli@google.com> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794551}
-
Kevin Ellis authored
Change-Id: Ifd4c7d4a9ffe6f3f763f7ee458c6f04523f3350c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333679Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#794550}
-
Daniel McArdle authored
The fuzzer found a test case that causes the BackoffEntry deserializer to discard the absolute timeout and fall back on the relative timeout. BackoffEntry::GetReleaseTime() is actually not guaranteed to equal the original release time (before serialization). However, it is guaranteed to be less than or equal to the original release time. This CL weakens the fuzzer's property check accordingly. Bug: 1085995 Change-Id: I1dafb08575e73b0548f973565145c8ba7890a33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324111Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794549}
-
Joe DeBlasio authored
This CL just flips the newly-introduced parameter to default to enabled when left unspecified. Keeping it default-enabled makes it much easier to test manually, and for now I'd like to maintain the manual testing. It'll be explicitly disabled via finch when not wanted. Bug: 1111731 Change-Id: I0502f6eecf51c7a6f44fc544f0797dbc98b4c3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332520Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#794548}
-
Kyle Horimoto authored
This moves ParseAddress() and CanonicalizeAddress() to //device/bluetooth/public/cpp. These functions are not specific to BluetoothDevice and are utility functions which more naturally fit in the public directory. This CL is a precursor to adding a Bluetooth address field for Phone Hub. Bug: 1106937 Change-Id: I5b321136a10715a50767b0d2c8536a96cadc4f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335676 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794547}
-
Tommy Li authored
This CL updates all the UI callsites to use the new AutocompleteResult::IsSuggestionGroupIdHidden() method, which respects the server-provided hint as to which groups should default-hidden. This CL also deletes the deprecated omnibox::IsSuggestionGroupIdHidden() method, which is no longer used after this CL. This CL also deletes the deprecated omnibox::ToggleSuggestionGroupIdVisibility() method, and migrates all callsites to the omnibox::SetSuggestionGroupVisbility() method. Bug: 1106096 Change-Id: I00a6248a65a4b2567fae204438534d1735020fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330320Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794546}
-
Viktor Semeniuk authored
Fix introduced earlier doesn't solve the issue fully. The crash is caused by calling reconfigureCellsForItems from loadModel. By removing that the problem should be gone. Bug: 1112344 Change-Id: I798b909182a5d59c653dc0c212c31225d59b9919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336077 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794545}
-
Milica Selakovic authored
Design mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_56 Bug: 1110309 Change-Id: Id0e4316e71d57b80271c0a596cd4de505dc1e54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332164Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#794544}
-
Chris Lu authored
Mark self.started as NO in stopAnimated: before calling dismissal callbacks in the Infobar Overlay Coordinators will prevent successive calls to stop from executing. This is bad because the request will be destroyed in the first callback sequence, and then a DCHECK will fail in a successive sequence. Bug: 1112482 Change-Id: I13f487ebe99f593e253a70af8f26a79375210fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335408 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#794543}
-
Chris Lu authored
This was a feature of Messages, and was neglected in the Overlay implementation. Bug: 1112421 Change-Id: I5fdc5cf993ed50f48ae6b0f14c167051891c8c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335553 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Swapnil authored
During the sync of the protos on client side and server side, it was requested to change UNKNOWN field to FAILURE_REASON_UNKNOWN to avoid confusion in the future and to be in sync with the guidelines. Bug: 1106343 Change-Id: I40c6a3e4a0299dfa7a8360dcc44bb09292ee57b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336079Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#794541}
-
Ricardo Quesada authored
This reverts commit 55c54eed. Reason for revert: Introduced flickering and weird artifacts in ARC P and ARCVM. http://b/162704898 https://crbug.com/1112017 Original change's description: > exo: Set the gfx::NativePixmapHandle modifier > > This will forward the modifier all the way to the eventual EGLImage or > gbm bo import such that GLES or KMS will properly understand the > buffer layout. > > BUG=b:145579089, b:79682290 > TEST=wayland_rects_client --use-drm=msm and verify modifiers get passed > > Change-Id: Ia422c3713f1a9384aa737c3d1cccb1dd76709e18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314984 > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Fritz Koenig <frkoenig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793405} TBR=frkoenig@chromium.org,lpique@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:145579089 Bug: b:79682290 Change-Id: I15f20a639d9fe532cf03022f566dfa539100eeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335817Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#794540}
-
David Roger authored
Screenshot: https://screenshot.googleplex.com/UaY0XVo8r6B.png With dark background: https://screenshot.googleplex.com/zkCm5YkgnpS.png Bug: 1076880, 1099286 Change-Id: I5255ce9f25d88c19b7d24cb684f574cc544cb63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328854Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794539}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a482652ab18..d14d99cd75b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib10c82a69060d54ebcf128d55aa4bf1dc34f9766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336503Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596523951-c381c0b70edf8b236c69b708afa84878f43cb61f.profdata to chrome-win32-master-1596527967-453034edae7748ca30b46c873b3303e5191c764d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id3f0754b6aa20193f3887acbf121aa0f18592cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336761Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/16150ea24b1e..965b1ffc561e 2020-08-04 sigurds@chromium.org Revert "Migrate browser_debugger to devtools_entrypoint" 2020-08-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-04 aerotwist@chromium.org Migrate browser_debugger to devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2faca9462e134f7f0241991625b1195b914962ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336763Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fbfa898df70..a79b9fd7235f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sinhak@google.com Change-Id: I55c8774dd72677c6822c58c62a5e2cd82f01ed00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794535}
-
Domenic Denicola authored
Per https://crbug.com/1103866, we eventually want to rename originIsolationRestricted to originIsolated. This is an initial update of all the plumbing in that direction, updating everything except the JavaScript-exposed API name. Bug: 1103866 Change-Id: I3f091ebfb9f27ac5e505596212682e3de0fbe0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335476Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#794534}
-
Alice Wang authored
This CL re-enables bookmark signin promo dismiss tests on tablet. The fix is already landed in another CL. Bug: 1103210 Change-Id: I63568482e6d64ec9aa2ca96059bcfbe8accd85c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326714Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794533}
-
David Bienvenu authored
Bug: 600915 Change-Id: Ie4125a40ecf161481bc03fd500ae5d202d8a9cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312956Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/471235dba5ca..1e4158db1ce7 2020-08-04 michaelludwig@google.com Add contains(SkPoint) to SkRRect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I6b66da8c8920a5f847cf11c58b53a073e95baaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336757Reviewed-by:
-
David Bokan authored
The doc refers to an `associated` keyword which doesn't exist and isn't used in the examples. I've updated it to refer to associated_pending_remote/receiver. It's also not clear (to me, at least) why an associated remote it "set" while a receiver is "get", the getter doesn't actually return anything. I've updated these to just say "pass". Change-Id: Id3a08146f31c576696a1b437bcc63f81aa8b380f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333386 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#794530}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/26d2e0461340..bec988515e9c 2020-08-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 928b7b26bd73 to f881f08358b0 (2 revisions) 2020-08-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b78f4b1518e0 to 92a71657fcba (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ife364fae6dbfc3e22435749afcf6aadd9c06b680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336755Reviewed-by:
-
Aaron Krajeski authored
Bug: 1112771 Change-Id: I267f6cfd80ed05097ce5ee9777186e944ff1a6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333682Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#794528}
-
Xi Han authored
This CL fixes the race condition that favicon is fetched before TabListFaviconProvider is initialized. Bug: 1110071 Change-Id: Ib87ab986d5b0b633ef7f358b411ebc37512264d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321304Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794527}
-
Irina Fedorova authored
Update style of password_edit_dialog to be consistent with password_check_edit_dialog. Screenshot of password_edit_dialog before and after changes: https://bugs.chromium.org/p/chromium/issues/detail?id=377410#c96 Bug: 377410 Change-Id: I67ef77f2e048988236da62cbe7fab8b717233dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332580 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794526}
-
Monica Basta authored
This CL adds a checkbox to the main view of the profile picker. By default the profile picker frequency is set to be shown on every startup. The user can decide to change that by checking/unchecking the 'Ask on startup' option. The profile picker is meant to be shown in the picker window and is a singleton not in a chrome tab, for that reason the profile picker does not listen on changes to |kBrowserShowProfilePickerOnStartup|. Screenshot: https://drive.google.com/file/d/1UH63Pl773SQ95iSLzxnnaPTjwJ5KwxJD/view?usp=sharing Bug: 1063856 Change-Id: I2e8f71abb8ad93a3e0f5dfd84426a7deb0ea15b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333834 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794525}
-
Vikas Soni authored
Refactor out common code to generate SyncToken dependencies. Bug: 1091945 Change-Id: I69ae971959f334fedc28c8f0d83103178b9081f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336499Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794524}
-
Richard Knoll authored
NearbySharingService needs to inherit from KeyedService so we can inject fake implementations into the NearbySharingServiceFactory. Bug: 1112723 Change-Id: I146b138f5a0e0f4c129abe3fd1c455d3aa21e9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333197Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794523}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I43dafc1cfaf4a98bc9cfc375b2887b9e5a179123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333678Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794522}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7c7bc098. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I078573dfd43e9c5af96ed38f3fa9f320f1e86325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794521}
-
Aaron Krajeski authored
This reverts commit 835d50e1. Reason for revert: Linux CFI failures https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI Original change's description: > Add managed text view in Security settings page. > > Screenshot: http://screen/zaaBRbPGsTd > > Bug: 1097310 > Change-Id: I26b76f2071d4e2ee5b4fc5ff04868b24bed88a8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316829 > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794260} TBR=vakh@chromium.org,chouinard@chromium.org,xinghuilu@chromium.org Change-Id: I065975a7f0ee2fbb6d04b22c36adc12bc8502d13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333685Reviewed-by:
-
