- 05 Mar, 2020 40 commits
-
-
David Bienvenu authored
If the user has more than one profile, specify the profile directory in the jumplist menu item. Bug: 19072 Change-Id: I6ece249f4414d01779f30473a24984a73164e08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079216 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747435}
-
sauski authored
CL 2088233 wrapped some elements on the privacy page into dom-if's such that they no longer appear in the static element map accessed with .$. Code that relied on these elements existing in this map thus failed. This CL changes these call sites to instead use the query selector $$ call, which will successfully return the elements inside a dom-if. Bug: 1058960 Change-Id: I2e0380a7e5f4251865f5ae809037401fccbc7446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090456 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747434}
-
Li Lin authored
Also added rich UI element for KpEntityResultParser. Bug: b/150783279 Test: unit tests Change-Id: Ia40b848f9e9caf8b246627d415b4b41fe188b28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088212Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747433}
-
Noel Gordon authored
This being the source of the crowd's recent oh-ah noises. Bug: 992819 Change-Id: I22c56910f25b1e9b704950ca84716a1fa05a9593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089432Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747432}
-
Patrick Noland authored
The LoadProgress MVC refactoring inadvertently dropped a check against starting load progress for same-doc navs; this patch restores that check. Bug: 1058778 Change-Id: I17087cdefe9ecadb37e6ca84cc75839a7ccee59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088833 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#747431}
-
John Budorick authored
Bug: 1058447 Change-Id: I6783cd081f5396f2c9fd098a31fadd5835c1af67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089990Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747430}
-
Manu Cornet authored
Bug: 1020720, 1009638 Change-Id: If6abc991ec412400449b6501012e200bdf01fb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078556Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747429}
-
Aaron Leventhal authored
Currently table layout interfaces are used in IsDataTable(), but unfortunately these interfaces will not work if a table is styled using another display type, e.g. display: block / flex, etc. This CL does not change how ordinary <table> elements are exposed. It only makes the display style irrelevant in how a table is exposed. Bug: 1011067 Change-Id: I2044015e1ec1345a9bc636f867526c7b75a78041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083602 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747428}
-
Mohamed Heikal authored
This CL adds the 3.11.4 protoc prebuilt binary to the repo to be used to compile java protos used on chrome>Android. Bug: 988512 Change-Id: I30b2d9fde9093f468f4d01b19ece39f4bfb23428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079617 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#747427}
-
mark a. foltz authored
It was enabled by default in M81. Bug: 1032324 Change-Id: I6e9aa76c5cfbae1c239de6b968b1b9e9d66ff7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088342Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b05ca4b6168c..987ef4825826 git log b05ca4b6168c..987ef4825826 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 terelius@webrtc.org Adds field trial to separate audio and video packets for delay-based overuse detection. 2020-03-05 srte@webrtc.org Always limit delay based bitrate by the acknowledged rate. 2020-03-05 danilchap@webrtc.org Fix dependency templates for VP8 3 temporal layers Created with: gclient setdep -r src/third_party/webrtc@987ef4825826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8e9ad1082995ae7cff049053b602810cef9b574c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747425}
-
Nicolas Ouellet-Payeur authored
Previously, IE would be launched directly from the UI thread. This was not only causing jank, but also browser freezes when `DdeConnect()' would take a long time to complete (>1min in some cases). This CL makes `DdeConnect()' and `base::LaunchProcess()' run on a worker thread with blocking allowed, so the browser is still responsive in the meantime. Bug: 1054895 Change-Id: I305063c12ebce67a9feffecfeb9f1d4c75211cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082994 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747424}
-
Mike Dougherty authored
This DCHECK is occasionally hit. Printing the error description will provide more details in order to determine the cause. Bug: 1058354 Change-Id: Ib36ed843aaccb3f83ff0b915bebfe05ac2ce066e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090027 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747423}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/af823daff93a..1bdc5980b3a4 git log af823daff93a..1bdc5980b3a4 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 rwkeane@google.com Discovery: Update config comments Created with: gclient setdep -r src/third_party/openscreen/src@1bdc5980b3a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I92515b019049197b5b210e62e000f276be0f1612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090221Reviewed-by:
-
Luciano Pacheco authored
Add files-ng classes and attribute to main.html so files-ng styles are applied during app startup (to avoid a FOUC flash of non-files-ng blue color). Enable file-ng by default in FilesApp and its browser test harness. Bug: 992818 Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308Reviewed-by:
-
John Budorick authored
Bug: 1054829 Change-Id: I92c11dbac5541ca783895b7afc5d5c172c50f73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089975Reviewed-by:
-
Mohamed Heikal authored
Supersize tiger viewer until now used just a regular fetch since it only dealt with public files. This cl allows it to use Google Cloud Storage' json api to access private files which the user has access to. Bug: 1048299 Change-Id: If4f4015efddea771c0de9fa36193d861a72902e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088639 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#747419}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2dbcbe8b12e8..456f9b5fe9d2 git log 2dbcbe8b12e8..456f9b5fe9d2 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 egdaniel@google.com Reland "Move GrGpuResource GrSurface and GrTexture into src." 2020-03-05 robertphillips@google.com Clean up for DDL program pre-compilation 2020-03-05 robertphillips@google.com Clarify expected compatibility matrix in CharacterizationFBO0nessTest 2020-03-05 nifong@google.com Remove all uses of bones 2020-03-05 herb@google.com Add Multiply-Subtract (fms) to SkVM 2020-03-05 reed@google.com expose per-vertex-data variant of SkVertices 2020-03-05 csmartdalton@google.com Don't rely on primProc textures when adding samplers 2020-03-05 tdenniston@google.com Add command line argument to specify the rendertests file. 2020-03-05 mtklein@google.com move skvm interpreter to SkOpts again 2020-03-05 jlavrova@google.com Adjusting getRectsForRange to grapheme edges. Created with: gclient setdep -r src/third_party/skia@456f9b5fe9d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I44ab28e14bf7aa4ccbcb737e4844958589403297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090219Reviewed-by:
-
Tomasz Wiszkowski authored
This CL deduplicates and consolidates Phone and Tablet behavior. Bug: 1050813 Change-Id: I6bf10f973c1b569570bc56fa821e53a0d69924fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086552 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#747417}
-
Rune Lillesveen authored
StyleResolverState::DistributedToV0InsertionPoint() doesn't mean that it is a V0 host child. There is no use in trying to make sense of that now as Shadow DOM v0 is going away, but the fact that it can actually be a shadow root child means parentElement() might be null. Bug: 1058605 Change-Id: Ia791f2caa1a4c7c19935135611a1fbdcfb07dc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089753Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#747416}
-
Tina Wang authored
- ProfileCardView inherit from textbubble - Add DEPs Bug: 1058144 Change-Id: I1c84bddc824993f170949fa919e8a18e9d9db542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085876 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747415}
-
btolsch authored
win-archive-rel failure appears to be due to lack of dependency between storage_access_api and //content/public/browser, which exports //components/services/public/mojom. Failure here: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/11508 TBR=engedy@chromium.org,sky@chromium.org Change-Id: I31d62ce8e20b4920939842f2816ae3626208bf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090601 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747414}
-
Natalie Chouinard authored
This reverts commit e8a71fe7. Reason for revert: Broke downstream build (remaining reference: https://crrev.com/i/2687160) Original change's description: > [webauthn] Clean up adjusted_timeout > > crrev.com/c/2084725 moved the timeout adjustment logic to the browser > side while keeping the old behaviour to make internal android source > happy. This removes the old behaviour. > > Fixed: 976428 > Change-Id: I2c6acb06f3efc6c4efbfc917b06a06603b81e7e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090091 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747346} TBR=kenrb@chromium.org,nsatragno@chromium.org Change-Id: Ic94a92fdb09d498755d2ad5d6f038b73a23ed8d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090617Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747413}
-
Ender authored
This reverts commit bec9b617. Reason for revert: breaks org.chromium.chrome.browser.compositor.overlays.strip.TabStripTest suite Original change's description: > Fix chopped text on tab switcher long-press menu when text size is huge > > There exists some unknown issue on the measurement of a text view with > a compound drawable. Using a linear layout containing an imageview and > a textview inside can avoid this issue. > > Bug: 1053448 > Change-Id: Ibdcd220e0eba7218c1d500d870da17d37c7e767c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083729 > Commit-Queue: Lijin Shen <lazzzis@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747078} TBR=twellington@chromium.org,lazzzis@chromium.org Change-Id: I8cc77daf8bfdf3a7a74a4288034de5a5ccdbc992 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090598Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#747412}
-
Rahul Arakeri authored
When a user clicks and drags the thumb, the sequence of events that gets generated is pointerdown, pointermoves(s), pointerup. The very first pointerdown sets up the state necessary for the scrollbar thumb drag. The pointerdown also injects a synthetic GestureScrollBegin in the CompositorThreadEventQueue. However, this GSB won't get dispatched until the next VSync. Sometimes, a pointerdown and the following pointermove can arrive at the ScrollbarController before the GSB is dispatched at the VSync. When this happens, the value of the currently_scrolling_node is null (since the GSB wasn't dispatched yet). This in turn causes the drag_state_ to be nullopt and we get stuck in a state where thumb drag doesn't work (because we keep early'ing out in ScrollbarController::HandlePointerMove). The fix here is to use ScrollbarLayerImplBase::scroll_element_id() to look up the target node. That way, even tough the pointermove arrives before the GSB, the node to be scrolled can still be queried by ScrollbarController::HandlePointerMove. Bug: 1057929 Change-Id: I5cd584b9298c97fc2feb058aa6b46d264f0cdc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085533 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747411}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/852653954526..55228e53750d git log 852653954526..55228e53750d --date=short --first-parent --format='%ad %ae %s' 2020-03-05 spang@chromium.org Add Chrome texture formats test for VulkanExternalImageTest Created with: gclient setdep -r src/third_party/angle@55228e53750d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058521 Tbr: ianelliott@google.com Change-Id: I3f0fa21b09c3270d3a413e208c717c340ee36075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090218Reviewed-by:
-
yilkal authored
This CL ensures that restored AppStates are not overwritten when OnAppAvailable calls are called. Bug: 1056475, 1019837 Change-Id: I8f8d14300a1e9d63a7e1cfcb2de21beda6ea7123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085844 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747409}
-
Jérôme Lebel authored
-[UIViewController popViewControllerAnimated:] should not be used to know if a view controller is removed or not. This method is called when the view starts to be swapped away. Unfortunately, the gesture can cancel the swipe. This is an issue since the coordinator is stopped and deallocated at as soon as the method is called. This method needs to be replaced by -[UIViewController didMoveToParentViewController:]. This method is called when the view controller is really popped out of the screen. Cleanup for popViewControllerAnimated with: crrev.com/c/2089811 Bug: 1055782 Change-Id: Ibddec42996506eec3d6898ef4a2cc68ab8973784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088516Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747408}
-
Sasha McIntosh authored
In Display::RemoveOverdrawQuads we use the quad->rect area and quad->visible_rect area to influence occlusion culling and quad splitting. In some cases (as found by cluster_fuzz) the rect area does not fit into an int. We prevent these cases by validating the quad rects in mojom_traits. Test: VizSerializationPerfTest.DelegatedFrame_ManyQuads_1_4000 Bug: 1055766 Change-Id: Ia7686f5f9073f39f99b560df32d01efb0faa6903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078737Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747407}
-
Sean O'Brien authored
Add whitelist of stylus bluetooth button devices, and specify that they don't have a keyboard. Bug: b:139781900, b:147859473 Change-Id: Ice2f8bcef453526f2e1f06937fb947a32d92f198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084722 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747406}
-
Morten Stenshorne authored
This field will not be used when painting with LayoutNG fragment traversal. Bug: 1043787 Change-Id: I7196c9ea0175d357a3d7c3f0be4c4044c9a70461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089754Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#747405}
-
Aidan Wolter authored
This will make it easier to modify the sdk path in the future. Bug: None Test: CQ Change-Id: Ib93dbbb45b93b4795d158483d68496d520519a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088735 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#747404}
-
zhaoyangli authored
To make method calls logically cleaner. "TestMethod" is changed to "TestCase" because this is a place to create a configuration that's used across a TestCase. Bug: 1058588 Change-Id: I6da6a19a2ac8321a5bd3c0d66bb36db55039211e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087985 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
-
Ben Joyce authored
Bug: 1052460 Change-Id: I0f7ff8213a5a2513dd6c517957db3756526f8e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090351Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Christian Biesinger authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dbpth-n7LZo R=chrishtr@chromium.org, vmpstr@chromium.org Bug: 991096 Change-Id: Idb7ee2c2995841f185977dd12e52d9b62f60d139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090019 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747401}
-
Peter Kotwicz authored
This CL fixes bug where WebAPKs with adaptive icons would incorrectly think they need to be updated due to the value of WebApkInfo#isIconAdaptive() being incorrect. In particular, the WebApkInfo#create() call in WebappLauncherActivity produces a WebApkInfo where WebApkInfo#isIconAdaptive() == false if native is not yet loaded. This CL: - Only considers OS version when building WebApkInfo object - Modifies WebApkUpdateManager code to enable downgrading a WebAPK from an adaptive-primary-icon to a non-adaptive-primary-icon if the ChromeFeatureList.WEBAPK_ADAPTIVE_ICON feature is disabled. BUG=1058066 TEST=WebApkInfoTest.* Change-Id: I6a00a3046bf1f82fb5fd50e171d35a49a7b6ecba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085392 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747400}
-
Ken Rockot authored
This introduces a new FilesystemProxy API into the Storage Service client library. FilesystemProxy provides common filesystem operations and can operate either directly on the filesystem in an unrestricted mode (which only actually works outside of a sandbox), or it can operate on a remote implementation of a new storage.mojom.Directory interface, securely scoped to a single directory tree within the filesystem. Bug: 1052045 Change-Id: I7fa391f2d29d9475167613c379dea6653ab22b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080588 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#747399}
-
Yiming Zhou authored
This means installing the chocolatey core extension package, which is a requisite of sysinternals, and changing the python2 executable path. Change-Id: I13e1a0b3c493540017137e70b831d12229fa6f93 Bug: 1058970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080082 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747398}
-
Charlie Hu authored
According to https://w3c.github.io/webappsec-feature-policy/document-policy.html#reporting, This CL implements the report-to endpoint mechanism so that each feature can uniquely identify which endpoint to report to. This CL also implements the support for Document-Policy-Report-Only header. Bug: 993790 Change-Id: Ia9588bc6bfaf0b9b0996b45331636ef4f11fe52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025879 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#747397}
-
Lindsay Pasricha authored
This reverts commit 7d6c5197. Reason for revert: This breaks on device runs for xcodebuild_runner. This revert will land before the revert of crrev/c/2048851. Original change's description: > Enable iOS test runner unit tests as part of presubmit > > Run iOS test runner unit tests as part of presubmit. Keeping scope to > functional tests, and will have separate CLs for the remaining files > that require further fixes. > > * PRESUBMIT.py - include unit test execution for ios/build/bots/scripts > * run.py - unit tests caught logic incorrectness. Running the json > parsing first, before validation. > * wpr_runner_test.py - remove install xcode mock, fixed broken tests > * test_apps_test.py and xcode_log_parser_test.py - include main call > to unittest. > > Bug: 1056457,1058257 > Change-Id: Ifc233695ba8f6120f862586a497df61e96d4954f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076765 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746102} TBR=rohitrao@chromium.org,lindsayw@chromium.org,zhaoyangli@chromium.org,jeffyoon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056457 Change-Id: Iaa9e1ca8a6ac76c41e067d17e13108aeeb2ac83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089992Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#747396}
-
