GitLab

We want to connect the source of a resource request with the resource fetch event. Adding the requestId to resource fetch is the first step.

BUG=

Review URL: https://codereview.chromium.org/1815383003

Cr-Commit-Position: refs/heads/master@{#383834}

To support multiple attached devtools, we have to instantiate
individual agents on demand, rather than on creation.
This patch moves regular of agents, with view-specific and worker's left.

BUG=590878

Review URL: https://codereview.chromium.org/1834073002

Cr-Commit-Position: refs/heads/master@{#383833}

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- management.json
- mime_handler_private.idl
- mojo_private.idl
- networking_config.idl
- networking_private.idl
- power.idl
- printer_provider.idl
- printer_provider_internal.idl
- runtime.json

BUG=595949

Review URL: https://codereview.chromium.org/1841543002

Cr-Commit-Position: refs/heads/master@{#383832}

https://boringssl.googlesource.com/boringssl/+log/e29ea166a6ec44bbfce81d1c93f064b9aca0f443..feaa57d13daa0b5bf3c068ce18d24870d50bfae9

BUG=none
TBR=svaldez@chromium.org

Review URL: https://codereview.chromium.org/1844673002

Cr-Commit-Position: refs/heads/master@{#383831}

This CL fixes the following issues in the autoplay experiment:

 - "Any media playback" wasn't checking if the media was playing
   already, so it over-counted quite a bit.

 - "ifmuted" counting was broken, since the autoplay experiment
   didn't call autoplayMediaEncountered in all cases.  For mute,
   this could actually allow the media to start playback without
   preventing additional autoplay metrics for the next playback.

 - made shouldAutoplay not call autoplayMediaEncountered, since
   the experiment might not have overridden the gesture requirement
   yet.  This would generate incorrect metrics in SetReadyState.

 - Adds a metric for "played to completion".

 - Adds metrics for initial playback that capture whether any
   user gesture was seen, and / or if one is active curently.
   This will give us an idea about how often a gesture in
   the inital load() call is responsible for a playback.

 - Added counters for "total media elements seen" and "total video
   elements seen".

BUG=561098

Review URL: https://codereview.chromium.org/1470153004

Cr-Commit-Position: refs/heads/master@{#383830}

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- omnibox.json
- page_action.json
- page_capture.json
- passwords_private.idl
- permissions.json
- platform_keys.idl
- platform_keys_internal.idl
- preferences_private.json
- privacy.json

BUG=595949
TBR=mpearson@chromium.org (trivial c/b/autocomplete/ change)

Review URL: https://codereview.chromium.org/1833773002

Cr-Commit-Position: refs/heads/master@{#383829}

When DevTools draws to capture the screen output for the remote
side, the video draw quad isn't processed as an overlay since
it's not in the root render pass.  However, on android, overlays
aren't optional since Chrome doesn't have the pixels.  So, it
uses the PictureBuffer texture to draw, which obscures the surface
view by removing the transparent box that the overlay put there.

Plus, drawing also happens normally, with overlays (no idea why),
and both results end up on the device display.  The result is that
the user sees a visible flicker as the transparent overlay box
shows up and goes away.  This normal draw has the side-effect of
updating the SurfaceView's contents.

It's unclear to me why this draw happens if we're also going to
display the one for DevTools.  The frame rate is ~halved.

This CL attaches changes the PictureBuffer textures to be 2D, and
attaches a 1x1 transparent textures to them, in the case we're using
SurfaceView.  When DevTools draw uses this texture to draw the video
quad, it draws the transparent box instead of obscuring it.

In the long run, we should probably transition away from SurfaceView
if we ever detect that we're drawing the video quads rather than
processing them for overlays.  This would have the benefit that one
could see the video in DevTools, too.

BUG=592798

Review URL: https://codereview.chromium.org/1785153004

Cr-Commit-Position: refs/heads/master@{#383828}

This adds 1 method, viewRect(), to LayoutViewItem in the new layout API
and calls it from FrameView::collectFrameTimingRequests. There are a
few other references to other methods in the same function which will
require more extensive refactoring, which are not included in this CL.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1842653004

Cr-Commit-Position: refs/heads/master@{#383827}

order in main page.

BUG=None

Review URL: https://codereview.chromium.org/1836343002

Cr-Commit-Position: refs/heads/master@{#383826}

BUG=598736

Review URL: https://codereview.chromium.org/1843663002

Cr-Commit-Position: refs/heads/master@{#383825}

These are deprecated since 10.9. NSUnderlineStyleNone and
NSUnderlineStyleSingle are drop-in replacements with the same enum
value.

BUG=547071

Review URL: https://codereview.chromium.org/1842663003

Cr-Commit-Position: refs/heads/master@{#383824}

Revert of Mac: Decode hardware to 420 instead of 422 (patchset #3 id:40001 of https://codereview.chromium.org/1822173002/ )

Reason for revert:
This likely spiked the crash rates.
BUG=598388

Original issue's description:
> Mac: Decode hardware to 420 instead of 422
>
> If the decoded frame is going to be used as a CALayer overlay, then
> it will never be converted to RGBA. If it is used by OpenGL, then the
> same infrastructure for software frames will be employed to make an
> expensive RGBA copy of the frame.
>
> BUG=594452
>
> Committed: https://crrev.com/24da601d444c8822c5ff0a10751b9384f25dd1b4
> Cr-Commit-Position: refs/heads/master@{#382797}

TBR=sandersd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=594452

Review URL: https://codereview.chromium.org/1842673003

Cr-Commit-Position: refs/heads/master@{#383823}

The timestamp portion of the EXT_disjoint_timer_query does not have much
support from GPU drivers and emulation of them by Chromium at a level
that is accurate enough for users has been determined to be infeasible.
Therefore timestamps are disabled at the WebGL/client side on all
platforms as time elasped queries should be used by developers instead
as they are more widely supported.

BUG=595172
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1800383002

Cr-Commit-Position: refs/heads/master@{#383822}

BUG=598393

Review URL: https://codereview.chromium.org/1841613002

Cr-Commit-Position: refs/heads/master@{#383821}

Platform painting should be through skia::ScopedPlatformPaint.
(Only one compositor callsite was calling Begin/End directly.)

Remove skia::EndPlatformPaint() and all device-specific implementations,
which were effectively noops.

Remove skia::BeginPlatformPaint(), and make all device-specific impls
protected.

BUG=598695
R=fmalita@chromium.org
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/1839113002

Cr-Commit-Position: refs/heads/master@{#383820}

BUG=453002
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/1843793003 .

Cr-Commit-Position: refs/heads/master@{#383819}

BUG=

Review URL: https://codereview.chromium.org/1837993002

Cr-Commit-Position: refs/heads/master@{#383818}

Matching rules are fetched when Chrome starts and can take in the order
of 100-200ms. UI navigations that happen before these rules are fetched
will not start the data use tracking. This race condition is fixed by
buffering the navigation events until rule fetch is complete.

BUG=586235

Review URL: https://codereview.chromium.org/1837223002

Cr-Commit-Position: refs/heads/master@{#383817}

Remove SimpleWebViewController as it was used as an abstraction
when both WKWebView and UIWebView were used simulatenously.
WKWebView can now be used directly.

BUG=593897

Review URL: https://codereview.chromium.org/1829493003

Cr-Commit-Position: refs/heads/master@{#383816}

Preparatory CL for renaming scoped_ptr to std::unique_ptr. One of the
changes is replacing all uses of make_scoped_ptr() with WrapUnique(),
which lives in a separate header.

In order to incrementally update files to use the new header, this CL
moves make_scoped_ptr to ptr_util.h but still includes it in
scoped_ptr.h to avoid breaking the build during the transition.

BUG=554298

Review URL: https://codereview.chromium.org/1838323002

Cr-Commit-Position: refs/heads/master@{#383815}

BUG=598506

Review URL: https://codereview.chromium.org/1839813003

Cr-Commit-Position: refs/heads/master@{#383814}

BUG=598748
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1842883002

Cr-Commit-Position: refs/heads/master@{#383813}

Chrome sends the mousedown/up in some cases
when the 4th/5th button is pressed/released
without actually sending that button value as
we don't have yet the plumbing needed for that.

BUG=574959

Review URL: https://codereview.chromium.org/1824733006

Cr-Commit-Position: refs/heads/master@{#383812}

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722

Review URL: https://codereview.chromium.org/1725563003

Cr-Commit-Position: refs/heads/master@{#383811}

VS2015 is happy for us to simply override the CRT symbols since they
seem to be defined weakly by the universal CRT.

This shim is far simpler than the previous one, as the libcmt stripping
technique can be removed.

Allocator shim is also now only be enabled on Release Static builds.

BUG=481611
TEST=base_unittests --gtest_filter=*Memory* in all configurations
 (Debug/Release/Static/Component/GN/gyp/x64/x86)
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1414453017

Cr-Commit-Position: refs/heads/master@{#383810}

BUG=586173

Review URL: https://codereview.chromium.org/1840743003

Cr-Commit-Position: refs/heads/master@{#383809}

Otherwise this gn assertion fails:
  ERROR at //build/config/sanitizers/sanitizers.gni:85:1: Assertion failed.
  assert(!using_sanitizer || is_clang,
  ^-----
  Sanitizers (is_*san) require setting is_clang = true in 'gn args'

R=dpranke@chromium.org,scottmg@chromium.org
BUG=598761

Review URL: https://codereview.chromium.org/1838953003

Cr-Commit-Position: refs/heads/master@{#383808}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/ca352b231f2f..8151fc95fb5c

$ git log ca352b231..8151fc95f --date=short --no-merges --format='%ad %ae %s'
2016-03-29 dschuff Update revision for PNaCl

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/1844643002

Cr-Commit-Position: refs/heads/master@{#383807}

CRWWebUserInterfaceDelegate was added to web shell to test auth and
is unnecessary now. Web shell must use only public web// API and
CRWWebUserInterfaceDelegate is not public.

BUG=597997

Review URL: https://codereview.chromium.org/1838073002

Cr-Commit-Position: refs/heads/master@{#383806}

https://chromium.googlesource.com/skia.git/+log/6e26205cece9..cfb6bdf76779

$ git log 6e26205ce..cfb6bdf76 --date=short --no-merges --format='%ad %ae %s'
2016-03-29 reed switch xfermodes over to sk_sp
2016-03-29 brianosman Dirty mipmaps whenever we upload new contents for a texture.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1837263002

Cr-Commit-Position: refs/heads/master@{#383805}

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bluetooth.idl
- bluetooth_private.idl
- bluetooth_socket.idl
- cast_channel.idl
- declarative_web_request.json
- diagnostics.idl
- display_source.idl
- dns.idl
- document_scan.idl
- events.json
- extension_options_internal.idl
- extension_types.json
- extension_view_internal.json
- extensions_manifest_types.json
- guest_view_internal.json
- hid.idl
- idle.json

Also add templates for movable types with errors.

Note: The declarative content API uses events::Rules as linked ptrs to do cheap
refcounting (which it shouldn't do). This will be addressed in a separate CL.

BUG=595949

Review URL: https://codereview.chromium.org/1841483002

Cr-Commit-Position: refs/heads/master@{#383804}

Revert of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of https://codereview.chromium.org/1834413002/ )

Reason for revert:
clang-cl complains about not understanding /d2FastFail. I added it upstream, but we need to roll that in first (or add !is_clang checks here in the meantime if it's important to have this CL in. The description sounds like it could wait a while, though.)

Original issue's description:
> Fast-fail to catch VC++ compiler crashes
>
> The VC++ compiler and linker default to catching their crashes using
> structure exception handling. They then print out a helpful message.
> This helpful message is rarely enough information to let us diagnose
> what went wrong. crrev.com/1816333002 added /fastfail to the linker
> command line and this adds /d2FastFail to the compiler command line,
> for gyp and gn.
>
> These options are undocumented and unsupported but very handy -
> the linker /fastfail option was crucial in tracking down a linker
> crash.
>
> Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
> Cr-Commit-Position: refs/heads/master@{#383765}

TBR=scottmg@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1843783002

Cr-Commit-Position: refs/heads/master@{#383803}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/018cee950ffa..9bcc481fe3e6

$ git log 018cee950..9bcc481fe --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1840173002

Cr-Commit-Position: refs/heads/master@{#383802}

Fixes a regression from: https://codereview.chromium.org/1816753002
Also reverse expected behavior for touching tooltips.
(closes on stable, tests expected them to stay open...)

Inline bubble function definitions.
Use WindowObserver to remove the handler on window destruction.
TODO: Encapsulate more ShelfLayoutManager code.

BUG=595853
TEST=ChromeOS tooltips stay open on hover; close for external touches.
R=sky@chromium.org

Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24
Cr-Commit-Position: refs/heads/master@{#383404}

Committed: https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38
Cr-Commit-Position: refs/heads/master@{#383579}

Review URL: https://codereview.chromium.org/1828133004

Cr-Commit-Position: refs/heads/master@{#383801}

BUG=561829

Review URL: https://codereview.chromium.org/1835953002

Cr-Commit-Position: refs/heads/master@{#383800}

This runs what was a background thread for file operations on the same
thread as the mojo application, which is the db thread in chrome, and
the main thread when run as an app.

BUG=585587

Review URL: https://codereview.chromium.org/1839823002

Cr-Commit-Position: refs/heads/master@{#383799}

We were forgetting to reset our picture of trailing-space width when
we re-entered a run of normal text.

BUG=597193

Review URL: https://codereview.chromium.org/1838723002

Cr-Commit-Position: refs/heads/master@{#383798}

BUG=496258

Review URL: https://codereview.chromium.org/1833393002

Cr-Commit-Position: refs/heads/master@{#383797}

(taking over samli's patch).

Review URL: https://codereview.chromium.org/1840533002

Cr-Commit-Position: refs/heads/master@{#383796}

This brings the bookmarks widget into the Material era. The widget now
shows a list of bookmarks that resembles the bookmarks UI in Chrome.

BUG=593587

Review URL: https://codereview.chromium.org/1780893005

Cr-Commit-Position: refs/heads/master@{#383795}