- 01 Oct, 2018 40 commits
-
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Ic3deb3353377e950fadc0d011c75f7ed91ca5366 Reviewed-on: https://chromium-review.googlesource.com/1250923 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595445}
-
Maksim Sisov authored
Nothing special, just doing some garderning. TBR=rjkroege@chromium.org Bug: 859012 Change-Id: I2f750bbf2438521109b48be5932c74f93a80dc35 Reviewed-on: https://chromium-review.googlesource.com/1254263Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595444}
-
Rayan Kanso authored
- Set is_resumable in the OfflineItem to true so that paused downloads can be resumed. - Fix deallocated memory access in the Abort workflow which was causing the browser to crash. Change-Id: I2369ffe517796c245b6d3351e4d90aa6b4a1510b Reviewed-on: https://chromium-review.googlesource.com/1253624 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595443}
-
chrome://sync-internalsMarc Treib authored
Additionaly, when RequestStart is triggered from sync-internals, also set first setup compelete to true (since a previous RequestStop(CLEAR_DATA) might have cleared it). (though this should help with investigating bugs like 890361 or 885211) Bug: none Change-Id: Ie670ee055f177304a824b29d7e625d06c67a6b59 Reviewed-on: https://chromium-review.googlesource.com/1251423 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595442}
-
Vaclav Brozek authored
There are two flags guarding support for detecting sync password reuse: (1) password_reuse_detection_support in components/password_manager/core/browser/BUILD.gn, and (2) SYNC_PASSWORD_REUSE_DETECTION_ENABLED in components/password_manager/core/browser/password_reuse_defines.h Those got out of sync, with the former excluding Android and the latter not. This can cause compilation errors. Furthermore, at some places, direct mentions of OS_* macros are used instead of SYNC_PASSWORD_REUSE_DETECTION_ENABLED. This breaks compilation if SYNC_PASSWORD_REUSE_DETECTION_ENABLED is changed. Therefore this CL defines (2) by (1) and abolishes password_reuse_defines.h completely. It also replaces OS_* macros with SYNC_PASSWORD_REUSE_DETECTION_ENABLED as appropriate. Finally, it adds "// nogncheck" to conditional #includes which would otherwise cause troubles, following the guidance of [1], and also adds a missing #include, which was found when switching password_reuse_detection_support to exclude Linux instead. [1] https://chromium.googlesource.com/chromium/src/+/eca97f87e275a7c9c5b7f13a65ff8635f0821d46/tools/gn/docs/reference.md#controlling-includes-individually Bug: 706392 Change-Id: I40113777be9440faccb4e80fbca2a3571e2f6110 Reviewed-on: https://chromium-review.googlesource.com/1252585Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bba2921c1970..e8e2bb1384ad git log bba2921c1970..e8e2bb1384ad --date=short --no-merges --format='%ad %ae %s' 2018-10-01 robertphillips@google.com Test YUV images in DDL Created with: gclient setdep -r src/third_party/skia@e8e2bb1384ad The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: If838c87135789ec6c9684b5144d4ed165a63f8b8 Reviewed-on: https://chromium-review.googlesource.com/1254182Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595440}
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Ia158d98717cf0360870f46eeabca0777b1954ec1 Reviewed-on: https://chromium-review.googlesource.com/1243143Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#595439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/279decb72e03..8dfa5c869e08 Created with: gclient setdep -r src-internal@8dfa5c869e08 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iecbf708d862a34c46e9c8ca04a45e6369514992c Reviewed-on: https://chromium-review.googlesource.com/1254181Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595438}
-
Hirokazu Honda authored
Add DCHECK(thread_checker_.CalledOnValidThread()) so that a reader can figure out easily what thread should execute a function. BUG=None TEST=VEA unittest on eve and veyron_minnie with dcheck_always_on Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0f3f0a777f97cbb095d498fe8c70355377cdcf21 Reviewed-on: https://chromium-review.googlesource.com/1005374Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595437}
-
Maksim Sisov authored
It turned out that it was not a good idea to try to guess buffer formats if a Wayland compositor had not announced supported buffer formats. If such a case happened (the Wayland compositor did not announce the formats), guessing them resulted in crashes in YouTube videos for example. Thus, it's better to fallback to software GpuMemoryBuffers rather than crashing. What is more, the Wayland spec says it must announce the supported formats once zwp_linux_dmabuf interface is bound, but in some versions of the compositors it does not happen. It looks more like a bug, which must be reported. Bug: 890284 Change-Id: I9bd20019709b0cbd82fa9654627b825adceb479b Reviewed-on: https://chromium-review.googlesource.com/1253641Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595436}
-
Alex Clarke authored
The bug was operator++ shouln't assume index zero is the front of the ring's buffer. This patch also improves test coverage of LazilyDeallocatedDeque. Change-Id: I8d8a6dd50177a44ab78ef4262a794d6175898864 Reviewed-on: https://chromium-review.googlesource.com/1253982Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595435}
-
Vaclav Brozek authored
Presubmit checks flag some deprecated functions in the sync layer of password_manager component. This CL fixes those issues to unblock merging that layer with the core layer in a separate CL. The two most frequent fixes here are: * Replacing base::Closure with base::RepeatingClosure in cases when this seems intended. Note 1: Closure is currently an alias for RepeatingClosure, so this results in no change. Note 2: There was also one case when OnceClosure was more appropriate. This was handled in https://crrev.com/c/1252582. * arraysize -> base::size; this is the encouraged and a straightforward change Bug: 515108 Change-Id: I554cff1c1ef1965eab82f87bbd3fceb92c2ebd41 Reviewed-on: https://chromium-review.googlesource.com/1252745Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595434}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I4ed9022a181156fdfb13210d00c1b947a9a0df51 Reviewed-on: https://chromium-review.googlesource.com/1253168Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#595433}
-
Javier Ernesto Flores Robles authored
Adds iOS usage key for face ID to the plist file. Bug: 889430 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I75aaeb919f6d68c105e8a7711c5d0ca1a70aec3d Reviewed-on: https://chromium-review.googlesource.com/1245371 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595432}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ba5eaee9a23e..4f340fa01e33 git log ba5eaee9a23e..4f340fa01e33 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 mbonadei@webrtc.org Compile audio_device without -Wno-global-constructors. 2018-10-01 srte@webrtc.org Adds allocated rate without feedback to new congestion controller. 2018-10-01 mbonadei@webrtc.org Remove runtime_enabled_feature. Created with: gclient setdep -r src/third_party/webrtc@4f340fa01e33 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc3b81b65922aadfc6419963a7e1ee38434a3c17 Reviewed-on: https://chromium-review.googlesource.com/1253823Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e133d78eb6b1..279decb72e03 Created with: gclient setdep -r src-internal@279decb72e03 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6058f86d81c3de197723c8fc93413d3848481c80 Reviewed-on: https://chromium-review.googlesource.com/1253824Reviewed-by:
-
Greg Kraynov authored
In order to remove unrelevant clutter from TaskQueue which eventually will become a lean interface. TBR=gab@chromium.org Bug: 865411 Change-Id: Ia0e2284c745895cf2869308be8af3fa164438dff Reviewed-on: https://chromium-review.googlesource.com/1245469 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78374c5b9264..ac93684421fa git log 78374c5b9264..ac93684421fa --date=short --no-merges --format='%ad %ae %s' 2018-10-01 dtu@chromium.org [pinpoint] Make "patch not found" an HTTP 400 instead of a 500. 2018-10-01 perezju@chromium.org [pinpoint_cli] Add command to download results as csv 2018-10-01 perezju@chromium.org [pinpoint_cli] Cache locally content from isolate digests Created with: gclient setdep -r src/third_party/catapult@ac93684421fa The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:889875,chromium:879526,chromium:879526 TBR=sullivan@chromium.org Change-Id: I08d1f0e25bfc78f84b5b97b380f52d85f6e1a53b Reviewed-on: https://chromium-review.googlesource.com/1253822Reviewed-by:
-
Hans Wennborg authored
Bug: none Change-Id: I7c267cf630c6e8ee29bbf39b295adc6c9e4bbd93 Reviewed-on: https://chromium-review.googlesource.com/1252589Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595427}
-
Morten Stenshorne authored
Didn't intend to submit this. TBR=cbiesinger@chromium.org Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iaadb3d155e24d3b15e5ccd5586c052d316131540 Reviewed-on: https://chromium-review.googlesource.com/1253981 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595426}
-
Daniel Bratell authored
Windows normally defines macros so that FAR expands to far, and far expands to nothing. Angle undefs far, leaving the FAR macro hanging, expanding to far which is not a legal keyword anymore. zlib already tries to handle that someone/something has undefined FAR but it doesn't handle that someone/something has undefined far. This patch changes that. This problem appeared in some jumbo builds in gpu/command_buffer/service which uses both angle and zlib. Bug: 889429 Change-Id: Ia3b10a9a82fc51b302c67b24a19f30a73bdda489 Reviewed-on: https://chromium-review.googlesource.com/1245723 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#595425}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8935b67baa50..e133d78eb6b1 Created with: gclient setdep -r src-internal@e133d78eb6b1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If640b14852692c817c5a2a557a031387e92a48fd Reviewed-on: https://chromium-review.googlesource.com/1253821Reviewed-by:
-
Mark Cogan authored
This Cl removes usgae of IsBookmarksUIRebootEnabled(), refactors code around it, removes unused images, and removes unused classes. Bug: 884719 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I12bf030f91f3510418b9d53666d1a387e8b937fe Reviewed-on: https://chromium-review.googlesource.com/1250926 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#595423}
-
Eric Willigers authored
The coordinates after H and V commands were being calculated incorrectly during path serialization. BUG=887871 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia2f55213c4a4837d82f9783d1ad1af29de9937ae Reviewed-on: https://chromium-review.googlesource.com/1252229Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#595422}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/156d11ddd939..ba5eaee9a23e git log 156d11ddd939..ba5eaee9a23e --date=short --no-merges --format='%ad %ae %s' 2018-10-01 mbonadei@webrtc.org Remove rtc::EnsureWinsockInit and g_winsockinit. 2018-10-01 buildbot@webrtc.org Roll chromium_revision 11cc0baf..148156b3 (595285:595385) Created with: gclient setdep -r src/third_party/webrtc@ba5eaee9a23e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia54c9cf83e9a145b2eedccd1e1fdcb399b4d6e23 Reviewed-on: https://chromium-review.googlesource.com/1253543Reviewed-by:
-
Amos Lim authored
Move Document#onselectionchange, Document#onselectstart, and Element#onselectstart to GlobalEventHandlers as per the spec[1]. [1]: https://w3c.github.io/selection-api/#extensions-to-globaleventhandlers Bug: 692631 Change-Id: Icc940336827f42e73e40b9f62cd8d4a6552fbd8b Reviewed-on: https://chromium-review.googlesource.com/1252225Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#595420}
-
Vaclav Brozek authored
PasswordStore::ScheduleTask schedules a task to be run once. Often, the passed task has move-only arguments, so cannot really be run repeatedly, even though it is a base::Closure, which is an alias for base::RepeatingClosure. Moreover, having ScheduleTask require a base::Closure blocks further refactorings, which block further refactorings. :) Therefore this CL changes the argument accepted by ScheduleTask to a OnceClosure. As a result, the argument has to be passed by value instead of copied from a reference. Bug: 515108 Change-Id: I825ca66ac54bfd8040440aca73dbe17170534e13 Reviewed-on: https://chromium-review.googlesource.com/1252582Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595419}
-
Eric Seckler authored
Replicating the equivalent BrowserThread documentation for ios, see https://chromium-review.googlesource.com/c/chromium/src/+/1246361 Bug: 878356, 882872 Change-Id: Ie9470baecbce1dbb5b6c45852836db238cffe3b7 Reviewed-on: https://chromium-review.googlesource.com/1253763Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595418}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/98289bcecf60..78374c5b9264 git log 98289bcecf60..78374c5b9264 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 perezju@chromium.org [pinpoint_cli] Add UserServices bundle Created with: gclient setdep -r src/third_party/catapult@78374c5b9264 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I3800a6ba1a4a7267ef0b9bf6975fee478e12ef5c Reviewed-on: https://chromium-review.googlesource.com/1253545Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7f3ceba5dc7f..bba2921c1970 git log 7f3ceba5dc7f..bba2921c1970 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 79207e6e11df..a78092cb2557 (1 commits) Created with: gclient setdep -r src/third_party/skia@bba2921c1970 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I010945cfa620b68a5cedf21a863fcca2836dd3b3 Reviewed-on: https://chromium-review.googlesource.com/1253546Reviewed-by:
-
Yoichi Osato authored
Since DocumentMarkerController::MarkerMap only contains Text nodes as key, the removing map entry functions should receive only Text node rather than Node. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id9b4daa1d116660f13d3c3961d5ed97758ceb01b Reviewed-on: https://chromium-review.googlesource.com/1244698Reviewed-by:
-
Fredrik Söderquist authored
SVGElement::CssPropertyIdForSVGAttributeName has a: HashMap<StringImpl*, CSSPropertyID> which will require traits for the value (CSSPropertyID). Without Jumbo this usually works out by using the default traits. Bug: 890434 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ff50a0648106057dad898d1fe6d79e9a53a1bd2 Reviewed-on: https://chromium-review.googlesource.com/1253662Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595414}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/547280e74c55..8935b67baa50 Created with: gclient setdep -r src-internal@8935b67baa50 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3b68e3a2ee8eeb91386c183b34fe1b720c23bea Reviewed-on: https://chromium-review.googlesource.com/1253440Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79207e6e11df..a78092cb2557 git log 79207e6e11df..a78092cb2557 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 oetuaho@nvidia.com Support ESSL 3.00 EXT_blend_func_extended shaders Created with: gclient setdep -r src/third_party/angle@a78092cb2557 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9983375c2e780b4c7a147ba529d0babf873b8775 Reviewed-on: https://chromium-review.googlesource.com/1253544Reviewed-by:
-
Tobias Sargeant authored
This reverts commit 61bed816. Reason for revert: Broke [Build Non-Channel Targets] build step Original change's description: > Horizontal tab switcher use tab toggle > > Replace the HTS Incognito Button with a toggle. > > Bug: 851166 > Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf > Reviewed-on: https://chromium-review.googlesource.com/1246453 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594780} TBR=yusufo@chromium.org,amaralp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851166 Bug: 890673 Change-Id: I3631d88c29bd950beea9280e97e0ff50ed332bc8 Reviewed-on: https://chromium-review.googlesource.com/1253741Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#595411}
-
Yuichiro Hanada authored
to support proxying IME APIs between Android IMEs and text fields on a browser window. Bug: 845079 Change-Id: Ie0df8db88893b9d3e98c9b8494ce887325f15d8f Reviewed-on: https://chromium-review.googlesource.com/1177526Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#595410}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae37766f..d46dfc57 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6058700401d0828af362ac65dbc33923d170afa8 Reviewed-on: https://chromium-review.googlesource.com/1253214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595409}
-
Takashi Toyoshima authored
Since these tests are not for web platform features, and it's a little difficult to change configurations for browser process and NetworkService from blink layout tests, these tests will run as a content_browsertests if OOR-CORS is enabled. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7d483708b30e220fd7a79db813c8818db310f85c Reviewed-on: https://chromium-review.googlesource.com/1213102 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#595408}
-
Mario Sanchez Prada authored
Use the IdentityManager APIs and update callers accordingly, including calls from the associated test suite. Bug: 889879 Change-Id: I69c1c29d033602dd0c37618fefd71c5229ceacbe Reviewed-on: https://chromium-review.googlesource.com/1251609Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595407}
-
Fergal Daly authored
This test was using mock.py's assert_not_called method but that does not exist in the version in third_party/pymock. The result is that the assert call was mocked out, allowing the test to pass without actually testing anything. Fix is two-fold: 1 factor out the filtering code and test it directly 2 assert that .call_count is 0 Bug: 890657 Change-Id: Iffc6382ad0d9335a11c17f5ffe4d0c6ae6cbcf6c Reviewed-on: https://chromium-review.googlesource.com/1253601 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
