- 11 Jun, 2020 40 commits
-
-
Anupam Snigdha authored
Below were some feedbacks from TAG (https://github.com/w3ctag/design-reviews/issues/507): 1. Changed overlaygeometrychange event to geometrychange as it is fired on the virtualKeyboard object. 2. Added boundingRect to virtualkeyboard object so web authors can query whenever they want to know the last VK geometry values that was reported. Bug: 856269 Change-Id: I7408133aa907fbf11d375c89417364059f2b3fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240458Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777563}
-
My Nguyen authored
Bug: 1081582 Change-Id: I93dedd52e56519366f0c9e45294a99a9e2ed2d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241362 Commit-Queue: My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#777562}
-
Li Lin authored
Bug: b/120678625 Test: manual test Change-Id: Ia60a3c6554fb0a5be27b6abb2ebd7bf39e84c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240366 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777561}
-
Taylor Bergquist authored
Bug: 1094033 Change-Id: If3fb879e2624833eb8448a61bab57891258f17bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241646Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#777560}
-
Ted Meyer authored
Sometimes websites can set massive data encodings as the player URL and this can cause out of memory crashes. Bug: 1090752 Change-Id: I783daeb7d9ae48061dc299c09952719dffa65197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239373 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777559}
-
Kevin Marshall authored
Adds a "--enable-protected-media-identifier" flag to WebEngineShell which allows content in W.E.S. to play back DRM-encrypted media. Bug: 1093600 Test: played back portions of Sintel on Shaka demo page Change-Id: Ib78b458b6b573541873f4dd9d20b69e322c05945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241859 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#777558}
-
Scott Violet authored
BUG=1087464 TEST=covered by tests Change-Id: I0b9d30e5699a69f17bb64259a90c649966aeeece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240419 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#777557}
-
Ian Wells authored
Bug: 1044139 Change-Id: I838d3a9f5e6a4f40cfaeb265aee28337e523d4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241470Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#777556}
-
Tommy C. Li authored
This CL standardizes the kSelection accessibility event for all the omnibox popup auxiliary buttons. This also gives the Header collapse button this accessibility event. Bug: 1078183, 1052522 Change-Id: Ia56b2e15b47c299bb55f74aa16bb1648b47b322c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240298Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#777555}
-
Benjamin Gordon authored
It can take 2-3 minutes to scan a single page at high DPI. Extend the timeout to 3 minutes for the specific ScanImage call so that these requests can complete. Bug: b:158504381 Test: Scanned a page at 1200 dpi Change-Id: If7e20f88779059e7b46a56107568bd0cd4b32244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240261Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Cr-Commit-Position: refs/heads/master@{#777554}
-
ssid authored
Change-Id: Iefe8522f0aae153dcd896bd4f8334b856370fb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228056Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#777553}
-
Hitoshi Yoshida authored
Makes it clear that |kUnspecified| means CookieStoreGetOptions.matchType is missing. Bug: 839389 Change-Id: I71a94e7b41a8bbfb12aa64ef9b0e5c0e0a844791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210180Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#777552}
-
Kenneth Russell authored
This reverts commit 6eda333b. Reason for revert: speculative to see if it caused http://crbug.com/1093939 Original change's description: > Add MojoDedicatedThread field trial testing config > > Bug: 1082761 > Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#777367} TBR=rockot@google.com,asvitkine@chromium.org Change-Id: I61c7c9ed5cd76e77e41f5b934587451e9eb78743 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082761, 1093939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240908Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777551}
-
Istiaque Ahmed authored
This CL expands EventListenerMapTest.FilteredEventsOnlyGoToMatchingListeners to also test that correct listener is fired. Bug: None Test: Internal test only cleanup. Change-Id: Ic353f20aba30e6175e1fe3f524bff951c00d9c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237988Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777550}
-
Renjie Tang authored
This CL also patches in crrev.com/c/2194176, which is a fix to the original CL. This is a reland of 652185a0 Original change's description: > Default enable QUIC in Cronet Android and IOS. > > This change introduces no API changes. But API documents need to be updated. > > Change-Id: Ibc347df79066de704c5be0683c5b658ba6e1896a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168553 > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Misha Efimov <mef@chromium.org> > Cr-Commit-Position: refs/heads/master@{#765334} Change-Id: I37f62746a35d634641febf16f29dfd1608b1e483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235981Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#777549}
-
dpapad authored
A large portion of the UI is only present in the stand-alone PDF Viewer, and not in Print Preview. This CL makes it such that only strings that are used in each case are registered for $i18n{} replacements, as opposed to always registering all of them. Note that chrome.resourcesPrivate.getStrings() still returns all of them, since there is no way currently to differentiate between the two contexts. Bug: 1091516 Change-Id: I6d12ef310dd74112cd9cc68216b260f0e2c0652e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240017 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#777548}
-
rbpotter authored
All directional key handling is done via calls to Viewport methods. Split this handling out of pdf_viewer.js and move it directly to the viewport. This will also reduce duplicated code when pdf_viewer.js is forked for Print Preview. Change-Id: Ia318c3fe83c417b3db0e5f409e9dd200fa092019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238854 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id00be11c422a1ff43b6a82d773f99c04aa0b21e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777546}
-
Dominic Mazzoni authored
This is a reland of http://crrev.com/c/2209630 Previously, in order to do a hit test for accessibility we'd send an action to the renderer with the x,y coordinates, and the renderer would fire an accessibility event on the matching node. It'd be more flexible if we had an API that could do a hit test and call a callback function with the result. That eliminates the need for keeping track of requests and matching them up with events. This patch refactors the way hit testing works so that a hit testing request may contain a request for an accessibility event to fire, or a callback function to call, or both. Existing tests are extended to cover both mechanisms. Tbr: estark@chromium.org, aleventhal@chromium.org Bug: 1083834, 1091140 Change-Id: I17596f9a7a850e89d467bb450741865f75407f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233706 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#777545}
-
Lukasz Anforowicz authored
It turns out that before this CL |SomeTemplate<SomeClass>* ptr_field| would match the |non_free_standing_tag_type| matcher and therefore would not get rewritten. :-( Both the old |non_free_standing_tag_type| matcher, and the old |hasUniqueTypeLoc| matcher were trying to prevent generating conflicting replacements (i.e. separate edits of overlapping sections of a source file). This CL fixes this problem in a more direct way - by introducing |overlapsOtherDeclsWithinRecordDecl| matcher for FieldDecls. The new matcher replaces both of the old matchers. The new matcher is a more generic version of the old, removed |hasUniqueTypeLoc| matcher. The new matcher: 1) considers all Decls under a RecordDecl (not just FieldDecls) 2) looks for any SourceRange overlap (rather than just considering the starting SourceLocation of a field type) Bug: 1069567 Change-Id: I6392aa84e9e808790be3d84d0ba3079d1cc4ddf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211054Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#777544}
-
Adam Langley authored
cryptotoken used to always get the raw U2F reply. It can do attestation stripping itself and the dummy certificates that it creates duplicate the transports from the real certificate. However, when cryptotoken was rebased atop WebAuthn, the attestation preference was translated into WebAuthn. Thus stripping happened at the WebAuthn layer and there was no transport information to use. (Well, there's the transports array in WebAuthn, but cryptotoken doesn't use that.) Thus, since that transition, transport information has been lost in the non-direct case. This change always requests direct attestation from the WebAuthn layer and lets cryptotoken handle the stripping. BUG=1094002 Change-Id: I7abc7c44c2e386aa97fd98e9d866384b0388adb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241466 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#777543}
-
Francois Doray authored
DumpWithoutCrashing can be correlated with long tasks (see https://crbug.com/1092465). To make it easier to identify cases where long tasks happen at the same time as DumpWithoutCrashing, this CL adds a trace event in DumpWithoutCrashing. DumpWithoutCrashing is usually invoked when an unexpected situation occurs. It already causes a report to be uploaded to crash servers. Therefore, in most performance analysis, traces that contain a DumpWithoutCrashing event should be discarded. For now, we think it's still valuable to upload traces that contain a DumpWithoutCrashing event, as those could be used to diagnose a drop in the number of traces uploaded or the absence of traces uploaded for a new trigger. R=gab@chromium.org Bug: 1092465 Change-Id: Ie1e2b947b476910738e802cdc85569ec4f3cc1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239928Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#777542}
-
Adrienne Walker authored
This is a follow-up to this patch: https://chromium-review.googlesource.com/c/chromium/src/+/2233709 Bug: 582750,1093785,1093780 Change-Id: I8940974cd474a48df7a2970e100caad6e3fab1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242119Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777541}
-
Donn Denman authored
The recent change to clear the selection after the user has opened and closed the panel needs to check if the selection is invalid. In that case there's no point in clearing the selection and might clear the user's selection that we cannot handle (like long selections). Also mark the change reason generated by closing for an invalid selection. BUG=1093271 Change-Id: I3c244227b2346b92e936807e5aea7f8f0bdb0d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242118 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#777540}
-
Jian Li authored
This fixes the drawinf freezing problem when the user navigates away from Feed v2 page. Bug: none Change-Id: I2d14aa6eac0f03ff51c561ae34a65cdc011d664c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242200Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#777539}
-
Charlene Yan authored
This fixes the issue with the loading favicon still appearing when the group is collapsed. Bug: 1018230 Change-Id: Ia985cb2fa5d83fdb886a2e3004e7d44909e522e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240450Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#777538}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I712f6e244f3399e3b241eae0ac584418b6d315a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777537}
-
Katie D authored
NOTRY=true Change-Id: Ib263b44be73614c7d78b0d52df8c417dae0e7c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242203 Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#777536}
-
Jarryd authored
Change-Id: Ib3fc3bce00d1d8d457be52aa069c4c9b45114e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240115 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#777535}
-
David Van Cleve authored
<meta name=referrer> supports some unspecified behavior right now: - it has an effect outside of <head>, which the HTML spec says it shouldn't - it parses the "content" attribute as a comma-separated list of referrer policies (as if it were the value of a Referrer-Policy header), which the HTML spec also says it shouldn't In order to analyze whether we can possibly change this behavior---the <meta name=referrer>, as a whole, is hugely widely used---we add some more granular UseCounters to measure (1) how often <meta name=referrer> is used outside of <head> (2) how often <meta name=referrer>'s value contains multiple tokens (in other words, how often it contains a comma). Bug: 1093914, 1092930 Change-Id: Ifd7be938bca08fd5701c10fa45db2e8cf32f7087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241188 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#777534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36a4d5db981c..f512e8752bfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangs@google.com,japhet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1087037,chromium:1091385 Tbr: huangs@google.com,japhet@google.com Change-Id: I8f943815d267beae7ec73550c0b03d1d0234bff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241926Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777533}
-
Daniel McArdle authored
Bug: 1052476 Change-Id: I84517a018726155240ec17337ee5081fe6488065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089958 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#777532}
-
Torne (Richard Coles) authored
The test was flaking because sometimes the renderer was not evaluating the JS code used to block the blink thread until *after* we had already sent the input event to the frame, and thus the hang detection never kicked in. Add explicit synchronization in JSBlocker so that the test thread can wait until the blink thread is actually blocked before continuing. Fixed: 1092707 Change-Id: Ib993b32ffc06b49c8015b6c248477ee91079c575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238866Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777531}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/526424e2cc47..6f714b101dfc 2020-06-11 fmayer@google.com Merge "Roll trace_to_text for heap_profile." 2020-06-11 rslawik@google.com Compute CPU mcycles from time_in_state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157216280 Tbr: perfetto-bugs@google.com Test: Test: tools/diff_test_trace_processor.py Change-Id: Ic99cb2438981e4f28e51f4f29c59b07c2a20e1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777530}
-
Nico Weber authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/d0a6f072..9a0496a7 9a0496a7 Make data_deps in copy() targets work. fa40610a include the missing tuple deps in version.cc 0ce25e39 [rust-project] switch cfgs to new list schema c7bbac32 Don't assert on gn builds without any target. d26b346f Specify deps format for actions 317fdc1d Support specifying required Ninja version 89483505 Fix incorrect check for expansion of {{bundle_root_dir}} 981f46c6 Make simple build example runnable on macOS 0a9affbe Update docs/reference.md b175fa5d Add Ihor Karavan to list of authors c494b98a Add Oleksandr Motsok to list of authors 1a34e42d Fix a comment regarding --ide=json builder 382f5ef9 Divide sources between targets and add include paths to them 86df3084 Add support escape JSON string to stream for export compile commands db57fe08 Revert "Specify deps format for actions" d2f5e438 Add new build configuration variable to add an extension to build file names. 7d9b8111 Specify deps format for actions 2c801de7 Fixes typo in example f4545417 [rust-project] Only list direct dependencies, not transitive deps TBR=hans Bug: none Change-Id: I861b1a83e54863d47b151e907b191bbedd383d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241508Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777529}
-
Nate Chapin authored
This reverts commit 5bd1f98a. Reason for revert: ChromeURLDataManagerTestWithWebUIReportOnlyTrustedTypesEnabled.NoTrustedTypesViolationInWebUIGroupA failing on bots (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/89566) Original change's description: > Reland "Group tests of Trusted Types for WebUI" > > This change groups tests of Trusted Types for WebUI into 20 WebUI pages > per test to minimize the size of the file. This change also fixes a bug > where `CallJavascriptFunction` might be called before allowing JS. > See: crrev.com/c/2237534 > > Bug: 41905 > Change-Id: I2d99b16c9157d8287d777c9a723457d6d10e4304 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238998 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#777412} TBR=tommycli@chromium.org,dpapad@chromium.org,Jun.Kokatsu@microsoft.com Change-Id: Idf900d20a6c1504ac1035fa35fd34b8508512484 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 41905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242372Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#777528}
-
Matt Jones authored
This patch moves the responsibility of creating the bottom sheet's view to the controller. Glue shouldn't have to know implementation details about the sheet. Instead, a root view, inflater, and callback are passed in. Bug: 1002277 Change-Id: I796f26e4a33b061ebcca9862f9bf19dea6d3aafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238560 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#777527}
-
Mei Liang authored
The flaky test, TabSelectionEditorTest.testTabSelectionEditorLayoutCanBeGarbageCollected is reproduced locally, and noticed a longer timeout is needed. This CL extends the time out by using the CriteriaHelper.pollUiThread with GarbageCollectionTestUtils.canBeGarbageCollected. Change-Id: Id82312493e52601609ca4cbbd63bd68637f45373 Bug: 1075816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241345 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#777526}
-
Daniel Rubery authored
This CL updates the unscanned file reason to match the new values (see bug) It also renames BinaryUploadService::Result::UNSUPPORTED_FILE_TYPE to DLP_SCAN_UNSUPPORTED_FILE_TYPE, since that's the reason string we will give. If we add unsupported file types for malware scanning, we'll need a new BinaryUploadService::Result so that we can distinguish the two cases. Fixed: 1088143 Change-Id: Ifc8cdb4244e0f80b781b7dd922ed22226c125913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236062 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777525}
-
Philip Rogers authored
We no longer need to composite for clipping because the clip can be applied in the compositor via property trees. Change-Id: I740cd8e7b247a7f8bcd98562daedaeef7f1efca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235638 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777524}
-