- 04 Dec, 2019 40 commits
-
-
Ahmed Mehfooz authored
The message center redesign kUnifiedMessageCenterRefactor feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 976952, 958020 Change-Id: I172f310831a0ef64dfecccc210850464b2a5c80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951283 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721653}
-
David Bokan authored
The state is unused except in deferred_scroll_end_state_ where its existence is used as a signal to call ScrollEnd at the end of an animation. Removed state as an input to ScrollEnd and turned the deferred state into a bit. Bug: 1029781 Change-Id: Ia0d4261f5d0d21c08f01650eb436c091112e0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948515 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721652}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/006a15542867..5f3456e3314b git log 006a15542867..5f3456e3314b --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thomasanderson@chromium.org Expose GL_ARB_sync for GL Created with: gclient setdep -r src/third_party/angle@5f3456e3314b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028799 Tbr: geofflang@google.com Change-Id: I902a32975bf941a98852354117420d34844e5996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721651}
-
Xiyuan Xia authored
Pass display transform hint via CompostiorFrameMetaData instead of via DisplayPrivate. This ensures proper display transform used for a frame in viz::Display::DrawAndSwap. Bug: 1026744 Change-Id: I1645c177b948946fab5549a3b48000ee9e2f576e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930216Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721650}
-
Taylor Bergquist authored
Bug: 989131 Change-Id: If8e698c9f95fe20ffc99b434f5a6e1e690a60141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949681Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721649}
-
Devlin Cronin authored
ShowToolbarActionPopup() is called from the ExtensionActionAPI to trigger a popup from a couple different call sites. Move the method to ExtensionsContainer, and implement it on ExtensionsToolbarContainer. Bug: 984654, 985834 Change-Id: I37033f132f01546e0b26f3f84cf7a8c15d922ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927214Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721648}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/38f725fb445a..024cbe1befe1 git log 38f725fb445a..024cbe1befe1 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 tsepez@chromium.org Add unit tests for FPDF_BSTR. 2019-12-04 tsepez@chromium.org Test FPDF_SetSandboxPolicy() public API. 2019-12-04 tsepez@chromium.org Test CJX_Event::emit() and reset() 2019-12-04 thestig@chromium.org Fix nits in CFX_XMLParser::DoSyntaxParse(). 2019-12-04 tsepez@chromium.org Remove some DOXY-style punctuation from fpdf_formfill.h. 2019-12-04 thestig@chromium.org Remove an unused struct in AGG code. 2019-12-04 thestig@chromium.org Stop manually setting -Wshadow. Created with: gclient setdep -r src/third_party/pdfium@024cbe1befe1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6372ad4b00533a5c71dbc5d084c518217fe9dd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951153Reviewed-by:
-
John Budorick authored
Starting with sdcard size as well as screen dimensions and density. Also adds a marshmallow tablet AVD configuration. Bug: 922145 Change-Id: I72d083599e920307f5db1eeb7e6fd708105878bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918275 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#721646}
-
dalyk authored
Bug: 985589 Change-Id: I6a7e3a66041ae5b0a6e42a27d3123412ac382113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943475Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#721645}
-
danakj authored
Long running tasks make for slow tests make for overloaded bots make for slow commit queue! R=gab@chromium.org Change-Id: I003e70a98477084d6a948553c78f3d48376d2480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949028 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#721644}
-
Xiaoqian Dai authored
Bug: 1027353, 997885 Change-Id: I23a421baf0b684c5c1cccf9c8c6183e137b6cd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951183 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Includes some modernizing of the use of base::Value in the code. Bug: 1005404 Change-Id: Ibbaad2585637ab265bd7fc214d3d940fe2e79171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949365 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721642}
-
Tricia Crichton authored
Several places where UnexpectedAlertOpen status is returned do not include the alert text in the status object. This cl adds the text where missing. Bug: chromedriver:3184 Change-Id: I3087ed77d73c326ca93c77667c2a9eaa7c460134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950862 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721641}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kbr@chromium.org Bug: 1023677 Change-Id: I3f94fcf12837e64582ff2b834e201f88f017df11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927011 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721640}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4eacc1612b6..6f790e4528b7 git log c4eacc1612b6..6f790e4528b7 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 brgoddar@microsoft.com Memory: Deselect Nodes when Filtered Out 2019-12-04 sigurds@chromium.org Fix: Initialize member 2019-12-04 liviurau@chromium.org [test] Port the virtual test suites from Chrome Created with: gclient setdep -r src/third_party/devtools-frontend/src@6f790e4528b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1018670,chromium:1030462 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7621b81724d2cc0bca879355a4b7eb679b2defce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951149Reviewed-by:
-
Kamila authored
This cl sets a specific width for the promo, and modifies the promo label, according to the UX requirements. Before-after screenshots attached on the bug below. Bug: 986737 Change-Id: I59f8c183e95eac4ba67501c775a71e553ad5c559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950903Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#721638}
-
Johannes Kron authored
Change return type of GpuVideoAcceleratorFactories::IsDecoderConfigSupported() from bool to a tristate enum class Supported to be able to distinguish between supported (kTrue/kFalse) and not yet initialized (kMaybe). Bug: chromium:1029737 Change-Id: I2a70947f2bf37398aba5a9b9dc2db3080265163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945175Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721637}
-
Aran Gilman authored
Bug: 1027612 Change-Id: I924bde8462b459fad436ebcc1cc8afe645cb4276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931109 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721636}
-
Mikel Astiz authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1827368 after the underlying issues have been resolved in other patches and FieldTrialList is guaranteed to be instantiated on all platforms. Original change's description: > Revert "Send variation headers to sync server" > > This reverts commit c305a2ba. > > Reason for revert: DCHECK failures observed on ios. > > Original change's description: > > Send variation headers to sync server > > > > This information is already sent to other servers such as the one used > > for omnibox personalization, hence the patch doesn't upload additional > > information but allows measuring the impact variations have on the sync > > server and debug errors caused by client-side experiments. > > > > Bug: 887521 > > Change-Id: I3358956639bf96260bb5010279012195086eec37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368 > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#700678} > > TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 887521, 1011088 > Change-Id: I07fb576d156cf9efd334ce89617e9a823db61662 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844814 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703254} TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org Bug: 887521, 1011088 Change-Id: I1e7ee5d44d1137dfaa5bdc7dd063cfe8bd2b7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950947 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721635}
-
Bettina authored
Add Update and Get methods in compromised credentials table to be able to log metrics and also update rows when the signon_realm or username has changed. Get method allows checking of whether or not existing rows will be changed/removed. This CL also adds a check to make sure the database exists before performing actions on it. Bug: 1026006 Change-Id: I6792d135de7d74a5d7b0f83bdb8f4dc87a409628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943308 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721634}
-
Tommy Li authored
This CL makes the Remove button in the Views omnibox send accessibility data. This brings it to accessibility parity with the Tab Switch button, generally functioning the same way. I tested this with ChromeVox, but the implementation is independent of the platform. Bug: 1205 Change-Id: Ia25a8af74cad154c31ddc00b7b5401498c87f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951135Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#721633}
-
Takumi Fujimoto authored
Disabled on debug builds for flaky timeouts. TBR=michaelpg Bug: 1030782 Change-Id: Ib69e47f7c4ff72940de95fe092d2aec8effb62ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951326Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721632}
-
Josh Nohle authored
The CryptAuthKeyCreator now returns a null CryptAuthKey if key creation fails. The CryptAuth v2 Enrollment and DeviceSync flows look for null results and error out with result codes kErrorKeyCreationFailed and kErrorCreatingGroupKey, respectively. Previously, for v2 Enrollment, key-creation failures would be caught during key-proof computations, resulting in a misleading error code. This was particularly relevant considering the recent M79 platform bug http://crbug.com/1017858. It is not necessary to merge these changes into M79 since M79 is already in beta. The result is that key creation failures will be interpreted as key-proof computation failures until M80. Bug: 899080, 951969 Change-Id: I9682b1fe548e4b3c0c9a00aea06f415d0aedd924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932402 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Emily Stark authored
This CL loosens mixed content restrictions to omit mixed content warnings for external protocol URLs (a.k.a. non-webby URLs). Why? Native applications cannot return data to the browser via an external protocol URL, so a page that loads a frame or a subresource over an external protocol is not actually displaying or running mixed content. One might reason that external protocols should be treated as mixed content because sending data to a native application can be dangerous (because e.g. the website could send a malicious payload to a vulnerable application), but the website can already do so via a top-level navigation, and the external protocol dialog is supposed to ensure that users only accept these resource loads from websites that they trust. (The dialog is currently not very good and needs to be revised to communicate more of a warning message, but that's a separate issue orthogonal from mixed content warnings.) This change simplifies an M80 change to give passive mixed content (images, particularly) a more aggressive UI treatment in advance of autoupgrading+blocking them in M81 (https://security.googleblog.com/2019/10/no-more-mixed-messages-about-https_3.html). Forms that target external protocols are still treated as passive mixed content (this is the same as forms that target http:// URLs). This could probably be argued either way, but the reasoning is that we should downgrade the UI when we know that user data is explicitly being sent to a potentially insecure endpoint. Bug: 621131 Change-Id: Ie945f516db087a9a98cca294d6959d70bbf0dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946934 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721630}
-
Lei Zhang authored
I have not worked on Autofill in years, so I am giving up my ownership here. A bug has been filed for a TODO with my name on it. Bug: 1030490 Change-Id: I9afb96a4a8b4a7eefc97854e2c5f29746eb5b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949208Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721629}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 891670 Change-Id: Ic635324cffd0bc9113bf40e21b1d647cbf33c344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945170 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721628}
-
Sonny Sasaka authored
This reverts commit d85ee3b4. Reason for revert: b:145163508 Original change's description: > device/bluetooth: Enable the use of btdispatch by default > > This sets the feature flag kNewblue to be enabled by default. The effect > of this is that Chrome will by default communicate to Chrome OS' > Bluetooth dispatcher (btdispatch) instead of BlueZ. Currently, > btdispatch only forwards the D-Bus traffic to BlueZ without NewBlue > enabled. > > Bug: 999676 > Change-Id: I7089225726ef52c1b8465f3a67b3fdbf01b01882 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783719 > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693431} TBR=mcchou@chromium.org,reillyg@chromium.org,sonnysasaka@chromium.org,hansberry@chromium.org Bug: b:145163508,b:145317234 Change-Id: Iaa5ee6dd719ccc38bf31ce7adfd7ebfec1b08f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951128 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721627}
-
Brian Sheedy authored
Supports outputting the closest image known to Gold and its diff with the produced image when running the GPU pixel tests locally. This should improve the usability of the tests when debugging locally, as before they only output the produced image and a link to all images known to Gold for the test. Bug: 1030349 Change-Id: I55cd724541f86edf8d6de534bd921d70d03d6eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949727Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0eccc52635b4..1759c2d96833 git log 0eccc52635b4..1759c2d96833 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 fmayer@google.com Merge "Fix crash if send fails." 2019-12-04 eseckler@google.com Merge "proto/processor: Add typed TrackEvent args for three chrome messages." Created with: gclient setdep -r src/third_party/perfetto@1759c2d96833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f1aba9353d15f78b7970c674876b848ed414582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951145Reviewed-by:
-
Owen Min authored
Record the timestamp when user request the extension for better UX on the server side. The timestamp will be stored in the Pref as a DictionaryValue with the format: { "$extension-id" : {"timestamp : "$java-time-as-string"}, } The pref type is chagned from list to dict. It's safe to do so because the only code path to set the value is behind a private API which is used by no one now. Also, allow ExtensionApiUnittest to pass TaskEnvironmentTraits to BrowserWithTestWindowTest so that we can pause the clock for the test. Bug: 1006899 Change-Id: I3c0463ed3847f6d14a14d31f6073355d6dc43716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940670 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721624}
-
Peter Kotwicz authored
This is unused as of https://chromium-review.googlesource.com/c/chromium/src/+/1382499 BUG=None Change-Id: I0ed23f05fe2630cdaa2ab2cf7c904f3b0cb53ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949859 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721623}
-
Ian Prest authored
As part of review for a previous CL, we identified several functions in |ax_role_properties.h| that take an |AXNodeData|. Logically, however, the functions in |ax_role_properties.h| should only require the |AXRole| enum. - The functions that require |AXNodeData| were removed from that header, and replaced with member functions on |AXNodeData| itself. - Tests of those functions were moved to their appropriate new home. - Other changes were made as required to compile. - Fixed common misspelling of 'invocable' in the moved functions, identified by Tricium. Bug: 1030414 Change-Id: I9e2037fcd5a0bae7a922c9da9529ad48656aeceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948376 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#721622}
-
Kyle Milka authored
Wire up the send-tab-to-self feature to the sharing hub. This requires some refactoring of the STTS code so that it's no longer dependent on being passed a ChromeActivity. Bug: 1009124 Change-Id: I7b0c0c9e4015d78d8727e6305324c663c4081095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925088Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721621}
-
Kevin McNee authored
Now that BrowserPlugin is being removed, there is no longer a need for the root to filter the gesture events in a child. Bug: 533069, 751782 Change-Id: I6b5684fdb0c4a296cfe94aabd931677800918839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944316Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721620}
-
Jasper Chapman-Black authored
Change-Id: I8cf3be77f4bd98e0516854de1f2056cb8777fa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949325Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721619}
-
danakj authored
This changes BluetoothDevice::ConnectErrorCallback to be a OnceCallback, then the Bind() call in content can become a BindOnce(). While doing so, the Pair() method is changed to take a OnceCallback as well. And callers to Pair() and Connect() are changed to use OnceCallbacks and BindOnce(), including in unit tests. R=reillyg@chromium.org TBR=sky Bug: 1007760 Change-Id: I2ec6dfd45c868cd49b898506f8495427b51448ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943941 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#721618}
-
Ian Kilpatrick authored
Previously we only had to consider "start" and "end" static-positions. If a OOF positioned element is a child of a flexbox which has align-content: center its static-position edge is the center. This adjusts: - StaticPositionStartInset - StaticPositionEndInset - the computed_available_size calculation ... to take "center" static-positions into account. Bug: 845235 Change-Id: Idfc4b301c95c93073e072f7ac53cd9510d887a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930689Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721617}
-
Yi Gu authored
QueryClientInternal was introduced to distinguish v1 and v2 query paths. It's no longer needed. Bug: 1029012 Change-Id: Ie7682848335b98a7a54052372b4509fda6cb1dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950707Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721616}
-
Ian Kilpatrick authored
This does a couple of things: - Removes a loop from within SwapOutOfFlowPositionedCandidates. - Moves the inline logic within SwapOutOfFlowPositionedCandidates to MoveOutOfFlowDescendantCandidatesToDescendants (picking up the inline_container logic). - Moves SaveStaticPositionFromLegacy out to the NGOutOfFlowLayoutPart. - Disables the relayout boundary for static-position OOFs (due to SaveStaticPositionFromLegacy change). Bug: 845235 Change-Id: I0a0995432f7a4e3e1323ea0c5558b6cf92ac910e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929972Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721615}
-
Maksim Moskvitin authored
Directory implementation stores keystore keys in sync prefs. Since missing keystore keys from the response are possible and can cause significant sync issues (such as infinite configuration sync cycles), it's worth to support their migration. Packed keystore keys are propagated through the bridge constructor and passed to SetKeystoreKeys() if following conditions satisfied: 1. There are some keystore keys in preferences. 2. There is no errors during unpacking keystore keys. 3. Bridge didn't yet received any keystore keys (i.e. they weren't restored from Nigori storage). Bug: 1030736, 922900 Change-Id: I4419da22dbe010e226dae61fdc4164d3a37b5e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950946 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
