- 21 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f25a1c68473b..23742c0958dd git log f25a1c68473b..23742c0958dd --date=short --no-merges --format='%ad %ae %s' 2019-08-21 chrisforbes@google.com Fix linux build with gcc-8.2 2019-08-21 geofflang@chromium.org Support RGB formats with IOSurface client buffer surfaces. Created with: gclient setdep -r src/third_party/swiftshader@23742c0958dd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:995142 Change-Id: Ib5daec1d5ce25cd035e8abbb8863a7ea7acd2bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689227}
-
Joe Mason authored
This is a reland of e5f1b06d It was reverted in https://crrev.com/c/1760644 for causing test failures on CI builders that couldn't be reproduced on other machines. This patch disables the failing tests. A followup will reenable the tests with extra debugging to diagnose the failures on the CI builders. Then it was relanded and reverted again in https://crrev.com/c/1764124 because it raced on the CQ with an API change to CreateSequencedTaskRunner. TBR=wfh TBR_REASON=Reland of test-only proto change that was already reviewed. Original change's description: > Implement ProtoChromePromptIPC. > > Bug: 969139 > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#688357} Bug: 969139 Change-Id: I989a66205db61caefd7777d0046226e3244dc4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764471Reviewed-by:
Joe Mason <joenotcharles@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689226}
-
Jinsuk Kim authored
This CL logs UMA histogram for various user actions performed for gesture navigation as proposed in the PRD: - GestureNavigation.Abandoned - GestureNavigation.Completed - GestureNavigation.Reversed - GestureNavigation.Sheet.Peeked - GestureNavigation.Sheet.Selected - GestureNavigation.Sheet.Viewed - GestureNavigation.Sheet.Used - GestureNavigation.Triggered Before this, partial actions were logged (Overscroll.Navigated3/Cancelled3) which were from an old desktop experiment to recycle the histogram. This is not really necessary, and prone to a problem if there's any change in the one it depends on. This CL defines a new set of UMA histogram entries above to make it independent. This will work in conjunction with cl/264091291. Also fixed some bugs/polished code in the navigation feature while testing the histogram: - Navigation sheet should be fully expanded when user lifts his finger while the sheet is in peeked state. The arrow puck then should fade away at that position. For this, NavigationSheet.isPeeked() is required for SideSlideLayout to decide which animation to start and what to log. NavigationSheet provides isPeeked() instead of isExpanded(). - NavigationSheetCoordinator.hide/setVisible(false) always go in pair. This CL moves the latter inside the former method. - NavigationHandler.onTouchEvent was not calling NavigationSheet.release, which caused a bug for native pages. Added it. Bug: 937946 Change-Id: I7a2075fc5952c4a691ef8ec9ad5b7943b790a8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758042Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#689225}
-
Navid Zolghadr authored
Bug: 984222 Change-Id: I3e032bd55c6b024ccad4ea42f5d743106f021bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761775Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689224}
-
Sharon Yang authored
The Fuchsia SemanticsManager uses a ViewRef to identify a View in registration. This change allows a ViewRef to be associated with a View created by the WebEngine. Bug: 990432 Change-Id: Ib7554deb9054aeeabb1322008e6c7566807d6faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742988Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689223}
-
Evan Stade authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3490 TBR=caseq@chromium.org Bug: 847114 Change-Id: I2ebf3486557e74d94e0eb7f0fd2e73ab10f84ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764671Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689222}
-
Chris Cunningham authored
Bug: 992235 Change-Id: Ic17fb19707e8c3e20763ecb974a729d52ba2428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761330Reviewed-by:
-
tby authored
We don't have a pure frequency predictor on the chrome side yet, which we'd like to use for part of the upcoming files ranking model. Bug: 921444 Change-Id: I43f6d2ed86845878fe50142a790cfd19caa83c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761894Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#689220}
-
Jonah Ryan-Davis authored
These tests have a specific condition on a driver version being less than 24.20.100.6557, but the test expectations aren't working. Likely due to a recent change in gpu info collection. More info in the bug. TBR=kbr@chromium.org Bug: 994852 Change-Id: I5ae793777f442f0423cb22193f43d0b9eeed4263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762757Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689219}
-
Brian Geffon authored
As described in go/dynamic-tcmalloc this CL will dynamically adjust tcmalloc's thread cache sizes in response to memory pressure. Experimentally this improved the number of loadable tabs on low end Chromebooks by 10% while also reducing tab switch times by nearly 5%. BUG=chromium:993569 Change-Id: Ib2101db7165fdb63d396e4ad49b01e335a674bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758666 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689218}
-
Rose Garcia authored
Added functions to be used in custom menu order implementation. These functions currently do not do anything and are not called. These functions are currently set up to run with the current menu (no submenus). This will be updated and refactored in an upcoming change following the menu redesign. The functions are to sort and insert the Switch Access menu buttons based on a given order. Bug: 994256 Change-Id: I707bf727d73318b451c80e2e87470170f6dc9b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759893Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Rose Garcia <rosalindag@google.com> Cr-Commit-Position: refs/heads/master@{#689217}
-
Evan Stade authored
This reverts commit 4b84d3c3. Reason for revert: breaks win-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4316 Original change's description: > Roll src/third_party/perfetto 2891cbc02f12..2d256c406cde (2 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..2d256c406cde > > git log 2891cbc02f12..2d256c406cde --date=short --no-merges --format='%ad %ae %s' > 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events" > 2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest" > > Created with: > gclient setdep -r src/third_party/perfetto@2d256c406cde > > The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=perfetto-bugs@google.com > > Bug: None > Change-Id: I19c290c53bb20801185f414fa8c8026a29108089 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764456 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#689188} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I855b974f7df2c8d15cb8d805b0288f729149e314 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764336Reviewed-by:
-
Fergus Dall authored
Currently CrostiniPackageService::UpdatePackageOperationStatus doesn't check for the after-the-end iterator when looking up package operation notifications. This can cause crashes when unexpected messages are received. This CL adds checks for this case. Bug: 995192 Change-Id: I4b50f5ef9439e09e42db5174de408492eb5bab3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763549 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689215}
-
Andrew Comminos authored
Adds histogram measurement for calls to performance.profile. Bug: 956688 Change-Id: Ida185e18f796d2d3349f18f59097a7841195a0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763163Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#689214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53297790de09..255b36d8ae06 git log 53297790de09..255b36d8ae06 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-21 ehmaldonado@chromium.org Fix pylint on windows Created with: gclient setdep -r src/third_party/depot_tools@255b36d8ae06 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:866772 Change-Id: I4de9038ca2a7acbec3af3eeaf03218f32152f760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764464Reviewed-by:
-
Eric Karl authored
Does a few things: -Adds BACKGROUND dumps to memory dump providers needed for the GpuMemory metric. -Update process memory metrics to dump the needed categories when collecting metrics. -Adds a kIgnored EmitTo value to process memory metrics for metrics which are not interesting on their own but will later be summed into a larger metric. Bug: 987813 Change-Id: Id9e1da6d5f1e7f2c60bf3d04c263b0c916aa0430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754506 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689212}
-
Aran Gilman authored
This should be less error-prone than trying to remember which bool is which, something I found myself looking up repeatedly while working on the associated bug. Bug: 990104 Change-Id: I9323ab25a3d30273963e8b9b7fa51cacfe0b44ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762705 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689211}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f69bd5f184cc..b689af4c995e git log f69bd5f184cc..b689af4c995e --date=short --no-merges --format='%ad %ae %s' 2019-08-21 mellem@webrtc.org Changes to enable use of DatagramTransport as a data channel transport. 2019-08-21 steveanton@webrtc.org Revert "Simplification and refactoring of the AudioBuffer code" 2019-08-21 sprang@webrtc.org Remove WebRTC-Pacer-LegacyPacketReferencing flag and most usage 2019-08-21 peah@webrtc.org Process 8 kHz audio as 16 kHz internally of the audio processing module 2019-08-21 peah@webrtc.org Simplification and refactoring of the AudioBuffer code Created with: gclient setdep -r src/third_party/webrtc@b689af4c995e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Idbc9ba0c8e28fca2f041fe5bb599f551d7c0d507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764457Reviewed-by:
-
Jeremy Roman authored
Changed NULL to nullptr where the presubmit complained (due to new line wrapping). Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Tbr: gab@chromium.org Change-Id: I1f9c781cd980150ad1eecee9342be2e3116617b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763040Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689209}
-
Will Harris authored
ASAN has not yet fully initialized by the time the CIG intercepts execute. Most of the code works fine but the call to std::unique_ptr ends up hitting an uninitialized instrumentation and crashing. Various options were considered including: * Add all of the std::unique_ptr calls used in the interception code to the exclusion list. * Implement our own smart pointers in the interception. * Just use stack allocations and/or dumb pointers in interception. It seemed, upon reflection, the best use of engineering resources to just disable CIG on ASAN builds. BUG=995986 Change-Id: I5078a21c70864d7e14a8196ec05bb217b3251f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763095Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689208}
-
khmel@chromium.org authored
As described. TEST=Manually,autotest to be added BUG=b:122555793 Change-Id: Iebeafb130b659c8a573da460987598a8bf8f1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763638Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Bug: 994721 Change-Id: I59513333ac07d472c4ce66f8b54e606e3fd07bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758035Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#689206}
-
Gavin Williams authored
Originally the Printers mock specified to display a button with "Configure" for configuring discovered printers. This was changed to display a button with "Set up". Bug: 993816 Change-Id: I20409dd3661e7ee78d91122eed112d4dae26579c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758838Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#689205}
-
Jared Saul authored
Walter is definitely not the right owner for these anymore. Looks like the histograms expired and we weren't aware of it (I caught it by luck, thanks to the UMA dashboard highlighting the expiration.) Also removes their expiries, because we do use these histograms to determine the latency difference between Google Payments server calls and what Chrome sees in the end, due to added latency getting the calls to/from mobile devices, etc. Bug: 975010, 975231, 975638 Change-Id: Id11faa3c73b14758064558a0da0893feed1066aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759390 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689204}
-
Joel Hockey authored
Change-Id: I41d7bd3a3b1225ad0aba49f75e3b0113f7f43ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757416 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689203}
-
Karan Bhatia authored
This CL corrects comments for the |request_initiator| parameter in WillCreateURLLoaderFactory. The current comments say that navigation requests are not associated with an initiator which is incorrect. Also, add a check for a null |render_frame_host| to ProxyingURLLoaderFactory::MaybeProxyRequest to prevent a null pointer dereference and fix associated crashes. BUG=996041 Change-Id: I4a468ded6006c19f0a321d685fa40aa7f6ad1331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761607Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689202}
-
Ahmed Fakhry authored
This reverts commit 66630f37. Reason for revert: Breaks compile on linux-chromeos-rel. BUG=996442 Original change's description: > Removing dead ServiceManager constants > > Since ServiceManager went away, we're clearing up some leftover > CupsProxyService constants. Trivial change. > > Bug: chromium:945409 > Test: confirmed service behavior unchanged > Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430 > Auto-Submit: Luum Habtemariam <luum@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689164} TBR=dcheng@chromium.org,rockot@google.com,skau@chromium.org,luum@chromium.org Change-Id: Ic9914332352bc21a15ce96e14f192eefdbed499e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:945409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764333Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#689201}
-
Donn Denman authored
Enables the ContextualSearchTranslationModel Chrome Feature for testing. This feature is currently used to switch from the custom Contextual Search translation logic and the Chrome Translation Model. This might have an impact on testing or stability. Also fix a logic error which switching between translation models -- the disable switch should be considered. TBR=twellington BUG=644909 Change-Id: Ia155461999d983d952e1ce4c1c1c422a3cd89da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763298 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
-
Peter Kasting authored
The light mode color (#BABABA) dates back well before Material Design (v1), and doesn't seem to have an updated spec anywhere. kGoogleGrey300 matches button borders. (Dialog borders use a different color that's based on alpha-blending black, and has a surrounding shadow, so it doesn't seem quite as parallel.) Using kGoogleGrey800 in dark mode happens to provide the same contrast against the menu background (1.37) as GG300 does in light mode. Bug: 995442 Change-Id: If8c668ad58c90f4a82dd1869219330b811894fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762479 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
It's a very edge case that a percentage may be resolved against a negative value, which is allowed only in 'background-position' property. To support this without massively changing existing code, this patch adds an indicator flag to |CSSMathFunctionValue|, so that when the flag is set, the resolution of calculated percentage values is delayed to when a reference value is available. When the flag is not set, we still use the existing code path where a calculated percentage value can be resolved immediately. Together with this patch is a test suite on parsing and evaluation of comparisons on percentages. Bug: 825895, 978682 Change-Id: I2a6aabd48313ccda82b50f6dc00fd62c4548bc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762970 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#689198}
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: I236fb8dbf2f0fd6ea879a6996e2a11a143406b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761272 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#689197}
-
Kristi Park authored
This reverts commit 371290bf. Reason for revert: Flexbox does not play well with the colors menu Original change's description: > [NTP] Position richer picker elements using flexbox > > Position elements with flexbox instead of inline-block. This allows us > to remove the "font-size: 0" hack that fixed the extra space between > inline-block elements. > > Change-Id: Ie3b6f02281795e60806259a00b2ee948df3b0959 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725334 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688355} TBR=kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4a5a2a70e58e2d1d03d15505d9c5be5b866fe959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763340 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#689196}
-
Daksh Idnani authored
Bug: 996344 Change-Id: I0d81bb75ee75ae0b9c58bebb555c8c037261ec44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764240 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Kevin Babbitt authored
The crash key is no longer needed, and it's suspected that the code for logging it is contributing to further instability. Remove it. R=aleventhal@chromium.org Bug: 974444 Change-Id: I38ae47c60258f2a48f383d3b20c35910b81cd296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764122 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#689194}
-
Kyle Milka authored
Hide the entire MV container rather than just the iframe. This fixes an issue with keyboard focus when the tiles are hidden. Bug: 996156 Change-Id: Ia0e19920b3d06e916851334a1b223161736bf100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763299Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL re-enables all tests in the suite. browser_tests are flaky, but all known differences with SkiaRenderer have been fixed. Please add vasilyt@chromium.org and jonross@chromium.org for new bugs related to flakes in this suite. Test: skia_browser_tests Bug: 982933 Change-Id: I6e5427d427aa22d5a4d38645b58f9b718c3239af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764251Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689192}
-
Gabriel Charette authored
This reverts commit eb651697. Reason for revert: the culprit was another one of my CLs! Original change's description: > Revert "[TaskEnvironment] Standardize paradigm for classes forwarding traits" > > This reverts commit 7472b906. > > Reason for revert: sheriff suspects this caused a build break on win{,32}-archive-rel: > > https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4309 > > In file included from ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc:14: > In file included from ../..\base/test/scoped_task_environment.h:15: > In file included from ../..\base/task/lazy_task_runner.h:17: > ../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)" > static_assert( > ^ > ../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here > base::CreateSequencedTaskRunner({base::MayBlock()}); > ^ > 1 error generated. > > Original change's description: > > [TaskEnvironment] Standardize paradigm for classes forwarding traits > > > > As discussed @ > > https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84 > > > > Usage of explicit everywhere also avoids implicit copy construction > > and is the reason for changes to a few unit tests that previously > > used operator= to initialize their task environments. > > > > TBR=dcheng@chromium.org > > (for widespread mechanical change) > > > > Bug: 992483 > > Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338 > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689098} > > TBR=dcheng@chromium.org,gab@chromium.org > > Change-Id: I69b71b220ab583bc3a18e8fb07213fa1b6a75b50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 992483 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762475 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689122} TBR=ellyjones@chromium.org,dcheng@chromium.org,gab@chromium.org Change-Id: Ibc0ab9c4df6dcbc4a65fd26e0356c78e8b0f90b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764390Reviewed-by:
-
gogerald authored
Bug: 982018 Change-Id: Idb97cf0d324b4addc23a8ced0c75facb4096c126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757508 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Kyle Milka authored
When the daily refresh toggle was deselected it was applying the selected state to the wrong element. Bug: 996147 Change-Id: I76bbb4590701636a56439940f1d69afe359661ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763339Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#689189}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..2d256c406cde git log 2891cbc02f12..2d256c406cde --date=short --no-merges --format='%ad %ae %s' 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events" 2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest" Created with: gclient setdep -r src/third_party/perfetto@2d256c406cde The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I19c290c53bb20801185f414fa8c8026a29108089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764456Reviewed-by:
-
