- 19 Sep, 2018 40 commits
-
-
Adithya Srinivasan authored
As per discussion in the associated bug, we call EnsurePaintLocationDataValidForNode, which ensures that the document lifecycle is advanced to kCompositingInputsClean for sticky elements in order to correctly calculate its position. Bug: 850380 Change-Id: I27665028393cee6f330fda747b4a344e994fe8fe Reviewed-on: https://chromium-review.googlesource.com/1231378Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592440}
-
edchin authored
This CL: 1) Notifies observers when the SnapshotCache removes a snapshot. This approach gives symmetry since observers are notified when a snapshot is added. 2) Adds a unittest for notifying observers on setting and removing a snapshot. 3) Adds TabGridMediator as an observer. Bug: 739840 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib6fa854670537a1d225f92adbc51a361a1714623 Reviewed-on: https://chromium-review.googlesource.com/1231897Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592439}
-
Sadrul Habib Chowdhury authored
Some of the discrepancy_ and mean_ metrics have been removed in crrev.com/c/1228794 and crrev.com/c/1229335. Update the tests accordingly. BUG=884950, 886913 Change-Id: If47fa9231e55fe52d6511b71cbcce1776cef4d60 Reviewed-on: https://chromium-review.googlesource.com/1234015Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592438}
-
Dan Zhang authored
Remove unnecessary forward declare of RandomBase in random_util_helper.h Merge quic part internal change: 210537018, 211551817 R=rch@chromium.org Change-Id: Idd96a1b6308dca93d68682490323d3ab7dee3f4f Reviewed-on: https://chromium-review.googlesource.com/1228838 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#592437}
-
Robert Ogden authored
See the UI mocks and specs in the bug for more detail. This CL also moves around some logic from the PreviewsInfoBarDelegate to the tab helper. Bug: 871839 Change-Id: Iba7f034fca449cf98c4c9054072365eef5bb339c Reviewed-on: https://chromium-review.googlesource.com/1222406 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#592436}
-
Ned Nguyen authored
Bug: 885913 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If4d056738ff1ae84fa43f1d229ca89a39a71e81d Reviewed-on: https://chromium-review.googlesource.com/1234034Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592435}
-
Ahmed Fakhry authored
In this case, a web contents won't be the delegate of the render view host, and content::WebContents::FromRenderViewHost() will return nullptr. BUG=885207 TEST=Manual Change-Id: I76b722ebdd4ce2446dfb2087f3a2f4b3daae45a7 Reviewed-on: https://chromium-review.googlesource.com/1232681Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592434}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I6e2b277d3083645c7967cc3a1a481c8bf645eebd Reviewed-on: https://chromium-review.googlesource.com/1233739Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592433}
-
Weiyong Yao authored
In another cl, the logic in capture() was modified according to the review comments, which causes the problem in crbug.com/883984. This cl is to restore the logic in capture() as before. Bug: 883984 Change-Id: I0c8684c7611fd75f37ce9d3b12c2dc8290668534 Reviewed-on: https://chromium-review.googlesource.com/1225974 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592432}
-
Antonio Gomes authored
Currently, there is currently ~9 identical implementations of this method spread across various tests / components. This CL is a first step that eliminates this redundancy, by adding a API to it in TestURLLoaderFactory and convert a couple of call sites. TBR=dewittj@chromium.org (straight forward switch in //components/offline_pages). BUG=773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie6b6867b046a72d0be7a7ec2bb6d964d2cfceb3e Reviewed-on: https://chromium-review.googlesource.com/1234133 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#592431}
-
Morten Stenshorne authored
The implementation is the same, but I threw in a DCHECK that inline size not being indefinite. This function can be used for other things than converting from border-box to content-box. It can e.g. also be used to convert from padding-box to content-box, or from border-box to padding-box. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic14550ec7019eedf03d3a16d31cd6ab51e507811 Reviewed-on: https://chromium-review.googlesource.com/1233698Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592430}
-
Scott Violet authored
EmbedRoot: needs to show the WindowTreeHost. I'm a surprised we actually see anything without this. WindowPortMus: removes an unnecessary local. WindowTree: Renames GetClientRootWindowFor() to FindClientRootContaining(). BUG=881574 TEST=covered by tests Change-Id: I869d59dd2a20c5a608ef1c7346bc906de73f84dc Reviewed-on: https://chromium-review.googlesource.com/1233173 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592429}
-
Asanka Herath authored
This reverts commit 888677bc. Reason for revert: Tests failing on chromium.memory/Linux CFI. See crbug.com/886576 Original change's description: > Switch UserScriptListener ResourceThrottle to NavigationThrottle > > ResourceThrottles do not work with network service enabled, a > NavigationThrottle will work both with NS enabled and disabled. > > Bug: 884006 > Change-Id: Ifea0e59bd67d70b593b46c2a2a2bd4be0e3f98f0 > Reviewed-on: https://chromium-review.googlesource.com/1227358 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592182} TBR=jam@chromium.org,rdevlin.cronin@chromium.org,cduvall@chromium.org Change-Id: I18519542954bf23e2e76ea83598382f4f00188e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884006 Reviewed-on: https://chromium-review.googlesource.com/1234214Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592428}
-
Boris Sazonov authored
This CL modifies OAuth2TokenService.hasOAuth2RefreshToken to check whether the account list cache has been populated and is ready to use. Native MutableProfileOAuth2TokenService::RefreshTokenIsAvailable also returns false if refresh tokens haven't been loaded yet. Bug: 837374 Change-Id: Ia7c2475566b05c93fd706ca2ce1e9f16bfbae608 Reviewed-on: https://chromium-review.googlesource.com/1231935Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c42c66b2dd05..4544f3711024 git log c42c66b2dd05..4544f3711024 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 hjd@google.com perfetto-ui: Add v0 of record page Created with: gclient setdep -r src/third_party/perfetto@4544f3711024 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I32bb837d0a0775d7924c3c9ee0e767ee303082a6 Reviewed-on: https://chromium-review.googlesource.com/1233993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592426}
-
Stephen McGruer authored
This was replaced by Blink.UseCounter.CSSProperties in crbug.com/458925, and is no longer used. Bug: 838487 Change-Id: I74adf77c7c291487fd0aed6a40646016aa6fa6b1 Reviewed-on: https://chromium-review.googlesource.com/1228786Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592425}
-
Sylvain Defresne authored
As std::function<> is forbidden, convert KeyedServiceFactory to use base::Callback<> instead; eventually this will allow sub-classes to accept callbacks instead of function pointers. Also convert KeyedServiceFactory to std::unique_ptr<> in the std::map<> instead of raw pointers and delete. Bug: 809610 Change-Id: I14dcae6f9086a8788942431f6f68ab294cf11745 Reviewed-on: https://chromium-review.googlesource.com/1233702Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592424}
-
Stephen McGruer authored
This CL adds startScrollOffset and endScrollOffset to the ScrollTimelineOptions and the equivalent accessors to the ScrollTimeline object. It includes the full parsing of the input DOMStrings into the relevant CSS types. Thie CL does not actually add use of the values in the currentTime algorithm - that is left for a follow-up. https://wicg.github.io/scroll-animations/#dom-scrolltimeline-startscrolloffset Bug: 885196 Change-Id: I85bd6698abe2acaa2d57d69cec17d99a186e22e7 Reviewed-on: https://chromium-review.googlesource.com/1231156Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592423}
-
Michael Spang authored
This was not tested since it is only compiled in Chrome OS builds. Bug: none Test: compile Change-Id: I5c8954faa1b782efe744e312f4d578fe43567ed3 Reviewed-on: https://chromium-review.googlesource.com/1232521Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592422}
-
Peter E Conn authored
Change-Id: Ibd1d85291b0620295aa26aa0369c5befa17564aa Reviewed-on: https://chromium-review.googlesource.com/1233594Reviewed-by:
-
Michael Spang authored
DRM is crashing in CreateBufferWithGbmFlags(), apparently because there are no DRM devices. Move the crash earlier and add a log when the primary device opens, after which GetDrmDevice() should never be able to return nullptr. Bug: 877661 Test: compile Change-Id: I0cf117513e5d853d31635e9e6d2c7fc2f59a4feb Reviewed-on: https://chromium-review.googlesource.com/1232394 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#592420}
-
Antoine Labour authored
This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. This also adds memory accounting in SharedImageFactory/SharedImageStub. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I37eba221bc2aeb4d03b7d4d93bde772482dc681b Reviewed-on: https://chromium-review.googlesource.com/1178977 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#592419}
-
Dave Tapuska authored
- Use DOMNodeId where appropriate - Use wtf_size_t when dealing with WTF containers - Apply truncation/SafeCast where appropriate BUG=879657 Change-Id: I4c81a2f3e10000fc04e0a56f29080c4447862c85 Reviewed-on: https://chromium-review.googlesource.com/1227187Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592418}
-
kylechar authored
VizProcessContextProvider is missing memory reporting logic found in ContextProviderCommandBuffer. Make VizProcessContextFactory a MemoryDumpProvider so display compositor gpu memory is reported again. This is expected to have an impact on the gpu and skia memory tracing categories. This isn't a regression itself, it's just fixing memory reporting that was broken when VizDisplayCompositor experiment was enabled by fieldtrial test config. Bug: 876508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia885fccd122dbfc8909f62e0a970c10ab3499632 Reviewed-on: https://chromium-review.googlesource.com/1209985Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592417}
-
Aga Wronska authored
Offline ToS are loaded if attempt to load online content fails. Play Store ToS are region dependent. The proper version is decided based on language from chosen locale and device region from the VPD. Dedicated resources are used for most of the regions targeted by v1 Demo Mode: * Belgium: nl-BE, fr-BE * Finland: fi-FI * Sweden: sv-SE * Norway: nb-NO * Denmark: da-DK * France: fr-FR * Ireland: en-IE * Netherlands: nl-NL * Canada: en-CA, fr-CA * US: en-US * UK - en-GB * Luxembourg: eu (no dedicated terms available for de-LU nor fr-LU) The other regions use default resources: * EMEA: emea * EU: eu * APAC: apac * AMERICAS: en-US * Germany: de * South Korea: kr * Anything else defaults to en-US Information about VPD regions: https://storage.googleapis.com/chromeos-factory-docs/sdk/regions.html#available-regions If Demo Mode expands the list of targeted regions dedicated resources should be added for the new regions. Bug: 857275 Test: Run wizard controller and demo setup browser tests. Run about_ui_unittest. Manually perform offline demo mode setup. Change-Id: I556f08720f6214f1b33be09af9ac232c103b2f14 Reviewed-on: https://chromium-review.googlesource.com/1211737Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592416}
-
Annie Sullivan authored
Doc with background info: https://docs.google.com/document/d/1yg7wiWwYbd5hybJfHJC1aCZlOH7E8AR1f93IA71eU3I/edit# Bug: 750639 Change-Id: Ifccd618c0e44f297f54b0c0bc3792f565eb47be9 Reviewed-on: https://chromium-review.googlesource.com/1226518 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592415}
-
Mythri Alle authored
In GeneratedCodeCache::ReadDataComplete also handle cases when the entry was just created but no data is written into. We always expect response_time as the header in the cache entry. If the number of bytes read is smaller than the response_header then it should be treated as a Error. Also, we can have entries with only response time and no data associated with it. Bug: chromium:884217 Change-Id: I5cc3f0923aa87ce208fe766ab6e9fb2633c24159 Reviewed-on: https://chromium-review.googlesource.com/1228123 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#592414}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c72f28d1a3f..2c8f0845431d git log 5c72f28d1a3f..2c8f0845431d --date=short --no-merges --format='%ad %ae %s' 2018-09-19 oetuaho@nvidia.com Add ANGLE_multiview_multisample Created with: gclient setdep -r src/third_party/angle@2c8f0845431d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2c34eaa7dbb1c136592dbde51f55cd787868693d Reviewed-on: https://chromium-review.googlesource.com/1233636Reviewed-by:
-
Asanka Herath authored
This reverts commit 5fc998cf. Reason for revert: Added tests are failing. See crbug.com/886616 Original change's description: > Added threaded virtual test suites for fast/events/touch|wheel > > This cl adds threaded tests suites for fast/events/touch|wheel/* layout tests. > Other than the following tests the rest of the tests are passing without any > issues: > > Touchpad fling related tests: these tests are skipped since touchpad swipe > is recently added to gpu benchmarking. I already have a bug for converting > these tests to use gpu benchmarking. see crbug.com/857490 > -virtual/threaded/fast/events/touch/gesture/pad-gesture-cancel.html > -virtual/threaded/fast/events/touch/gesture/pad-gesture-fling.html > -virtual/threaded/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html > -virtual/threaded/fast/events/wheel/mainthread-touchpad-fling-latching.html > -virtual/threaded/fast/events/wheel/wheel-fling-cancel.html > > The following test is flaky, but checking flakiness dashboard showed that its > other variations are flaky as well. see crbug.com/884312 > -virtual/threaded/fast/events/touch/multi-touch-user-gesture.html > > The following two tests are failing, but again so are their other variations. > I updated all the expectations to point to the same bug and added expectations > for the threaded versions. see crbug.com/876305 > -virtual/threaded/fast/events/touch/compositor-touch-hit-rects-list-translate.html > -virtual/threaded/fast/events/touch/compositor-touch-hit-rects.html > > Only the threaded version of the following tests are failing since they are using > event sender. I filed a bug to convert it to use gpu benchmarking: crbug.com/884332 > -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state-hidden-iframe.html > -virtual/threaded/fast/events/touch/gesture/gesture-tap-frame-removed.html > -virtual/threaded/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html > -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state.html > -virtual/threaded/fast/events/touch/gesture/focus-selectionchange-on-tap.html > > One additional test is failing when running with > --additional-driver-flag=--enable-blink-gen-property-trees, for which I have filed a bug: > crbug.com/884846 > > Bug: 874995, 884332, 884312, 876305 > Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ifbc4ca54b48307320fe3a703b93cff1620dd1878 > Reviewed-on: https://chromium-review.googlesource.com/1227331 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592215} TBR=bokan@chromium.org,pdr@chromium.org,sahel@chromium.org Change-Id: Ida4607d90ff08b8e218491d85165015b05177937 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874995, 884332, 884312, 876305 Bug: 886616 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1234193Reviewed-by:
-
Arthur Sonzogni authored
BrowserSideNavigation (aka PlzNavigate) launched. There is no more need to prefix those tests with the "BrowserSide" prefix. Bug: 789577 Change-Id: I5987644fdee4020eae1d7e420be1d24f6c656919 Reviewed-on: https://chromium-review.googlesource.com/1233493 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592411}
-
Bence Béky authored
1. Remove |response->head.mime_type| assignment before ParseContentType call. 2. Rename Content-Type test parameter to response_content_type. 3. Initialize |had_charset| to false to address MSAN bug; this will be removed from this CL as soon as https://crrev.com/c/1232591 lands and I rebase. Bug: 886629 Change-Id: I32fbe9d5c1fa6a0ba735bfd335923f0e1a723b04 Reviewed-on: https://chromium-review.googlesource.com/1233814Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This reverts commit 5665173d. Reason for revert: this is ranked as #1 renderer process related crash on the latest chrome dev 71.0.3554.0 on Windows. 97 crashes from 90 clients so far. Original change's description: > Use of dump without crashing to debug smooth scroll animation bug. > > Bug: 797708 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Icce9d0c3eeed94297936aebc81681f5db2ec0682 > Reviewed-on: https://chromium-review.googlesource.com/1226825 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591377} TBR=bokan@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 797708, 884592 Change-Id: I1e2787982eb1920e28e9a38281de0c76334162f2 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1233954Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592409}
-
Manu Cornet authored
This does not fix any known issues (and in fact doesn't change any behavior), but it seems wasteful to set the background blur to the exact same value multiple times. Bug: 881134 Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141 Reviewed-on: https://chromium-review.googlesource.com/1233122Reviewed-by:
-
HyeockJinKim authored
Bug: 844242 Change-Id: I980a50866506181759ad78424e9c35bfc3cd9edc Reviewed-on: https://chromium-review.googlesource.com/1201627Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#592407}
-
Fan Yang authored
In QUIC, consider session has pending crypto data if crypto stream has buffered data waiting to be sent. Protected by FLAGS_quic_reloadable_flag_quic_fix_has_pending_crypto_data. Also rename HasPendingCryptoData to HasUnackedCryptoData. Merge internal change: 213505364 R=rch@chromium.org Change-Id: I7225bf701a96dd4f07b1b0388d632d286fcfd4b2 Reviewed-on: https://chromium-review.googlesource.com/1232036 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce2e95b6cc38..be50d76e46ea Created with: gclient setdep -r src-internal@be50d76e46ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6e48aac8d9d3dd595ca7779927ea8660b464f7c1 Reviewed-on: https://chromium-review.googlesource.com/1233634Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592405}
-
Marc Treib authored
This prevents a crash in chrome://sync-internals in some situations, e.g. when we're waiting for a custom passphrase to be entered. This is analogous to https://crrev.com/c/1160229 and https://crrev.com/c/1228198. Bug: 878887 Change-Id: I3e1261fb7f0d98d73f98a82622ee4bb7511c9d6f Reviewed-on: https://chromium-review.googlesource.com/1233697Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#592404}
-
Morten Stenshorne authored
Fixed one test that I expected to pass, but didn't because it was pointing to the wrong ref. Fixed that, and now it passes. Updated some expectation files. More stuff from various tests (but not whole tests) is passing than before. Bug: 781135 Change-Id: Ieb1312b8bf13c7a45afe644ad2a58f3f955044b6 Reviewed-on: https://chromium-review.googlesource.com/1228073Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592403}
-
Dong-hee Na authored
If the Response body object is a readable stream then check whether the object is disturbed or locked. If the condition is true then throw TypeError. refernce: https://fetch.spec.whatwg.org/#concept-bodyinit-extract Bug: 878281 Change-Id: I0593d048e7bd146863efdc9f1d355bc70857cdc0 Reviewed-on: https://chromium-review.googlesource.com/1226718Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#592402}
-
Leonard Grey authored
Currently, UIDevToolsTest tests the whole system together in a single test file. This file uses WindowElement in most tests, which makes it difficult to port for the forthcoming Mac implementation, which does not have WindowElement due to not being an Aura platform. This is the first of a series of changes that will break most of UIDevToolsTest up into more granular tests, which will make it easier to isolate WindowElement use to Aura. This change takes the functionality that was previously being tested in the style tests in UIDevToolsTest, and breaks it into: - css_agent_unittest.cc, which tests interaction between elements and CSSAgent - Separate files for individual element subclasses, to ensure the mapping between the elements and their underlying objects. Additionally, it fixes a few bugs smoked out by the new tests in CSSAgent and WidgetElement. Bug: 769352 Change-Id: Ie24f2166a2dbe7fef31db2800c8bf88a1f470057 Reviewed-on: https://chromium-review.googlesource.com/1231033 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
