- 05 Mar, 2015 17 commits
-
-
newt authored
TBR=nyquist@chromium.org BUG=411461 Review URL: https://codereview.chromium.org/973403002 Cr-Commit-Position: refs/heads/master@{#319182}
-
ananta authored
We were not scaling the mouse coordinate by the scale factor before invoking the ClientToScreen API. With this change the blink::WebMouseEvent.globalX and globalY values have to be converted back to DIP after convering them to screen. This should fix the mouse locking issue. BUG=411634 TEST= The main test case in bug 411634 Review URL: https://codereview.chromium.org/973123003 Cr-Commit-Position: refs/heads/master@{#319181}
-
jrummell authored
BUG=442982 TEST=media_unittests pass Review URL: https://codereview.chromium.org/975983002 Cr-Commit-Position: refs/heads/master@{#319180}
-
dschuff authored
This pulls in the following Native Client changes: fd6546b: (dschuff@chromium.org) Update revision for PNaCl and x86 newlib nacl-gcc edcd955: (mcgrathr@chromium.org) Add test for code_data_allocate after mmap PROT_EXEC,MAP_FIXED 1c07f10: (dschuff@chromium.org) Use the LLVM integrated assembler for x86-64 nacl-clang target lib builds c162a1e: (dschuff@chromium.org) Test that invoking longjmp with an argument of 0 causes setjmp to return 1 5513033: (dschuff@chromium.org) Update revision for PNaCl cfe4942: (jvoung@chromium.org) Add subzero nexe to the pnacl translator build (NaCl build scripts). 4d1385a: (dschuff@chromium.org) toolchain_build: Switch canonical push URL to https://chromium.googlesource.com 7b92e88: (inferno@chromium.org) Fix ASAN build failure with linking nacl_bootstrap. ff68e26: (jvoung@chromium.org) Revert two recent nacl-gcc x86 newlib rolls and disable longjmp test. 68a738d: (shinyak@chromium.org) Avoid deadlock in build_nexe.py 99e2d42: (mseaborn@chromium.org) Cleanup: Move desc_metadata_types.h out of public/ 5e7b602b: (mcgrathr@chromium.org) Fix code_data_allocate after mmap PROT_EXEC,MAP_FIXED 19f11aa: (dschuff@chromium.org) Roll PNaCl back to ab8a5c605e1502be0605783bfe477d1a3d315817 Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/dac922075e8f2e020b3538133d619c02a5a0e4fa..19f11aa481261f38f2a1e9a04e41a7e12aa70e32 BUG= https://code.google.com/p/chromium/issues/detail?id=463455 TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/978073002 Cr-Commit-Position: refs/heads/master@{#319179}
-
eroman authored
Update some comments and code to reflect the fact that HMAC() is no longer hostile to NULL key data. BUG=395826 Review URL: https://codereview.chromium.org/975273002 Cr-Commit-Position: refs/heads/master@{#319178}
-
changwan authored
Previously on Android, we silently uniquified when there is a filename conflict. Now we're changing the behavior to prompt the user with an infobar. BUG=333085,415711 TEST=1) Download same file twice, choose 'replace file', and checked that file is overwritten. 2) Download same file twice, choose 'create new file', and checked a new file is created. 3) Download same file twice, dismiss the infobar and checked download did not happen. 4) Download file A twice, check the infobar, download file B twice, and checked that two infobars have showed up, and checked that both files can still be overwritten and new files can be created. 5) Download same file twice, check that infobar shows up, and navigate to another link and checked that infobar is still there and you can initiate the download. Review URL: https://codereview.chromium.org/580043002 Cr-Commit-Position: refs/heads/master@{#319177}
-
tapted authored
From 10.8 onwards, CoreText provides CTFontCopyDefaultCascadeListForLanguages() which is exactly what we want. For 10.6 and 10.7, use an older private interface, CTFontCopyDefaultCascadeList(). Adds tests to ensure the feature detection and API behavior is sane across all OSX versions we support. BUG=439039, 462477 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/971673002 Cr-Commit-Position: refs/heads/master@{#319176}
-
hubbe authored
This adds javascript bindings for the functions in cast_receiver_session, allowing a cast_receiver to be initiated from a whitelisted javascript extension. Also fixes a crashing bug in udp_transport.cc. Review URL: https://codereview.chromium.org/938903003 Cr-Commit-Position: refs/heads/master@{#319175}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ceac7ed..ce370d0 TBR=samli@chromium.org,aboxhall@chromium.org,dpranke@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/981703003 Cr-Commit-Position: refs/heads/master@{#319174}
-
rkaplow authored
Followed a local Linux machine which was slower than expected to where the time was going. Stopped at the ExtensionManagement::Refresh level, and will measure if this is general slow. BUG=454789 Review URL: https://codereview.chromium.org/977673002 Cr-Commit-Position: refs/heads/master@{#319173}
-
lukasza authored
This verifies that we detect and report misspelled policy names regardless of whether "RemoteAccessHost" appears as a prefix, suffix or a substring. I felt adding this test is important to "document" the behavior asked about in https://codereview.chromium.org/966433002/diff/120001/remoting/host/policy_watcher.cc#newcode109 The new test verifies expected behavior via MockLog class moved to base/test in crrev.com/966423003. I feel that the benefit of documenting and automatically verifying the expected behavior outweights the small maintenence cost of an additional test and the slight ickyness of verifying the behavior by looking at log output. BUG= Review URL: https://codereview.chromium.org/979823004 Cr-Commit-Position: refs/heads/master@{#319172}
-
xhwang authored
Revert of Adding Maps page to page_sets for telemetry. (patchset #7 id:310001 of https://codereview.chromium.org/955653003/) Reason for revert: Failed tests in drag_unittest.py: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests&number=3803 Original issue's description: > Adding Maps page to page_sets for telemetry. > > This CL adds google maps page to telemetry, and runs a synthetic drag > gesture on the page. This helps testing of maps page in telemetry to > track the performance on desktop chrome. > > BUG=457148 > > Committed: https://crrev.com/f502701b2bcc43c05d82e5780b2d6cf2d326bc23 > Cr-Commit-Position: refs/heads/master@{#319135} TBR=skyostil@chromium.org,picksi@chromium.org,petrcermak@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457148 Review URL: https://codereview.chromium.org/982683003 Cr-Commit-Position: refs/heads/master@{#319171}
-
jvoung authored
Otherwise, after transferring ownership the old base_file will always be invalid and we get spurious error logs, which can be confusing. This started happening after the refactoring in r274783. https://codereview.chromium.org/307173002/diff/80001/components/nacl/renderer/pnacl_translation_resource_host.cc Alternatively, could have checked the file_handle variable that ends up owning the base_file at the later point, but might as well check it earlier. BUG=none (but it bugged ncbray =)) Review URL: https://codereview.chromium.org/982663002 Cr-Commit-Position: refs/heads/master@{#319170}
-
mostynb authored
PepperVideoCaptureHost::OnFrameReady makes use of kUnknownFrameRate which was previously only included in webrtc builds. Let's move these constants to the header file instead, since it can be included in both webrtc and non-webrtc builds. Followup to https://codereview.chromium.org/955253002. BUG=461116,463829 Review URL: https://codereview.chromium.org/973373002 Cr-Commit-Position: refs/heads/master@{#319169}
-
tnagel authored
BUG=none Review URL: https://codereview.chromium.org/948803004 Cr-Commit-Position: refs/heads/master@{#319168}
-
aconverse authored
VP9's tile encoding feature allows for multithreaded parallelism on both the encoder and decoder side. TEST=Run remoting_perftests under VTune and see that two logical CPUs are used BUG=134202 Review URL: https://codereview.chromium.org/977663004 Cr-Commit-Position: refs/heads/master@{#319167}
-
oshima authored
* Removed AdjustStringDirection() * Removed FORCE_XXXX_DIRECTIONALITY and replace with TEXT_ALIGN_TO_HEAD. This is necessary not to use Canvas::DefaultCanvasTextAlignment for labels. * Also removed the safe guard in SizeStringFloat because RenderTextWin has been removed. BUG=None TEST=No functional change. Removed LabelTest, DirectionalityFromText that no longer makes sense. R=msw@chromium.org Review URL: https://codereview.chromium.org/953093003 Cr-Commit-Position: refs/heads/master@{#319166}
-
- 04 Mar, 2015 23 commits
-
-
anandc authored
BUG= Review URL: https://codereview.chromium.org/963723003 Cr-Commit-Position: refs/heads/master@{#319165}
-
felt authored
This ensures that both infobars and bubbles are tested by creating both DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is forced with a switch. BUG=438758 Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 Cr-Commit-Position: refs/heads/master@{#318987} Review URL: https://codereview.chromium.org/976823002 Cr-Commit-Position: refs/heads/master@{#319164}
-
rpaquay authored
BUG=358315 NOTRY=true Review URL: https://codereview.chromium.org/978053002 Cr-Commit-Position: refs/heads/master@{#319163}
-
jdduke authored
When a Java-based WebContents instance is destroyed, it may yet have Java-based WebContentsObserver instances. Previously, these instances would always see a destroy (formerly detach) call, as they each had a native counterpart. With the introduction of the proxy WebContentsObserver, destroy was not always called, as the remaining observers were simply cleared from the observer list. Explicitly call WebContentsObserver.destroy for these dangling instances, ensuring proper cleanup. BUG=464076 Review URL: https://codereview.chromium.org/981703002 Cr-Commit-Position: refs/heads/master@{#319162}
-
erikchen authored
Previously, an intermediary exception InspectorException was generated. This was caught and then converted into a more common Telemetry exception. Now the connection failure throws a standard Telemetry exception directly. BUG=460625 Review URL: https://codereview.chromium.org/955263003 Cr-Commit-Position: refs/heads/master@{#319161}
-
dnicoara authored
Simplify code by removing an interface only used in testing. BUG=none Review URL: https://codereview.chromium.org/981583005 Cr-Commit-Position: refs/heads/master@{#319160}
-
jvoung authored
Remove a couple unused fwd declarations and make a Getter const while I'm messing with that file. BUG=none Review URL: https://codereview.chromium.org/977893003 Cr-Commit-Position: refs/heads/master@{#319159}
-
aurimas authored
- Suppress missing drawables in components/web_contents_delegate_android/ - Remove unused progress_bar.xml BUG=266140 Review URL: https://codereview.chromium.org/971223004 Cr-Commit-Position: refs/heads/master@{#319158}
-
erikchen authored
Each location that catches AppCrashException does not actually want to know if the app crashed. Rather, the code wants to know if there was an error performing an operation. I've updated teh code to catch the more general Exception. BUG=460625 Review URL: https://codereview.chromium.org/969503002 Cr-Commit-Position: refs/heads/master@{#319157}
-
rockot authored
Also adjusts cron runtime to 180 minutes. It's been at 240 on the live instance for a while but was never committed that way. Refresh cycles are taking less time now, so dropping down to 180. R=kalman@chromium.org NOTRY=True BUG=None Review URL: https://codereview.chromium.org/977213002 Cr-Commit-Position: refs/heads/master@{#319156}
-
eakuefner authored
This change adds a field called interaction_record to values, which will specify the label of the interaction_record with which the value is associated, if it was generated by TimelineBasedMeasurement. R=nednguyen,dtu BUG=461101 Review URL: https://codereview.chromium.org/963313002 Cr-Commit-Position: refs/heads/master@{#319155}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/4e644f5..82b33db CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/975353004 Cr-Commit-Position: refs/heads/master@{#319154}
-
jackhou authored
Test coverage is provided by native_app_window_cocoa_browsertest.mm which now uses whichever implementation of NativeAppWindow is instantiated. Added a new sources list to minimize having to change BUILD.gn when more files are added. BUG=459877 Review URL: https://codereview.chromium.org/975043003 Cr-Commit-Position: refs/heads/master@{#319153}
-
ppi authored
This patch uses the unified JNI_OnLoad mechanism introduced in http://crbug.com/447393 in mojo network service. BUG=447393 Review URL: https://codereview.chromium.org/977843003 Cr-Commit-Position: refs/heads/master@{#319152}
-
jamiewalch authored
BUG=464020 Review URL: https://codereview.chromium.org/968193006 Cr-Commit-Position: refs/heads/master@{#319151}
-
lfg authored
Review URL: https://codereview.chromium.org/921793004 Cr-Commit-Position: refs/heads/master@{#319150}
-
tommi authored
WebRTC 8573:8602 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c9dfd1c..f30d5ec Libjingle 8571:8600 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3b22f07..8fe2b96 TBR=sergeyu@chromium.org,magjed@chromium.org Review URL: https://codereview.chromium.org/970513005 Cr-Commit-Position: refs/heads/master@{#319149}
-
dnicoara authored
ui::OzoneGpuTestHelper needs to be uninstantiated in TearDown() since it creates a base::Thread which wants to register with the AtExitManager. However the AtExitManager runs out of scope before the testing::Environment. BUG=447798 TEST=compile and run ./video_decode_accelerator_unittest (I had https://codereview.chromium.org/938873002/ applied as well to make sure tests succeed) Review URL: https://codereview.chromium.org/949183004 Cr-Commit-Position: refs/heads/master@{#319148}
-
michaelbai authored
content_app_browser and content_app_child are designed to be used for Windows DLL, for android we build browser and child process in same shared library, content_app_both should be used in Android. BUG=464008 TBR=jochen Review URL: https://codereview.chromium.org/970413002 Cr-Commit-Position: refs/heads/master@{#319147}
-
weiliangc authored
Take |draw_rect|'s coordinates and |BitmapData|'s point into consideration in |FakeContentClientLayerClient| paint into DisplayList. R=ajuma BUG= Review URL: https://codereview.chromium.org/984443002 Cr-Commit-Position: refs/heads/master@{#319146}
-
jrummell authored
WebMediaKeySystemConfiguration is changing to use enums for initDataTypes and sessionTypes, so update WebEncryptedMediaClientImpl to use the enums. BUG=418239 TEST=EME tests still pass Review URL: https://codereview.chromium.org/979463002 Cr-Commit-Position: refs/heads/master@{#319145}
-
limasdf authored
R=kalman@chromium.org BUG=354046 TEST=extensions_unittests Review URL: https://codereview.chromium.org/977763002 Cr-Commit-Position: refs/heads/master@{#319144}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/970943003 Cr-Commit-Position: refs/heads/master@{#319143}
-