- 01 Nov, 2017 40 commits
-
-
David Jacobo authored
Removing IsSwapElementsNeeded since this functionality is no longer needed, also removing the test for this. Bug: 678141 Test: Build. Change-Id: I86c34578d39ec75b2c79a0151cc04ef8366a31e0 Reviewed-on: https://chromium-review.googlesource.com/748709Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#513247}
-
Sammie Quon authored
Fixes a regression which i am not sure when it came up. Adds a test to device_page_tests. Test: browser_tests CrSettingsDevicePageTest.StylusTest Bug: 779243 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia658c07b90a816f0bb8ba0051068376f96466ea9 Reviewed-on: https://chromium-review.googlesource.com/742457Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#513246}
-
Eric Karl authored
With the addition of the TransferCache, we need a way to pass support objects in to the Deserialize function. This adds an empty DeserializeOptions struct to Deserialize. The transfer cache will be added to this struct in a future CL. Bug: 777622 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibf75721d0dd45987335204c9a0a4d91713f2ae99 Reviewed-on: https://chromium-review.googlesource.com/749442Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#513245}
-
Lei Tian authored
The crashe is because TabPersistentStore.mergeState() kicks off an AsyncTask to restoreTabs and restoreTabs creates a Handler in LayoutManager.onTabStateInitialized(). But the Handler is not created in UI thread whose Looper is not created. Bug: 778447 Change-Id: Ibad4993471c461c0df61903025211488f4e50328 Reviewed-on: https://chromium-review.googlesource.com/746025 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513244}
-
Xianzhu Wang authored
It tests invalidation when visibility changes from hidden to visible, and expects invalidation of the changed object. However, the object previously used an invalid color value causing it was never visible. SPv175 is smart to skip raster invalidations for objects painting nothing. Fix the test to let SPv1 and SPv175 produce the same result. Bug: 771643 Change-Id: I09729ac33b993c98b908bc8ec35a288205af04b3 Reviewed-on: https://chromium-review.googlesource.com/749042 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513243}
-
Peter Collingbourne authored
If I send a second upload tryjob with the same revision/subrevision as a previous job, it means that I have changed the script and I want to rebuild that revision/subrevision with my changes, so the correct thing to do is to rebuild. Bug: Change-Id: I1d1822ec695aecc92df25d24d09c3becc506eb4d Reviewed-on: https://chromium-review.googlesource.com/747623Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513242}
-
chrome://net-internals/#eventsEric Roman authored
It used to be that you could select whether to strip cookies and auth headers for export, with the default being to strip. The ability to export was since removed, which also lost the option to disable stripping. This change removes stripping all together. (With stripping removed from net-internals#events, users can inadvertently expose data when copy-pasting visualizations of the net log, however this is considered out of scope.) Ultimately this won't matter as net-internals#events is slated for eventual removal (crbug.com/678391). Bug: 777473 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7833e3c1f15feab8acf8609a82cbc9e2f2dae422 Reviewed-on: https://chromium-review.googlesource.com/747864Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513241}
-
Eugene But authored
Ignoring the result of WaitUntilConditionOrTimeout call is incorrect in many cases. So WaitUntilConditionOrTimeout will have WARN_UNUSED_RESULT annotation to force callers to do the checks. This CL prepares ios/web for WaitUntilConditionOrTimeout changes. Bug: 780062 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide53b4613df407149c43cdfa68751be171db313f Reviewed-on: https://chromium-review.googlesource.com/746995Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513240}
-
Johann authored
R=tomfinegan@chromium.org Change-Id: Ib12dc27749f3fee141c2367773effcd58a390530 Reviewed-on: https://chromium-review.googlesource.com/746026Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#513239}
-
Navid Zolghadr authored
Before this CL we had two different paths for creating pointercancels. One for mouse pointercancels and one for touch/pen cancels. This LC refactor the code for these two paths. Bug: 778351 Change-Id: Ie498c5afb2e3aee7938e51db33ea8de7cb7323dc Reviewed-on: https://chromium-review.googlesource.com/740144Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513238}
-
Emil A Eklund authored
Add a new performance test for line breaking using ShapingLineBreaker to allow us to catch/detect performance regressions and track progressions. Test: Source/platform/testing/ShapingLineBreakerPerfTest.cpp Change-Id: If95c2d3b3f2279219f3d883f0015a3d1de5eaa2a Reviewed-on: https://chromium-review.googlesource.com/729560 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#513237}
-
Peter Collingbourne authored
The bot no longer exists by this name, and there's a fuchsia bot on the regular CQ now anyway. Bug: Change-Id: I4187b9de545ae36acccc38f719e9718136c1e353 Reviewed-on: https://chromium-review.googlesource.com/749622Reviewed-by:
-
Robert Liao authored
This change initializes the Windows Runtime as an MTA for versions at or above Windows 8 and COM as an MTA for versions below Windows 8 if the caller requests for COM MTA. BUG=706479 Change-Id: I55e08bb270ac9d1ebbce35647e8ae23ec8504f95 Reviewed-on: https://chromium-review.googlesource.com/741455 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#513235}
-
Cathy Li authored
Data urls are disabled from top-level navigations as of Chrome 60. This will display the JSON in a floating textarea instead. Bug: 775599 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6a66eaf19f005cbf75640db146ea4ca4acf26277 Reviewed-on: https://chromium-review.googlesource.com/724236 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#513234}
-
Ian Vollick authored
With this change, the voice search button is disabled via binding when we are in incognito mode. Additionally, we store a bit on the model for when we've got experimental VR features enabled so that it may more easily be bound and toggled in tests. This also means that the ui scene manager no longer needs to retain a pointer to the voice search button. Further, we no longer add the button to control_elements_ since it will inherit the visibility of the URL bar due to being in its subtree. Bug: 779592 Change-Id: I92832f46b4cdf33e7a9caf57076001a24ff9ab83 Reviewed-on: https://chromium-review.googlesource.com/748774 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#513233}
-
Andrew Grieve authored
Problem is the same, but didn't get the sort key exactly right. This also adds a test for idempotency (but our test data is too trivial to catch this bug). Bug: 779895 Change-Id: I3021ec2cf222c27b51cfaba1b90bd3b7ed1f912f Reviewed-on: https://chromium-review.googlesource.com/748809 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#513232}
-
Charles Harrison authored
Now that RenderFrameHostTesters keep track of these messages, it makes writing unit tests pretty easy. Bug: 661629 Change-Id: I3ddd13d7d9a83a90dba70dc6807073bf3d4b2b46 Reviewed-on: https://chromium-review.googlesource.com/749319Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#513231}
-
Peter Kotwicz authored
This CL adds a metric which records an approximation of how old the "pending update request" file is. The purpose of the metric is to assess how often Chrome is killed by the OS during an update. Bug=713655 Change-Id: I4f6177ec1be6ddb3e6321f9a79588cb8a36c6ec2 Reviewed-on: https://chromium-review.googlesource.com/671149 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513230}
-
Peter Kotwicz authored
This CL fixes a potential buffer overflow in InputScalesValid() BUG=778251 Change-Id: Iec1dfa3a7758e94cbcdf50006540334fefba451f Reviewed-on: https://chromium-review.googlesource.com/747323Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513229}
-
John Z Wu authored
Bug: 763797 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ba29392c1b16a64cadf4792cdb7b2a947ee04eb Reviewed-on: https://chromium-review.googlesource.com/744429 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#513228}
-
Lei Zhang authored
Replace it with GetNetworkInterfaceList() which more accurately describe what it does. Use base::PostTaskWithTraitsAndReplyWithResult() so it does not need to know how to reply. Change-Id: Ibc9f9cdec03cbc602903fc2342c9629ba79aa42d Reviewed-on: https://chromium-review.googlesource.com/740945Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#513227}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c4a14324e29c..6063e98dcb50 $ git log c4a14324e..6063e98dc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iafa5eda012a2d487e913abbe356420ed0d073546 Reviewed-on: https://chromium-review.googlesource.com/749252Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513226}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/206bda5b7931..d29e0da3523e $ git log 206bda5b7..d29e0da35 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 csmartdalton Fold analytic clip FPs into GrReducedClip 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 63458a3ed..4751aabb7 (3 commits) 2017-11-01 bungeman Directly use SkScalerContextRec. 2017-11-01 fmalita Gradient cleanup pass 2017-11-01 brianosman Add testcase for gbr config running on GTX1070 bots to test.py 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 206a58d1f..63458a3ed (1 commit) 2017-11-01 csmartdalton Revert "Fold analytic clip FPs into GrReducedClip" 2017-10-31 csmartdalton Fold analytic clip FPs into GrReducedClip 2017-11-01 brianosman Test SkColorSpaceXformCanvas on GTX1070 bots 2017-11-01 mtklein consolidate SkSRGB functions, and remove unused Created with: roll-dep src/third_party/skia BUG=774807,779346 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I4acba3e45376fc7007bd455124260045960e9aa3 Reviewed-on: https://chromium-review.googlesource.com/749046Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513225}
-
Eugene But authored
This function will be used in New Download API and can also be used for SystemCookieStore creation. TBR=michaeldo@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f85c59a6e759f226b01937e598db866273f1838 Reviewed-on: https://chromium-review.googlesource.com/744325Reviewed-by:
-
Benjamin Pastene authored
It's the same thing as linux_android_rel_ng without the tests. Note that there's no test-less mirror of android_n5x_swarming_rel, which is also on the CQ. Need to remove it here before updating buildbucket.config TBR=phajdan.jr@chromium.org Bug: 773872 Change-Id: I7a04f92f19752ab3f31cd2203249f485fe678c94 Reviewed-on: https://chromium-review.googlesource.com/748216 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513223}
-
MinChen authored
Changes: 1. Update the optional divider ratios (0.33f, 0.67f) according to the minimum size of the snapped windows. 2. Show the black scrim when the divider passes over the window's minimum size. Test: SplitViewControllerTest.DividerPositionWithWindowMinimumSizeTest Bug: 775227 Change-Id: Ia7ca6b42639a2e8963d5bfb95eb449e520f048fa Reviewed-on: https://chromium-review.googlesource.com/735980 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#513222}
-
Xianzhu Wang authored
When the scrolling contents layer is resized and it paints the background, we should invalidate the expanded/shrunk part of the background. For SPv1 this is done by calling IncrementallyInvalidatePaint. For SPv175 we need to pass kIncremental reason to PaintController. Bug: 732611 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I501ed3e899282b31f4f9d461e23637ab1ca4460d Reviewed-on: https://chromium-review.googlesource.com/749283Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513221}
-
Daniel Park authored
Moves command like check to the top Bug: 780324 Change-Id: Ia3cfa831d4c642d5cb22e28701ec6fb9ca1f05b9 Reviewed-on: https://chromium-review.googlesource.com/748206Reviewed-by:
-
Charles Harrison authored
This class was used to mock out console log requests flowing through RenderFrameHost. Now all unit tests can get the same functionality from TestRenderFrameHost/RenderFrameHostTester, without injecting a mock. Bug: None Change-Id: I76a2603e48c9e7afd97a9b85da12ae2d4fe5714f Reviewed-on: https://chromium-review.googlesource.com/748770 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Francois Doray authored
LayerAnimator::AddObserver registers an observer to observe all LayerAnimationSequences scheduled by a LayerAnimator in the future. This makes it hard to figure which LayerAnimationSequences the observer will observe when reading code. With this CL, we use LayerAnimationSettings::AddObserver instead of LayerAnimator::AddObserver in ui/keyboard/. LayerAnimationSettings::AddObserver registers an observer to observe only the LayerAnimationSequences scheduled within the scope of the LayerAnimationSettings. Bug: 738387 Change-Id: I2db9b7d73828d3bcc57d4a5992b1d8055d5a2107 Reviewed-on: https://chromium-review.googlesource.com/749304Reviewed-by:
-
Mark Mentovai authored
b88fde0b5647 Add the AnnotationSnapshot object and attach it to ModuleSnapshot 38c8f51ae88b Add MinidumpByteArray extension and its Writer e4723d524f19 Expand the MachOImageAnnotationsReader to read Annotation objects 9609b7471676 Expand the PEImageAnnotationsReader to read Annotation objects 7e82179d43a4 Move filesystem test utilities to test/ 8db7e7dc3912 test: Don’t hide --gtest_* arguments from Chromium’s test runner 81eced5192d9 snapshot: Specify test dependencies properly a0f4f294b1e2 win handler: Provide a wmain() entry point a51e912004a6 Fix warnings produced by trunk clang in test code af594c8deb08 Heap-allocate MinidumpContextAMD64Writer objects with proper alignment 1669ca2bac66 test: Rework TestPaths interface for obtaining 32-bit build artifacts c542a5ae0371 net: Remove extra spaces from WinHttp log messages 43b798b492a2 test: Fix paths for crashpad_tests monolith in Chromium 4f5524fc684c Fix Windows build after 81eced5192d9 6950a552bfab doc: Fix Doxygen-generated documentation after 34699d378b82 Change-Id: I6361f8a454e1539399fa260165f4385ed209a2de Reviewed-on: https://chromium-review.googlesource.com/748815Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#513217}
-
Marijn Kruisselbrink authored
Since BlobStorageContext and BlobRegistryImpl are owned by different classes it is possible for BlobRegistryImpl to outlive BlobStorageContext. So rather than keeping a raw pointer to the context, change that to a weak pointer, and guard every access to it with a null check. Bug: 779495 Change-Id: Ie35bc4135c4839cfd4c3e3836f83669349e7401a Reviewed-on: https://chromium-review.googlesource.com/748912 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#513216}
-
Elly Fong-Jones authored
In locales with significantly longer strings, the checkbox labels can require wrapping, which may require moving all the controls below them downward and growing the window vertically. This change: 1) Adds support for the resizing and reflowing mentioned above; 2) Adds a new command-line flag "--force-unofficial-first-run", which causes the First Run flow to happen even on non-branded builds. Bug: 776683 Change-Id: I51952a79340248ccf3ea223538a679edaa4678e6 Reviewed-on: https://chromium-review.googlesource.com/749315Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513215}
-
Jialiu Lin authored
Clear URL fragment before recording navigation events and before matching event url or webcontents url against navigation events. Bug: 776587 Change-Id: I91ee7b9365dd365a5971b64fee55f4df7d395936 Reviewed-on: https://chromium-review.googlesource.com/745318Reviewed-by:
Robert Shield <robertshield@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#513214}
-
Jonathan Metzman authored
https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git/+log/52af4b0f6f55..3fc43a01d721 $ git log 52af4b0f6..3fc43a01d --date=short --no-merges --format='%ad %ae %s' 2017-10-26 vitalybuka Update with UTF-8 details 2017-10-16 vitalybuka Return LIB_PROTO_MUTATOR_FUZZER_LIBRARIES as it's used by OSS-fuzz 2017-10-16 vitalybuka Remove reference to LIB_PROTO_MUTATOR_FUZZER_LIBRARIES and set -fsanitize-coverage=0 2017-10-16 vitalybuka Switch to clang 6.0 2017-10-16 vitalybuka Switch to -fsanitize=fuzzer 2017-09-28 vitalybuka Improve protection against stack overflow 2017-09-13 vitalybuka Fix endif() in cmake file 2017-09-13 vitalybuka Update CMakeLists.txt Created with: roll-dep src/third_party/libprotobuf-mutator/src Bug: 780535 Change-Id: I0306a463efa4527eb40a45e9faf3269cc8fe1d19 Reviewed-on: https://chromium-review.googlesource.com/749106 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#513213}
-
John Z Wu authored
This allows more flexibility when including header files that contain objc references. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3bf28ef2c367348906fe7be8481aa348480720a0 Reviewed-on: https://chromium-review.googlesource.com/747093 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513212}
-
Xiaohui Chen authored
BUG=None TEST=locally build and see animation running as before. Change-Id: I1eb62490108beaaec0795adb4251054c03b364e1 Reviewed-on: https://chromium-review.googlesource.com/748273 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513211}
-
Fabio Tirelo authored
Bug: Change-Id: I76e57841c0cb570aca8953137f9543642a61fc4e Reviewed-on: https://chromium-review.googlesource.com/748780Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#513210}
-
Helen Li authored
This CL modifies content/network/OWNERS file to add one additional owner and remove an existing one. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3bf8464cbfe9026801b7cf30d0076e87084ccc30 Reviewed-on: https://chromium-review.googlesource.com/749525Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#513209}
-
Xiaohui Chen authored
When assistant is started and triggered hiding animation, during a very short time window if the user lifted their finger, we would try to play end animation. We should avoid doing that. BUG=b:67496461 TEST=build and flash locally, see animation playing normally Change-Id: Idf52f692edd9d05b16ad48687384d291b208a42e Reviewed-on: https://chromium-review.googlesource.com/748268Reviewed-by:
-
