GitLab

It was being used to allowed passing ownership of an error handler, but passing
a weak handle works just as well.

BUG=511235

Review URL: https://codereview.chromium.org/1275743002

Cr-Commit-Position: refs/heads/master@{#342384}

base::Version constructor already takes a std::string, so no need to
pass in result of c_str() which would just create a second std::string.

Review URL: https://codereview.chromium.org/1280673002

Cr-Commit-Position: refs/heads/master@{#342383}

Requires: //components/policy:policy_component_browser

BUG=507294

Review URL: https://codereview.chromium.org/1268443004

Cr-Commit-Position: refs/heads/master@{#342382}

This reverts the following:

  commit 5cb0c01e
  Author: oshima <oshima@chromium.org>
  Date:   Fri May 15 15:16:07 2015 -0700

      Compute the base dpi from X

  commit 42de8ba1
  Author: oshima <oshima@chromium.org>
  Date:   Wed Jul 22 15:17:49 2015 -0700

      Use org.gnome.desktop.interface text-scaling-factor directly

R=oshima@chromium.org, stapelberg@google.com
BUG=485183

Review URL: https://codereview.chromium.org/1276553007

Cr-Commit-Position: refs/heads/master@{#342381}

"units" should be "enum"

BUG=none
TEST=none
R=rouslan@chromium.org

Review URL: https://codereview.chromium.org/1274893004

Cr-Commit-Position: refs/heads/master@{#342380}

BUG=508935

Review URL: https://codereview.chromium.org/1280443003

Cr-Commit-Position: refs/heads/master@{#342379}

BUG=513399
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1275103003 .

Cr-Commit-Position: refs/heads/master@{#342378}

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
R=nick@chromium.org
BUG=470994
TEST=

Review URL: https://codereview.chromium.org/1254103002

Cr-Commit-Position: refs/heads/master@{#342377}

This histogram shows that the measured event is generally quite fast, and any
future slowness should be identified with a profiler, rather than by remembering
to check the histogram.

BUG=517206
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1275093002

Cr-Commit-Position: refs/heads/master@{#342376}

The keyboard layout ABC - AZERTY was added in 10.11, which maps 'm' to the
same keycode as the Belgian, Italian, and French layouts. Add this case.

BUG=none
TEST=NSMenuItemAdditionsTest.TestMOnDifferentLayouts

Review URL: https://codereview.chromium.org/1282543002

Cr-Commit-Position: refs/heads/master@{#342375}

This is the first step towards unifying client side and service side ServicePort
instances, but also removes a layer of abstraction in how connections to
services are setup. The abstraction layer will probably later be reintroduced
differently.

BUG=426458

Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20
Cr-Commit-Position: refs/heads/master@{#341987}

Review URL: https://codereview.chromium.org/1224263007

Cr-Commit-Position: refs/heads/master@{#342374}

Add WebRTC.Video.AverageRoundTripTimeInMilliseconds histogram for measuring round-trip time in WebRTC calls.

BUG=507314

Review URL: https://codereview.chromium.org/1280933002

Cr-Commit-Position: refs/heads/master@{#342373}

This CL has a moderate chance of breaking the CFI buildbot:
while I don't observe any CFI failures, browser_tests and
interactive_ui_tests are extremely flaky on my machine,
so I could miss some.

Should the buildbot be broken, I will quickly remove the
failing tests.

BUG=chromium:457523

Review URL: https://codereview.chromium.org/1272563003

Cr-Commit-Position: refs/heads/master@{#342372}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f6ae725..494accf

TBR=hiroshige@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/1278153003

Cr-Commit-Position: refs/heads/master@{#342371}

* CMA backend interfaces moved into chromecast/public/media
* CMA backend implementation loaded from libcast_media through
  CastMediaShlib
* Backend API changes to remove dependency on Chromium types:
  * DecryptContext replaced with CastKeySystem
  * scoped_refptr replaced with raw pointers
  * In particular, DecoderBufferBase replaced in the backend API
    with non-refcounted DecoderBuffer.  In order to allow us to keep
    using refcounting and in particular use DecoderBufferBase in the
    rest of our pipeline, it gets wrapped in a DecoderBufferImpl
    (implementation of DecoderBuffer) for passing to the backend. So
    backends must delete the buffer pointer they're given but this is
    actually just decrementing the refcount on the underlying buffer.
  * base::Callback replaced with abstract interfaces
  * base::TimeDelta replaced with chromecast::TimeDelta in backend
    interface, essentially a stripped-down copy
  * NonThreadSafe removed (implementations can use ThreadChecker)
* TaskRunner interface provides PostTask/PostDelayedTask service to
  backend implementations
* Backend ownership / factory model changed.  Now, backend
  implementations return a MediaPipelineBackend which manages ownership
  and hookup of all the components.  It returns access to them as raw
  pointers.  The pipeline manages the lifetime of the MediaPipelineBackend
  instance.
* GetIsCodecSupportedOnChromecast refactored to remove calls back into
  cast_shell from backends (implementation can just return 'default' to
  indicate default logic should apply, including HDMI capabilities.

BUG=508534

Review URL: https://codereview.chromium.org/1257013003

Cr-Commit-Position: refs/heads/master@{#342370}

Reland of Add channel-specific product logo to chrome://help (patchset #1 id:1 of https://codereview.chromium.org/1280033002/ )

Reason for revert:
Official build bots were all happy with the change --- suspect the issue was a local config problem (such as not updating src-internal).

Original issue's description:
> Revert of Add channel-specific product logo to chrome://help (patchset #3 id:40001 of https://codereview.chromium.org/1269383005/ )
>
> Reason for revert:
> Reverting due to missing files.  See comments in cl:
> https://codereview.chromium.org/1269383005/
>
> Original issue's description:
> > Add channel-specific product logo to chrome://help
> >
> > BUG=511000
> >
> > Committed: https://crrev.com/9836302ea4ffb887ce6ffa597c1ee5484d2f1091
> > Cr-Commit-Position: refs/heads/master@{#342183}
>
> TBR=oshima@chromium.org,dbeam@chromium.org,estade@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=511000
>
> Committed: https://crrev.com/abd20f67987aaa47bb47e61288ec92b4ab761521
> Cr-Commit-Position: refs/heads/master@{#342324}

TBR=oshima@chromium.org,dbeam@chromium.org,tommi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511000

Review URL: https://codereview.chromium.org/1279093002

Cr-Commit-Position: refs/heads/master@{#342369}

Implements storing of per-frame selection offsets in the accessibility tree and adds Windows specific code for reporting these offsets across embedded objects according to the IA2 Spec.
BUG=491027
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1195223006

Cr-Commit-Position: refs/heads/master@{#342368}

While trying to hook up new strings from crrev.com/1270793002 into TC,
I have realized that some changes need to be made to their definitions.

1. In Chrome, html fragments (grit 'structures') are not used. Instead, they
   just put into .grd files as regular messages, with markup being isolated
   inside fake placeholders to avoid the translators messing with it.
   (and grit also requires non-empty 'example' tags to present for them).
   Thus, removed 'structure.html' and put its contents into a scary-looking
   message.

2. .grd files containing messages must not include anything, as only .grd
   files themselves are copied into the internal tree for processing.
   Thus, split the messages into a separate .grd file with no includes.

3. From the strings .grd, per-locale .pak files must be produced, and then
   all those xxx_strings_xx.pak files repacked into a single xx.pak file.
   As WebView already uses content_strings, changed the script to pack
   content_strings together with the new strings, and renamed the script
   accordingly.

4. As I would not like to repeat this process again would we need some
   native strings on the browser part, and as we share native resources
   between the browser and the renderer, moved the .grd files out from
   'renderer' into a new 'ui' subdir.

BUG=515691

Review URL: https://codereview.chromium.org/1273263002

Cr-Commit-Position: refs/heads/master@{#342367}

Revert of GC plugin: consider references equal to raw pointers. (patchset #2 id:20001 of https://codereview.chromium.org/1274403002/ )

Reason for revert:
Turned the clang/win tot bots red: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2327/steps/compile/logs/stdio

..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(13,1) :  error: [blink-gc] Class 'CSSSupportsParser' contains invalid fields.
class CSSSupportsParser {
^
..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(31,5) :  note: [blink-gc] Stack-allocated field 'm_parser' declared here:
    CSSParserImpl& m_parser;
    ^

Original issue's description:
> GC plugin: consider references equal to raw pointers.
>
> Unmanaged raw pointers to managed(GC) classes aren't safe across GCs,
> hence fields with raw pointer types to such GCed classes are identified
> and reported as errors or warnings.
>
> Extend that checking to also apply to reference pointer types.
>
> R=haraken
> BUG=420515
>
> Committed: https://crrev.com/70fe23896f81cd66ba1a205b0336f91c64e3fa4e
> Cr-Commit-Position: refs/heads/master@{#342320}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420515

Review URL: https://codereview.chromium.org/1275383002

Cr-Commit-Position: refs/heads/master@{#342366}

This allows an MITM to make the firs byte of a valid HTTP/1.x response
look like a valid HTTP/0.9 reponses, so best to be safe.

BUG=517106

Review URL: https://codereview.chromium.org/1276943003

Cr-Commit-Position: refs/heads/master@{#342365}

This CL add a device management request to send GCM id after registration to
the server, so that server can maintain a mapping between GCM id and DM token.

BUG=517466

Review URL: https://codereview.chromium.org/1258313002

Cr-Commit-Position: refs/heads/master@{#342364}

The "AndroidSessionNotifications" experiment disables session invalidations
because session sync invalidations represent the bulk of the invalidation
traffic. Session invalidations cause the client to fetch the updated
"Recent Tabs" from the sync server.

This CL enables session sync invalidations only after the user has had the
RecentTabsPage open for a while. This enables the Android RecentTabsPage to be
"live": If a user opens a tab on a device which is signed in to the same profile
as the Android device, the RecentTabsPage on the Android device is updated with
the new tab. The CL disables session sync when the RecentTabsPage is closed
because the invalidations are not longer useful at that time.

BUG=477054
TEST=InvalidationControllerTest.*

Review URL: https://codereview.chromium.org/1263773007

Cr-Commit-Position: refs/heads/master@{#342363}

This is the first patch towards adding support for browser-process quad hittesting. This will be used for out of process iframes as a way to determine which process should receive input events.

BUG=491334
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1265013003

Cr-Commit-Position: refs/heads/master@{#342362}

Inadvertently removed lines from ios_chrome.gyp due to a bad rebase.

Review URL: https://codereview.chromium.org/1274213004

Cr-Commit-Position: refs/heads/master@{#342361}

If we have credentials with the empty username and the user uses them for sign-in with non-empty username then delete no-username credentials. These no-username credentials most probably were stored on change password or reset forms, and we don't need them anymore.

BUG=359315

Review URL: https://codereview.chromium.org/1272613002

Cr-Commit-Position: refs/heads/master@{#342360}

This CL implements Cache.matchAll(). When an optional request is omitted,
CacheStorageCache iterates all responses in this cache and returns them. When
the optional request is given, the backend runs an existing implementation
for Cache.match().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-matchall

(1) Blink: https://codereview.chromium.org/1268463003/
(2) Chromium: THIS PATCH
(3) Blink: https://codereview.chromium.org/1262773003/

BUG=428363

Review URL: https://codereview.chromium.org/1248003004

Cr-Commit-Position: refs/heads/master@{#342359}

Spec: https://github.com/whatwg/notifications/pull/48

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/6tlbJW0NjEA/LF0kPfJx7c0J

Part of a sequence of patches:
- https://codereview.chromium.org/1254423011 (blink)
- https://codereview.chromium.org/1263043002 (blink)
- https://codereview.chromium.org/1263043003 (blink)
- https://codereview.chromium.org/1268813007 (blink)
- https://codereview.chromium.org/1267673003 (chromium)
- https://codereview.chromium.org/1262893005 (blink)
- https://codereview.chromium.org/1269923003 (chromium)
- this patch (chromium)
- https://codereview.chromium.org/1264403002 (blink)

BUG=513671
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1262893006

Cr-Commit-Position: refs/heads/master@{#342358}

Not really a security issue, but just doesn't seem like a good idea.

BUG=468037

Review URL: https://codereview.chromium.org/1276843006

Cr-Commit-Position: refs/heads/master@{#342357}

//third_party/WebKit is not supported on iOS, so put the deps
behind a is_ios check.

BUG=None

Review URL: https://codereview.chromium.org/1277183002

Cr-Commit-Position: refs/heads/master@{#342356}

This histograms tracks the sum of CPU memory allocations of Buffer11
copies in order to measure the impact of copy pruning methods.

BUG=angleproject:516

Review URL: https://codereview.chromium.org/1280743003

Cr-Commit-Position: refs/heads/master@{#342355}

BUG=506498

Review URL: https://codereview.chromium.org/1276233002

Cr-Commit-Position: refs/heads/master@{#342354}

Disable InstantExtendedTest.OmniboxMarginSetForSearchURLs on Linux Asan due to flaky crashes at shutdown

BUG=517886
TBR=pkasting@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1282483002

Cr-Commit-Position: refs/heads/master@{#342353}

BUG=517806
TBR=sullivan
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Review URL: https://codereview.chromium.org/1271203004

Cr-Commit-Position: refs/heads/master@{#342352}

This change makes it possible to provide a Service derived from
CustomTabsConnectionService and make some fields and methods protected
in CustomTabsConnection.

BUG=504479

Review URL: https://codereview.chromium.org/1261893002

Cr-Commit-Position: refs/heads/master@{#342351}

UDP TURN servers are already used as STUN servers at the PortAllocator
level, so we don't need to do anything any longer at the
PeerConnectionDependencyFactory level.

BUG=webrtc:4215

Review URL: https://codereview.chromium.org/1273213004

Cr-Commit-Position: refs/heads/master@{#342350}

Disable FLAGS_quic_require_handshake_confirmation for ZeroRTT test.

relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable
QUIC 0-rtt

Adding a reloadable flag to allow quickly disabling QUIC's 0-rtt
handshake as an interim measure (0-rtt DoS protection) to allow
StrikeServer turndown before full DoSServer integration.  See b/20122788

Merge internal change: 99600488
https://codereview.chromium.org/1272153006/

relnote: Deprecate FLAGS_quic_send_fec_packet_only_on_fec_alarm.

Merge internal change: 99599597
https://codereview.chromium.org/1279433004/

relnote: Limit the number of burst tokens in QUIC's pacing sender to the
min of 10 and the current CWND in packets.

Protected by FLAGS_quic_limit_pacing_burst.

Should decrease retransmit rate for low CWND flows.

Merge internal change: 99597412
https://codereview.chromium.org/1276983003/

Preparation for changing SpdyHeaderBlock to be ordered. This just reduces
the number of files in upcoming CL by 2. No behavior change as these are
currently entries into a map, and the key:value pairs haven't changed.
However after changing to ordered SpdyHeaderBlock, the pseudo-header
order of authority,path,scheme,method is what ends up getting written,
and thus I'm changing the order here in advance.

relnote: n/a (test only)

Merge internal change: 99394725
https://codereview.chromium.org/1281463002/

relnote:  Close QUIC connections due to too many open streams earlier in
processing.  No significant behavior change.  Flag-protected by enabled
FLAGS_exact_stream_id_delta.

Replace the "maximum delta in stream ID" test on a newly-created stream
with an exact test for the max number of open streams.  Change the error
in this case from QUIC_INVALID_STREAM_ID to QUIC_TOO_MANY_OPEN_STREAMS.

FIXED=22477228

Merge internal change: 99369742
https://codereview.chromium.org/1277753002/

relnote: Minor format changes to keep the code similar to internal source.

Merge internal change: 99250353
https://codereview.chromium.org/1274003002/

relnote: Change the QuicStreamSequencer to call OnDataAvailable instead
of OnFinRead when the fin is consumed.

Make ReliableQuicStream::OnFinRead() non-virtual and remove overrides in
subclasses.

Merge internal change: 99214926
https://codereview.chromium.org/1261273003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1277723003

Cr-Commit-Position: refs/heads/master@{#342349}

BUG=517871

Review URL: https://codereview.chromium.org/1276623003

Cr-Commit-Position: refs/heads/master@{#342348}

For AutofillFieldMetadata.

Review URL: https://codereview.chromium.org/1275073002

Cr-Commit-Position: refs/heads/master@{#342347}

Review URL: https://codereview.chromium.org/1279843003

Cr-Commit-Position: refs/heads/master@{#342346}

Review URL: https://codereview.chromium.org/1274513004

Cr-Commit-Position: refs/heads/master@{#342345}