- 16 Dec, 2020 40 commits
-
-
Nohemi Fernandez authored
Chrome will re-generate missing GAIA cookies when the user takes an explicit action that requires user sign-in. For example, if the user clicks on the "Sign in" button in google.com or "Your Data on Maps" in the iOS Maps app. Bug: 1157475 Change-Id: I8c6011959cd90c2ff5b651a831c9570baf559f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587066 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837610}
-
Yuki Shiino authored
Cleans up make_steps_of_ce_reactions after https://crrev.com/c/2586019 Change-Id: I1429f49bdedaad27b9aa1c9a2d49528dc2bb1a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592238Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#837609}
-
Illia Klimov authored
This CL adds AbusiveOriginNotificationPermissionRevocation study into fieldtrial_testing_config.json. Bug: 1159417 Change-Id: Id33d0876d7f6085d3a144a564d8564bc888a7743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595287Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837608}
-
Clark DuVall authored
ModuleUtil.initApplication() ends up calling SplitCompat.install() with the application context. We need to make sure the application context ClassLoader has been replaced by the chrome ClassLoader at this point, otherwise SplitCompat may not be able to load fake installed splits. This is a bit unfortunate since ModuleUtil.initApplication() is pretty expensive, and the chrome module will no longer be able to preload in parallel, but not sure if there's much that can be done about that. Bug: 1158024 Change-Id: Ie81f7b85100707ed1e8273f57553812918c08a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593518Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837607}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Idce96e9c4e774c1d75f86b5524863c34b3e062d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593851 Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837606}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vut0tWjt1yQoJk5vrwYDcHtYQKjr64przVZjYeqRU6EC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/174321021,b/175249082 Tbr: help-app@grotations.appspotmail.com Change-Id: I965b3bc6157182764a7aced065cc2e5fb8aacc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595187Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837605}
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: Icdd4c45ab0ccfbffe0b4800079f983b0a8229320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593123Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#837604}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/875334114827..cfb206c8b386 $ git log 875334114..cfb206c8b --date=short --no-merges --format='%ad %ae %s' 2020-12-15 ianswett Change the return value of CheckBandwidthGrowth to an enum from a bool. No functional change. 2020-12-15 wub Change TlsServerHandshaker::SetTransportParameters to return a SetTransportParametersResult instead of a boolean. 2020-12-15 ianswett gfe-relnote: Change QUIC BBRv2 to reduce bandwidth_lo when the BBQ6, BBQ7, BBQ8, and BBQ9 connection options are present. 2020-12-15 renjietang Allow QUIC applications to access path validation context and explicitly cancel path validation. 2020-12-15 dschinazi Move enforcement of single RETRY from QuicConnection to QuicFramer 2020-12-15 bnc Internal QUICHE change 2020-12-15 dschinazi Make QUIC interop runner print version 2020-12-15 bnc Internal QUICHE change 2020-12-15 bnc Add PRIORITY_UPDATE frame and implement serialization. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=vasilvv@chromium.org Change-Id: Ia9ef8effb9d5d29f7dc58e52c9742fa78055198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595014 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#837603}
-
Bruce Dawson authored
Window creation is failing occasionally for some users for no clear reason. There appear to be guarantees that the atom parameter is valid but it seems worth getting the data into crash dumps just in case it reveals anything. Bug: 1158704 Change-Id: Ia9ad80d9b3af90298cd7ee1f139362d953362261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593595Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837602}
-
David Schinazi authored
Change-Id: I7533673833cae9e9356fd9b0589d8a8f9b2da0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593388 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837601}
-
David Bokan authored
This CL converts BluetoothEventRouter's methods: - StartDiscoverySession - StopDiscoverySession - SetDiscoveryFilter from base::Closure to base::OnceClosure. The call stack never stores either the |callback| or |error_callback| and each is only ever called once; hence, it's safe to convert these to OnceClosure. BluetoothEventRouter::OnSetDiscoveryFilter is never referenced so is removed. Bug: 1152268 Change-Id: I9a38a87cd029c7009a9fab52b91efd98c9b91d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592187Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837600}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608087498-7951485823b3a2725f3c6d796de85103e94919f6.profdata to chrome-win32-master-1608097529-a53990c96ba4fe0e9c85a726eccdb7c47db8df34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I73612b59d495c07d36809238f5b395ba342ad6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837599}
-
Stephen Chenney authored
Bug: 841364 Change-Id: Ibacd58d44e208aa42e85d964c8344519de4e88f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594014 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837598}
-
Roman Aleksandrov authored
Move classes related to text styles inside the dialog. Use host-context to check the orientation so the minimum number of CSS vars are set outside of the object. Bug: 1151292 Change-Id: Ic372098d24dc4af123d5b6ee737b970d3959ae34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593631Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#837597}
-
David Bokan authored
The ConsistencyChecker callback is only ever invoked from DeclarativeRule::Create and never stored so this should be a OnceCallback. Bug: 1152268 Change-Id: I6148ce40bc0a04d25e5ab9c936fd8f83fa7e5b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593936Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837596}
-
David Bokan authored
The callback in ClearData is either called immediately or passed to other async code that does the same so this callback is only ever called once. Bug: 1152268 Change-Id: I11a0d565a11503955e1224c4e370437c6dba9a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593877Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837595}
-
David Bokan authored
ExecuteScript already takes a OnceCallback so this is a trivial change. Bug: 1152268 Change-Id: Ie077677c529ec9a2186aa9b5d97e1405b74f3440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593763Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/e07510293160..181d8baf8f01 2020-12-16 dsinclair@chromium.org Add helper for function creation. 2020-12-16 dsinclair@chromium.org Add helper to create StructMember nodes. 2020-12-16 dsinclair@chromium.org Rename Index and Member builder helpers. 2020-12-15 sarahmashay@google.com fix gcc error: changes meaning of Transform 2020-12-15 bclayton@google.com reader/spirv: Fix permissive GCC warning 2020-12-15 dneto@google.com spirv-writer: Exit gracefully when bad inst outside function 2020-12-15 dsinclair@chromium.org Add symbol to member name. 2020-12-15 bclayton@google.com ast: Make all non-semantic fields const 2020-12-15 bclayton@google.com Start cleaning up tests (5/N) 2020-12-15 bclayton@google.com Start cleaning up tests (4/N) 2020-12-15 bclayton@google.com ast::Builder: Remove zero-init Source constructors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Ic192628f25b759b48f5d8a3163b73db4d7fc1cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595210Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=poromov Bug: 1159423 Change-Id: I4172f2f1fa777d12e2d2f845a12b3eba41214f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595527Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837592}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a7bb5a5b74f5..455dbfdd428f 2020-12-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e07510293160 to 8b40a67cf792 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I6471bbab26e20d940e1c0bb50cae78665b986665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595209Reviewed-by:
-
Hans-Filip Elo authored
The file idle_linux.cc contains some precompiler macro statements for non-X11 builds which assumes that the macro NOTREACHED from base/notreached.h is available. When not building with ozone or X11, this macro is not available. This CL adds an include for non X11 builds so that builds not using ozone or X11 succeeds. Change-Id: I1092e4eb8fcab7c326a6e48ca8890b990d6a652a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593116Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837590}
-
Hiroki Nakagawa authored
The mode is deterministically kPrefetchOnly. It's not necessary to propagate it. Bug: 755921 Change-Id: Ib297fba318436d78d72be3c1f2507bb86a372ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837589}
-
Nate Fischer authored
This updates the styleguide to recommend androidx.annotation.Nullable because android.support.* is generally deprecated. We've already migrated chromium to the AndroidX imports, so this just updates the styleguide to be in line with our current practices. This deletes the word "other" from the section header because this is the only reference I could find to Java annotations. Test: tools/md_browser/md_browser.py styleguide/java/java.md Test: Upload to gerrit > open file > click "gitiles" Change-Id: I84a78e3396fc05eeabda1114aab1658593a9be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593182 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Robbie Gibson authored
crrev.com/c/2136232 added the ability to block the web content area when an HTTP auth dialog from a different host is displayed. However, in this case, the tools menu site info item is still enabled and shows the incorrect url. This disables that info when the content area is blocked. Bug: 1157800 Change-Id: I0004c0ce608303e41e970f4389481ad31bcd050d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592998 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837587}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Change-Id: If5bf960d24f9b860647288759a411dfd687c3e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593852 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: -
Thiabaud Engelbrecht authored
This Cl is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2564938, which added metrics for ParkableImages. This CL fixed a typo ("Memory.ParkableImages.TotalSize" -> "Memory.ParkableImage.TotalSize") which was preventing collection of metrics. Bug: 1154295 Change-Id: Iaa3b5cce518b761c87fc2cea719d31ab7e2a7a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589027Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#837585}
-
Corentin Wallez authored
TBR=ynovikov@chromium.org Bug: chromium:1159394 Change-Id: Ibbf7a20405d38ad3ca3dd2d6586dffbce0629889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593105Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837584}
-
Nick Burris authored
* Make ExternalAuthUtils provide its own instance instead of callers having to use AppHooks. A follow up patch will remove the ExternalAuthUtils instance from AppHooks. * This is patch 3/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2587430 after adding the missing dependency to the android_sync_integration_tests target. Bug: 1154371, 1159404 Change-Id: I28a98e549dd139af9cfcb5f9a802e02839c3e0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593652Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#837583}
-
Yuta Hijikata authored
The change is mechanical replacing GN variable is_chromeos with is_chromeos_ash. (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ib66985f4e40f01ec17be99c7ad1545403b243dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594619 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Motivations: * Provides test coverage for the integration of Chrome and PRService. * The integration test for GooglePayPaymentApp & factory will be added based on the test supports of this CL. Summary: This CL adds an integration test for the integration of: - PaymentRequest - MojoPaymentRequestGateKeeper - PaymentRequestService - ChromePaymentRequestService ...excluding: - Ui (PaymentUiService) - App factories (e.g., Android, service-worker payment app factory) In order to rule out the low level details, CPRService delegates the following creators/static methods so that mocks can be injected: * PaymentUiService * ChromeActivity * AndroidPaymentAppFactory * PaymentAppServiceBridge * AutofillPaymentAppFactory * AutofillPaymentAppFactory.canMakePayments * PaymentRequestServiceUtil.isWebContentsActive * PaymentHandlerHost Bug: 1158522 Change-Id: Ica52f4858042dded01e328824ce4550dcff68901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566372Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837581}
-
Sean Gilhuly authored
This reverts commit 297828da. Reason for revert: Suspected cause of crbug.com/1159427 Bug: 1159427 Original change's description: > Roll ANGLE from c47b951ecbcb to f32fbb51e8a1 (4 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/c47b951ecbcb..f32fbb51e8a1 > > 2020-12-15 m.maiya@samsung.com Add EXT_shader_framebuffer_fetch_non_coherent entry points > 2020-12-15 m.maiya@samsung.com Vulkan: Add the tests for EXT_clip_cull_distance > 2020-12-15 timvp@google.com Vulkan: flushCommandsAndEndRenderPass during glFenceSync() > 2020-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c16dc7107fd3 to fa44979d90aa (5 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: cwallez@google.com > Change-Id: Ib3a7f645466a7bd9b9d3189dcfed4fb9ff763621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593591 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#837367} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Icb842f4f1d82cdd083eccfb46d7f5f10deca3b28 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595587Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#837580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85af6214. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I2fd61fb5c54ae2fed2d9c92c743a7b80fd2ca618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592146Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibf751a9e735f13a3e643e18dab2cf3f79331ff63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595011Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837578}
-
Benoit Lize authored
No need to use int, makes one of the tables fit in single cache line. Bug: 998048 Change-Id: I29d35e872f4e39c823bf787977defb6058a69866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593385Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837577}
-
Scott Violet authored
This reverts commit f770838a. Reason for revert: This is causing crashes. See https://bugs.chromium.org/p/chromium/issues/detail?id=1159386 . Original change's description: > Reland "Remove unneeded CursorLoaderWin::SetPlatformWindow calls" > > This is a reland of 1208732e > > Original change's description: > > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > > guarantees that the platform cursor has been set. > > > > Bug: 1097556 > > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#810120} > > Bug: 1097556 > Change-Id: I89b742a80ddd9fee7a77b5af1bee07b58c18f39b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445550 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#837132} TBR=sky@chromium.org,hferreiro@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4bec9fe875e8bfd6c97663e63a499bc4b27d390f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595510Reviewed-by:
-
Akihiro Ota authored
Modal dialogs are supposed to trap focus inside the context of the dialog. This change fixes an issue in OOBE where focus was incorrectly moved from a dialog to the login shelf when pressing tab enough times. Bug: 1157982 Change-Id: Ia426871d02dbf3e2f66aa1ca42d48c0f322e4c44 AX-Relnotes: Ensure dialogs in OOBE trap focus. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590371Reviewed-by:
-
Steven Bingler authored
With the constructor use of CanonicallCookie greatly reduced (with ongoing work to privatize the constructor) CookieMonster no longer needs to set the source scheme of a cookie. This change will fix a bug in which cookies set by DevTools always get ovewritten with a "Secure" scheme regardless which sourceScheme they entered the CookieMonster with. Bug: 1031721 Change-Id: I58d9a938755bc04b085f4a6b6279bd4898e1d1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590016Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837574}
-
Ioana Pandele authored
Bug: 1044930 Change-Id: Ia52660f3bab6dfe405fd0d77e6147d402a4196c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593001Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#837573}
-
Joon Ahn authored
prevent computed values from updating before initial values have been set. Bug: 1158524 Change-Id: I993fbd30730e9a64a8b584e6d5634674d048ee10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594236Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#837572}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/F2qSaG03RybV34PPKgVY50FpLeJhLL-u5pz5Gmi9s9AC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/168070817,b/173980515,b/174286210 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia0251d6f45a55f83bb56c917e4faada6e291e3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594097Reviewed-by:
-
