- 13 Nov, 2020 40 commits
-
-
Shakti Sahu authored
This CL fixes : 1 - Fixed layout styling for section header 2 - Added plumbing to mark an article as read 3 - Added fix to show the sign-in promo at the top of reading list 4 - Fixed search state to not show any read/unread section headers Bug: 1148472, 1148524 Change-Id: I6269b28bf7146acc684437446686c76c88006892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535616Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827135}
-
Josiah K authored
Bug: 1138781 Change-Id: Ibf8c9594777db2b6f0fd813ac9320962acf62734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535643Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#827134}
-
Clark DuVall authored
Assets were being kept in both the base module and DFM due to the recursive_resource_deps arg which pulls resources into the base module. This change excludes assets, preventing them from being duplicated in the base module. Bug: 1126301 Change-Id: I6dd110c86f5befb7271880fee0c5c2c94740a766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536750Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827133}
-
Kevin Marshall authored
Applies the fuchsia.web.AutoplayPolicy which may be passed in at Frame creation time to the Frame's top-level WebContents. Test: autoplay_browsertest.cc Bug: 1067101 Change-Id: Id3b69ddea474c9b8d6f2a1b05ec195270cad3cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533555 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827132}
-
David Trainor authored
This is a large patch moving all of the downloads home files to a module. Code in //chrome/android/java/src/.../download/home moved to //chrome/browser/download/internal/android/java/src/.../download/home. Resources were moved to the internal directory as well, except when they were used by other features, in which case they were moved to //components/browser_ui/styles. TBR=bjoyce@chromium.org, ajwong@chromium.org Bug: 1062116 Change-Id: Id4fd950dad81002c85b28be5a71181ecc5c3178d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230199 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827131}
-
Xing Liu authored
backend." Original change's description: > Read later: Add a method to notify update for reading list backend. > > Adds an observer method to notify update for reading list backend. OCL:https://chromium-review.googlesource.com/c/chromium/src/+/2519151 Revert:https://chromium-review.googlesource.com/c/chromium/src/+/2532074 Revert bug:1147311 Difference: None, the ASAN issue is fixed in the previous reland: https://chromium-review.googlesource.com/c/chromium/src/+/2532911 TBR=dtrainor@chromium.org Bug: 1139133 Change-Id: I4911f5e8d30fd0fb7f6e19116b7554f4e78b0a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535019Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827130}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/420f7362d68a..2a9b38f2dacd 2020-11-12 rohpavone@chromium.org Moves Fuchsia platform to Desktop. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: zhanliang@google.com Change-Id: Id4976e61576da5d03d03505e3d3657a58c8bc13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827129}
-
Josiah K authored
Utilize getNextMagnifierBounds for better end-to-end testing approach. Fixed: 1139939 Change-Id: I65665dcb655f0bf948a36f28c4e5ba396010fbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533678Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#827128}
-
Jonathan Freed authored
Bug: 1128169 Change-Id: I423085d3d3f6ac7b9434b72cb794cd7f19ace64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531365 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827127}
-
Devlin Cronin authored
tabs.executeScript() and tabs.insertCSS() are being replaced by methods on the new chrome.scripting API. Restrict the old features to MV2. Bug: 987838 Change-Id: I3bf76ac9cf4821765531d08379bfb8eb21bf92e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535996Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827126}
-
Meilin Wang authored
Updates assets to finalized images. Fixed: 1146563 Bug: 1106937 Change-Id: I6a1f1ccf26f187832a1a7128e96f7d4f1ccb683c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533410Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827125}
-
Evan Stade authored
Provide the CastOptionsProvider in the public AndroidManifest.xml so that no client integration is required. This could cause a conflict with a client that already integrates with GMSCore cast library and has a CastOptionsProvider, but current clients do not. Bug: 1057099, 1148410 Change-Id: I8b342f7515f6b8c5b00b63a5eb86aefe2ea45692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534176Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827124}
-
Evan Stade authored
Bug: 1147276 Change-Id: I3fd1c16cf67eadf27a8ccc8b7f638f4c090a1ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531294Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827123}
-
Shengsong Tan authored
This change add a new event for desktop window focus state change. With this change, ARC can have different behavior when Chrome window or ChromeOS desktop get activated. BUG=b:171450038 TEST=Active different window between Chrome/ARC and logcat events Change-Id: I11cee5d5279ad12524092518cadd05fff67bab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519686 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827122}
-
Nate Fischer authored
It appears the MemoryInstrumentation singleton can be null in UMA logging code, possibly because this runs prior to //content initialization. There's no memory metrics to log in this case, so we work around this by null-checking the singleton and exiting early. Fixed: 1140173 Test: None Change-Id: Id5e783dd068381dac1d7ac48b86764acc54ed620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533738 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#827121}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5157fbfbae86..e61ccc59a240 2020-11-13 gavinmak@google.com [depot_tools] Make try-results fetch recent dry-runs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:774179 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7f8cbdb9702721d6f3275b71f67692166a80c75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827120}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5ecab06485a37c9797e0d2cf28ae5bcdac7821ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827119}
-
Jia authored
This cl cleans up logged messages that were intended for model debugging. Now that the model is launched, we can remove these messages and reduce spamming to the logs. Bug: 1148161 Change-Id: Iad9d202dde77ee5ca5662f6ac77494ea7e958ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535894Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827118}
-
Christopher Cameron authored
There exist method CanvasRenderingContext::ColorParams() and BaseRenderingContext2D::ColorParams(). Same names. The classes CanvasRenderingContext2D and OffscreenCanvasRenderingContext2D inherit from both CanvasRenderingContext and BaseRenderingContext2D. So, what does the ColorParams() method mean in those classes? Rename the methods to CanvasRenderingContextColorParams and GetCanvas2DColorParams to remove the ambiguity. Make the method GetCanvas2DColorParams be pure virtual, too. R=yiyix, jbroman TBR=fserb Bug: 1115317 Change-Id: Id0962d56df572b720f7edd669fd048ae9009913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530942 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#827117}
-
Anand K Mistry authored
Since querying of supported encoder profiles is asynchronous, it is possible for a site to create a MediaRecorder before the list of supported profiles is known. So wait until that list retrieved from the browser before continuing initialization. Bug: b:168834129 Change-Id: I8310e3342b413a120ad45a5ae0f7ac66fde41ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417873 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#827116}
-
Ryo Hashimoto authored
Values should be validated by iterating with i{{level+1}}. BUG=1148220 Change-Id: Iaa837dd73091c0f938bb2461569f3b46d04920b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532547Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827115}
-
Brandon Wylie authored
TBR=xingliu@chromium.org Bug: 1148568 Change-Id: I655de8fb181ae060992fea1454ba698a2b0bc8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536119Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827114}
-
Lukasz Anforowicz authored
A comment in //content/public/test/content_browser_test_utils.h says: if a function here also works with browser_tests, it should be in content/public/test/browser_test_utils.h. The NavigateToURLFromRenderer functions only depend on //contnet/public types and therefore this CL moves them to browser_test_utils.h. Bug: 1148049 Change-Id: I5746e85e1478ffd8cbb6ed35111dbec74230ee86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533198 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827113}
-
Yu Su authored
0-RTT for idempotent request is enabled here: https://chromium-review.googlesource.com/c/chromium/src/+/2508299 Here an idempotency setter is added in java ExperimentalUrlRequest builder with a default implementation to enable 0-RTT for idempotent request on Android. The setIdempotency API is not added in UrlRequest.Builder as an abstract method since client has already implemented UrlRequest. Bug: 1148031 Change-Id: I43fddfbd65a197599924c03aeeede461dcef3dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535657Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#827112}
-
Nnamdi Theodore Johnson-Kanu authored
- Add provider name where possible Before: https://screenshot.googleplex.com/7EE62daLS47D2Y2.png After : https://screenshot.googleplex.com/9oHhYyy7TnbtVR7.png Bug: 1093185 Change-Id: I353580175952c83f83b9d430e46f7a8bc52179d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506169 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827111}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605203985-a72b3d0424c525881821dc3609a4c23423acaf56.profdata to chrome-linux-master-1605225603-3e78f0541b05b7200384abc9a699177331fd68ec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia8e5467db42ae8c36e77cca35096cc321bc2b6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827110}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was always returning 1 from FuchsiaVideoDecoder::GetMaxDecodeRequests() for encrypted streams. As result the decoder had at most one decode request and so it wasn't decoding quickly enough. As result the renderer was sometimes running of output buffers. This change updates GetMaxDecodeRequests() to return value that includes the number of input buffers in the decryptor which allows to run decoder pipeline more efficiently. Bug: b/172062874 Change-Id: I394513debc02b43ea1bad801adc21a5b9efa5d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536450Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827109}
-
Wan-Teh Chang authored
Call PostDecodeProcessing() when Decode() sets the status of an image frame buffer to ImageFrame::kFrameComplete. This matches the Decode() methods of the other image decoders that support animation (GIFImageDecoder, PNGImageDecoder, and WEBPImageDecoder). This is related to the UpdateAggressivePurging() call at the beginning of Decode(). Change-Id: Ib98db567cdb492fcbcdaad36d055e73177f651df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536112Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827108}
-
Alec Douglas authored
This commit makes extract_actions.py and its dependencies compatible with Python 3.8+. extract_actions.py and its dependencies are still Python 2 compatible. Bug: 941669 Change-Id: I4038e49449ef0cda8e7801ea49aef7e80a53c9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531120 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#827107}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/90bf4ba461d1..052885405c6c 2020-11-12 alexleung@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1a2add0e09ff64ddc3c8d71f34507f519371d243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827106}
-
Yuheng Huang authored
The following stories are added: tab_search:close_and_open:2020 tab_search:top10:loading:2020 tab_search:top50:loading:2020 tab_search:top100:loading:2020 Also increase buffer size and remove delay when adding tabs Bug: 1099917 Change-Id: I08268ff34760775142acdc38d48aa3603f1d4b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533236Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827105}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605203985-0458f2948c8ea3f9d90fd537422a290135941c1f.profdata to chrome-mac-master-1605225603-5553135a8604afd70a132d716de6c70ddfcfdb1a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2c67765e817727db746fa68daf8de26df075e6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827104}
-
Eric Orth authored
Not sure what this is, and it has no documentation that I can find. Looks like some sort of non-automated fuzzer, so I'm assuming it's a legacy thing from before the current fuzzing support and deprecated in favor of our many fuzzers covering HostResolver and DNS functionality. Removing because it would otherwise need to be updated for the switch to DnsResponseResultExtractor. Change-Id: I5266d145baf5ba012dbad9ac7db44c35744c23b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536154Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827103}
-
Ravjit Singh Uppal authored
This reverts commit 8f9cd957. Reason for revert: Fixed compile failure after mid-air collision. Re-added include that this CL needs but was removed by https://crrev.com/c/2532577 in-between try jobs and landing. Original change's description: > Revert "Added support for one-time geolocation permission grants on desktop." > > This reverts commit 6e5cadb7. > > Reason for revert: compile failure > https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/22520? > > Original change's description: > > Added support for one-time geolocation permission grants on desktop. > > > > Expanded the current permission request dialog to have the possibility > > to accept the permission for only one time. > > > > The permission will be invalidated when all the tabs with that origin > > are closed or navigated away from, or if a day has elapsed since the > > grant, whichever comes earlier. > > > > Bug: 1147918 > > Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832 > > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826981} > > TBR=vasilii@chromium.org,engedy@chromium.org,ravjit@chromium.org > > Change-Id: I511823b3a656f211c472d76a9cce2d30ca7ab644 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147918 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536153 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826987} TBR=vasilii@chromium.org,engedy@chromium.org,zmin@chromium.org,ravjit@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1147918 Change-Id: I1acdb5f0af83bc74c3307b8ba1ba3d6cbb9ad232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536430Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#827102}
-
Wan-Teh Chang authored
A future CL will eliminate the image_data_ member. Replace the use of image_data_ in the ImageHasBothStillAndAnimatedSubImages() method with direct use of the data_ member. Change-Id: Idd086243eb7aed6c72b0253ef15ee2c2cb49b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536085Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827101}
-
Kevin Marshall authored
Implements support for setting the light/dark color theme via the fuchsia.web.Frame FIDL API or the fuchsia.settings.Display service. Fixed: 1119521 Change-Id: Iab2fb9d38cabd1af2e57886563c203440b15d74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518261Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827100}
-
David Black authored
UX prefers the non-material version of the chevron_right icon for use in system UI. Bug: 1147930 Change-Id: I7da0659212fc7087fdb23cf908ed77dc266b3fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536097Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#827099}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.60 R=rmhasan@google.com Bug: 1041619 Change-Id: I146db8315b102e994b606a7ff99e62e50a262eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535768 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#827098}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605128385-e428bee778404d65a307409bc6db7ad616d50a2d.profdata to chrome-win64-master-1605203985-641ad6c9d1aaad676b930873880400e5a1a9a471.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f6d78464a1931fa5b11b1563b095f6b4fc5a159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827097}
-
Scott Violet authored
I naively thought the wiring was so simple nothing could go wrong. Time has proven me wrong. BUG=11478276 TEST=test only change Change-Id: I4dfdd7a7613a1f6a04a2e4356f63b040da063b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535919 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827096}
-