GitLab

Review URL: http://codereview.chromium.org/7979014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102177 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jennb

Review URL: http://codereview.chromium.org/7981037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102176 0039d316-1c4b-4281-b951-d872f2087c98

To stave off future collisions, I went ahead and prefixed all of the Autofill label names.

BUG=97322
TEST=none


Review URL: http://codereview.chromium.org/7978010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97498
TEST=

Review URL: http://codereview.chromium.org/7977032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102174 0039d316-1c4b-4281-b951-d872f2087c98

Rename PanelMouseWatcherGtk into PanelMouseWatcherTimer. Added implementation of gfx::Point GetCursorScreenPoint() on Mac.

Review URL: http://codereview.chromium.org/7981012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102173 0039d316-1c4b-4281-b951-d872f2087c98

Use Chrome's user agent string for content_shell, since some sites (i.e. Gmail) give a degraded experience otherwise.

BUG=90445
Review URL: http://codereview.chromium.org/7980044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102172 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7980051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102171 0039d316-1c4b-4281-b951-d872f2087c98

It had turned off after June 30, 2011 builds. Extend to 2013. This is useful to gather SPDY over SSL vs HTTP over SSL metrics, which have disappeared now :(

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7946009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102170 0039d316-1c4b-4281-b951-d872f2087c98

Create new classes SyncManager::Change{Delegate,Observer} to handle
and observe changes.

Make SyncBackendRegistrar the SyncManager::ChangeDelegate.

Make SyncBackendHost call RefreshEncryption asynchronously and wait for it.
Also make the initialization state machine more explicit.

Remove the hack done to make use of observers_ in SyncManager::SyncInternal
almost thread-safe.

Comment which SyncManager member functions can be called from any thread.

Introduce helper struct WriteTransactionInfo and have DirectoryChangeDelegate
take that instead of just an EntryKernelMutationMap.

Beef up thread safety checks in SyncBackendHost.

Limit number of ChangeRecord -> value conversions done.

Move ChangeRecord unit tests into their own file.

BUG=89658,85481
TEST=

Review URL: http://codereview.chromium.org/7926001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=see unittest
Review URL: http://codereview.chromium.org/7983039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual.


Review URL: http://codereview.chromium.org/7867018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102167 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7955001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=binji,gbillock,jhawkins

Review URL: http://codereview.chromium.org/7983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102165 0039d316-1c4b-4281-b951-d872f2087c98

Use DISABLE_RUNNABLE_METHOD_REFCOUNT macro in several places I've previously specialized RunnableMethodTraits.

Review URL: http://codereview.chromium.org/7980014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102164 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?view=rev&revision=102006

fix know issues in RenderText

1. add tests.
2. change SelectWord() to use BreakIterator, so it works for Chinese and Complex script.
3. DELETE/ReplaceChar delete/replace a whole grapheme. ReplaceTextInternal should only replace one grapheme when there is no selection.
4. pointing to position outside of text returns HOME/END position.
5. based on Chrome Linux omnibox and gedit, given 
"abc|   def", double click should select "   " instead of "abc". Change test expectation.

BUG=90426
TEST=compile with touchui=1 test omnibox. run views_unittests.NativeTextfieldViewsTest/TextfieldViewsModelTest
Review URL: http://codereview.chromium.org/7841056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102160 0039d316-1c4b-4281-b951-d872f2087c98

matched by the whitelist regexp.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7980032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=SafeBrowsingDatabaseTest


Review URL: http://codereview.chromium.org/7863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/7915008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102157 0039d316-1c4b-4281-b951-d872f2087c98

Removes the dependency on chromeos-specific code in the extension-based file picker.  Compiles, links, and runs, but the dialog doesn't function yet - there's still some work to do to wire up the private JavaScript API calls.  See crbug.com/97424

BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102113

Review URL: http://codereview.chromium.org/7941014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102156 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=64887
TEST=none

Review URL: http://codereview.chromium.org/7982036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102154 0039d316-1c4b-4281-b951-d872f2087c98

Retry r100017. This time, prevent a potential shutdown race by moving the call to DownloadManager.Shutdown() from ExitedOffTheRecordMode() to ~OTRProfileImpl() to match ProfileImpl and guarantee that Shutdown() is called.

Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.

Make DownloadManager read this field to initialize its next_id_ counter in Init().

Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.

This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.

The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.

Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.

When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.

Owners:
Randy: downloads/* (no change from 7776012)
(Done) John: content/browser/{renderer_host/,resource_context.}* (no change from 7776012)
(Done) Will, Miranda: profiles/* (small bugfix)

Review URL: http://codereview.chromium.org/7847027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102149 0039d316-1c4b-4281-b951-d872f2087c98

This avoids the need for NPObjectStub to use PluginThread::plugin_path() and allows us to remove the content/plugin/ include from npobject_stub.cc. We can also remove PluginThread::plugin_path().

Refactoring only, no functional change.

BUG=96703

Review URL: http://codereview.chromium.org/7982026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102145 0039d316-1c4b-4281-b951-d872f2087c98

crbug.com is down so i'm suppressing without bugs for now.
I'll update the suppression with bug once filed.

TBR=qsr@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7981032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102144 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ofri

BUG=97453

Review URL: http://codereview.chromium.org/7983040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102143 0039d316-1c4b-4281-b951-d872f2087c98

on the RenderWidgetHost/RenderViewHost objects. Moved the Edit operation APIs out of RenderViewHost to
RenderWidgetHost.

1.  ViewMsg_UpdateWebPreferences
2.  ViewMsg_SetBackground
3.  ViewMsg_AccessibilityDoDefaultAction
4.  ViewMsg_SetAccessibilityFocus
5. ViewMsg_ScrollFocusedEditableNodeIntoRect
6. ViewMsg_SelectRange
7. ViewMsg_Cut
8. ViewMsg_Copy
9. ViewMsg_Paste
10. ViewMsg_Delete
11. ViewMsg_SelectAll
12. ViewMsg_ClearFocusedNode
13. ViewMsg_SetAltErrorPageURL
14. ViewMsg_ExitFullscreen

Continuing fixes to ensure that IPC messages don't span across content and
chrome.

BUG=87335.
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/7972006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102142 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ofri

BUG=97453

Review URL: http://codereview.chromium.org/7976031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102141 0039d316-1c4b-4281-b951-d872f2087c98

Original patch by kalman@chromium.org.

BUG=94575
TEST=unit tests included
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7977018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102140 0039d316-1c4b-4281-b951-d872f2087c98

This should fix problems caused by calling ImportantFileWriter
on wrong threads.

BUG=none

Review URL: http://codereview.chromium.org/7966005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102139 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102138 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7979024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102137 0039d316-1c4b-4281-b951-d872f2087c98

Also add various tests required or enabled by this change.

This changes two aspects of Cancel semantics (for downloads, not save page):
a) Cancel can now be called anytime during the lifetime of a download, and
b) if it is called before the history callback occurs, the download will be removed from the system (no where to store it persistently while waiting)

BUG=85408

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101510

Review URL: http://codereview.chromium.org/7796014

TBR=rdsmith@chromium.org
Review URL: http://codereview.chromium.org/7983037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102136 0039d316-1c4b-4281-b951-d872f2087c98

Fixes issues where WGC3D based on OSMesa GL implementation isn't allowing OES extensions that are supported.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7980034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102135 0039d316-1c4b-4281-b951-d872f2087c98

by the OOM killer to get killed.

BUG=chromium-os:18421
TEST=Verify that "He's dead JIM tab doesn't come on the currently focused tab in OOM
cases. It can still happen only if there is one tab present and it eats up all the
available system memory."

Patch by amruthraj@motorola.com, rosen.dash@motorola.com

Review URL: http://codereview.chromium.org/7930022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102134 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation for content_browsertests target.

BUG=90448

Review URL: http://codereview.chromium.org/7980026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102133 0039d316-1c4b-4281-b951-d872f2087c98

The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure.

Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/7879006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97131
TEST=ui_unittests links and runs with use_aura=1

Review URL: http://codereview.chromium.org/7977025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19851
TEST=manual on Cr48.

Review URL: http://codereview.chromium.org/7826037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102130 0039d316-1c4b-4281-b951-d872f2087c98

In stand-alone Proxy Settings dialog, 'keyup' events now trigger 'change' events. This is to circumvent http://crosbug.com/20660.

BUG=chromium-os:11487
TEST=Manual: in login screen, open proxy settings, type in any IP and a non-standard port number (e.g. 9999), then press Esc or click the close button without focus leaving the port textbox. Port should be saved and re-appear when opening that dialog again.

Review URL: http://codereview.chromium.org/7982024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7979026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102127 0039d316-1c4b-4281-b951-d872f2087c98

Also add various tests required or enabled by this change.

This changes two aspects of Cancel semantics (for downloads, not save page):
a) Cancel can now be called anytime during the lifetime of a download, and
b) if it is called before the history callback occurs, the download will be removed from the system (no where to store it persistently while waiting)

BUG=85408

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101510

Review URL: http://codereview.chromium.org/7796014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102126 0039d316-1c4b-4281-b951-d872f2087c98