GitLab

Followup to crrev.com/c/2326632 and some comments there.

For the Tab Groups Extensions API, it's useful to be able to query all browsers for the one containing a TabGroupId, without needing to know the profile up-front. There are separate checks for ensuring that a group doesn't move across profiles. This is still assuming it's unlikely for group IDs to clash across profiles.

If there's a better way to approach this I'm happy to adjust!

Bug: 1098439
Change-Id: I71bd07f5d00fad74ee5aa02d1a62feb4883e3819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339341
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795549}

Following the comments from crrev.com/c/2310800.

Bug: 1085115
Change-Id: I2985b8a8f912009524edbcbb4286687ec6a5c0aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339668Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795548}

Bug: 866790
Change-Id: I8f9f3c567717f36e91f8a8f12b42124f4114ed03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340913
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795547}

Bug: 1111856
Change-Id: I3b201ae3900980f52849d0dafc4632c5c16bce5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337513Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795546}

We want to simplify error handling and use CLOUD_PROVISION_FLOW_ERROR with message code everywhere instead of CLOUD_PROVISION_FLOW_FAILED for few special cases.

BUG=b:62613791
BUG=b:146435695
TEST=deploy to dut, disable playstore, re-enable playstore, successfully
finish the authorization flow

Change-Id: Idb4dfeed9fa60d427703170488a3d581f66a9041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340111Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795545}

Break-before, break-after, and break-inside don't apply to absolute
positioned elements, so we don't need to add any special handling for
these when fragmenting OOF positioned elements. This change adds tests
to ensure that these forced breaks don't apply to abspos elements, as
expected, but do still apply to the children of abspos elements.

Bug: 1079031
Change-Id: Iaee4dfa67244e1999f659978c7cb3bbfce55ad8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327818
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795544}

This cl renames the SigninButton and ChooseAccountButton to Primary and
Secondary button respectively.

Bug: 1095628
Change-Id: I6c502c8f6509a4e45395204f986ccb554fad1f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273238
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795543}

This change fixes IdleWakeups' SystemInformationSampler failing to
handle processes for which ::NtQuerySystemInformation() returns a
thread count of zero. With this change, processes with "zero" threads
are simply skipped.

Currently, the "Secure System" process reports a thread count of 0
(as it prohibits other processes from accessing it in any way), and
SystemInformationSampler subtracts 1 from this (logically assuming
that every process has at least one thread), which overflows to a
large number. SystemInformationSampler, noting that thread
information for <large number> threads would not fit in its buffer,
triggers an early return.

In practice, this results in IdleWakeups showing 0 processes when
a process with "zero" threads exists before its targeted process in
the process list, because it hits the early return described above
before reaching the process of interest.

Change-Id: I63b9a36bb139aba0b18539e65312bdc5d836cc69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335799
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795542}

R=chrisha

Change-Id: If77da5ebdff20e663f1fe9e216a2b1a46dda56bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341345Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795541}

Bug: skia:104662
Change-Id: I6f7f4ba8f77a19174b50d8485b3a0c2a5e9a46f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340704
Commit-Queue: Adlai Holler <adlai@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Adlai Holler <adlai@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#795540}

TBR=kinuko@chromium.org

Bug: 1113696, 1113692
Change-Id: I2e949d45670d0155dc45c125904d35386ecbd38e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340184
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795539}

TBR=sky@chromium.org

Bug: 1113694
Change-Id: I299d834ec9369d6314a25956f0b00e56cae308e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341242Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795538}

The implementation of the legacy TLS interstitial on iOS relies on
committed interstitials being enabled, so we should gate triggering
the interstitial on the committed interstitials feature being enabled.

Bug: 1100647
Change-Id: I0901deb007b34c14916a3f2daf4f2054f254e06d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340588Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795537}

Bug: 1109965
Change-Id: I619729473928759c478dbb64e215eff29dbb09c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335905Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#795536}

QuicSession::OnGoaway() is only for transport layer GOAWAY in Google
QUIC.  IETF QUIC uses HTTP/3 layer GOAWAY instead, and in order to
handle it, QuicChromiumClientSession should override
QuicSpdySession::OnHttp3Goaway() as well.

Bug: 1113661
Change-Id: I4ffa2edea730f823af22af232ecd2cc97856ba56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340856Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795535}

This change disconnects caBLEv2 on the desktop and mobile so that
further changes can be made incrementally. Otherwise, in order to
keep everything working, large changes cannot be broken up.

BUG=1002262

Change-Id: If2e4c5c561fd2b57cd8f70dbe33c769109ca9c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332375
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795534}

Some misconfigured servers redirect to a 200 code instead of a 204,
meaning that the response payload can be quite large. This is not an
issue in practice, but it does confuse metrics a bit. Since there is no
harm in increasing the limit, do it to make metrics easier to
understand.

Bug: 816837
Change-Id: I908a3cad22779b57bdb78f5957e8839048ee3597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339981Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795533}

Change-Id: I86093e9275eac2cf79ec3e77b8697b732958d9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341384
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795532}

This CL blocks private network requests coming from insecure contexts when the
network feature kBlockInsecurePrivateNetworkRequests is enabled. That feature
is renamed to reflect the name change in the spec. Right now, the feature is
disabled by default.

Bug: 986744
Change-Id: I78c1aa26d1e385ba8b10e13e08545ce8aada7867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260423Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795531}

https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ia0ecc8b909fc306e70a786f6aa504081ff1eadde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341383Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795530}

This CL changes the '#omnibox-ui-elide-to-registrable-domain' flag to
only elide to registrable domain when the domain triggers a basic
heuristic.

This CL also builds out the scaffolding for future elision heuristics.

Bug: 1106962
Change-Id: Ia23c9f05a8e6d758a219e2d10e167e5ca20de80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337761Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795529}

Bug: 1072012, 1106905
Change-Id: Ia6f73f6beaae7c60130281269bc2012fa72cba81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333745Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#795528}

Change-Id: I16ef2d65b20c95df7ad590d2485b6364c0340ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337236Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795527}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fa830b464d9f..37009c358bdf

2020-08-06 kprokopenko@google.com [issues] Protocol update for element handling
2020-08-06 jacktfranklin@chromium.org Migrate cm_modes to devtools_entrypoint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1082628,chromium:1101738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic2be7a5c2a503e8f92b098973ebdb195aa1e0108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341119Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795526}

This metric corresponds to current accessibility metric:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/catapult/tracing/tracing/metrics/accessibility_metric.html;drc=ae4cc909a3bb9b54c09107a87f2d3682d762e077.

Change-Id: I403d5125bee913d0eb8041dc012d60e5d68bafa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339335Reviewed-by: Deep Roy <dproy@chromium.org>
Commit-Queue: Julia Semavina <nuwanda@google.com>
Cr-Commit-Position: refs/heads/master@{#795525}

Bug: none
Change-Id: I2a0935480d8928d531e246c1efa14e3f538910f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339465
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795524}

Before, this happened by default. However, this was confusing, so now
there are two separate flags, so zoom can be enabled without changing
the default zoom level.

Bug: 1113270
Change-Id: I912dbbec72ad527b515ffab151a3a57c9fd76fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339346Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#795523}

This change makes SystemInformationSampler::TakeSnapshot() smaller by
extracting a block of code into a separate function, shortening this
long function from 88 lines to a slightly more readable 58 lines.

This change also moves an early return for validation to the earliest
place it can be, slightly clarifies a comment, and fixes a typo in
IdleWakeups.

Change-Id: I3ef0271e82de74b87d1b9ce57b4bd38dc834bd23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335797Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#795522}

Change-Id: I379eb250fd11836bb3b8584ce0235d782284e89f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310327
Commit-Queue: Pavel Iliin <Pavel.Iliin@arm.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795521}

PowerMonitor checked for EXTRA_PLUGGED on Intents that don't set
it.  This CL listens for power connected / disconnected Intents
directly.  It still uses EXTRA_PLUGGED to set the initial state.

Bug: 1112932
Change-Id: Ia01c5bb46ab6319bd0079abb1471651e5f84a97c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337111Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795520}

Bug: 1107489
Change-Id: I6c68d226f8ae148d3c8bb3842bc127ca1962cb42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337573
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795519}

Bug: None
Change-Id: I72116c939a055ad8458d9163d1279d21fd10cde3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333315
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795518}

Bug: 1106950
Change-Id: Ie1c1fac0955afe6908335d2360a07954c718c25f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337103
Commit-Queue: Gary Tong <gatong@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795517}

Adding:
- Open in New Tab
- Open in New Incognito Tab
- Open in New Window (if Multi-Window is supported and iPad)
- Delete

Bug: 1093302
Change-Id: I86df229a836df599b5f9febab4ba6541ec1e8ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332274Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795516}

https://android.googlesource.com/platform/external/perfetto.git/+log/76488e6d8e63..dc68e3248ed9

2020-08-06 primiano@google.com Merge "Fix base::Subprocess move ctor and operator="

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I090180f9073daa0fd1c860d37b14774a1f2d80df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795515}

- Adds new string search tags for Phone Hub and related features
- Adds new sections for new Phone Hub realated features
- Update test to include new Phone Hub feature

Bug: 1106937
Change-Id: I4dbe78b0c94a9e26118ea4e51b725294472e6cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315394Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#795514}

For performance and privacy reasons, we sometimes don't capture as much
data as possible -- in these cases, we want to mark data as "tainted" so
that it can be analyzed separately server-side.

There are 3 taint categories that we represent as bits in the final
digest:

1) For at least one op we intentionally didn't capture everything
(images).

2) At least one op was skipped (buffer not big enough or too many ops).

3) Undersampling (using 16-bit hash for sensitive strings).

Bug: 973801
Change-Id: I0ded6b8f06792893cad584f0540a3797fede325a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264769Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795513}

The android.sensor.orientation metadata specifies the clockwise angle
through which the output image needs to be rotated to be upright on the
device screen in its native orientation.

Bug: 990682
Change-Id: I552a0b0bedc126efe85519cd25cc904d6e550e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341026
Auto-Submit: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795512}

In TabListMediator, TabModelObserver is registered in constructor. This
assumes that when constructor is called, the TabModel side should be
ready to accept observers, which is no longer true with instant start
as the constructor for TabListMediator for GridTabSwitcher is now
called before native is ready. This CL fixes this issue by registering
the TabModelObserver after native is ready.

Bug: 1110783
Change-Id: Ia944a1cb7fef30933b4094adb1045e664e3df1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328038Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795511}

Bug: 915344
Change-Id: Id09fb177297e014201581fd3a6057cf1961d2cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335911Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795510}