- 23 Aug, 2017 40 commits
-
-
Akari Asai authored
Changed CanEditRichly() in Source/core/editing/Editor.cpp to use IsRichlyEditablePosition() instead of VisibleSelection::IsContentRichlyEditable() to remove VisibleSelection's IsContentRichlyEditable(). Bug: Change-Id: Ib61170d6922ff8e2fbb667f7c56b7c22a144bd27 Reviewed-on: https://chromium-review.googlesource.com/627245 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496609}
-
Hiroki Nakagawa authored
Before this CL, some tests in ModuleScriptLoaderTest have wrong test expectations and test helpers have wrong implementation as follows: 1) Dummy Modulator doesn't have a valid SecurityOrigin, so the CORS handling fails. 2) Mocked ResourceResponse doesn't have a Content-Type header, so a generated ScriptResource doesn't have a valid MIME type (ScriptResource respects the header instead of ResourceResponse::MimeType()). This CL fixes them and corrects the test expectations. In addition, this CL... 3) replaces NullURL() on the KURL constructor calls with kParsedURLString because they generate KURL instances from URL strings. 4) makes TouchActionTests specify the MIME types. Without this change, these tests set the Content-Type header to the default MIME type "text/html" and start to fail. Bug: n/a Change-Id: Ifffa734dcb4e44a670172f27c30efcdcc075e5be Reviewed-on: https://chromium-review.googlesource.com/627523 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#496608}
-
Pavel Feldman authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I02fc9531fa4db3f054fc09e448db9036d7436729 Reviewed-on: https://chromium-review.googlesource.com/627123 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#496607}
-
Mike Dougherty authored
Triggering the context menu is done independently of fetching details of the DOM element the user long pressed. Previously, if the details of the DOM element were not available when the long press recognizer completed, the system context menu would be displayed instead of Chrome's custom context menu. The system context menu can cause the user lots of confusion. For example, the "Add to Reading List" item which is shown on the system context menu conflicts with the Chrome Reading List feature. If the user taps the system Reading List item, the item will not be added to their Chrome Reading list, but they will likely believe that it has been successfully added. To resolve these problems, this change always suppresses the system context menu and waits for the DOM element to be returned before showing the custom Chrome Context Menu. In addition, iFrames will no longer show the WKWebView context menu. Now, the custom context menu will always be displayed once the DOM element details have been fetched as long as the user is still long pressing on the element. Bug: 542933 Change-Id: Ia47e659868449bb514fc6b679e0f233c2bcd8182 Reviewed-on: https://chromium-review.googlesource.com/579585Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#496606}
-
Eliot Courtney authored
Suppose we have a notification with surface size 720x161. In |UpdatePreferredSize|, we make sure the notification is of width kNotificationWidth (360). While scaling, 161/2 is truncated to 80. Later, in |Layout|, we use |contents_size| which holds the truncated 80 to compute the transform. This leads to the notification eventually being displayed as 720x160. Instead, compute the scale factor based on the surface width and kNotificationWidth. BUG=754369 Change-Id: Ib2025bf7aac9d096085e0a641c20c6cc84689503 Reviewed-on: https://chromium-review.googlesource.com/625605Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#496605}
-
Wu-Cheng Li authored
BUG=None TEST=None Change-Id: I4c7cf261450016822c6f2b5f3fbef3445dfd9a69 Reviewed-on: https://chromium-review.googlesource.com/618529Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Wu-Cheng Li <wuchengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#496604}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b5cc2cf..6bc744de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ic893de57e98762ca6070236de6fc743587ddf84c Reviewed-on: https://chromium-review.googlesource.com/627838Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#496603}
-
Eriko Kurimoto authored
Bug: Change-Id: I87ca0541e15a803d7939a138dc0d4a844182a2e4 Reviewed-on: https://chromium-review.googlesource.com/618430 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#496602}
-
Eddy Mead authored
Diff of generated CSSPropertyAPI.cpp: https://www.diffchecker.com/jIgWEunn Bug: 753010,751373 Change-Id: I06ce4a0b038311b779e1f6e1e33c9de570f637eb Reviewed-on: https://chromium-review.googlesource.com/620512 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#496601}
-
Greg Thompson authored
This change also makes the handling of the make_chrome_default and make_chrome_default_for_user master preferences options conditional on a brand's support for in-product default browser handling. BUG=752007 R=pmonette@chromium.org Change-Id: I1eb6d4344aa845943e726b69cf2319e6cf056cb9 Reviewed-on: https://chromium-review.googlesource.com/625896Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#496600}
-
Tatsuhisa Yamaguchi authored
The context menu has once disabled by 606068 when we assigned long-tap to enter the selection mode. Bug: 755757 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I282901d190e63c264eb6238abd34bf0cff107a66 Reviewed-on: https://chromium-review.googlesource.com/625506Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#496599}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 18970acc. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/509 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I0f430290bfa421b5ce5da39a3c1b8fbe9a98f7cd Reviewed-on: https://chromium-review.googlesource.com/627129 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496598}
-
Rune Lillesveen authored
Style sharing is no longer present in the codebase, so the SetStyle / LocalStyleChange should no longer be necessary here. Bug: 721517 Change-Id: I0437f3c3c3188101299b053d81b36a7542baf610 Reviewed-on: https://chromium-review.googlesource.com/625880Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#496597}
-
John Abd-El-Malek authored
r496531 renabled a test that flaked. Also disable some new failing tests added in r496577. BUG=729848 TBR=kinuko@chromium.org NOTRY=true Change-Id: I5a59f687df52f65441c7ff03c0ac45920ff2e081 Reviewed-on: https://chromium-review.googlesource.com/628016Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#496596}
-
Tetsui Ohkubo authored
According to MD notification mock, EOL notification has theme color and new |small_image| icon. (go/cirvr) If chrome://flags#enable-message-center-new-style-notification is disabled, this CL has no effect. TEST=manually tested on Chell device BUG=751024 Change-Id: I4018d129659b1a0700ebbb695162452ce90ef8aa Reviewed-on: https://chromium-review.googlesource.com/622509 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#496595}
-
Ramin Halavati authored
Typos corrected in network traffic annotations of the following files: chrome/browser/safe_browsing/download_protection/ check_client_download_request.cc chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc components/omnibox/browser/contextual_suggestions_service.cc content/browser/loader/resource_dispatcher_host_impl.cc Bug: 656607 Change-Id: I606d3b2b5cc5f31dbafd4c820c6dd1051eabb562 Reviewed-on: https://chromium-review.googlesource.com/620650Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#496594}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/810d9d2ae52b..6980765beb91 $ git log 810d9d2ae..6980765be --date=short --no-merges --format='%ad %ae %s' 2017-08-22 nednguyen Modify record_wpr to record benchmark once only Created with: roll-dep src/third_party/catapult BUG=757804 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idc48ad38e2acdcb95dddabb57615bb78f35b8372 Reviewed-on: https://chromium-review.googlesource.com/627497 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496593}
-
Tim 'mithro' Ansell authored
Should fix; ------------------------------------ 22:11:25.948 2648 Found 13285 tests (total 66425); running 11471, skipping 1814. 22:11:25.948 2648 Checking build ... 22:11:25.948 2648 Unable to find test driver 22:11:25.949 2648 at e:\b\swarm_slave\w\ir\out\Release\content_shell.exe 22:11:25.949 2648 Unable to find content_shell_crash_service.exe 22:11:25.949 2648 at e:\b\swarm_slave\w\ir\out\Release\content_shell_crash_service.exe 22:11:25.949 2648 Could not find crash service, unexpected crashes won't be symbolized. 22:11:25.949 2648 Did you build the target blink_tests? 22:11:25.949 2648 22:11:25.949 2648 For complete Windows build requirements, please see: 22:11:25.949 2648 22:11:25.949 2648 https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md 22:11:25.949 2648 Build check failed 22:11:25.952 2648 22:11:25.952 2648 Testing completed. Exit status: 255 ------------------------------------ BUG=717348,524758,757955 TBR=tapted@google.com CC=qyearsley@chromium.org,dpranke@chromium.org NOTRY=true Change-Id: I27047cca345ec367d70a7bfa486f459f596a2f90 Reviewed-on: https://chromium-review.googlesource.com/627551Reviewed-by:
Tim 'mithro' Ansell <tansell@chromium.org> Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#496592}
-
Jia authored
This cl implements parseShorthand APIs for background, -webkit-mask, background-repeat and -webkit-mask-repeat. Properties background and -webkit-mask are handled by the same API. This is because their parsing logic is too similar. In order to avoid duplicating the code and also without having to pass shorthand id to util functions, we check shorthand id within the API class and parses property according to shorthand id. Bug: 668012 Change-Id: I0751a2b7517fb3fbff53adeb54797fda8f89dd80 Reviewed-on: https://chromium-review.googlesource.com/601770 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#496591}
-
Kinuko Yasuda authored
This patch: - Creates SWSubresourceLoader in CreateURLLoader for SW-controlled clients - The SubresourceLoader intercepts requests and directly dispatches Fetch events to BrowserSideSWEventDispatcher - The BrowserSideSWEventDispatcher then forwards the events to renderer-side SWEventDispatcher Bug: 715640 Change-Id: I3cf7e8cbca4648560a7849ed7e30b463e8f67ca5 Reviewed-on: https://chromium-review.googlesource.com/607948 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#496590}
-
Dominic Mazzoni authored
Chrome fires accessibility events on page load, and when the web page moves focus. This makes sense. WebView shouldn't do this, because there may be more than one WebView on the page and they might all be fighting with each other. We already had a boolean shouldFocusOnPageLoad that's false when we're in a WebView, so we can avoid firing a focus event when the page loads, but there were two more places that sometimes moved accessibility focus on load, and those need to respect the preference too. Bug: 757948 Change-Id: I3c1b60ea5f81b3bb85776dfa950869a3e96c7cfa Reviewed-on: https://chromium-review.googlesource.com/627166Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#496589}
-
Kent Tamura authored
This will enable us to simplify some code. e.g. - Merge WebFileChooserParams and FileChooserSettings - Merge WebFileChooserCompletion::SelectedFileInfo and FileChooserFileInfo Change-Id: Id6d2982d6fae1082edaf6f7cb405b228e17227df Reviewed-on: https://chromium-review.googlesource.com/624832Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#496588}
-
wutao authored
Add one UMA for hiding window animation smoothness, used in closing windows, so that we can evaluate how much improvement we can achieve by caching render surface. Bug: 756739 TEST: has histogram at local device. Change-Id: I11e3ab879e246b034f021caa3340061aec188220 Reviewed-on: https://chromium-review.googlesource.com/620253Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#496587}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/04f4666c..7b5cc2cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I129a8ed4787899d8dd44b525dd6f17a38ab9ad69 Reviewed-on: https://chromium-review.googlesource.com/627796Reviewed-by:
-
David Bokan authored
This test uses the Ahem font but on machines/bots without this font it will fallback. The expectations were set for the fallback without realizing it. This causes the test to fail on a system with Ahem installed. This patch calls LoadAhem in the test and resets the expectations. Bug: 749836 Change-Id: I7c0854f8d45bbadf1b88c27ab4964b2dac312058 Reviewed-on: https://chromium-review.googlesource.com/627378Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#496585}
-
Michael Martis authored
ChromeLanguageDetectionClient replaces ContentTranslateDriver as the endpoint for language detection IPCs. ContentTranslateDriver maintains a set of bindings for this IPC, but we thought we could simplify things by using a single binding. This change reverts to a binding set, as ChromeLanguageDetectionClient has begun causing crashes. Bug: 757879 Change-Id: Iec3308b631ed32b4d123e13b4273b7299de63677 Reviewed-on: https://chromium-review.googlesource.com/627521Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#496584}
-
Fadi Meawad authored
The old memory uma distinguished between extension render process and non-extension ones. This CL reintroduces that in the new memory UMAs. For UKM, it add the number of extensions in the process instead. For both, We only account for true extensions, and we exclude hosted apps. Bug: chromium:749775 Change-Id: I5e2dda7d6fa4420af7f63f4cbace09f5f7cf9309 Reviewed-on: https://chromium-review.googlesource.com/611316 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#496583}
-
Erik Luo authored
Object-type objects in the console always format as an ObjectPropertiesSection with an expansion arrow. This CL removes the unnecessary expansion arrow for objects that have no properties. Screenshot: http://imgur.com/a/Iiwu9 Bug: 673894 Change-Id: Ic82cb745ee2f564ed51dccb03607e57449a83c8d Reviewed-on: https://chromium-review.googlesource.com/624464 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Bug: 757535 Change-Id: I87a997cb848a948e674be9293f85aa0c70198fed Reviewed-on: https://chromium-review.googlesource.com/627089Reviewed-by:
-
Carlos Knippschild authored
Bug: 701939 Change-Id: If4882e98fe2bee0c7d04df6d7f08bd1d7a67e476 Reviewed-on: https://chromium-review.googlesource.com/627516 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#496580}
-
Erik Luo authored
Console sorts messages by timestamp, except for Command/Result messages, which are kept in arrival order. Before, a bug allowed a message with an earlier timestamp to appear above the first command message, even though the command message arrived to the console first. After this CL, DevTools correctly checks for the adjusted time, so later messages will not be able to appear before the first command/results. Bug: 757245 Change-Id: I228d8774b96da36d218330fd11c9c94f11656893 Reviewed-on: https://chromium-review.googlesource.com/626945 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#496579}
-
tzik authored
After this CL, OpenFileSystem and ResolveURL on FileSystemBackend start using OnceCallback. Change-Id: I6b1778f356e366d1fcbe66db928b6af72fd5a3ea Reviewed-on: https://chromium-review.googlesource.com/625816 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
-
David Vallet authored
This cl implementes setDownloadBehavior devtools command, for both headles/non-headless BUG=696481 Change-Id: Ib4385e478e89219062241983a6ceb523bf476d09 Reviewed-on: https://chromium-review.googlesource.com/590913 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#496577}
-
tzik authored
After this CL, file_system_provider::Queue can take base::OnceCallback in addition to legacy base::Callback. Change-Id: I29e306205a27e4e514c040ff1304be56bcce8373 Reviewed-on: https://chromium-review.googlesource.com/625643 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
tzik authored
scoped_refptr should be passed by value to be compliant to our coding style, and also it can potentially reduce a copy of the ref count. Change-Id: Ifd559e9e2156f260aa94551c94f2cd4376ac27b5 Reviewed-on: https://chromium-review.googlesource.com/625610Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Sidney San Martín authored
FullscreenToolbarMouseTracker has a method, -updateToolbarFrame:, which sets trackingAreaFrame_ based on contentView_'s bounds, then calls -updateTrackingArea. However, -updateTrackingArea is responsible for setting contentView_, so its value is stale (nil, in this case) when -updateToolbarFrame: looks at it. trackingAreaFrame_ only becomes correct if -updateToolbarFrame: is called a second time. I haven't discovered why, but it looks like we get extra events from the light menu bar, but not the dark one, which masked the bug. Fix the bug by having -updateToolbarFrame: find the content view itself instead of relying on the contentView_ ivar (which seems to mainly be used to remember which view currently has a tracking area). Bug: 749224 Change-Id: I3c923d09590e3416ebcf8bbb428d1dd44f62fab7 Reviewed-on: https://chromium-review.googlesource.com/627296 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#496574}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: Id7eefeaf51ab744dd09307c5d52e7a37c11d937c Reviewed-on: https://chromium-review.googlesource.com/627126Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#496573}
-
Ben Wells authored
This has now rolled out to 100% stable, so should enable by default. Bug: 688208 Change-Id: I2b34824ca48072bad4df048451f2b8fc2c31136b Reviewed-on: https://chromium-review.googlesource.com/625504Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#496572}
-
Han Leon authored
- Makes device::SendBuffer ctor take 'const std::vector<uint8_t>&' rather than 'const std::vector<char>&' - Changes type of its member |data_| from 'const std::vector<char>' to 'const std::vector<uint8_t>'. BUG=749515 TBR=charliea@chromium.org Change-Id: I27424642d866174be84f7916f260b1f5e6b769a8 Reviewed-on: https://chromium-review.googlesource.com/620207 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496571}
-
tzik authored
For the preparation to migrate FileSystemProvider callbacks to OnceCallback, this CL convert these usage to OnceCallback-compatible style. Change-Id: Ifcb68699a7e39ac4b14e1115486791a07cc8141a Reviewed-on: https://chromium-review.googlesource.com/625859 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
