GitLab

https://chromium.googlesource.com/native_client/src/native_client.git/+log/385a05c3d606..5604391f597d


git log 385a05c3d606..5604391f597d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 hinoka@chromium.org Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""


Created with:
  gclient setdep -r src/native_client@5604391f597d

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mseaborn@chromium.org

Change-Id: Ib32d0d3f7078ffd0d9c0286890c329cbfbac9b37
Reviewed-on: https://chromium-review.googlesource.com/1217812Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590193}

A previous refactoring (http://crrev.com/586985) changed the CreateRoute
call in CastConfigClientMediaRouter::CastToSink to supply a null
callback. This causes a crash because MediaRouter assumes the callback
is not null. This patch fixes it by supplying base::DoNothing() instead.
Also, added a CHECK for null callback in MediaRouterMojoImpl.

Bug: 882567
Change-Id: Idaaf1ca24149dff4d0bab7228f10176e804226d4
Reviewed-on: https://chromium-review.googlesource.com/1217902Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590192}

The Chrome app menu and its submenus have a max-width of 800px. Bookmarks
_subfolders_ have a max-width of 400px. But this doesn't apply to the
bookmarks menu itself.

Currently if a bookmark has a long title and appears in the bookmarks
bar top-level, it will push out the width of the `Bookmarks` submenu
when accessed via the Chrome app menu to a width that feels inconsistent.

Bug: 881936
Change-Id: I1535b2b27f183e4106e21799ba91a5ab40287489
Reviewed-on: https://chromium-review.googlesource.com/1215503Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590191}

R=kojii@chromium.org,eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6eb59b3683c54d703b311842fe333b2590d05882
Reviewed-on: https://chromium-review.googlesource.com/1217708Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590190}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4624f2fdcfda..867aebe10898


git log 4624f2fdcfda..867aebe10898 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 chingcodes@google.com signing: add errors and add/update signers


Created with:
  gclient setdep -r src/third_party/chromite@867aebe10898

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2df033eeaae2bde498496550e47b670d9854587b
Reviewed-on: https://chromium-review.googlesource.com/1217810Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590189}

This CL lets PpapiThread use CreateMainThreadAndInitialize() so the
Platform class can create the main thread on behalf.

Previously, the code does not create an WebThread instance for the main
thread(!), and PpapiBlinkPlatform::CurrentThread() actually returns
nullptr on the main thread(!). This is because BlinkPlatformImpl::
CurrentThread() only cares about non-main threads created with
CreateThread(). This CL fixes this issue.

Bug: 826203
Change-Id: Icc1319e70da2d7c2a3ccaee0adb140df80cd496d
Reviewed-on: https://chromium-review.googlesource.com/1186019Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590188}

This is a clean up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1201507
which renames BubbleDialogDelegateView::set_arrow() to SetArrow().
This matches our style guide as SetArrow() isn't a simple getter function.

Bug: 877032
Change-Id: I9d506604d74651deed45a3854356ec7b66e57bb9
Reviewed-on: https://chromium-review.googlesource.com/1203493Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590187}

The ChromeOS Gallery, video_player, and audio_player currently pick out
a collection of .js files from various places inside the folder structure
of the ChromeOS files App.

This CL documents where that occurs, with a view to move these, shared
files out to a shared "toolkit" folder higher up in the folder structure.
There is already a "common" folder, but it is within the Files app
subtree and hard to enforce via layering.

It uses GN's "visibility" on the closure targets to detect whether new
dependencies are added.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6b134ccad20c22ad46372871ab488200d3cbafa1
Reviewed-on: https://chromium-review.googlesource.com/1188735
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590186}

../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(58,32):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
      keyboard_layout_handles_.size(), keyboard_layout_handles_.data());
      ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(75,35):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  return keyboard_layout_handles_.size();
  ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(32,44):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
        keyboard_layout_manager->GetLayout(i);
                                 ~~~~~~~~~ ^
../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(33,20):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    PopulateLayout(i, dom_keyboard_layout);
    ~~~~~~~~~~~~~~ ^

../../ui/events/test/event_generator.cc(673,51):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
      (ui::EventTimeForNow() - base::TimeTicks()).InMicroseconds();
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

../../ui/events/win/events_win_utils.cc(257,36):  warning: implicit conversion loses integer precision: 'const LPARAM' (aka 'const long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
    return gfx::Point(native_event.lParam);
           ~~~        ~~~~~~~~~~~~~^~~~~~

../../ui/events/event_utils.cc(112,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(116,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(120,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(124,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
[22971/48339] CXX obj/ui/events/events/keyboard_hook_win.obj
../../ui/events/win/keyboard_hook_win.cc(117,25):  warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
    MSG msg = {nullptr, w_param, ll_hooks->vkCode,
              ~         ^~~~~~~

../../ui/events/event.cc(1137,47):  warning: implicit conversion loses integer precision: 'const WPARAM' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    key_ = DomKey::FromCharacter(native_event.wParam);
           ~~~~~~                ~~~~~~~~~~~~~^~~~~~

BUG=879657

Change-Id: If41fb68b2e054ff4f429396e78048d48f71a3e38
Reviewed-on: https://chromium-review.googlesource.com/1214682Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590185}

The new pill notification functions for hide/show were being called
instead of the old notification functions.

Bug: 881781
Change-Id: Ibc6012a1a6ef23b1405d1121941c511a58910821
Reviewed-on: https://chromium-review.googlesource.com/1217595
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590184}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I54ee7b0993650f57e768bb979b3c8df9c7841cf0
Reviewed-on: https://chromium-review.googlesource.com/1218223Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590183}

The old implementation of |updateFootersForFullscreenProgress:|
just updates the height constraint for the toolbar, which isn't
actually applied to the model layer until the end of the runloop. In
order to animate this change, the model layer must be updated from
within the animation block, so |-layoutIfNeeded| is called to commit
the new constraint value to the view hierarchy.

Simply calling |-layoutIfNeeded| on the toolbar view itself will
only animate the height, not the positioning.  Since the positioning
constraint is added to BVC.view, we'd need to force a full BVC layout
to also animate the position correctly.  However, since BVC is a
heavy-weight view, and this is called for every scroll offset, calling
|-layoutIfNeeded| on BVC.view may introduce performance regressions.

This CL adds a container view for the secondary toolbar that has a
constant frame equal to that of the secondary toolbar at a fullscreen
progress of 1.0.  That way, all the constraints that need to be
animated are owned by the container and its subviews, so we can just
call |-layoutIfNeeded| on the container rather than the entire
browser view.


Bug: 880656
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia0520d4cbfb55846efa16282e5aefae6e7f11212
Reviewed-on: https://chromium-review.googlesource.com/1208713
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590182}

This patch simplifies conditions around the code in gpu/

Bug: 561800
Change-Id: I798f95ba388c8f6b0e5488ef053e62b763363e07
Reviewed-on: https://chromium-review.googlesource.com/1186289Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#590181}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba11264e0971..2353705f52ff


Created with:
  gclient setdep -r src-internal@2353705f52ff

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:882510
TBR=mmoss@chromium.org

Change-Id: I73481705080dca9c633b1837bed690f5a29ba432
Reviewed-on: https://chromium-review.googlesource.com/1217816Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590180}

Using wpt-import in Chromium dd042963.
With Chromium commits locally applied on WPT:
d7762551 "Consistently use single quotes in Background Fetch WPTs."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24519

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I09c064128b48e2a90d9e8525e70b6d9f7a9848c2
Reviewed-on: https://chromium-review.googlesource.com/1217854
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590179}

https://chromium.googlesource.com/catapult.git/+log/f182b1fc9a95..c80faf456d4c


git log f182b1fc9a95..c80faf456d4c --date=short --no-merges --format='%ad %ae %s'
2018-09-11 dtu@chromium.org [pinpoint] Add JSON output for /api/isolate.


Created with:
  gclient setdep -r src/third_party/catapult@c80faf456d4c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:868926
TBR=sullivan@chromium.org

Change-Id: I02e4eb2eb6221701bd06c4e909d8150e7089a0ab
Reviewed-on: https://chromium-review.googlesource.com/1217814Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590178}

This CL changes timing of stacking notification counter to appear in
UnifiedSystemTray. Combined with https://crrev.com/c/1215507, it fixes
top corner artifact of ARC++ notifications in UnifiedSystemTray.

TEST=manual
BUG=866777

Change-Id: I57f0ca846b129c18e7500d7738375644ff82157b
Reviewed-on: https://chromium-review.googlesource.com/1215602
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590177}

This binary was broken by me but left unnoticed because no bot executes
it. This test is simple and CreateMainThreadAndInitialize() would
suffice.

Bug: 826203
Change-Id: Icdf9e3941be862abbedc20086ee909447c28645f
Reviewed-on: https://chromium-review.googlesource.com/1206753Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590176}

Currently some invariants violation checks are in LayerTreeHost for mac
but not for other platforms. This CL enables the check on other platforms.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iade0eee8322f9126a5ee7409b2e79aa00593b2d1
Reviewed-on: https://chromium-review.googlesource.com/1217598Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590175}

TBR=bnc@chromium.org

Change-Id: Iadd9cef6cec3357c3e3e66440fbcc10f31e7dd5a
Reviewed-on: https://chromium-review.googlesource.com/1217746Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590174}

The double-tap gesture on Aura (which causes zoom) does not respect the
touch-action filter as it should. i.e., double-tapping over a region
with touch-action: none should prevent zooming.

This is caused by IsGestureEvent() returning false for the
TAP_UNCONFIRMED event. IsGestureEvent is used in EventHandler::OnEvent
to determine whether to pass the event to OnGestureEvent and meant that
the TAP_UNCONFIRMED gesture would get dropped at this point.

The reason this was working on Android was that Android's
GestureProivderClient is RenderWidgetHostViewAndroid. When
FilteredGestureProvider forwards the gesture it passes it straight back
to the RWHVA which doesn't go through the IsGestureEvent check mentioned
above.

On Aura, the GestureProviderClient is GestureProviderAura which passes
the forwarded gesture back through WindowEventDispatch before finding
the RenderWidgetHostViewAura. The WindowEventDispatch call chain is
where we accidentally filtered the TAP_UNCONFIRMED gesture because of
!IsGestureEvent. This means the TouchActionFilter never saw this
gesture, which it needs to determine whether to filter the subsequent
double-tap gesture.

Bug: 865090
Change-Id: I5f8932dcf8b33ec132fa946864a462610cc8413b
Reviewed-on: https://chromium-review.googlesource.com/1213881Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590173}

Usage was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1188587 but
the actual feature flag was missed.  This is final cleanup.

Change-Id: I84537c6112eea803a991eefff9c997c7f0dce758
Reviewed-on: https://chromium-review.googlesource.com/1213923
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590172}

Removes /deep/ usage, which no longer works in Shadow DOM v1. Also fixes
some test timing that caused part of the failures.

Bug: 875505,860069
Change-Id: I5642105a6df148bdea2d02b8e1af8889f400c89d
Reviewed-on: https://chromium-review.googlesource.com/1217026Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590171}

https://skia.googlesource.com/skia.git/+log/3c4d533d8ebd..5518e65d90d7


git log 3c4d533d8ebd..5518e65d90d7 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 480edb8c1d7d..63aa0e5b7001 (2 commits)


Created with:
  gclient setdep -r src/third_party/skia@5518e65d90d7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I0fe248380451033bd1a22c14682e3cc7f9bc0a6e
Reviewed-on: https://chromium-review.googlesource.com/1217813Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590170}

Some initial formatting to get closer to the mocks:
https://drive.google.com/open?id=0B1-cJJPK-cu6UGQ1Yk9uQzhReVlEc0J1N2ZZU0FaLTlvaFZB

Bug: 878644
Change-Id: Ib985d48cd91014ae82c1f7d6c57df86be38f0a67
Reviewed-on: https://chromium-review.googlesource.com/1212353Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590169}

Please see b/114134918 for more details.

Bug: 835029
Change-Id: Iefeffe6c9d0335aa61c24097b190092a3a657fbd
Reviewed-on: https://chromium-review.googlesource.com/1213521
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590168}

Bug: 881488
Change-Id: Icd1464af653037ea59c20d4b5aa91dd315f9dba8
Reviewed-on: https://chromium-review.googlesource.com/1211962Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590167}

This reduces duplication of strings.

Change-Id: I8c075f81282f63d151273e7704458afbe666b36f
Reviewed-on: https://chromium-review.googlesource.com/1185896Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590166}

CL also includes a few minor UI fixes to match mocks and a11y.

Bug: 832933
Change-Id: Ibb9fd594b80d79692593e65f00636fbd7115eb3e
Reviewed-on: https://chromium-review.googlesource.com/1212265
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590165}

This CL records touch action rects for TableRowPainter. A layout test
case is added to ensure the correctness.

Bug: 851674
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3280aaf9c72dda6a75eed5d5ad85b60045c377f7
Reviewed-on: https://chromium-review.googlesource.com/1216706
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590164}

https://chromium.googlesource.com/catapult.git/+log/b9b825ec0c30..f182b1fc9a95


git log b9b825ec0c30..f182b1fc9a95 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 simonhatch@chromium.org Dashboard - Combine yield on multiple futures


Created with:
  gclient setdep -r src/third_party/catapult@f182b1fc9a95

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I96d379242e01181b1eaea846d97c2719e289ce6b
Reviewed-on: https://chromium-review.googlesource.com/1217811Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590163}

There's some churn going on with extension bindings (to native bindings)
and user gestures (to UAv2). Add two end-to-end bindings tests to expand
our coverage:
- Test that extension messages "pass" the user gesture to the receiver;
  that is, if a user gesture is active when a message is created, it
  should be active on the receiving end as well.
- Test that extension API callbacks are invoked with an active user
  gesture iff the API is invoked when a gesture is active.

Bug: None

Change-Id: I7d4036356bd20fd00c0774210b2019287413e30c
Reviewed-on: https://chromium-review.googlesource.com/1217166Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590162}

https://webrtc.googlesource.com/src.git/+log/cf64a04acdf3..f2582da04e4d


git log cf64a04acdf3..f2582da04e4d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 mbonadei@webrtc.org Revert "Partial revert of: 'Bump xcode versions for WebRTC bots.'"
2018-09-10 perkj@webrtc.org Decrease complexity of RtpPacketHistory::GetBestFittingPacket.


Created with:
  gclient setdep -r src/third_party/webrtc@f2582da04e4d

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0718a5951cdc2e98717b1079f39f30ed26f5e1fe
Reviewed-on: https://chromium-review.googlesource.com/1217803Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590161}

arraysize is deprecated, we should use base::size() instead.
This cl clears a presubmit warnings.

Bug: 837308
Change-Id: I5479c0f16e6df0b43b617c0e15c6c28527c41cbd
Reviewed-on: https://chromium-review.googlesource.com/1213622Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#590160}

This helps provide an estimate how old the poses are when polled
by the gamepad API and when read from JavaScript.

BUG=878181

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I623b876cff559709ff858d9df0ee1df33b736481
Reviewed-on: https://chromium-review.googlesource.com/1200569Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590159}

Previously, we remove the SessionManagerListener upon session
ending/ended. This is to stop listening to session changes after we are
no longer interested in casting, while not being affected by MediaFling.
However there's some tricky SDK behavior, such that session ending could
be notified during a session relaunch. Then we never get
onSessionStarted() signal.

This CL checks for pending launch request before removing the listener,
so that sessions can be relaunched.

Bug: 711860
Change-Id: I582ae8bb6f038956c256ea88ae6115ed289fdfff
Reviewed-on: https://chromium-review.googlesource.com/1217749Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590158}

Bug: 882689
Change-Id: Ib80ccf82e70ddf242ecab87a0ed8d2b9f2937c8e
Tbr: battre@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1218122
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590157}

This reverts commit 34b81f99.

Reason for revert: Due to failures on the Leak bot.
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/24067

Original change's description:
> Make AXObjectCache garbage-collected
> 
> This is a follow-up to http://crrev.com/c/1150824 - instead of having
> Document keep track of its AXContexts, let the garbage collector do the
> work for us. Each AXContext owns a Persistent<AXObjectCache>, and
> the associated Document has a WeakPersistent<AXObjectCache>. That way
> when the last AXContext goes out of scope, the AXObjectCache will be
> cleaned up automatically.
> 
> This requires a few changes due to assumptions that AXObjectCache couldn't
> outlive its corresponding document.
> 
> Bug: 867324
> Change-Id: Id0479f59c9a9652b2cb321ed14369e8996748d8a
> Reviewed-on: https://chromium-review.googlesource.com/1162743
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590104}

TBR=dmazzoni@chromium.org,aboxhall@chromium.org,haraken@chromium.org

Change-Id: Ic63c70078865bf5fdc8a7743bd07484eb95068e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867324
Reviewed-on: https://chromium-review.googlesource.com/1217646Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590156}

Re-landing after revert:

https://chromium-review.googlesource.com/c/chromium/src/+/1200388

... but leave the flaky tests disabled.

R=chrishtr@chromium.org
BUG=879798

Change-Id: Ia588f9d82665a533b4e1bd2f77809692ded0cb41
Reviewed-on: https://chromium-review.googlesource.com/1215370
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590155}

It currently takes an OmniboxFocusState, but only two states are ever
used. Change it to a bool to remove the possibility of the renderer
sending an invalid state.

Change-Id: Ib1bc4bb5bd3415bbaf4de96d63b81fd8cfa89907
Reviewed-on: https://chromium-review.googlesource.com/1217168Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590154}