- 05 Jan, 2021 40 commits
-
-
Reilly Grant authored
Updates runtime_enabled_features.json5 and the stable webexposed tests to mark the Web Serial API stable on desktop platforms. Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/RCtZPCQLLOQ Bug: 884928 Change-Id: Ifefaa045a239d3b482287016c98e72c0d8c1da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579840 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840355}
-
Yi Gu authored
This patch changes the owner of some viz hit tesing related metrics because yigu@ is no longer working on this project. Bug: 1160809 Change-Id: Ic5ea3c2905adb3219e668eab327b66c687d8929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597653Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840354}
-
Mustafa Emre Acer authored
When upgrading a typed omnibox navigation to HTTPS, we observe the HTTPS load and fallback to HTTP if it fails. For slow HTTPS sites, this will introduce a very user visible delay. Instead of indefinitely waiting for the HTTPS navigation to succeed or finish, this CL implements a timeout so that we can cancel the HTTPS navigation (i.e. the "upgrade") and fall back to HTTP. Bug: 1141691 Change-Id: I8ec6d4bdd42abd2a9b8f90a802b9280cc0ded6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577633 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#840353}
-
Daniel Nicoara authored
Insets represent a "border" like area around each side of the Webview. By setting insets the Webview's visible area will shrink. This will be used to represent occluded area in a Webview where the virtual keyboard will be shown. Bug: internal b/175873498 Test: cast_shell_browsertests and on device by calling the new API Change-Id: Ide948ab2cd955f7f7a687de7cb91ef418dd0aa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596073Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#840352}
-
Zhaoyang Li authored
git grep -l '12b5044c' | xargs sed -i '' -e 's/12b5044c/12c33/g' Bug: 1158906 Change-Id: I51f5e5031b66d4a5606f77b7bff87a3d5088e261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594272 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#840351}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iabef9134fa34e209277ca3facd2bf03d8ce44115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840350}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ifbac49491ff181550f23b4bd611eb0f28e470688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602289 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#840349}
-
Cattalyya Nuengsigkapian authored
Regardless of where the highlight position is, after switching alt-tab mode, the highlight will be reset to the first or second window. This is consistent with highlighting when users first enter alt-tab mode: - In general case, highlight the second (next) most recently used window after the current one. - In the special case that the most recently used is minimized, highlight itself (the MRU window), so tabbing into it causes it to unminimize rather than opening up the next window in the list. - Track mode switching state in the controller to differentiate between normal tab pressing and mode switching. - Add Ash unit tests for both cases. `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.SwitchingModeUpdates*WindowHighlight` Bug: 1157100 Test: Manual test (a video uploaded to crbug) and ash unit tests Change-Id: Id85b389ba9d59eb1815b8250d640e5aa9128240b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604907Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#840348}
-
cfredric authored
This aims for a simpler method signature for CanonicalCookie::IsSetPermittedInContext, and aims to have all exclusion reasons (except those set by MaybeDeleteEquivalentCookieAndUpdateStatus) set by CanonicalCookie itself. Change-Id: Id0673d11795241f10728d90424612b1bc0ab9883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611764Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840347}
-
Trent Begin authored
The network ONC strings are used both in //chrome and //chromeos. Strings that are required in both locations need to be moved to //chromeos to prevent a layering violation. Screenshots are added in this change as they were not required when these strings were originally added. Bug: chromium:1159069 Change-Id: Id2615e0b42b11c88ac3170fc7734cb8f817d0831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606632Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840346}
-
Tarun Bansal authored
Add experiment config parameter to disable preconnects to Default Search Engine (DSE) when the browser app is likely to be in the background. Bug: 1163183 Change-Id: I4bea073aeac20b6ae717305bdfac2bb0df052751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605226 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840345}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609858728-6f035387130eda965f3c879c319423c426ffdda8.profdata to chrome-win64-master-1609869437-3a75c705c558e60abdee705e3f24c9125b018e03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id3601eb822428c821d63549871e703b14eae5603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840344}
-
Alan Ding authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d6f3734b69e2..e5fc0c7ccb3c $ git log d6f3734b6..e5fc0c7cc --date=short --no-merges --format='%ad %ae %s' 2020-12-16 alanding system_api: Add field to disable MediaStore maintenance tasks in ARC. 2020-12-23 allenwebb Renamed chromeos_dbus_bindings to chromeos-dbus-bindings. 2020-12-15 matthewmwang shill: wifi: move RekeyInProgress property from Device to Service 2020-12-16 sonnysasaka system_api: bluetooth: Update battery-related constants Created with: roll-dep src/third_party/cros_system_api Bug: b:173906243 Change-Id: I532d6027a8fd6320d17a740b344d1b7b44f97125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606628Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#840343}
-
Patrick Noland authored
Accessing the UrlCoordinator post-destroy is no longer safe as of https://crrev.com/c/2553145. finishUrlFocusChange and setUrlFocusChangeInProgress can both be invoked post-destroy by tablet animation code, so these are guarded with early returns. I've left other call sites alone for the moment, since I'd like to understand and address other null accesses independently. Bug: 1160975 Change-Id: I4b5acd24b180cc8389cc45c8c99e01d5b30ea077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610949Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#840342}
-
Joel Hockey authored
Crosh (chrome-untrusted://crosh) will be hosted in lacros, and this field used by process_proxy must be included in lacros. Bug: 1161413 Change-Id: I504dadb1d34f68298ebd3bc044f9203ed3ca50dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608101 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840341}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6796f9607a75c620f5bc7a8a0fd9d8828752b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840340}
-
Andrew Grieve authored
Shaves off ~500ms off of blink_public_mojom_mojom_platform With python3 & change applied, logs on my machine: I 18 Started (mojom_parser.py) I 30 Parsing 177 .mojom into ASTs I 2117 Processing dependencies I 2342 Loaded 92 modules from dependencies I 2342 Ensuring inputs are loaded I 2488 Serializeing 177 modules I 2958 Finished Bug: 1143399 Change-Id: I926e9ea71b44b1b754ab00b0c42dd718922fdd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605873Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#840339}
-
David Bokan authored
Text fragments have been enabled in stable since M80 so we can now remove the flag. The runtime feature remains since the feature can still be disabled via enterprise policy so this just removes the about:flag. Bug: 919204 Change-Id: Ifccc631362795c35dc0ac2fd78c519916cb28066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606129Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840338}
-
Scott Violet authored
Prior to this patch what was the non-snapshotting backend did not use timestamps. This is racy, as it means the file is potentially in a bad state if WebLayer were to crash before the initial state was written. This changes the kOther backend to use time stamps. This required some changes in the WebLayer to deal with the additional files. BUG=648266 TEST=covered by tests Change-Id: I232cdfbf44ddc90b8942048d92028a646d746a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605525 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840337}
-
Jeremy Roman authored
flat_map construction prefers taking a vector so that it need only be sorted once (and it happens that here, it will always be correctly sorted) rather than having to do a binary search for each insertion. host_model_features is also now searched only once, rather than once in contains() and another in find(). Technically it could be searched slightly more efficiently (given its sorted order is guaranteed to match the other two flat trees here), but this is slightly awkward to do and so I'll stop this premature optimization short of doing that. Change-Id: I9ce61d68c16e63cefbcd2d758bee522696f6528d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605649Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840336}
-
Xianzhu Wang authored
The maximum animation scale may be unknown in the following cases: 1. ui:TransformAnimationCurveAdapter's AnimationStartScale() and MaximumTargetScale() always return false for any animation curve, making cc not able to optimize raster scale for ui transform animations. 2. When the maximum animation to screen scale can't be computed, e.g. when there are nested scale animations. This CL partly reverts crrev.com/c/2566053 for the case that the scale is unknown by using the native scale. For 1, in the future we need to 1. distinguish translation-only transform animation (scale==1, but for now kNotScaled) and transform animations with non-computable scale (scale==kNotScaled). 2. implement ui::TransformAnimationCurveAdapter scale methods (crbug.com/1161586). Bug: 1157407, 1163100 Change-Id: I104261aa4c9400eded02e850bd2cc0e61394e2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602699 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840335}
-
David Bokan authored
The handler is meant to be called repeatedly so convert to RepeatingCallback. The caller already uses BindRepeating. Bug: 1152268 Change-Id: I62af30b2ce6fa0234a7efd5f2788c4e045c25a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605876Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840334}
-
Jeremy Roman authored
* PredictionModel was using SequenceChecker incorrectly, to no effect. Since the fields it was guarding are immutable, this sequence check was in any event unnecessary. Instead, the members have been made const. * PredictionModel::model_info_ was never set or read. It is removed. * The PredictionModel constructor has been made explicit, consistent with Chromium style. * The code was very inconsistent about whether optimization_guide:: qualification was used. For consistency, brevity and style it has been rewritten in these places to not be qualified. * It is inefficient to construct a flat_set by repeated insertion. It is equally easy, and preferred (see base/containers/flat_set.h) to construct a vector that can be sorted on construction. This reduces complexity from O(n^2) to O(n log n). * PredictionModel::GetModelFeatures returned a copy, unneecessarily. It now returns a const reference. * Fewer conversions between std::unique_ptr<proto::PredictionModel> and const proto::PredictionModel& are now done. std::unique_ptr is left where ownership is passed or where it interfaces with other code that uses unique_ptr in a more complicated way. This reduces copies and heap allocations. Regrettably it requires a number of trivial changes to the unit tests. * DecisionTreePredictionModel::ValidateTreeNode's node_index argument is changed to int, which is more efficient and more usual than const int&. Change-Id: Ib6b9d77d4f5941f578d3213c323ead01319715b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607485 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840333}
-
Ian Clelland authored
The trial is no longer active (Document Policy has shipped) and so this configuration is no longer needed. Bug: 993790 Change-Id: Iaefea88f07c123a68f742de301dc83160df21465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600034Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#840332}
-
Dirk Pranke authored
This is a reland of bb97ab9b I believe all of the breakages we encountered on the first go-round have been fixed. Original change's description: > Force Python 3 to be used in build. > > This CL makes Python 3 be the default script executable used by Ninja > to run action() and action_foreach()'s during the build. > > This does *not* mean that everything works with Python3; many targets > may still use Python 2 via the python2_action() and > python2_action_foreach() targets or via custom logic. > > However, it does mean that it should prevent regressions from > creeping in. > > This CL should not be taken to imply that we can start to write > Python3-specific code that can run during the build; we should > still be trying to ensure that everything is compatible with Python2. > > Also, this CL does not enable the use of vpython in actions; we should > still avoid that because vpython is slower than direct Python > invocations. > > Bug: 1112471 > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#836234} Bug: 1112471 Change-Id: I075999ef45df00708fabe480d4b71fdbf25a2ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591588 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840331}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ib470f5bf4c8969d112c79c13fdaaa73a064d3401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840330}
-
Clark DuVall authored
It looks like we are getting some crashes on VrModule.getImpl() even in versions where we use SplitCompatAppComponentFactory. I suspect this is due to the vr preload, so disabling to see if it stops crashes. If this works, I'll see if there's anything we can do to prevent crashing with the preload. Bug: 1142589 Change-Id: I7de6c48edbb9d0a37ee271bff49295912b549d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611847Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840329}
-
Andrew Grieve authored
This causes trichrome's dex to be compile with "speed" rather than "speed-profile", which is a substantial binary size regression. Also adds a histogram to track when the work-around happens. Bug: 1152970, 1159608 Change-Id: I25e2c350b54724613234b23505078f5df88d9cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602657 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#840328}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I6677026925fc0914197e51de557ab5df37d08c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595835Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#840327}
-
Bailey Berro authored
This change introduces a count histogram for the number of routines a user runs during one session in the Diagnostics App. The count starts at zero each time the app is opened, and it is emitted when the app is closed. Bug: 1128204 Change-Id: I5dc7eec4f33006a9694c6c694d5a83a06d59a3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570345 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#840326}
-
David Bokan authored
This flag has been matching the value of the overlay-scrollbars flag since M63 so we can remove it. It's used in the corresponding LayerTreeSettings member. The setting can now (remain) always-disabled on Android and enabled on other platforms whenever overlay scrollbars are. Bug: 746342 Change-Id: I799dcfd52e97d0ee1745ad73d19951341e9f25f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605883Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840325}
-
Paul Jensen authored
This change implements a new NetworkCallback class used for listening to changes to the default network on Android. It includes two fixes: 1. Avoids calling synchronous ConnectivityManager methods which is prohibited inside NetworkCallbacks. This is a preemptive fix, not known to actually be causing issues. 2. Catches onCapabilitiesChanged() which includes cellular connections transitioning to and from SUSPENDED states. Failing to catch this could leave the NetworkChangeNotifier in an incorrect disconnected state, see crbug.com/1120144. This new NetworkCallback is used on Android R and newer versions to limit retesting and as these are the only versions experiencing issues. I've tested this thoroughly on Android R. Additional automated testing isn't feasible given the code's closeness with Android APIs involving immutable classes with no public constructors (e.g. NetworkCapabilities). Bug: 1120144 Change-Id: If77d4524f8f8e0be78563412176c2ea2d07f00c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605304 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840324}
-
Yuly Novikov authored
Notable differences from the existing fake CI bots: 1. Instead of splitting the bots by dEQP/non-dEQP they are split now by Chromium/ANGLE-specific, which means: 2. Suites which don't depend on Chromium, like angle_end2end_tests and angle_perftests now run together with dEQP suite. 3. Some tests suites were removed from ANGLE bots - gpu_unittests, as well as all GLES2 conformance tests. Bug: angleproject:4483 Change-Id: I5aac17351c8067c6f53a1527be3285cbd80822ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603577 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#840323}
-
Siye Liu authored
Due to the fact that we reuse TSF document for text fields with same input type, we should property reset the state by clearing focus before re-using the document. Bug: 1162974 Change-Id: Ia92187705e93cc064e992e28c8638d5647e06ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610147Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840322}
-
Alexander Cooper authored
The current token expired on December 29th, and should be updated. Change-Id: Ia7dbcd367b5bb0ba6b536b0bd44fba5039fbaa19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611688 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#840321}
-
Yue Zhang authored
Bug: 1157892 Change-Id: I386fb6bc5377c0a32c504eac5d8f0f92497a2943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599446Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840320}
-
Alice Gong authored
BUG=1157672 Change-Id: Ib31d8dd60486f8634d9477ad82d5d9bbbc095dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590428 Commit-Queue: Alice Gong <alicego@google.com> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840319}
-
Andrew Grieve authored
Bug: 1027683 Change-Id: Idd35bc8cdb81f7e04ddfd997d28d128902e1ee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611288 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#840318}
-
Erik Chen authored
This CL adds a lacros browser test that creates a lacros window, triggers overview mode, and then closes the window while overview mode is still active. Change-Id: Ib16b9f8dedabc49a3f1722bd6416f9c99ec7a8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601260 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#840317}
-
Francois Doray authored
This class added an unnecessary layer of complexity to access memory instrumentation functionality. Follow-up: Rename //services/resource_coordinator/ to //services/memory_instrumentation and remove "memory_instrumentation" subdirectories. Change-Id: I556423d2004ab0d2b2462ae5b0cac529712d50de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593829Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#840316}
-